65319 2011-07-28 07:42:35 -0700 [GTK] Use GRefPtr for SOUP_TYPE_CONTENT_DECODER in WebKit2. 2012-03-30 10:21:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED WORKSFORME P2 Normal --- 0 l.slachciak webkit-unassigned mrobinson svillar oldest_to_newest 443490 0 l.slachciak 2011-07-28 07:42:35 -0700 Use GRefPtr for decoder (SOUP_TYPE_CONTENT_DECODER) reference tracking, the same way as other SoupSessionFeature's. 443492 1 102257 l.slachciak 2011-07-28 07:43:42 -0700 Created attachment 102257 SOUP_TYPE_CONTENT_DECODER fix 445829 2 102257 mrobinson 2011-08-03 05:44:39 -0700 Comment on attachment 102257 SOUP_TYPE_CONTENT_DECODER fix View in context: https://bugs.webkit.org/attachment.cgi?id=102257&action=review > Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:65 > - soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER); > + GRefPtr<SoupSessionFeature> decoder = adoptGRef(static_cast<SoupSessionFeature*>(g_object_new(SOUP_TYPE_CONTENT_DECODER, NULL))); > + soup_session_add_feature(session, decoder.get()); Why is this an improvement? 445830 3 mrobinson 2011-08-03 05:45:09 -0700 (In reply to comment #2) > (From update of attachment 102257 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102257&action=review > > > Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:65 > > - soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER); > > + GRefPtr<SoupSessionFeature> decoder = adoptGRef(static_cast<SoupSessionFeature*>(g_object_new(SOUP_TYPE_CONTENT_DECODER, NULL))); > > + soup_session_add_feature(session, decoder.get()); > > Why is this an improvement? By this I mean, why don't we just use soup_session_add_feature_by_type everywhere? 446044 4 102257 l.slachciak 2011-08-03 13:11:48 -0700 Comment on attachment 102257 SOUP_TYPE_CONTENT_DECODER fix View in context: https://bugs.webkit.org/attachment.cgi?id=102257&action=review >>> Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:65 >>> + soup_session_add_feature(session, decoder.get()); >> >> Why is this an improvement? > > By this I mean, why don't we just use soup_session_add_feature_by_type everywhere? I wanted just to have all features initialized in the same way. In fact we don't need to use GRefPtr here. For me it looks like that we can have soup_session_add_feature_by_type for all features. 446099 5 mrobinson 2011-08-03 14:47:41 -0700 If that's possible, let's do that. :) It will cut down on the number of lines of code. 592257 6 svillar 2012-03-30 10:21:53 -0700 The patch added after bug 68602 changes the way we initialize libsoup features so this is no longer needed. 102257 2011-07-28 07:43:42 -0700 2011-08-03 15:48:28 -0700 SOUP_TYPE_CONTENT_DECODER fix decoder.patch text/plain 1833 l.slachciak ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2OWMyYzNhLi5jZTZkMGRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDctMjAgIEx1a2FzeiBTbGFjaGNpYWsgIDxsLnNsYWNoY2lha0BzYW1zdW5nLmNv bT4KKworICAgICAgICBbR1RLXSBVc2UgR1JlZlB0ciBmb3IgU09VUF9UWVBFX0NPTlRFTlRfREVD T0RFUiBpbiBXZWJLaXQyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjUzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2UgR1JlZlB0ciBmb3IgZGVjb2RlciAoU09VUF9UWVBFX0NPTlRFTlRfREVDT0RF UikgcmVmZXJlbmNlIHRyYWNraW5nLCB0aGUgc2FtZSB3YXkgYXMgb3RoZXIKKyAgICAgICAgU291 cFNlc3Npb25GZWF0dXJlJ3MuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2d0ay9XZWJQcm9jZXNz TWFpbkd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NNYWluR3RrKTogVXNlIGFk b3B0R1JlZiBpbnRyb2R1Y2VkIGluIHI3NTAwOSBmb3IgR1JlZlB0ciBjcmVhdGlvbi4KKwogMjAx MS0wNy0yMCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmVydCB3b3JrZXIgYW5kIFdlYktpdDIgcnVubG9vcHMgdG8gdXNlIGN1cnJlbnRUaW1lKCkg Zm9yIHNjaGVkdWxpbmcgaW5zdGVhZCBvZiB0aGUgbW9ub3RvbmljIGNsb2NrCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2d0ay9XZWJQcm9jZXNzTWFpbkd0ay5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2d0ay9XZWJQcm9jZXNzTWFpbkd0ay5jcHAKaW5kZXgg MTY3MWUxYS4uNDM5OTI5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9n dGsvV2ViUHJvY2Vzc01haW5HdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv Z3RrL1dlYlByb2Nlc3NNYWluR3RrLmNwcApAQCAtNjEsNyArNjEsOCBAQCBXS19FWFBPUlQgaW50 IFdlYlByb2Nlc3NNYWluR3RrKGludCBhcmdjLCBjaGFyKiBhcmd2W10pCiAgICAgR1JlZlB0cjxT b3VwU2Vzc2lvbkZlYXR1cmU+IHNuaWZmZXIgPSBhZG9wdEdSZWYoc3RhdGljX2Nhc3Q8U291cFNl c3Npb25GZWF0dXJlKj4oZ19vYmplY3RfbmV3KFNPVVBfVFlQRV9DT05URU5UX1NOSUZGRVIsIE5V TEwpKSk7CiAgICAgc291cF9zZXNzaW9uX2FkZF9mZWF0dXJlKHNlc3Npb24sIHNuaWZmZXIuZ2V0 KCkpOwogCi0gICAgc291cF9zZXNzaW9uX2FkZF9mZWF0dXJlX2J5X3R5cGUoc2Vzc2lvbiwgU09V UF9UWVBFX0NPTlRFTlRfREVDT0RFUik7CisgICAgR1JlZlB0cjxTb3VwU2Vzc2lvbkZlYXR1cmU+ IGRlY29kZXIgPSBhZG9wdEdSZWYoc3RhdGljX2Nhc3Q8U291cFNlc3Npb25GZWF0dXJlKj4oZ19v YmplY3RfbmV3KFNPVVBfVFlQRV9DT05URU5UX0RFQ09ERVIsIE5VTEwpKSk7CisgICAgc291cF9z ZXNzaW9uX2FkZF9mZWF0dXJlKHNlc3Npb24sIGRlY29kZXIuZ2V0KCkpOwogCiAgICAgR1JlZlB0 cjxTb3VwU2Vzc2lvbkZlYXR1cmU+IGF1dGhEaWFsb2cgPSBhZG9wdEdSZWYoc3RhdGljX2Nhc3Q8 U291cFNlc3Npb25GZWF0dXJlKj4oZ19vYmplY3RfbmV3KFdFQl9UWVBFX0FVVEhfRElBTE9HLCBO VUxMKSkpOwogICAgIHNvdXBfc2Vzc2lvbl9hZGRfZmVhdHVyZShzZXNzaW9uLCBhdXRoRGlhbG9n LmdldCgpKTsK