65313 2011-07-28 06:39:09 -0700 MinGW-w64 - JIT causes build failure 2012-09-27 04:25:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P1 Blocker --- 61235 0 net147 webkit-unassigned ademar ap barraclough hausmann kai.koehne vanboxem.ruben webkit.review.bot oldest_to_newest 443465 0 net147 2011-07-28 06:39:09 -0700 JIT shouldn't be enabled on MinGW-w64 as it is unstable and causes crash when executing JavaScript. The following should be added to JavaScriptCore/wtf/Platform.h: /* JIT is not implemented for 64 bit on MinGW-w64 */ #if !defined(ENABLE_JIT) && COMPILER(MINGW64) && CPU(X86_64) #define ENABLE_JIT 0 #endif 444019 1 ap 2011-07-29 11:13:26 -0700 Would you be willing to contribute this code to WebKit as described in <http://www.webkit.org/coding/contributing.html>? I do not mean to diminish the contribution you made already by pointing out this bug, but historically, patches that aren't submitted according to the process almost never get landed. 446693 2 vanboxem.ruben 2011-08-04 12:45:25 -0700 I believe this wouldn't work on 64-bit MSVC either. IMHO I think that the COMPILER(MINGW64) check is superfluous (and wrong). Last I knew, Win64 had no working JIT. 458001 3 net147 2011-08-28 01:00:12 -0700 This issue causes build failure as indicated in bug 61235. 458003 4 105446 net147 2011-08-28 02:47:23 -0700 Created attachment 105446 proposed patch 458004 5 net147 2011-08-28 02:51:43 -0700 (In reply to comment #1) > Would you be willing to contribute this code to WebKit as described in <http://www.webkit.org/coding/contributing.html>? > > I do not mean to diminish the contribution you made already by pointing out this bug, but historically, patches that aren't submitted according to the process almost never get landed. Patch contributed as requested. 458005 6 webkit.review.bot 2011-08-28 02:52:11 -0700 Attachment 105446 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 458006 7 105447 net147 2011-08-28 02:55:07 -0700 Created attachment 105447 proposed patch 458015 8 105447 webkit.review.bot 2011-08-28 12:24:53 -0700 Comment on attachment 105447 proposed patch Clearing flags on attachment: 105447 Committed r93950: <http://trac.webkit.org/changeset/93950> 458016 9 webkit.review.bot 2011-08-28 12:24:58 -0700 All reviewed patches have been landed. Closing bug. 458207 10 ademar 2011-08-29 07:26:13 -0700 Revision r93950 cherry-picked into qtwebkit-2.2 with commit b017396 <http://gitorious.org/webkit/qtwebkit/commit/b017396> 729388 11 kai.koehne 2012-09-27 03:26:28 -0700 Unfortunately this is broken again in latest qtwebkit: jit\ExecutableAllocatorFixedVMPool.cpp:34:22: fatal error: sys/mman.h: No such file or directory I've yet to find out what goes wrong this time ... 729415 12 kai.koehne 2012-09-27 04:25:08 -0700 Created another bug report for the regression: https://bugs.webkit.org/show_bug.cgi?id=97772 105446 2011-08-28 02:47:23 -0700 2011-08-28 02:54:34 -0700 proposed patch 65313.patch text/plain 1240 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTM5NDgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDgtMjggIEpvbmF0aGFuIExpdSAgPG5ldDE0N0BnbWFpbC5jb20+CisKKwlGaXggYnVp bGQgZXJyb3Igd2hlbiBjb21waWxpbmcgd2l0aCBNaW5HVy13NjQgYnkgZGlzYWJsaW5nIEpJVAor CW9uIFdpbmRvd3MgNjQtYml0CisJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxMjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlUaGUg Zml4ZWQgbW1hcCBleGVjdXRhYmxlIGFsbG9jYXRvciBmb3IgSklUIG9uIHg4Nl82NCByZXF1aXJl cworCXN5cy9tbWFuLmggd2hpY2ggaXMgbm90IGF2YWlsYWJsZSBvbiBXaW5kb3dzLgorCisgICAg ICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTEtMDgtMjcgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBKU0M6OkV4ZWN1dGFibGUgaXMgaW5jb25zaXN0ZW50IGFi b3V0IHVzaW5nIHdlYWsgaGFuZGxlIGZpbmFsaXplcnMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDkzOTQ4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC05MzUsOCArOTM1LDggQEAKICNkZWZp bmUgRU5BQkxFX0pJVCAwCiAjZW5kaWYKIAotLyogSklUIGlzIG5vdCBpbXBsZW1lbnRlZCBmb3Ig NjQgYml0IG9uIE1TVkMgKi8KLSNpZiAhZGVmaW5lZChFTkFCTEVfSklUKSAmJiBDT01QSUxFUihN U1ZDKSAmJiBDUFUoWDg2XzY0KQorLyogSklUIGlzIG5vdCBpbXBsZW1lbnRlZCBmb3IgV2luZG93 cyA2NC1iaXQgKi8KKyNpZiAhZGVmaW5lZChFTkFCTEVfSklUKSAmJiBPUyhXSU5ET1dTKSAmJiBD UFUoWDg2XzY0KQogI2RlZmluZSBFTkFCTEVfSklUIDAKICNlbmRpZgogCg== 105447 2011-08-28 02:55:07 -0700 2011-08-28 12:24:53 -0700 proposed patch 65313.patch text/plain 1275 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTM5NDgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDgtMjggIEpvbmF0aGFuIExpdSAgPG5ldDE0N0BnbWFpbC5jb20+CisKKyAgICAgICAg Rml4IGJ1aWxkIGVycm9yIHdoZW4gY29tcGlsaW5nIHdpdGggTWluR1ctdzY0IGJ5IGRpc2FibGlu ZyBKSVQKKyAgICAgICAgb24gV2luZG93cyA2NC1iaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZpeGVkIG1tYXAgZXhlY3V0YWJsZSBhbGxvY2F0 b3IgZm9yIEpJVCBvbiB4ODZfNjQgcmVxdWlyZXMKKyAgICAgICAgc3lzL21tYW4uaCB3aGljaCBp cyBub3QgYXZhaWxhYmxlIG9uIFdpbmRvd3MuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoK KwogMjAxMS0wOC0yNyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAg IEpTQzo6RXhlY3V0YWJsZSBpcyBpbmNvbnNpc3RlbnQgYWJvdXQgdXNpbmcgd2VhayBoYW5kbGUg ZmluYWxpemVycwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNp b24gOTM5NDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtp bmcgY29weSkKQEAgLTkzNSw4ICs5MzUsOCBAQAogI2RlZmluZSBFTkFCTEVfSklUIDAKICNlbmRp ZgogCi0vKiBKSVQgaXMgbm90IGltcGxlbWVudGVkIGZvciA2NCBiaXQgb24gTVNWQyAqLwotI2lm ICFkZWZpbmVkKEVOQUJMRV9KSVQpICYmIENPTVBJTEVSKE1TVkMpICYmIENQVShYODZfNjQpCisv KiBKSVQgaXMgbm90IGltcGxlbWVudGVkIGZvciBXaW5kb3dzIDY0LWJpdCAqLworI2lmICFkZWZp bmVkKEVOQUJMRV9KSVQpICYmIE9TKFdJTkRPV1MpICYmIENQVShYODZfNjQpCiAjZGVmaW5lIEVO QUJMRV9KSVQgMAogI2VuZGlmCiAK