65304 2011-07-27 23:24:33 -0700 [Chromium] Add form() function to access parent WebFormElement from WebFormControlElement. 2011-07-28 22:32:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 honten honten abarth fishd honten isherman webkit.review.bot oldest_to_newest 443362 0 honten 2011-07-27 23:24:33 -0700 [Chromium] Add form() function to access parent WebFormElement from WebFormControlElement. 443363 1 102229 honten 2011-07-27 23:27:00 -0700 Created attachment 102229 Patch 443364 2 honten 2011-07-27 23:32:49 -0700 Please review. 443416 3 102229 isherman 2011-07-28 02:19:38 -0700 Comment on attachment 102229 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102229&action=review Looks ok to me, but I am not a WebKit reviewer. > Source/WebKit/chromium/src/WebFormControlElement.cpp:35 > +#include "HTMLFormElement.h" nit: Why do you need to include this header here? 443532 4 102229 fishd 2011-07-28 10:07:47 -0700 Comment on attachment 102229 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102229&action=review >> Source/WebKit/chromium/src/WebFormControlElement.cpp:35 >> +#include "HTMLFormElement.h" > > nit: Why do you need to include this header here? he needs that so that the WebFormElement(const PassRefPtr<HTMLFormElement>&) constructor can be called. that requires the definition of the HTMLFormElement class. 443820 5 102229 webkit.review.bot 2011-07-28 22:32:36 -0700 Comment on attachment 102229 Patch Clearing flags on attachment: 102229 Committed r91975: <http://trac.webkit.org/changeset/91975> 443821 6 webkit.review.bot 2011-07-28 22:32:41 -0700 All reviewed patches have been landed. Closing bug. 102229 2011-07-27 23:27:00 -0700 2011-07-28 22:32:36 -0700 Patch bug-65304-20110727232659.patch text/plain 2803 honten U3VidmVyc2lvbiBSZXZpc2lvbjogOTE2OTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NTRkNDQ5MzU1NzMwMTYxYmEzMzUyODEzOTZkNzc2MGRjYzQ5MzUzZC4uM2I0ZDc4MjJmMTBiOTQz MjY3ODA2Mjk0ZGUyZTAwYjdmNDVlMWVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMS0wNy0yNyAgTmFva2kgVGFrYW5vICA8aG9udGVuQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEFkZCBmb3JtKCkgZnVuY3Rpb24gdG8gYWNjZXNz IHBhcmVudCBXZWJGb3JtRWxlbWVudCBmcm9tIFdlYkZvcm1Db250cm9sRWxlbWVudC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MzA0CisgICAgICAg IGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTYzNTUz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21p dW0gQXV0b2ZpbGwgZmVhdHVyZSBuZWVkcyB0byBhY2Nlc3MgdGhlIHBhcmVudCBXZWJGb3JtRWxl bWVudCBmcm9tIFdlYkZvcm1Db250cm9sRWxlbWVudC4gU28gYWRkZWQgZm9ybSgpIG1ldGhvZC4K KworICAgICAgICAqIHB1YmxpYy9XZWJGb3JtQ29udHJvbEVsZW1lbnQuaDogQWRkIGZvcm0oKSBm dW5jdGlvbi4KKyAgICAgICAgKiBzcmMvV2ViRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViRm9ybUNvbnRyb2xFbGVtZW50Ojpmb3JtKTogUmV0dXJuIHBhcmVudCBX ZWJGb3JtRWxlbWVudC4KKwogMjAxMS0wNy0yMyAgQWxvayBQcml5YWRhcnNoaSAgPGFsb2twQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBTd2l0Y2hpbmcgb2ZmIGFjY2VsZXJhdGlvbiBmb3Igc21h bGwgY2FudmFzIGJyb2tlIGdwdSB0ZXN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViRm9ybUNvbnRyb2xFbGVtZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJGb3JtQ29udHJvbEVsZW1lbnQuaAppbmRleCA1M2VmODUwMGEwZmI1OGVl MzRhMGU0NjYxMzI2ZTA3OWI1NzkyMzQ1Li5jMTEzN2E1NDU3ZTE2NTRjOGU3ZThlNWQzMjYwOTk0 ZmMyNzI0MTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJG b3JtQ29udHJvbEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJGb3JtQ29udHJvbEVsZW1lbnQuaApAQCAtMzIsNiArMzIsNyBAQAogI2RlZmluZSBXZWJGb3Jt Q29udHJvbEVsZW1lbnRfaAogCiAjaW5jbHVkZSAiV2ViRWxlbWVudC5oIgorI2luY2x1ZGUgIldl YkZvcm1FbGVtZW50LmgiCiAjaW5jbHVkZSAiV2ViU3RyaW5nLmgiCiAKICNpZiBXRUJLSVRfSU1Q TEVNRU5UQVRJT04KQEAgLTY1LDYgKzY2LDggQEAgcHVibGljOgogICAgIC8vIHN0cmluZyBpZiBp dCBoYXMgbm8gbmFtZSBhbmQgbm8gaWQuCiAgICAgV0VCS0lUX0FQSSBXZWJTdHJpbmcgbmFtZUZv ckF1dG9maWxsKCkgY29uc3Q7CiAKKyAgICBXRUJLSVRfQVBJIFdlYkZvcm1FbGVtZW50IGZvcm0o KSBjb25zdDsKKwogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogICAgIFdlYkZvcm1Db250cm9s RWxlbWVudChjb25zdCBXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6SFRNTEZvcm1Db250cm9sRWxl bWVudD4mKTsKICAgICBXZWJGb3JtQ29udHJvbEVsZW1lbnQmIG9wZXJhdG9yPShjb25zdCBXVEY6 OlBhc3NSZWZQdHI8V2ViQ29yZTo6SFRNTEZvcm1Db250cm9sRWxlbWVudD4mKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZvcm1Db250cm9sRWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGb3JtQ29udHJvbEVsZW1lbnQuY3BwCmlu ZGV4IGYwMGIwNThlOTA5NjExYjhlN2Q0ZDU2MzEzYzM3YTU0YzAwMzMxNWIuLmE4OTc3MzVkMTAz MjZmYWY0YTZkNWIxOTFiMzA5NDZmODQ1MTc4MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkZvcm1Db250cm9sRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRm9ybUNvbnRyb2xFbGVtZW50LmNwcApAQCAtMzIsNiArMzIsNyBA QAogI2luY2x1ZGUgIldlYkZvcm1Db250cm9sRWxlbWVudC5oIgogCiAjaW5jbHVkZSAiSFRNTEZv cm1Db250cm9sRWxlbWVudC5oIgorI2luY2x1ZGUgIkhUTUxGb3JtRWxlbWVudC5oIgogI2luY2x1 ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwpAQCAtNzYs NiArNzcsMTEgQEAgV2ViU3RyaW5nIFdlYkZvcm1Db250cm9sRWxlbWVudDo6bmFtZUZvckF1dG9m aWxsKCkgY29uc3QKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKK1dlYkZvcm1FbGVtZW50IFdl YkZvcm1Db250cm9sRWxlbWVudDo6Zm9ybSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIFdlYkZvcm1F bGVtZW50KGNvbnN0VW53cmFwPEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ+KCktPmZvcm0oKSk7Cit9 CisKIFdlYkZvcm1Db250cm9sRWxlbWVudDo6V2ViRm9ybUNvbnRyb2xFbGVtZW50KGNvbnN0IFBh c3NSZWZQdHI8SFRNTEZvcm1Db250cm9sRWxlbWVudD4mIGVsZW0pCiAgICAgOiBXZWJFbGVtZW50 KGVsZW0pCiB7Cg==