65302 2011-07-27 21:48:30 -0700 [EFL] Modify type of both col and row parameters for backing store's internal api. 2011-08-19 06:23:56 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 hyuki.kim webkit-unassigned antognolli+webkit gyuyoung.kim leandro lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 443324 0 hyuki.kim 2011-07-27 21:48:30 -0700 As both col and row parameter's type for both _ewk_tiled_backing_store_item_fill and ewk_tiled_backing_store_item_add are different from each other, I modify type of them. In addition, in order to increase readability of _ewk_tiled_backing_store_item_fill, some related lines of those parameters are modified. 443326 1 102227 hyuki.kim 2011-07-27 21:51:48 -0700 Created attachment 102227 Patch 443422 2 rakuco 2011-07-28 05:00:42 -0700 IMO the patch needs further investigation. The data types were changed from _ewk_tiled_backing_store_item_add upwards, but you also need to check which data is passed to it as well (by quickly skimming through the file I can see some long to unsigned int conversions done before item_add is called, for example), so that it is verified that no useless casts are done or whether other data types should be changed. _ewk_tiled_backing_store_view_cols_end_add (which calls item_add) and _ewk_tiled_backing_store_recalc_renderers (which calls end_add) are good starting points. > Source/WebKit/efl/ChangeLog:7 > + and ewk_tiled_backing_store_item_add are different from each other, I modify type of them. Extra space after "and". > Source/WebKit/efl/ChangeLog:9 > + some related lines of those parameters are modified. From what I see, the changes made were fairly obvious, so this paragraph should not be needed. If you did some changes which were not obvious, it'd be better to mention them below in each function in the ChangeLog instead of here. 443428 3 102242 hyuki.kim 2011-07-28 05:16:24 -0700 Created attachment 102242 Patch 443437 4 hyuki.kim 2011-07-28 05:27:08 -0700 First of all, thank you for your review, > The data types were changed from _ewk_tiled_backing_store_item_add upwards, but you also need to check which data is passed to it as well (by quickly skimming through the file I can see some long to unsigned int conversions done before item_add is called, for example), so that it is verified that no useless casts are done or whether other data types should be changed. _ewk_tiled_backing_store_view_cols_end_add (which calls item_add) and _ewk_tiled_backing_store_recalc_renderers (which calls end_add) are good starting points. I agree with you. In order to reduce the type conversions, tiled_matrix and callers data type are better to be changed. So, I will generate new patch for it soon. In addition, as you know, eina_matrixsparse is now using unsigned long type for both col and row parameter, so, I am thinking that ewk is also better to use same parameter type for col and row. > Extra space after "and". Fixed. > From what I see, the changes made were fairly obvious, so this paragraph should not be needed. Fixed. 448529 5 hyuki.kim 2011-08-09 05:39:25 -0700 Shall i get your opinion for the 2nd patch, :-) 448583 6 102242 leandro 2011-08-09 07:34:12 -0700 Comment on attachment 102242 Patch Informal r+. 453758 7 102242 aroben 2011-08-19 05:25:20 -0700 Comment on attachment 102242 Patch Hopefully callers never pass negative values to these functions. 453788 8 102242 webkit.review.bot 2011-08-19 06:23:51 -0700 Comment on attachment 102242 Patch Clearing flags on attachment: 102242 Committed r93399: <http://trac.webkit.org/changeset/93399> 453789 9 webkit.review.bot 2011-08-19 06:23:56 -0700 All reviewed patches have been landed. Closing bug. 102227 2011-07-27 21:51:48 -0700 2011-07-28 05:16:24 -0700 Patch 0728_modify_type_of.patch text/plain 4007 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA3ODIzNTk1Li5jN2U1OTc1IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMjcgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTW9kaWZ5IHR5cGUgb2YgYm90aCBjb2wgYW5kIHJv dyBwYXJhbWV0ZXJzIGZvciBiYWNraW5nIHN0b3JlJ3MgaW50ZXJuYWwgYXBpLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzMDIKKworICAgICAgICBB cyBib3RoIGNvbCBhbmQgcm93IHBhcmFtZXRlcidzIHR5cGUgZm9yIGJvdGggX2V3a190aWxlZF9i YWNraW5nX3N0b3JlX2l0ZW1fZmlsbAorICAgICAgICBhbmQgIGV3a190aWxlZF9iYWNraW5nX3N0 b3JlX2l0ZW1fYWRkIGFyZSBkaWZmZXJlbnQgZnJvbSBlYWNoIG90aGVyLCBJIG1vZGlmeSB0eXBl IG9mIHRoZW0uCisgICAgICAgIEluIGFkZGl0aW9uLCBpbiBvcmRlciB0byBpbmNyZWFzZSByZWFk YWJpbGl0eSBvZiBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfaXRlbV9maWxsLAorICAgICAgICBz b21lIHJlbGF0ZWQgbGluZXMgb2YgdGhvc2UgcGFyYW1ldGVycyBhcmUgbW9kaWZpZWQuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBld2svZXdrX3Rp bGVkX2JhY2tpbmdfc3RvcmUuYzoKKyAgICAgICAgKF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9p dGVtX2ZpbGwpOgorICAgICAgICAoX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX2l0ZW1fYWRkKToK KwogMjAxMS0wNy0yNiAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFtFRkxdIEZpeCBwb2ludGVyIG9wZXJhdG9yIGNvZGluZyBzdHlsZSBpbiBld2tf dmlldy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2lu Z19zdG9yZS5jIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3Jl LmMKaW5kZXggM2MxZDIwZS4uMGRlZTUyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmMKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmMKQEAgLTQyNywxNiArNDI3LDEzIEBAIHN0YXRpYyBF aW5hX0Jvb2wgX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX2VuYWJsZV9yZW5kZXIoRXdrX1RpbGVk X0JhY2tpbmdfU3RvcmVfCiAgICAgcmV0dXJuIEVJTkFfVFJVRTsKIH0KIAotc3RhdGljIGlubGlu ZSBFaW5hX0Jvb2wgX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX2l0ZW1fZmlsbChFd2tfVGlsZWRf QmFja2luZ19TdG9yZV9EYXRhICpwcml2LCBFd2tfVGlsZWRfQmFja2luZ19TdG9yZV9JdGVtICpp dCwgbG9uZyBjb2wsIGludCByb3cpCitzdGF0aWMgaW5saW5lIEVpbmFfQm9vbCBfZXdrX3RpbGVk X2JhY2tpbmdfc3RvcmVfaXRlbV9maWxsKEV3a19UaWxlZF9CYWNraW5nX1N0b3JlX0RhdGEgKnBy aXYsIEV3a19UaWxlZF9CYWNraW5nX1N0b3JlX0l0ZW0gKml0LCB1bnNpZ25lZCBsb25nIGNvbCwg dW5zaWduZWQgbG9uZyByb3cpCiB7Ci0gICAgbG9uZyBtX2NvbCA9IHByaXYtPm1vZGVsLmJhc2Uu Y29sICsgY29sOwotICAgIGxvbmcgbV9yb3cgPSBwcml2LT5tb2RlbC5iYXNlLnJvdyArIHJvdzsK KyAgICB1bnNpZ25lZCBsb25nIG1fY29sID0gcHJpdi0+bW9kZWwuYmFzZS5jb2wgKyBjb2w7Cisg ICAgdW5zaWduZWQgbG9uZyBtX3JvdyA9IHByaXYtPm1vZGVsLmJhc2Uucm93ICsgcm93OwogICAg IGRvdWJsZSBsYXN0X3VzZWQgPSBlY29yZV9sb29wX3RpbWVfZ2V0KCk7CiAKLSAgICBpZiAobV9j b2wgPCAwIHx8IG1fcm93IDwgMAotICAgICAgICB8fCAodW5zaWduZWQgbG9uZykobV9jb2wpID49 IHByaXYtPm1vZGVsLmN1ci5jb2xzCi0gICAgICAgIHx8ICh1bnNpZ25lZCBsb25nKShtX3Jvdykg Pj0gcHJpdi0+bW9kZWwuY3VyLnJvd3MpIHsKLQorICAgIGlmIChtX2NvbCA+PSBwcml2LT5tb2Rl bC5jdXIuY29scyB8fCBtX3JvdyA+PSBwcml2LT5tb2RlbC5jdXIucm93cykgewogICAgICAgICBp ZiAoaXQtPnRpbGUpCiAgICAgICAgICAgICBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfdGlsZV9k aXNzb2NpYXRlKHByaXYsIGl0LCBsYXN0X3VzZWQpOwogICAgIH0gZWxzZSB7CkBAIC00NDUsMjAg KzQ0MiwxNCBAQCBzdGF0aWMgaW5saW5lIEVpbmFfQm9vbCBfZXdrX3RpbGVkX2JhY2tpbmdfc3Rv cmVfaXRlbV9maWxsKEV3a19UaWxlZF9CYWNraW5nX1N0bwogCiAgICAgICAgIGlmIChpdC0+dGls ZSkgewogICAgICAgICAgICAgRXdrX1RpbGUgKm9sZCA9IGl0LT50aWxlOwotICAgICAgICAgICAg aWYgKG9sZC0+cm93ICE9ICh1bnNpZ25lZCBsb25nKShtX3JvdykKLSAgICAgICAgICAgICAgICB8 fCBvbGQtPmNvbCAhPSAodW5zaWduZWQgbG9uZykobV9jb2wpCi0gICAgICAgICAgICAgICAgfHwg b2xkLT56b29tICE9IHpvb20pIHsKLSAgICAgICAgICAgICAgICBfZXdrX3RpbGVkX2JhY2tpbmdf c3RvcmVfdGlsZV9kaXNzb2NpYXRlKHByaXYsIGl0LAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGFzdF91c2VkKTsKLQotICAgICAgICAg ICAgfSBlbHNlIGlmIChvbGQtPnJvdyA9PSAodW5zaWduZWQgbG9uZykobV9yb3cpCi0gICAgICAg ICAgICAgICAgICAgICAgICYmIG9sZC0+Y29sID09ICh1bnNpZ25lZCBsb25nKShtX2NvbCkKLSAg ICAgICAgICAgICAgICAgICAgICAgJiYgb2xkLT56b29tID09IHpvb20pCisgICAgICAgICAgICBp ZiAob2xkLT5yb3cgIT0gbV9yb3cgfHwgb2xkLT5jb2wgIT0gbV9jb2wgfHwgb2xkLT56b29tICE9 IHpvb20pCisgICAgICAgICAgICAgICAgX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX3RpbGVfZGlz c29jaWF0ZShwcml2LCBpdCwgbGFzdF91c2VkKTsKKyAgICAgICAgICAgIGVsc2UgaWYgKG9sZC0+ cm93ID09IG1fcm93ICYmIG9sZC0+Y29sID09IG1fY29sICYmIG9sZC0+em9vbSA9PSB6b29tKQog ICAgICAgICAgICAgICAgIGdvdG8gZW5kOwogICAgICAgICB9CiAKLSAgICAgICAgdCA9IGV3a190 aWxlX21hdHJpeF90aWxlX2V4YWN0X2dldAotICAgICAgICAgICAgKHByaXYtPm1vZGVsLm1hdHJp eCwgbV9jb2wsIG1fcm93LCB6b29tKTsKKyAgICAgICAgdCA9IGV3a190aWxlX21hdHJpeF90aWxl X2V4YWN0X2dldChwcml2LT5tb2RlbC5tYXRyaXgsIG1fY29sLCBtX3Jvdywgem9vbSk7CisKICAg ICAgICAgaWYgKCF0KSB7CiAgICAgICAgICAgICAvKiBOT1RFOiBpdCBuZXZlciByZXR1cm5zIE5V TEwgaWYgaXQtPnRpbGUgd2FzIHNldCEgKi8KICAgICAgICAgICAgIGlmIChpdC0+dGlsZSkgewpA QCAtNDg5LDcgKzQ4MCw3IEBAIHN0YXRpYyBpbmxpbmUgRWluYV9Cb29sIF9ld2tfdGlsZWRfYmFj a2luZ19zdG9yZV9pdGVtX2ZpbGwoRXdrX1RpbGVkX0JhY2tpbmdfU3RvCiAgICAgcmV0dXJuIEVJ TkFfVFJVRTsKIH0KIAotc3RhdGljIEV3a19UaWxlZF9CYWNraW5nX1N0b3JlX0l0ZW0gKl9ld2tf dGlsZWRfYmFja2luZ19zdG9yZV9pdGVtX2FkZChFd2tfVGlsZWRfQmFja2luZ19TdG9yZV9EYXRh ICpwcml2LCBsb25nIGNvbCwgaW50IHJvdykKK3N0YXRpYyBFd2tfVGlsZWRfQmFja2luZ19TdG9y ZV9JdGVtICpfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfaXRlbV9hZGQoRXdrX1RpbGVkX0JhY2tp bmdfU3RvcmVfRGF0YSAqcHJpdiwgdW5zaWduZWQgbG9uZyBjb2wsIHVuc2lnbmVkIGxvbmcgcm93 KQogewogICAgIEV3a19UaWxlZF9CYWNraW5nX1N0b3JlX0l0ZW0gKml0OwogICAgIEV2YXNfQ29v cmQgeCwgeSwgdHcsIHRoOwo= 102242 2011-07-28 05:16:24 -0700 2011-08-19 06:23:51 -0700 Patch 0728_modify_type_of_2.patch text/plain 3850 hyuki.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA3ODIzNTk1Li5lNDQ2NzE3IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMjcgIEt3YW5nSHl1ayBLaW0gIDxoeXVraS5raW1Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gTW9kaWZ5IHR5cGUgb2YgYm90aCBjb2wgYW5kIHJv dyBwYXJhbWV0ZXJzIGZvciBiYWNraW5nIHN0b3JlJ3MgaW50ZXJuYWwgYXBpLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzMDIKKworICAgICAgICBB cyBib3RoIGNvbCBhbmQgcm93IHBhcmFtZXRlcidzIHR5cGUgZm9yIGJvdGggX2V3a190aWxlZF9i YWNraW5nX3N0b3JlX2l0ZW1fZmlsbAorICAgICAgICBhbmQgZXdrX3RpbGVkX2JhY2tpbmdfc3Rv cmVfaXRlbV9hZGQgYXJlIGRpZmZlcmVudCBmcm9tIGVhY2ggb3RoZXIsIEkgbW9kaWZ5IHR5cGUg b2YgdGhlbS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGV3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9yZS5jOgorICAgICAgICAoX2V3a190aWxlZF9i YWNraW5nX3N0b3JlX2l0ZW1fZmlsbCk6CisgICAgICAgIChfZXdrX3RpbGVkX2JhY2tpbmdfc3Rv cmVfaXRlbV9hZGQpOgorCiAyMDExLTA3LTI2ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1A c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gRml4IHBvaW50ZXIgb3BlcmF0b3IgY29kaW5n IHN0eWxlIGluIGV3a192aWV3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a190aWxlZF9iYWNraW5nX3N0b3JlLmMgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVk X2JhY2tpbmdfc3RvcmUuYwppbmRleCAzYzFkMjBlLi4wZGVlNTIyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuYworKysgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuYwpAQCAtNDI3LDE2ICs0Mjcs MTMgQEAgc3RhdGljIEVpbmFfQm9vbCBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfZW5hYmxlX3Jl bmRlcihFd2tfVGlsZWRfQmFja2luZ19TdG9yZV8KICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQog Ci1zdGF0aWMgaW5saW5lIEVpbmFfQm9vbCBfZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmVfaXRlbV9m aWxsKEV3a19UaWxlZF9CYWNraW5nX1N0b3JlX0RhdGEgKnByaXYsIEV3a19UaWxlZF9CYWNraW5n X1N0b3JlX0l0ZW0gKml0LCBsb25nIGNvbCwgaW50IHJvdykKK3N0YXRpYyBpbmxpbmUgRWluYV9C b29sIF9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9pdGVtX2ZpbGwoRXdrX1RpbGVkX0JhY2tpbmdf U3RvcmVfRGF0YSAqcHJpdiwgRXdrX1RpbGVkX0JhY2tpbmdfU3RvcmVfSXRlbSAqaXQsIHVuc2ln bmVkIGxvbmcgY29sLCB1bnNpZ25lZCBsb25nIHJvdykKIHsKLSAgICBsb25nIG1fY29sID0gcHJp di0+bW9kZWwuYmFzZS5jb2wgKyBjb2w7Ci0gICAgbG9uZyBtX3JvdyA9IHByaXYtPm1vZGVsLmJh c2Uucm93ICsgcm93OworICAgIHVuc2lnbmVkIGxvbmcgbV9jb2wgPSBwcml2LT5tb2RlbC5iYXNl LmNvbCArIGNvbDsKKyAgICB1bnNpZ25lZCBsb25nIG1fcm93ID0gcHJpdi0+bW9kZWwuYmFzZS5y b3cgKyByb3c7CiAgICAgZG91YmxlIGxhc3RfdXNlZCA9IGVjb3JlX2xvb3BfdGltZV9nZXQoKTsK IAotICAgIGlmIChtX2NvbCA8IDAgfHwgbV9yb3cgPCAwCi0gICAgICAgIHx8ICh1bnNpZ25lZCBs b25nKShtX2NvbCkgPj0gcHJpdi0+bW9kZWwuY3VyLmNvbHMKLSAgICAgICAgfHwgKHVuc2lnbmVk IGxvbmcpKG1fcm93KSA+PSBwcml2LT5tb2RlbC5jdXIucm93cykgewotCisgICAgaWYgKG1fY29s ID49IHByaXYtPm1vZGVsLmN1ci5jb2xzIHx8IG1fcm93ID49IHByaXYtPm1vZGVsLmN1ci5yb3dz KSB7CiAgICAgICAgIGlmIChpdC0+dGlsZSkKICAgICAgICAgICAgIF9ld2tfdGlsZWRfYmFja2lu Z19zdG9yZV90aWxlX2Rpc3NvY2lhdGUocHJpdiwgaXQsIGxhc3RfdXNlZCk7CiAgICAgfSBlbHNl IHsKQEAgLTQ0NSwyMCArNDQyLDE0IEBAIHN0YXRpYyBpbmxpbmUgRWluYV9Cb29sIF9ld2tfdGls ZWRfYmFja2luZ19zdG9yZV9pdGVtX2ZpbGwoRXdrX1RpbGVkX0JhY2tpbmdfU3RvCiAKICAgICAg ICAgaWYgKGl0LT50aWxlKSB7CiAgICAgICAgICAgICBFd2tfVGlsZSAqb2xkID0gaXQtPnRpbGU7 Ci0gICAgICAgICAgICBpZiAob2xkLT5yb3cgIT0gKHVuc2lnbmVkIGxvbmcpKG1fcm93KQotICAg ICAgICAgICAgICAgIHx8IG9sZC0+Y29sICE9ICh1bnNpZ25lZCBsb25nKShtX2NvbCkKLSAgICAg ICAgICAgICAgICB8fCBvbGQtPnpvb20gIT0gem9vbSkgewotICAgICAgICAgICAgICAgIF9ld2tf dGlsZWRfYmFja2luZ19zdG9yZV90aWxlX2Rpc3NvY2lhdGUocHJpdiwgaXQsCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsYXN0X3VzZWQp OwotCi0gICAgICAgICAgICB9IGVsc2UgaWYgKG9sZC0+cm93ID09ICh1bnNpZ25lZCBsb25nKSht X3JvdykKLSAgICAgICAgICAgICAgICAgICAgICAgJiYgb2xkLT5jb2wgPT0gKHVuc2lnbmVkIGxv bmcpKG1fY29sKQotICAgICAgICAgICAgICAgICAgICAgICAmJiBvbGQtPnpvb20gPT0gem9vbSkK KyAgICAgICAgICAgIGlmIChvbGQtPnJvdyAhPSBtX3JvdyB8fCBvbGQtPmNvbCAhPSBtX2NvbCB8 fCBvbGQtPnpvb20gIT0gem9vbSkKKyAgICAgICAgICAgICAgICBfZXdrX3RpbGVkX2JhY2tpbmdf c3RvcmVfdGlsZV9kaXNzb2NpYXRlKHByaXYsIGl0LCBsYXN0X3VzZWQpOworICAgICAgICAgICAg ZWxzZSBpZiAob2xkLT5yb3cgPT0gbV9yb3cgJiYgb2xkLT5jb2wgPT0gbV9jb2wgJiYgb2xkLT56 b29tID09IHpvb20pCiAgICAgICAgICAgICAgICAgZ290byBlbmQ7CiAgICAgICAgIH0KIAotICAg ICAgICB0ID0gZXdrX3RpbGVfbWF0cml4X3RpbGVfZXhhY3RfZ2V0Ci0gICAgICAgICAgICAocHJp di0+bW9kZWwubWF0cml4LCBtX2NvbCwgbV9yb3csIHpvb20pOworICAgICAgICB0ID0gZXdrX3Rp bGVfbWF0cml4X3RpbGVfZXhhY3RfZ2V0KHByaXYtPm1vZGVsLm1hdHJpeCwgbV9jb2wsIG1fcm93 LCB6b29tKTsKKwogICAgICAgICBpZiAoIXQpIHsKICAgICAgICAgICAgIC8qIE5PVEU6IGl0IG5l dmVyIHJldHVybnMgTlVMTCBpZiBpdC0+dGlsZSB3YXMgc2V0ISAqLwogICAgICAgICAgICAgaWYg KGl0LT50aWxlKSB7CkBAIC00ODksNyArNDgwLDcgQEAgc3RhdGljIGlubGluZSBFaW5hX0Jvb2wg X2V3a190aWxlZF9iYWNraW5nX3N0b3JlX2l0ZW1fZmlsbChFd2tfVGlsZWRfQmFja2luZ19TdG8K ICAgICByZXR1cm4gRUlOQV9UUlVFOwogfQogCi1zdGF0aWMgRXdrX1RpbGVkX0JhY2tpbmdfU3Rv cmVfSXRlbSAqX2V3a190aWxlZF9iYWNraW5nX3N0b3JlX2l0ZW1fYWRkKEV3a19UaWxlZF9CYWNr aW5nX1N0b3JlX0RhdGEgKnByaXYsIGxvbmcgY29sLCBpbnQgcm93KQorc3RhdGljIEV3a19UaWxl ZF9CYWNraW5nX1N0b3JlX0l0ZW0gKl9ld2tfdGlsZWRfYmFja2luZ19zdG9yZV9pdGVtX2FkZChF d2tfVGlsZWRfQmFja2luZ19TdG9yZV9EYXRhICpwcml2LCB1bnNpZ25lZCBsb25nIGNvbCwgdW5z aWduZWQgbG9uZyByb3cpCiB7CiAgICAgRXdrX1RpbGVkX0JhY2tpbmdfU3RvcmVfSXRlbSAqaXQ7 CiAgICAgRXZhc19Db29yZCB4LCB5LCB0dywgdGg7Cg==