65300 2011-07-27 20:50:53 -0700 Improve StringImpl::stripWhiteSpace() and simplifyWhiteSpace(). 2011-07-28 00:38:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tkent tkent darin shinyak webkit.review.bot oldest_to_newest 443300 0 tkent 2011-07-27 20:50:53 -0700 http://trac.webkit.org/changeset/91837 should have made the performance of stripWhiteSpace() and simplifyWhiteSpace() worse. 443321 1 102224 tkent 2011-07-27 21:37:02 -0700 Created attachment 102224 Patch 443323 2 tkent 2011-07-27 21:40:09 -0700 (In reply to comment #1) > Created an attachment (id=102224) [details] > Patch I confirmed the compiled code of stripWhiteSpace() contained inlined stripMatchedCharacters() and inlined isSpaceOrNewLine(), and the compiled code of simplifyWhiteSpace(9 contained inlined simplifyMatchedCharactersToSpace() and inlined isSpaceOrNewLine(). 443370 3 102224 darin 2011-07-27 23:42:03 -0700 Comment on attachment 102224 Patch OK. Thanks. 443375 4 102224 tkent 2011-07-27 23:57:28 -0700 Comment on attachment 102224 Patch Thank you for reviewing! 443382 5 102224 webkit.review.bot 2011-07-28 00:38:39 -0700 Comment on attachment 102224 Patch Clearing flags on attachment: 102224 Committed r91913: <http://trac.webkit.org/changeset/91913> 443383 6 webkit.review.bot 2011-07-28 00:38:43 -0700 All reviewed patches have been landed. Closing bug. 102224 2011-07-27 21:37:02 -0700 2011-07-28 00:38:39 -0700 Patch bug-65300-20110728133700.patch text/plain 6502 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTE4OTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGZk NWY4MGU2ZGQwZjZjMjNhMjM1ODkzODFkYzk2M2FmYTg4ZjJiOTUuLjlhMGZlYjE0MzFhZGRmMDIz ZWQyNDUwOTM0YTM1MjUwMzgwYWIxYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDI5IEBACisyMDExLTA3LTI3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4K KworICAgICAgICBJbXByb3ZlIFN0cmluZ0ltcGw6OnN0cmlwV2hpdGVTcGFjZSgpIGFuZCBzaW1w bGlmeVdoaXRlU3BhY2UoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTY1MzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgcjkxODM3IGhhZCBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIG9mIFN0cmluZ0ltcGw6 OnN0cmlwV2hpdGVTcGFjZSgpCisgICAgICAgIGFuZCBzaW1wbGlmeVdoaXRlU3BhY2UoKS4gVGhp cyBjaGFuZ2VzIHRoZSBjb2RlIHNvIHRoYXQgY29tcGlsZXJzCisgICAgICAgIGdlbmVyYXRlcyBj b2RlIGVxdWl2YWxlbnQgdG8gcjkxODM2IG9yIHBpcm9yLgorCisgICAgICAgICogd3RmL3RleHQv U3RyaW5nSW1wbC5jcHA6CisgICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OnN0cmlwTWF0Y2hlZENo YXJhY3RlcnMpOgorICAgICAgICBBIHRlbXBsYXRlIG1lbWJlciBmdW5jdGlvbiBmb3Igc3RyaXBX aGl0ZVNwYWNlKCkuIFRoaXMgZnVuY3Rpb24gdGFrZXMgYSBmdW5jdG9yLgorICAgICAgICAoV1RG OjpVQ2hhclByZWRpY2F0ZSk6CisgICAgICAgIEEgZnVuY3RvciBmb3IgZ2VuZXJpYyBwcmVkaWNh dGUgZm9yIHNpbmdsZSBVQ2hhciBhcmd1bWVudC4KKyAgICAgICAgKFdURjo6U3BhY2VPck5ld2xp bmVQcmVkaWNhdGUpOgorICAgICAgICBBIHNwZWNpYWwgZnVuY3RvciBmb3IgaXNTcGFjZU9yTmV3 bGluZSgpLgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjpzdHJpcFdoaXRlU3BhY2UpOgorICAg ICAgICBVc2Ugc3RyaXBtYXRjaGVkQ2hhcmFjdGVycygpLgorICAgICAgICAoV1RGOjpTdHJpbmdJ bXBsOjpzaW1wbGlmeU1hdGNoZWRDaGFyYWN0ZXJzVG9TcGFjZSk6CisgICAgICAgIEEgdGVtcGxh dGUgbWVtYmVyIGZ1bmN0aW9uIGZvciBzaW1wbGlmeVdoaXRlU3BhY2UoKS4KKyAgICAgICAgKFdU Rjo6U3RyaW5nSW1wbDo6c2ltcGxpZnlXaGl0ZVNwYWNlKToKKyAgICAgICAgVXNlIHNpbXBsaWZ5 TWF0Y2hlZENoYXJhY3RlcnNUb1NwYWNlKCkuCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nSW1w bC5oOgorCiAyMDExLTA3LTI3ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxl LmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjUyOTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJ bXBsLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcApp bmRleCA2YmM2ZDMyMmYwNzg3MDhmZTA0MDNmOGE4NTQwMzhlZGJkMDkwNzQzLi5hODNkZDEyZTFh NzU2ZjNhNjQwMzMyZDY4NWRmODgwNDhlODE4MzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCkBAIC0zMTMsMTIgKzMxMyw4IEBAIFBhc3NSZWZQ dHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6Zm9sZENhc2UoKQogICAgIHJldHVybiBuZXdJbXBs LnJlbGVhc2UoKTsKIH0KIAotUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpzdHJp cFdoaXRlU3BhY2UoKQotewotICAgIHJldHVybiBzdHJpcFdoaXRlU3BhY2UoaXNTcGFjZU9yTmV3 bGluZSk7Ci19Ci0KLVBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6c3RyaXBXaGl0 ZVNwYWNlKElzV2hpdGVTcGFjZUZ1bmN0aW9uUHRyIGlzV2hpdGVTcGFjZSkKK3RlbXBsYXRlIDxj bGFzcyBVQ2hhclByZWRpY2F0ZT4KK2lubGluZSBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IFN0cmlu Z0ltcGw6OnN0cmlwTWF0Y2hlZENoYXJhY3RlcnMoVUNoYXJQcmVkaWNhdGUgcHJlZGljYXRlKQog ewogICAgIGlmICghbV9sZW5ndGgpCiAgICAgICAgIHJldHVybiBlbXB0eSgpOwpAQCAtMzI3LDcg KzMyMyw3IEBAIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6c3RyaXBXaGl0ZVNw YWNlKElzV2hpdGVTcGFjZUZ1bmN0aW9uUHRyIGlzV2hpCiAgICAgdW5zaWduZWQgZW5kID0gbV9s ZW5ndGggLSAxOwogICAgIAogICAgIC8vIHNraXAgd2hpdGUgc3BhY2UgZnJvbSBzdGFydAotICAg IHdoaWxlIChzdGFydCA8PSBlbmQgJiYgaXNXaGl0ZVNwYWNlKG1fZGF0YVtzdGFydF0pKQorICAg IHdoaWxlIChzdGFydCA8PSBlbmQgJiYgcHJlZGljYXRlKG1fZGF0YVtzdGFydF0pKQogICAgICAg ICBzdGFydCsrOwogICAgIAogICAgIC8vIG9ubHkgd2hpdGUgc3BhY2UKQEAgLTMzNSw3ICszMzEs NyBAQCBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IFN0cmluZ0ltcGw6OnN0cmlwV2hpdGVTcGFjZShJ c1doaXRlU3BhY2VGdW5jdGlvblB0ciBpc1doaQogICAgICAgICByZXR1cm4gZW1wdHkoKTsKIAog ICAgIC8vIHNraXAgd2hpdGUgc3BhY2UgZnJvbSBlbmQKLSAgICB3aGlsZSAoZW5kICYmIGlzV2hp dGVTcGFjZShtX2RhdGFbZW5kXSkpCisgICAgd2hpbGUgKGVuZCAmJiBwcmVkaWNhdGUobV9kYXRh W2VuZF0pKQogICAgICAgICBlbmQtLTsKIAogICAgIGlmICghc3RhcnQgJiYgZW5kID09IG1fbGVu Z3RoIC0gMSkKQEAgLTM0Myw2ICszMzksMzcgQEAgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJp bmdJbXBsOjpzdHJpcFdoaXRlU3BhY2UoSXNXaGl0ZVNwYWNlRnVuY3Rpb25QdHIgaXNXaGkKICAg ICByZXR1cm4gY3JlYXRlKG1fZGF0YSArIHN0YXJ0LCBlbmQgKyAxIC0gc3RhcnQpOwogfQogCitj bGFzcyBVQ2hhclByZWRpY2F0ZSB7CitwdWJsaWM6CisgICAgaW5saW5lIFVDaGFyUHJlZGljYXRl KENoYXJhY3Rlck1hdGNoRnVuY3Rpb25QdHIgZnVuY3Rpb24pOiBtX2Z1bmN0aW9uKGZ1bmN0aW9u KSB7IH0KKworICAgIGlubGluZSBib29sIG9wZXJhdG9yKCkoVUNoYXIgY2gpIGNvbnN0CisgICAg eworICAgICAgICByZXR1cm4gbV9mdW5jdGlvbihjaCk7CisgICAgfQorCitwcml2YXRlOgorICAg IGNvbnN0IENoYXJhY3Rlck1hdGNoRnVuY3Rpb25QdHIgbV9mdW5jdGlvbjsKK307CisKK2NsYXNz IFNwYWNlT3JOZXdsaW5lUHJlZGljYXRlIHsKK3B1YmxpYzoKKyAgICBpbmxpbmUgYm9vbCBvcGVy YXRvcigpKFVDaGFyIGNoKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIGlzU3BhY2VPck5l d2xpbmUoY2gpOworICAgIH0KK307CisKK1Bhc3NSZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1w bDo6c3RyaXBXaGl0ZVNwYWNlKCkKK3sKKyAgICByZXR1cm4gc3RyaXBNYXRjaGVkQ2hhcmFjdGVy cyhTcGFjZU9yTmV3bGluZVByZWRpY2F0ZSgpKTsKK30KKworUGFzc1JlZlB0cjxTdHJpbmdJbXBs PiBTdHJpbmdJbXBsOjpzdHJpcFdoaXRlU3BhY2UoSXNXaGl0ZVNwYWNlRnVuY3Rpb25QdHIgaXNX aGl0ZVNwYWNlKQoreworICAgIHJldHVybiBzdHJpcE1hdGNoZWRDaGFyYWN0ZXJzKFVDaGFyUHJl ZGljYXRlKGlzV2hpdGVTcGFjZSkpOworfQorCiBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IFN0cmlu Z0ltcGw6OnJlbW92ZUNoYXJhY3RlcnMoQ2hhcmFjdGVyTWF0Y2hGdW5jdGlvblB0ciBmaW5kTWF0 Y2gpCiB7CiAgICAgY29uc3QgVUNoYXIqIGZyb20gPSBtX2RhdGE7CkBAIC0zNzUsMTIgKzQwMiw4 IEBAIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6cmVtb3ZlQ2hhcmFjdGVycyhD aGFyYWN0ZXJNYXRjaEZ1bmN0aW9uUHRyIGZpCiAgICAgcmV0dXJuIGFkb3B0KGRhdGEpOwogfQog Ci1QYXNzUmVmUHRyPFN0cmluZ0ltcGw+IFN0cmluZ0ltcGw6OnNpbXBsaWZ5V2hpdGVTcGFjZSgp Ci17Ci0gICAgcmV0dXJuIFN0cmluZ0ltcGw6OnNpbXBsaWZ5V2hpdGVTcGFjZShpc1NwYWNlT3JO ZXdsaW5lKTsKLX0KLQotUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpzaW1wbGlm eVdoaXRlU3BhY2UoSXNXaGl0ZVNwYWNlRnVuY3Rpb25QdHIgaXNXaGl0ZVNwYWNlKQordGVtcGxh dGUgPGNsYXNzIFVDaGFyUHJlZGljYXRlPgoraW5saW5lIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4g U3RyaW5nSW1wbDo6c2ltcGxpZnlNYXRjaGVkQ2hhcmFjdGVyc1RvU3BhY2UoVUNoYXJQcmVkaWNh dGUgcHJlZGljYXRlKQogewogICAgIFN0cmluZ0J1ZmZlciBkYXRhKG1fbGVuZ3RoKTsKIApAQCAt MzkyLDEyICs0MTUsMTIgQEAgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpzaW1w bGlmeVdoaXRlU3BhY2UoSXNXaGl0ZVNwYWNlRnVuY3Rpb25QdHIgaXMKICAgICBVQ2hhciogdG8g PSBkYXRhLmNoYXJhY3RlcnMoKTsKICAgICAKICAgICB3aGlsZSAodHJ1ZSkgewotICAgICAgICB3 aGlsZSAoZnJvbSAhPSBmcm9tZW5kICYmIGlzV2hpdGVTcGFjZSgqZnJvbSkpIHsKKyAgICAgICAg d2hpbGUgKGZyb20gIT0gZnJvbWVuZCAmJiBwcmVkaWNhdGUoKmZyb20pKSB7CiAgICAgICAgICAg ICBpZiAoKmZyb20gIT0gJyAnKQogICAgICAgICAgICAgICAgIGNoYW5nZWRUb1NwYWNlID0gdHJ1 ZTsKICAgICAgICAgICAgIGZyb20rKzsKICAgICAgICAgfQotICAgICAgICB3aGlsZSAoZnJvbSAh PSBmcm9tZW5kICYmICFpc1doaXRlU3BhY2UoKmZyb20pKQorICAgICAgICB3aGlsZSAoZnJvbSAh PSBmcm9tZW5kICYmICFwcmVkaWNhdGUoKmZyb20pKQogICAgICAgICAgICAgdG9bb3V0YysrXSA9 ICpmcm9tKys7CiAgICAgICAgIGlmIChmcm9tICE9IGZyb21lbmQpCiAgICAgICAgICAgICB0b1tv dXRjKytdID0gJyAnOwpAQCAtNDE2LDYgKzQzOSwxNiBAQCBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+ IFN0cmluZ0ltcGw6OnNpbXBsaWZ5V2hpdGVTcGFjZShJc1doaXRlU3BhY2VGdW5jdGlvblB0ciBp cwogICAgIHJldHVybiBhZG9wdChkYXRhKTsKIH0KIAorUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBT dHJpbmdJbXBsOjpzaW1wbGlmeVdoaXRlU3BhY2UoKQoreworICAgIHJldHVybiBTdHJpbmdJbXBs OjpzaW1wbGlmeU1hdGNoZWRDaGFyYWN0ZXJzVG9TcGFjZShTcGFjZU9yTmV3bGluZVByZWRpY2F0 ZSgpKTsKK30KKworUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpzaW1wbGlmeVdo aXRlU3BhY2UoSXNXaGl0ZVNwYWNlRnVuY3Rpb25QdHIgaXNXaGl0ZVNwYWNlKQoreworICAgIHJl dHVybiBTdHJpbmdJbXBsOjpzaW1wbGlmeU1hdGNoZWRDaGFyYWN0ZXJzVG9TcGFjZShVQ2hhclBy ZWRpY2F0ZShpc1doaXRlU3BhY2UpKTsKK30KKwogaW50IFN0cmluZ0ltcGw6OnRvSW50U3RyaWN0 KGJvb2wqIG9rLCBpbnQgYmFzZSkKIHsKICAgICByZXR1cm4gY2hhcmFjdGVyc1RvSW50U3RyaWN0 KG1fZGF0YSwgbV9sZW5ndGgsIG9rLCBiYXNlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3Rm L3RleHQvU3RyaW5nSW1wbC5oCmluZGV4IDRkNzEyMTAxN2JlMzY0NDhjOGU1NGVlM2Y0YThkODlh ZDhlOTAzODQuLjYyYTI2ZGIwNWQzMGQzYTRkMWUxNGJjNDdlNzA0NGI3OTlmMDBkNTMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaApAQCAtMzMxLDYgKzMz MSw5IEBAIHByaXZhdGU6CiAgICAgCiAgICAgQnVmZmVyT3duZXJzaGlwIGJ1ZmZlck93bmVyc2hp cCgpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PEJ1ZmZlck93bmVyc2hpcD4obV9yZWZDb3Vu dEFuZEZsYWdzICYgc19yZWZDb3VudE1hc2tCdWZmZXJPd25lcnNoaXApOyB9CiAgICAgYm9vbCBp c1N0YXRpYygpIGNvbnN0IHsgcmV0dXJuIG1fcmVmQ291bnRBbmRGbGFncyAmIHNfcmVmQ291bnRG bGFnU3RhdGljOyB9CisgICAgdGVtcGxhdGUgPGNsYXNzIFVDaGFyUHJlZGljYXRlPiBQYXNzUmVm UHRyPFN0cmluZ0ltcGw+IHN0cmlwTWF0Y2hlZENoYXJhY3RlcnMoVUNoYXJQcmVkaWNhdGUpOwor ICAgIHRlbXBsYXRlIDxjbGFzcyBVQ2hhclByZWRpY2F0ZT4gUGFzc1JlZlB0cjxTdHJpbmdJbXBs PiBzaW1wbGlmeU1hdGNoZWRDaGFyYWN0ZXJzVG9TcGFjZShVQ2hhclByZWRpY2F0ZSk7CisKICAg ICBjb25zdCBVQ2hhciogbV9kYXRhOwogICAgIHVuaW9uIHsKICAgICAgICAgdm9pZCogbV9idWZm ZXI7Cg==