65295 2011-07-27 17:37:30 -0700 Remove skia special case for outline rendering code 2011-07-27 22:23:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benwells benwells jamesr mikelawther simon.fraser webkit.review.bot oldest_to_newest 443239 0 benwells 2011-07-27 17:37:30 -0700 Webkit bug 58999 fixed rendering of outlines with an alpha channel, but was held back from skia until webkit bug 61369 was fixed. This change brings the fix to skia. 443259 1 102212 benwells 2011-07-27 18:30:49 -0700 Created attachment 102212 Patch 443283 2 102212 jamesr 2011-07-27 19:41:37 -0700 Comment on attachment 102212 Patch OK 443340 3 102212 webkit.review.bot 2011-07-27 22:23:04 -0700 Comment on attachment 102212 Patch Clearing flags on attachment: 102212 Committed r91907: <http://trac.webkit.org/changeset/91907> 443341 4 webkit.review.bot 2011-07-27 22:23:08 -0700 All reviewed patches have been landed. Closing bug. 102212 2011-07-27 18:30:49 -0700 2011-07-27 22:23:04 -0700 Patch bug-65295-20110728113046.patch text/plain 6051 benwells U3VidmVyc2lvbiBSZXZpc2lvbjogOTE4MjQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkZDkxMzBiODM0MmUzNGRhN2JhMzg0 YzViZjc0ZGU3OWY4NWRkYjgzLi44OTZhYmJkZjI1NzFhMTExYTZlZGU1MmQxYjM4Yjk0M2RjMWM2 MDY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDctMjcgIEJlbiBXZWxscyAgPGJlbndl bGxzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgc2tpYSBzcGVjaWFsIGNhc2UgZm9y IG91dGxpbmUgcmVuZGVyaW5nIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY1Mjk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6 CisKIDIwMTEtMDctMjYgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4K IAogICAgICAgICByZWR1Y2UgYW5kIHJlZHVjZVJpZ2h0IGJpbmQgY2FsbGJhY2sncyB0aGlzIHRv IG51bGwgcmF0aGVyIHRoYW4gdW5kZWZpbmVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggZGIyYWQ4YzNhZmI2MGNkN2E4 OGRiOGFkZThhZTg3MTViYTA0OThkMi4uZmM3M2U5ZmZlMGNjYTVlODA1OTkxMjIwODI4MGMwNjIw NzU1YzBmOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dApAQCAtMzkyOSwzICszOTI5LDggQEAgQlVHV0s2NDY5MiBXSU4gOiBm YXN0L2Zvcm1zL2ZpbGUtaW5wdXQtZGlzYWJsZWQuaHRtbCA9IElNQUdFCiBCVUdXSzY1MTk5IE1B QyA6IGZhc3QvYmxvY2tmbG93L2Jyb2tlbi1pZGVvZ3JhcGgtc21hbGwtY2Fwcy5odG1sID0gUEFT UyBGQUlMCiAKIEJVR1dLNjUyMTkgV0lOIDogd2ViYXVkaW8vdGVzdC1iYXNpYy5odG1sID0gUEFT UyBDUkFTSAorCisvLyBOZWVkcyBuZXcgYmFzZWxpbmUgZm9yIHNsaWdodCBwaXhlbCB2YWx1ZSBj aGFuZ2VzIGR1ZSB0byBjaGFuZ2VzIGluCisvLyBob3cgYWxwaGEgYmxlbmRlZCBvdXRsaW5lcyBh cmUgZHJhd24uCitCVUdXSzY1Mjk1IFdJTiBMSU5VWCA6IGZhc3QvYm94LXNoYWRvdy9ib3gtc2hh ZG93LXJhZGl1cy5odG1sID0gSU1BR0UKK0JVR1dLNjUyOTUgV0lOIExJTlVYIDogZmFzdC9sYXll cnMvc2VsZi1wYWludGluZy1vdXRsaW5lLmh0bWwgPSBJTUFHRQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdiYTZh MDY0MmFlMmRlYTU2Yjg0ZjczYTJkMjcwMThmMTg4NWQ1YTQuLjRmOGNhZWE3MDBkNTMxMWZlNjIx ZTcxZDI5ODBiYTQ2ZmU5ZTFjZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0w Ny0yNyAgQmVuIFdlbGxzICA8YmVud2VsbHNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92 ZSBza2lhIHNwZWNpYWwgY2FzZSBmb3Igb3V0bGluZSByZW5kZXJpbmcgY29kZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUyOTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZml4IGZvciBidWcgNTg5 OTkgKG91dGxpbmVzIHdpdGggYWxwaGEgY2hhbm5lbHMgc2hvd2VkIGFydGlmYWN0cyBpbiB0aGUg Y29ybmVycykgd2FzCisgICAgICAgIGV4Y2x1ZGVkIGZyb20gc2tpYSBidWlsZHMgdW50aWwgYnVn IDYxMzY5IChza2lhIGRyYXdDb252ZXhQb2x5IGRpZG4ndCBwYXkgYXR0ZW50aW9uIHRvCisgICAg ICAgIHNob3VsZEFudGlhbGlhcykgd2FzIGZpeGVkLiBUaGF0IGJ1ZyBpcyBmaXhlZCBzbyBub3cg dGhlICNpZidzIGNhbiBiZSByZW1vdmVkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcklu bGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJbmxpbmU6OnBhaW50T3V0bGluZSk6 CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJPYmplY3Q6OnBhaW50T3V0bGluZSk6CisKIDIwMTEtMDctMjYgIEphbWVzIFJvYmlu c29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFJFR1JFU1NJ T04oOTA5NjMpOiBDb250ZW50IGxheWVycyBhcmUgbm90IHJlZHJhd24gYWZ0ZXIgbG9zaW5nIHRo ZSBjb21wb3NpdG9yIGNvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJJbmxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGlu ZS5jcHAKaW5kZXggZTRiNDU1YmI2NTY3MGZhMzg5OTdlZGVmYTBiMTliOWQwMDgzOGIzMi4uNTgw ZmRlZGM1YmM5ZGZmYTJmMGUzN2MxYWY3ZTVlYTFhZjY1OWM0OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAKQEAgLTEzOTQsMjUgKzEzOTQsMTcgQEAgdm9pZCBS ZW5kZXJJbmxpbmU6OnBhaW50T3V0bGluZShHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4 dCwgY29uc3QgTGF5b3V0UG8KICAgICByZWN0cy5hcHBlbmQoTGF5b3V0UmVjdCgpKTsKIAogICAg IENvbG9yIG91dGxpbmVDb2xvciA9IHN0eWxlVG9Vc2UtPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihD U1NQcm9wZXJ0eU91dGxpbmVDb2xvcik7Ci0vLyBGSVhNRTogVXNpbmcgYSB0cmFuc3BhcmVuY3kg bGF5ZXIgZm9yIHJnYmEgb3V0bGluZXMgZXhhY2VyYmF0ZXMgYW4gZXhpc3RpbmcgU0tJQSBidWcu IFRoZSAjaWYKLS8vIGJlbG93IHByZXZlbnRzIHRoaXM7IGl0IHNob3VsZCBiZSByZW1vdmVkIHdo ZW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwMzQyIGlzIGZpeGVk LgotI2lmICFVU0UoU0tJQSkKICAgICBib29sIHVzZVRyYW5zcGFyZW5jeUxheWVyID0gb3V0bGlu ZUNvbG9yLmhhc0FscGhhKCk7CiAgICAgaWYgKHVzZVRyYW5zcGFyZW5jeUxheWVyKSB7CiAgICAg ICAgIGdyYXBoaWNzQ29udGV4dC0+YmVnaW5UcmFuc3BhcmVuY3lMYXllcihzdGF0aWNfY2FzdDxm bG9hdD4ob3V0bGluZUNvbG9yLmFscGhhKCkpIC8gMjU1KTsKICAgICAgICAgb3V0bGluZUNvbG9y ID0gQ29sb3Iob3V0bGluZUNvbG9yLnJlZCgpLCBvdXRsaW5lQ29sb3IuZ3JlZW4oKSwgb3V0bGlu ZUNvbG9yLmJsdWUoKSk7CiAgICAgfQotI2VuZGlmCiAKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAx OyBpIDwgcmVjdHMuc2l6ZSgpIC0gMTsgaSsrKQogICAgICAgICBwYWludE91dGxpbmVGb3JMaW5l KGdyYXBoaWNzQ29udGV4dCwgcGFpbnRPZmZzZXQsIHJlY3RzLmF0KGkgLSAxKSwgcmVjdHMuYXQo aSksIHJlY3RzLmF0KGkgKyAxKSwgb3V0bGluZUNvbG9yKTsKIAotLy8gRklYTUU6IFVzaW5nIGEg dHJhbnNwYXJlbmN5IGxheWVyIGZvciByZ2JhIG91dGxpbmVzIGV4YWNlcmJhdGVzIGFuIGV4aXN0 aW5nIFNLSUEgYnVnLiBUaGUgI2lmCi0vLyBiZWxvdyBwcmV2ZW50cyB0aGlzOyBpdCBzaG91bGQg YmUgcmVtb3ZlZCB3aGVuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 MDM0MiBpcyBmaXhlZC4KLSNpZiAhVVNFKFNLSUEpCiAgICAgaWYgKHVzZVRyYW5zcGFyZW5jeUxh eWVyKQogICAgICAgICBncmFwaGljc0NvbnRleHQtPmVuZFRyYW5zcGFyZW5jeUxheWVyKCk7Ci0j ZW5kaWYKIH0KIAogdm9pZCBSZW5kZXJJbmxpbmU6OnBhaW50T3V0bGluZUZvckxpbmUoR3JhcGhp Y3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGNvbnN0IExheW91dFBvaW50JiBwYWludE9mZnNl dCwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKaW5kZXggODY1OTlk ZDRiY2UyNzlmODk0NDYxOWIwYjJlODg5MjMwNTJmMzExMy4uODM4YmM5NWMxMDQ2MDk0OTk3ZjIx MjcwNzg4M2E2MjJiY2YxYWQ0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9i amVjdC5jcHAKQEAgLTEwNTAsMTUgKzEwNTAsMTEgQEAgdm9pZCBSZW5kZXJPYmplY3Q6OnBhaW50 T3V0bGluZShHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCwgY29uc3QgTGF5b3V0UmUK ICAgICBpZiAoYWRqdXN0ZWRQYWludFJlYy5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAot Ly8gRklYTUU6IFVzaW5nIGEgdHJhbnNwYXJlbmN5IGxheWVyIGZvciByZ2JhIG91dGxpbmVzIGV4 YWNlcmJhdGVzIGFuIGV4aXN0aW5nIFNLSUEgYnVnLiBUaGUgI2lmCi0vLyBiZWxvdyBwcmV2ZW50 cyB0aGlzOyBpdCBzaG91bGQgYmUgcmVtb3ZlZCB3aGVuIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MDM0MiBpcyBmaXhlZC4KLSNpZiAhVVNFKFNLSUEpCiAgICAgYm9v bCB1c2VUcmFuc3BhcmVuY3lMYXllciA9IG91dGxpbmVDb2xvci5oYXNBbHBoYSgpOwogICAgIGlm ICh1c2VUcmFuc3BhcmVuY3lMYXllcikgewogICAgICAgICBncmFwaGljc0NvbnRleHQtPmJlZ2lu VHJhbnNwYXJlbmN5TGF5ZXIoc3RhdGljX2Nhc3Q8ZmxvYXQ+KG91dGxpbmVDb2xvci5hbHBoYSgp KSAvIDI1NSk7CiAgICAgICAgIG91dGxpbmVDb2xvciA9IENvbG9yKG91dGxpbmVDb2xvci5yZWQo KSwgb3V0bGluZUNvbG9yLmdyZWVuKCksIG91dGxpbmVDb2xvci5ibHVlKCkpOwogICAgIH0KLSNl bmRpZgogCiAgICAgTGF5b3V0VW5pdCBsZWZ0T3V0ZXIgPSBhZGp1c3RlZFBhaW50UmVjLngoKSAt IG91dGxpbmVXaWR0aDsKICAgICBMYXlvdXRVbml0IGxlZnRJbm5lciA9IGFkanVzdGVkUGFpbnRS ZWMueCgpOwpAQCAtMTA3NCwxMiArMTA3MCw4IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjpwYWludE91 dGxpbmUoR3JhcGhpY3NDb250ZXh0KiBncmFwaGljc0NvbnRleHQsIGNvbnN0IExheW91dFJlCiAg ICAgZHJhd0xpbmVGb3JCb3hTaWRlKGdyYXBoaWNzQ29udGV4dCwgcmlnaHRJbm5lciwgdG9wT3V0 ZXIsIHJpZ2h0T3V0ZXIsIGJvdHRvbU91dGVyLCBCU1JpZ2h0LCBvdXRsaW5lQ29sb3IsIG91dGxp bmVTdHlsZSwgb3V0bGluZVdpZHRoLCBvdXRsaW5lV2lkdGgpOwogICAgIGRyYXdMaW5lRm9yQm94 U2lkZShncmFwaGljc0NvbnRleHQsIGxlZnRPdXRlciwgYm90dG9tSW5uZXIsIHJpZ2h0T3V0ZXIs IGJvdHRvbU91dGVyLCBCU0JvdHRvbSwgb3V0bGluZUNvbG9yLCBvdXRsaW5lU3R5bGUsIG91dGxp bmVXaWR0aCwgb3V0bGluZVdpZHRoKTsKIAotLy8gRklYTUU6IFVzaW5nIGEgdHJhbnNwYXJlbmN5 IGxheWVyIGZvciByZ2JhIG91dGxpbmVzIGV4YWNlcmJhdGVzIGFuIGV4aXN0aW5nIFNLSUEgYnVn LiBUaGUgI2lmCi0vLyBiZWxvdyBwcmV2ZW50cyB0aGlzOyBpdCBzaG91bGQgYmUgcmVtb3ZlZCB3 aGVuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MDM0MiBpcyBmaXhl ZC4KLSNpZiAhVVNFKFNLSUEpCiAgICAgaWYgKHVzZVRyYW5zcGFyZW5jeUxheWVyKQogICAgICAg ICBncmFwaGljc0NvbnRleHQtPmVuZFRyYW5zcGFyZW5jeUxheWVyKCk7Ci0jZW5kaWYKIH0KIAog SW50UmVjdCBSZW5kZXJPYmplY3Q6OmFic29sdXRlQm91bmRpbmdCb3hSZWN0KGJvb2wgdXNlVHJh bnNmb3JtcykK