65265 2011-07-27 09:45:01 -0700 [chromium] Make WebImage::operator=(CGImageRef) a WEBKIT_API 2011-07-28 20:25:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis fishd jamesr webkit.review.bot oldest_to_newest 442977 0 thakis 2011-07-27 09:45:01 -0700 [chromium] Make WebImage::operator=(CGImageRef) a WEBKIT_API 442979 1 102152 thakis 2011-07-27 09:46:37 -0700 Created attachment 102152 Patch 443178 2 thakis 2011-07-27 15:09:36 -0700 Darin: jamesr says this is for you 443183 3 102152 fishd 2011-07-27 15:16:36 -0700 Comment on attachment 102152 Patch This change is technically fine, but it would be nice to know why you want to make this change. Can you please explain the motivation for making this non-inline? Normally, the WebKit API implements operators inline as calls to exported functions. 443188 4 thakis 2011-07-27 15:20:18 -0700 The larger motivation is the components build for mac. As mentioned in the changelog, webkit/glue/webcursor_mac.mm ( http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/webkit/glue/webcursor_mac.mm&exact_package=chromium&q=webcursor_ma&type=cs ) calls operator=, so it needs to be exported. assign(CGImageRef) is currently private. If it's preferrable, I can make assign(CGImageRef) public, turn that into WEBKIT_API, keep operator=() inline, and update the call site (after waiting for the roll). Your call :-) 443190 5 fishd 2011-07-27 15:23:25 -0700 (In reply to comment #4) > The larger motivation is the components build for mac. > > As mentioned in the changelog, webkit/glue/webcursor_mac.mm ( http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/webkit/glue/webcursor_mac.mm&exact_package=chromium&q=webcursor_ma&type=cs ) calls operator=, so it needs to be exported. assign(CGImageRef) is currently private. If it's preferrable, I can make assign(CGImageRef) public, turn that into WEBKIT_API, keep operator=() inline, and update the call site (after waiting for the roll). Oh, I see. Yeah, the convention would be to tag assign(CGImageRef) with WEBKIT_API. We shouldn't need to make it public. 443347 6 102152 fishd 2011-07-27 22:43:58 -0700 Comment on attachment 102152 Patch As discussed, please tag the assign(CGImageRef) function with WEBKIT_API, and leave the rest as is. 443774 7 102325 thakis 2011-07-28 19:31:09 -0700 Created attachment 102325 Patch 443775 8 102325 jamesr 2011-07-28 19:32:39 -0700 Comment on attachment 102325 Patch R+ based on Darin's comment. 443788 9 102325 webkit.review.bot 2011-07-28 20:25:53 -0700 Comment on attachment 102325 Patch Clearing flags on attachment: 102325 Committed r91970: <http://trac.webkit.org/changeset/91970> 443789 10 webkit.review.bot 2011-07-28 20:25:57 -0700 All reviewed patches have been landed. Closing bug. 102152 2011-07-27 09:46:37 -0700 2011-07-28 19:31:04 -0700 Patch bug-65265-20110727094635.patch text/plain 2029 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3NTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg M2E4MzFiMzdkNTNmMWJlYWU3OTVlYjU2MTBkZGEyMWExMWY4ZGRmOS4uMTU5MjQ0NTE5YTk3Njg4 YjFkMjNmOTdhNDc0NmI1Zjg3ZjY0NTE5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wNy0yNyAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBNYWtlIFdlYkltYWdlOjpvcGVyYXRvcj0oQ0dJbWFn ZVJlZikgYSBXRUJLSVRfQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD02NTI2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEl0J3MgdXNlZCBieSB3ZWJraXQvZ2x1ZS93ZWJjdXJzb3JfbWFjLm1tCisKKyAg ICAgICAgKiBwdWJsaWMvV2ViSW1hZ2UuaDoKKyAgICAgICAgKiBzcmMvV2ViSW1hZ2VDRy5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYkltYWdlOjpvcGVyYXRvcj0pOgorCiAyMDExLTA3LTI1ICBB bCBQYXRyaWNrICA8YXBhdHJpY2tAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZWQgc3Vw cG9ydCBmb3IgdGhlIEdMX2xhdGNoX0NIUk9NSVVNIGV4dGVuc2lvbiB3aGljaCBDaHJvbWl1bSBu byBsb25nZXIgc3VwcG9ydHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbWFnZS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW1hZ2Uu aAppbmRleCBhN2I2ZjhjZDI2NTJiMzJiYTk1NGFiZmMwYjgyZjU4YzIyMmNlN2Q2Li5lYzBjNTli YmIzNjVmYTc0NGJiMDcyYTY2Mjc0MTRiYzM5NjFjYmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbWFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkltYWdlLmgKQEAgLTEwNiwxMiArMTA2LDcgQEAgcHJpdmF0ZToKICAgICAg ICAgYXNzaWduKGltYWdlUmVmKTsKICAgICB9CiAKLSAgICBXZWJJbWFnZSYgb3BlcmF0b3I9KENH SW1hZ2VSZWYgaW1hZ2VSZWYpCi0gICAgewotICAgICAgICBhc3NpZ24oaW1hZ2VSZWYpOwotICAg ICAgICByZXR1cm4gKnRoaXM7Ci0gICAgfQotCisgICAgV0VCS0lUX0FQSSBXZWJJbWFnZSYgb3Bl cmF0b3I9KENHSW1hZ2VSZWYpOwogICAgIENHSW1hZ2VSZWYgZ2V0Q0dJbWFnZVJlZigpIGNvbnN0 IHsgcmV0dXJuIG1faW1hZ2VSZWY7IH0KIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkltYWdlQ0cuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViSW1hZ2VDRy5jcHAKaW5kZXggZGRhODI5ZmMyM2FkOWQxZDg2ZDk4MmFiYWYwODAx Y2JjM2ZjYjc4My4uMDMwZDdiMTI1MmI3MzYxNDhlMTcxYWVlMGIzMzJmZTE0Y2FmNzIwZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VDRy5jcHAKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1hZ2VDRy5jcHAKQEAgLTEyMiw2ICsxMjIs MTIgQEAgV2ViSW1hZ2UmIFdlYkltYWdlOjpvcGVyYXRvcj0oY29uc3QgUGFzc1JlZlB0cjxJbWFn ZT4mIGltYWdlKQogICAgIHJldHVybiAqdGhpczsKIH0KIAorV2ViSW1hZ2UmIFdlYkltYWdlOjpv cGVyYXRvcj0oQ0dJbWFnZVJlZiBpbWFnZVJlZikKK3sKKyAgICBhc3NpZ24oaW1hZ2VSZWYpOwor ICAgIHJldHVybiAqdGhpczsKK30KKwogdm9pZCBXZWJJbWFnZTo6YXNzaWduKENHSW1hZ2VSZWYg aW1hZ2VSZWYpCiB7CiAgICAgLy8gTWFrZSBzdXJlIHRvIHJldGFpbiB0aGUgaW1hZ2VSZWYgZmly c3QgaW5jYXNlIG1faW1hZ2VSZWYgPT0gaW1hZ2VSZWYuCg== 102325 2011-07-28 19:31:09 -0700 2011-07-28 20:25:52 -0700 Patch bug-65265-20110728193107.patch text/plain 1285 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogOTE4MjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MjA2MjFmMzgxY2E5NDE1MmQ2OTZhMDA1MmMzYjgyNjQ0N2UwMTk4Yy4uYjczYWZhMzJjOTM5ZTQ0 MGI1NTBjMTNkMGIyODk5MzJhMTVjY2RhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0wNy0yOCAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBNYWtlIFdlYkltYWdlOjphc3NpZ24oQ0dJbWFnZVJl ZikgYSBXRUJLSVRfQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NTI2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlcXVpcmVkIGZvciB0aGUgY29tcG9uZW50cyBidWlsZCBvbiBtYWMuIFRoZSBpbmxp bmUgZnVuY3Rpb24KKyAgICAgICAgb3BlcmF0b3I9KENHSW1hZ2VSZWYpIGlzIHVzZWQgZnJvbSBv dXRzaWRlIHdlYmtpdCwgYW5kIGNhbGxzIHRoaXMKKyAgICAgICAgZnVuY3Rpb24uCisKKyAgICAg ICAgKiBwdWJsaWMvV2ViSW1hZ2UuaDoKKwogMjAxMS0wNy0yNiAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjkxODA5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi SW1hZ2UuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkltYWdlLmgKaW5kZXgg YTdiNmY4Y2QyNjUyYjMyYmE5NTRhYmZjMGI4MmY1OGMyMjJjZTdkNi4uMzgwNjAxNTUyYWU4ZDJl NWUxYzMyMjRiZjAzZGI2ZjQ0ZGNkNGIyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViSW1hZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJJbWFnZS5oCkBAIC0xMTYsNyArMTE2LDcgQEAgcHJpdmF0ZToKIAogcHJpdmF0ZToKICAg ICB2b2lkIGluaXQoKSB7IG1faW1hZ2VSZWYgPSAwOyB9Ci0gICAgdm9pZCBhc3NpZ24oQ0dJbWFn ZVJlZik7CisgICAgV0VCS0lUX0FQSSB2b2lkIGFzc2lnbihDR0ltYWdlUmVmKTsKICAgICBDR0lt YWdlUmVmIG1faW1hZ2VSZWY7CiAjZW5kaWYKIH07Cg==