<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>65262</bug_id>
          
          <creation_ts>2011-07-27 09:14:21 -0700</creation_ts>
          <short_desc>[skia] fix clipping of some glyphs on windows</short_desc>
          <delta_ts>2011-07-28 09:15:56 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mike Reed">reed</reporter>
          <assigned_to name="Mike Reed">reed</assigned_to>
          <cc>enne</cc>
    
    <cc>jamesr</cc>
    
    <cc>junov</cc>
    
    <cc>kbr</cc>
    
    <cc>rniwa</cc>
    
    <cc>senorblanco</cc>
    
    <cc>tonyg</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>442962</commentid>
    <comment_count>0</comment_count>
    <who name="Mike Reed">reed</who>
    <bug_when>2011-07-27 09:14:21 -0700</bug_when>
    <thetext>[skia] fix clipping of some glyphs on windows</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442963</commentid>
    <comment_count>1</comment_count>
      <attachid>102149</attachid>
    <who name="Mike Reed">reed</who>
    <bug_when>2011-07-27 09:16:27 -0700</bug_when>
    <thetext>Created attachment 102149
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442965</commentid>
    <comment_count>2</comment_count>
    <who name="Mike Reed">reed</who>
    <bug_when>2011-07-27 09:18:33 -0700</bug_when>
    <thetext>These will be rebaselined after we roll to skia rev. 1960, which fixes some clipping issues.

After that, we can process https://bugs.webkit.org/show_bug.cgi?id=65203</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443044</commentid>
    <comment_count>3</comment_count>
      <attachid>102149</attachid>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2011-07-27 11:46:36 -0700</bug_when>
    <thetext>Comment on attachment 102149
Patch

Looks good.  r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443304</commentid>
    <comment_count>4</comment_count>
      <attachid>102149</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-07-27 20:56:17 -0700</bug_when>
    <thetext>Comment on attachment 102149
Patch

Clearing flags on attachment: 102149

Committed r91897: &lt;http://trac.webkit.org/changeset/91897&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443305</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-07-27 20:56:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443367</commentid>
    <comment_count>6</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-07-27 23:38:15 -0700</bug_when>
    <thetext>This patch broke Chromium Windows (Tests):
http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/17090/steps/layout-test/logs/stdio</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443372</commentid>
    <comment_count>7</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-07-27 23:48:47 -0700</bug_when>
    <thetext>Fixed in http://trac.webkit.org/changeset/91912.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443513</commentid>
    <comment_count>8</comment_count>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2011-07-28 09:15:56 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Fixed in http://trac.webkit.org/changeset/91912.

mreed: Please run new-run-webkit-tests --lint-test-files when making test_expectations updates.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>102149</attachid>
            <date>2011-07-27 09:16:27 -0700</date>
            <delta_ts>2011-07-27 20:56:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-65262-20110727121626.patch</filename>
            <type>text/plain</type>
            <size>2918</size>
            <attacher name="Mike Reed">reed</attacher>
            
              <data encoding="base64">SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D
aGFuZ2VMb2cJKHJldmlzaW9uIDkxODUxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDctMjcgIE1pa2UgUmVlZCAgPHJlZWRA
Z29vZ2xlLmNvbT4KKworICAgICAgICBbc2tpYV0gZml4IGNsaXBwaW5nIG9mIHNvbWUgZ2x5cGhz
IG9uIHdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTY1MjYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisKIDIwMTEtMDct
MjcgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbV0sy
XSBVbnJldmlld2VkIGdhcmRlbmluZy4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t
aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0
Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHJldmlzaW9uIDkxODQzKQorKysg
TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3Jr
aW5nIGNvcHkpCkBAIC0xNTQwLDYgKzE1NDAsMzEgQEAgQlVHQ1IyNTYxNiBXSU4gOiBmYXN0L292
ZXJmbG93L292ZXJmbG93LQogLy8gRmxha3kuIFRoZSB3aWR0aCBvZiBjb250YWluaW5nIFJlbmRl
ckJsb2NrcyBzb21ldGltZXMgYmVjb21lcyBsYXJnZXIKIEJVR0NSMjE5NTggTUFDIDogc3ZnL2hp
eGllL2Vycm9yLzAxMi54bWwgPSBGQUlMCiAKKy8vIFRoZXNlIHdpbGwgYmUgcmViYXNlbGluZWQg
KGFuZCB0aGVyZWZvcmUgZml4ZWQpIHdoZW4gd2Ugcm9sbCBza2lhIDE5NjAsIHdoaWNoIGZpeGVz
CisvLyBjbGlwcGluZyBzb21lIGNoYXJhY3RlcnMuCitCVUdDUjkwNjczIFdJTiA6IGVkaXRpbmcv
c2VsZWN0aW9uL3ZlcnRpY2FsLWxyLWx0ci1leHRlbmQtbGluZS1iYWNrd2FyZC1ici5odG1sID0g
SU1BR0UKK0JVR0NSOTA2NzMgV0lOIDogZWRpdGluZy9zZWxlY3Rpb24vdmVydGljYWwtbHItbHRy
LWV4dGVuZC1saW5lLWZvcndhcmQtYnIuaHRtbCA9IElNQUdFCitCVUdDUjkwNjczIFdJTiA6IGVk
aXRpbmcvc2VsZWN0aW9uL3ZlcnRpY2FsLXJsLWx0ci1leHRlbmQtbGluZS1iYWNrd2FyZC1ici5o
dG1sID0gSU1BR0UKK0JVR0NSOTA2NzMgV0lOIDogZWRpdGluZy9zZWxlY3Rpb24vdmVydGljYWwt
cmwtbHRyLWV4dGVuZC1saW5lLWJhY2t3YXJkLXAuaHRtbCA9IElNQUdFCitCVUdDUjkwNjczIFdJ
TiA6IGVkaXRpbmcvc2VsZWN0aW9uL3ZlcnRpY2FsLXJsLWx0ci1leHRlbmQtbGluZS1iYWNrd2Fy
ZC13cmFwLmh0bWwgPSBJTUFHRQorQlVHQ1I5MDY3MyBXSU4gOiBlZGl0aW5nL3NlbGVjdGlvbi92
ZXJ0aWNhbC1ybC1sdHItZXh0ZW5kLWxpbmUtZm9yd2FyZC1ici5odG1sID0gSU1BR0UKK0JVR0NS
OTA2NzMgV0lOIDogZWRpdGluZy9zZWxlY3Rpb24vdmVydGljYWwtcmwtbHRyLWV4dGVuZC1saW5l
LWZvcndhcmQtcC5odG1sID0gSU1BR0UKK0JVR0NSOTA2NzMgV0lOIDogZWRpdGluZy9zZWxlY3Rp
b24vdmVydGljYWwtcmwtbHRyLWV4dGVuZC1saW5lLWZvcndhcmQtd3JhcC5odG1sID0gSU1BR0UK
K0JVR0NSOTA2NzMgV0lOIDogZmFzdC9ibG9ja2Zsb3cvZW5nbGlzaC1sci10ZXh0Lmh0bWwgPSBJ
TUFHRQorQlVHQ1I5MDY3MyBXSU4gOiBmYXN0L2Jsb2NrZmxvdy9qYXBhbmVzZS1ydWJ5LXZlcnRp
Y2FsLWxyLmh0bWwgPSBJTUFHRQorQlVHQ1I5MDY3MyBXSU4gOiBmYXN0L2Jsb2NrZmxvdy9qYXBh
bmVzZS1ydWJ5LXZlcnRpY2FsLXJsLmh0bWwgPSBJTUFHRQorQlVHQ1I5MDY3MyBXSU4gOiBmYXN0
L3JlcGFpbnQvc2hhZG93LW11bHRpcGxlLWhvcml6b250YWwuaHRtbCA9IElNQUdFCitCVUdDUjkw
NjczIFdJTiA6IGZhc3QvcmVwYWludC9zaGFkb3ctbXVsdGlwbGUtc3RyaWN0LWhvcml6b250YWwu
aHRtbCA9IElNQUdFCitCVUdDUjkwNjczIFdJTiA6IGZhc3QvcmVwYWludC9zaGFkb3ctbXVsdGlw
bGUtc3RyaWN0LXZlcnRpY2FsLmh0bWwgPSBJTUFHRQorQlVHQ1I5MDY3MyBXSU4gOiBmYXN0L3Jl
cGFpbnQvc2hhZG93LW11bHRpcGxlLXZlcnRpY2FsLmh0bWwgPSBJTUFHRQorQlVHQ1I5MDY3MyBX
SU4gOiBmYXN0L3RleHQvc3Ryb2tpbmctZGVjb3JhdGlvbnMuaHRtbCA9IElNQUdFCitCVUdDUjkw
NjczIFdJTiA6IGZhc3QvdGV4dC9zdHJva2luZy5odG1sID0gSU1BR0UKK0JVR0NSOTA2NzMgV0lO
IDogZmFzdC90cmFuc2Zvcm1zL3NoYWRvd3MuaHRtbCA9IElNQUdFCitCVUdDUjkwNjczIFdJTiA6
IHN2Zy9iYXRpay90ZXh0L3ZlcnRpY2FsVGV4dC5zdmcgPSBJTUFHRQorQlVHQ1I5MDY3MyBXSU4g
OiBzdmcvY3NzL2dyb3VwLXdpdGgtc2hhZG93LnN2ZyA9IElNQUdFCitCVUdDUjkwNjczIFdJTiA6
IHN2Zy9jc3MvdGV4dC1ncmFkaWVudC1zaGFkb3cuc3ZnID0gSU1BR0UKK0JVR0NSOTA2NzMgV0lO
IDogc3ZnL2Nzcy90ZXh0LXNoYWRvdy1tdWx0aXBsZS54aHRtbCA9IElNQUdFCisKIC8vIFdlYktp
dCBtZXJnZSA0ODUwMDo0ODU4NSwgbmV3bHkgaW1wbGVtZW50ZWQgT2JqZWN0LmRlZmluZVByb3Bl
cnR5LgogQlVHQ1IyMjUyNiBXSU4gTUFDIDogZmFzdC9qcy9PYmplY3QtY3JlYXRlLmh0bWwgPSBG
QUlMCiBCVUdDUjIyNTI2IDogZmFzdC9qcy9PYmplY3QtZGVmaW5lUHJvcGVydGllcy5odG1sID0g
RkFJTCBDUkFTSAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>