65239 2011-07-27 02:20:50 -0700 REGRESSION: [Chromium/782] Speech icon should be on the left side for dir=rtl 2011-07-27 22:06:24 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Other All RESOLVED FIXED P1 Major --- 1 tkent tkent dglazkov playmobil rniwa satish tonyg oldest_to_newest 442801 0 tkent 2011-07-27 02:20:50 -0700 M13 part of http://code.google.com/p/chromium/issues/detail?id=87045. M14 and the trunk already have another fix. 442802 1 102110 tkent 2011-07-27 02:26:52 -0700 Created attachment 102110 Patch *** This is a patch for chromium/782 branch, not the trunk. *** 442804 2 tkent 2011-07-27 02:30:26 -0700 I confirmed Chrome 13 with this patch works same as Chrome 12. - When I typed "שלום עולם" on www.google.com, the speech button moved to the left side. - I clicked on the speech button, then the speech bubble showed on the right side of the search box. This is not good, but it's same as Chrome 12. 442971 3 102110 rniwa 2011-07-27 09:30:36 -0700 Comment on attachment 102110 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102110&action=review > Source/WebCore/rendering/RenderTextControlSingleLine.cpp:342 > + x = borderLeft() + paddingLeft() + (spinBox ? spinBox->width() : 0); Don't we need to take outerSpinButtonElement into account here? 443254 4 102110 tkent 2011-07-27 18:21:09 -0700 Comment on attachment 102110 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102110&action=review >> Source/WebCore/rendering/RenderTextControlSingleLine.cpp:342 >> + x = borderLeft() + paddingLeft() + (spinBox ? spinBox->width() : 0); > > Don't we need to take outerSpinButtonElement into account here? In M13, the outer spin button is always located on the right side ;-P See the code just after this block. 443257 5 102110 rniwa 2011-07-27 18:26:28 -0700 Comment on attachment 102110 Patch (In reply to comment #4) > In M13, the outer spin button is always located on the right side ;-P > See the code just after this block. Okay. r=me then. 443335 6 tkent 2011-07-27 22:06:24 -0700 Landed: http://trac.webkit.org/changeset/91904 102110 2011-07-27 02:26:52 -0700 2011-07-27 18:26:28 -0700 Patch bug-65239-20110727182650.patch text/plain 1811 tkent SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxODI3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMjcgIEtlbnQgVGFt dXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT046IFtDaHJvbWl1 bS83ODJdIFNwZWVjaCBpY29uIHNob3VsZCBiZSBvbiB0aGUgbGVmdCBzaWRlIGZvciBkaXI9cnRs CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTIzOQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6OmxheW91dCk6CisgICAgICAgIEZvciBSVEwsIG1v dmUgdGhlIHNwZWVjaCBidXR0b24gdG8gdGhlIGxlZnQgc2lkZSBhbmQgc2hpZnQgdGhlCisgICAg ICAgIGlubmVyIHRleHQgdG8gdGhlIHJpZ2h0IGJ5IHRoZSB3aWR0aCBvZiB0aGUgc3BlZWNoIGJ1 dHRvbiBhbmQgdGhlCisgICAgICAgIHNwaW4gYnV0dG9uLgorCiAyMDExLTA3LTE5ICBTdGV2ZSBM YWNleSAgPHNqbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBNZWRpYSBwbGF5 ZXIgY29udHJvbHMgZG8gbm90IGZhZGUgb3V0LgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sU2luZ2xlTGluZS5jcHAJKHJldmlz aW9uIDkxODI1KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9s U2luZ2xlTGluZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzOCw4ICszMzgsMTAgQEAgdm9pZCBS ZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6OmxheW91dAogICAgICAgICAgICAgUmVuZGVyQm94 KiBzcGluQm94ID0gaW5uZXJTcGluQnV0dG9uRWxlbWVudCgpID8gaW5uZXJTcGluQnV0dG9uRWxl bWVudCgpLT5yZW5kZXJCb3goKSA6IDA7CiAgICAgICAgICAgICBpZiAoc3R5bGUoKS0+aXNMZWZ0 VG9SaWdodERpcmVjdGlvbigpKQogICAgICAgICAgICAgICAgIHggLT0gc3BpbkJveCA/IHNwaW5C b3gtPndpZHRoKCkgOiAwOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIGlubmVy VGV4dFJlbmRlcmVyLT5zZXRYKHBhZGRpbmdMZWZ0KCkgKyBib3JkZXJMZWZ0KCkgKyAoc3BpbkJv eCA/IHNwaW5Cb3gtPndpZHRoKCkgOiAwKSk7CisgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAg ICAgICAgICB4ID0gYm9yZGVyTGVmdCgpICsgcGFkZGluZ0xlZnQoKSArIChzcGluQm94ID8gc3Bp bkJveC0+d2lkdGgoKSA6IDApOworICAgICAgICAgICAgICAgIGlubmVyVGV4dFJlbmRlcmVyLT5z ZXRYKHggKyBidXR0b24tPndpZHRoKCkpOworICAgICAgICAgICAgfQogICAgICAgICAgICAgaW50 IHkgPSAoaGVpZ2h0KCkgLSBidXR0b24tPmhlaWdodCgpKSAvIDI7CiAgICAgICAgICAgICBidXR0 b24tPnNldExvY2F0aW9uKEludFBvaW50KHgsIHkpKTsKICAgICAgICAgfQo=