65223 2011-07-26 17:23:53 -0700 JSC command-line tool does not come with any facility for measuring time precisely 2011-07-26 19:56:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 442641 0 fpizlo 2011-07-26 17:23:53 -0700 The only facility for measuring time is Date, which clips and truncates the time. Internally, JSC has access to the most precise available method on any given OS. For profiling and benchmarking, it would be useful if the jsc command-line tool exposed this functionality to JavaScript programs. 442644 1 102079 fpizlo 2011-07-26 17:26:42 -0700 Created attachment 102079 the patch 442647 2 102079 ggaren 2011-07-26 17:31:58 -0700 Comment on attachment 102079 the patch Seems like the JS name should be "preciseTime" to match the C++ name. 442661 3 102085 fpizlo 2011-07-26 17:50:11 -0700 Created attachment 102085 the patch (changed function name) Good point, changed the name to preciseTime(). 442667 4 102085 barraclough 2011-07-26 17:56:50 -0700 Comment on attachment 102085 the patch (changed function name) To nitpick the change log is now wrong, but I don't think anyone is going to be confused by this patch, so r+. 442716 5 102085 webkit.review.bot 2011-07-26 19:56:37 -0700 Comment on attachment 102085 the patch (changed function name) Clearing flags on attachment: 102085 Committed r91817: <http://trac.webkit.org/changeset/91817> 442717 6 webkit.review.bot 2011-07-26 19:56:42 -0700 All reviewed patches have been landed. Closing bug. 102079 2011-07-26 17:26:42 -0700 2011-07-26 17:50:11 -0700 the patch currentTimePrecise_patch_1.diff text/plain 2699 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTE4MDEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDctMjYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBK U0MgY29tbWFuZC1saW5lIHRvb2wgZG9lcyBub3QgY29tZSB3aXRoIGFueSBmYWNpbGl0eSBmb3IK KyAgICAgICAgbWVhc3VyaW5nIHRpbWUgcHJlY2lzZWx5LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUyMjMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEV4cG9zZWQgV1RGOjpjdXJyZW50VGlt ZSgpIGFzIGN1cnJlbnRUaW1lUHJlY2lzZSgpLgorCisgICAgICAgICoganNjLmNwcDoKKyAgICAg ICAgKEdsb2JhbE9iamVjdDo6R2xvYmFsT2JqZWN0KToKKyAgICAgICAgKGZ1bmN0aW9uUHJlY2lz ZVRpbWUpOgorCiAyMDExLTA3LTI2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAK ICAgICAgICAgQnVmZmVyIG92ZXJmbG93IGNyZWF0aW5nIGVycm9yIG1lc3NhZ2VzIGZvciBKU09O LnBhcnNlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gOTE3NzMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODIsNiArODIsNyBA QCBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jCiBzdGF0aWMgRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkxvYWQoRXhlY1N0YXRlKik7CiBzdGF0aWMg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkNoZWNrU3ludGF4KEV4ZWNTdGF0 ZSopOwogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25SZWFkbGlu ZShFeGVjU3RhdGUqKTsKK3N0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0 aW9uUHJlY2lzZVRpbWUoRXhlY1N0YXRlKik7CiBzdGF0aWMgTk9fUkVUVVJOX1dJVEhfVkFMVUUg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblF1aXQoRXhlY1N0YXRlKik7CiAK ICNpZiBFTkFCTEUoU0FNUExJTkdfRkxBR1MpCkBAIC0xNzEsNiArMTcyLDcgQEAgR2xvYmFsT2Jq ZWN0OjpHbG9iYWxPYmplY3QoSlNHbG9iYWxEYXRhJgogICAgIHB1dERpcmVjdEZ1bmN0aW9uKGds b2JhbEV4ZWMoKSwgSlNGdW5jdGlvbjo6Y3JlYXRlKGdsb2JhbEV4ZWMoKSwgdGhpcywgZnVuY3Rp b25TdHJ1Y3R1cmUoKSwgMSwgSWRlbnRpZmllcihnbG9iYWxFeGVjKCksICJsb2FkIiksIGZ1bmN0 aW9uTG9hZCkpOwogICAgIHB1dERpcmVjdEZ1bmN0aW9uKGdsb2JhbEV4ZWMoKSwgSlNGdW5jdGlv bjo6Y3JlYXRlKGdsb2JhbEV4ZWMoKSwgdGhpcywgZnVuY3Rpb25TdHJ1Y3R1cmUoKSwgMSwgSWRl bnRpZmllcihnbG9iYWxFeGVjKCksICJjaGVja1N5bnRheCIpLCBmdW5jdGlvbkNoZWNrU3ludGF4 KSk7CiAgICAgcHV0RGlyZWN0RnVuY3Rpb24oZ2xvYmFsRXhlYygpLCBKU0Z1bmN0aW9uOjpjcmVh dGUoZ2xvYmFsRXhlYygpLCB0aGlzLCBmdW5jdGlvblN0cnVjdHVyZSgpLCAwLCBJZGVudGlmaWVy KGdsb2JhbEV4ZWMoKSwgInJlYWRsaW5lIiksIGZ1bmN0aW9uUmVhZGxpbmUpKTsKKyAgICBwdXRE aXJlY3RGdW5jdGlvbihnbG9iYWxFeGVjKCksIEpTRnVuY3Rpb246OmNyZWF0ZShnbG9iYWxFeGVj KCksIHRoaXMsIGZ1bmN0aW9uU3RydWN0dXJlKCksIDAsIElkZW50aWZpZXIoZ2xvYmFsRXhlYygp LCAiY3VycmVudFRpbWVQcmVjaXNlIiksIGZ1bmN0aW9uUHJlY2lzZVRpbWUpKTsKIAogI2lmIEVO QUJMRShTQU1QTElOR19GTEFHUykKICAgICBwdXREaXJlY3RGdW5jdGlvbihnbG9iYWxFeGVjKCks IEpTRnVuY3Rpb246OmNyZWF0ZShnbG9iYWxFeGVjKCksIHRoaXMsIGZ1bmN0aW9uU3RydWN0dXJl KCksIDEsIElkZW50aWZpZXIoZ2xvYmFsRXhlYygpLCAic2V0U2FtcGxpbmdGbGFncyIpLCBmdW5j dGlvblNldFNhbXBsaW5nRmxhZ3MpKTsKQEAgLTMxMiw2ICszMTQsMTEgQEAgRW5jb2RlZEpTVmFs dWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblJlYQogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUo anNTdHJpbmcoZXhlYywgbGluZS5kYXRhKCkpKTsKIH0KIAorRW5jb2RlZEpTVmFsdWUgSlNDX0hP U1RfQ0FMTCBmdW5jdGlvblByZWNpc2VUaW1lKEV4ZWNTdGF0ZSopCit7CisgICAgcmV0dXJuIEpT VmFsdWU6OmVuY29kZShqc051bWJlcihjdXJyZW50VGltZSgpKSk7Cit9CisKIEVuY29kZWRKU1Zh bHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25RdWl0KEV4ZWNTdGF0ZSogZXhlYykKIHsKICAgICAv LyBUZWNobmljYWxseSwgZGVzdHJveWluZyB0aGUgaGVhcCBpbiB0aGUgbWlkZGxlIG9mIEpTIGV4 ZWN1dGlvbiBpcyBhIG5vLW5vLAo= 102085 2011-07-26 17:50:11 -0700 2011-07-26 19:56:37 -0700 the patch (changed function name) currentTimePrecise_patch_2.diff text/plain 2692 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTE4MDEpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTEtMDctMjYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBK U0MgY29tbWFuZC1saW5lIHRvb2wgZG9lcyBub3QgY29tZSB3aXRoIGFueSBmYWNpbGl0eSBmb3IK KyAgICAgICAgbWVhc3VyaW5nIHRpbWUgcHJlY2lzZWx5LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUyMjMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEV4cG9zZWQgV1RGOjpjdXJyZW50VGlt ZSgpIGFzIGN1cnJlbnRUaW1lUHJlY2lzZSgpLgorCisgICAgICAgICoganNjLmNwcDoKKyAgICAg ICAgKEdsb2JhbE9iamVjdDo6R2xvYmFsT2JqZWN0KToKKyAgICAgICAgKGZ1bmN0aW9uUHJlY2lz ZVRpbWUpOgorCiAyMDExLTA3LTI2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAK ICAgICAgICAgQnVmZmVyIG92ZXJmbG93IGNyZWF0aW5nIGVycm9yIG1lc3NhZ2VzIGZvciBKU09O LnBhcnNlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gOTE3NzMpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODIsNiArODIsNyBA QCBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jCiBzdGF0aWMgRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkxvYWQoRXhlY1N0YXRlKik7CiBzdGF0aWMg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkNoZWNrU3ludGF4KEV4ZWNTdGF0 ZSopOwogc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25SZWFkbGlu ZShFeGVjU3RhdGUqKTsKK3N0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0 aW9uUHJlY2lzZVRpbWUoRXhlY1N0YXRlKik7CiBzdGF0aWMgTk9fUkVUVVJOX1dJVEhfVkFMVUUg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvblF1aXQoRXhlY1N0YXRlKik7CiAK ICNpZiBFTkFCTEUoU0FNUExJTkdfRkxBR1MpCkBAIC0xNzEsNiArMTcyLDcgQEAgR2xvYmFsT2Jq ZWN0OjpHbG9iYWxPYmplY3QoSlNHbG9iYWxEYXRhJgogICAgIHB1dERpcmVjdEZ1bmN0aW9uKGds b2JhbEV4ZWMoKSwgSlNGdW5jdGlvbjo6Y3JlYXRlKGdsb2JhbEV4ZWMoKSwgdGhpcywgZnVuY3Rp b25TdHJ1Y3R1cmUoKSwgMSwgSWRlbnRpZmllcihnbG9iYWxFeGVjKCksICJsb2FkIiksIGZ1bmN0 aW9uTG9hZCkpOwogICAgIHB1dERpcmVjdEZ1bmN0aW9uKGdsb2JhbEV4ZWMoKSwgSlNGdW5jdGlv bjo6Y3JlYXRlKGdsb2JhbEV4ZWMoKSwgdGhpcywgZnVuY3Rpb25TdHJ1Y3R1cmUoKSwgMSwgSWRl bnRpZmllcihnbG9iYWxFeGVjKCksICJjaGVja1N5bnRheCIpLCBmdW5jdGlvbkNoZWNrU3ludGF4 KSk7CiAgICAgcHV0RGlyZWN0RnVuY3Rpb24oZ2xvYmFsRXhlYygpLCBKU0Z1bmN0aW9uOjpjcmVh dGUoZ2xvYmFsRXhlYygpLCB0aGlzLCBmdW5jdGlvblN0cnVjdHVyZSgpLCAwLCBJZGVudGlmaWVy KGdsb2JhbEV4ZWMoKSwgInJlYWRsaW5lIiksIGZ1bmN0aW9uUmVhZGxpbmUpKTsKKyAgICBwdXRE aXJlY3RGdW5jdGlvbihnbG9iYWxFeGVjKCksIEpTRnVuY3Rpb246OmNyZWF0ZShnbG9iYWxFeGVj KCksIHRoaXMsIGZ1bmN0aW9uU3RydWN0dXJlKCksIDAsIElkZW50aWZpZXIoZ2xvYmFsRXhlYygp LCAicHJlY2lzZVRpbWUiKSwgZnVuY3Rpb25QcmVjaXNlVGltZSkpOwogCiAjaWYgRU5BQkxFKFNB TVBMSU5HX0ZMQUdTKQogICAgIHB1dERpcmVjdEZ1bmN0aW9uKGdsb2JhbEV4ZWMoKSwgSlNGdW5j dGlvbjo6Y3JlYXRlKGdsb2JhbEV4ZWMoKSwgdGhpcywgZnVuY3Rpb25TdHJ1Y3R1cmUoKSwgMSwg SWRlbnRpZmllcihnbG9iYWxFeGVjKCksICJzZXRTYW1wbGluZ0ZsYWdzIiksIGZ1bmN0aW9uU2V0 U2FtcGxpbmdGbGFncykpOwpAQCAtMzEyLDYgKzMxNCwxMSBAQCBFbmNvZGVkSlNWYWx1ZSBKU0Nf SE9TVF9DQUxMIGZ1bmN0aW9uUmVhCiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1N0cmlu ZyhleGVjLCBsaW5lLmRhdGEoKSkpOwogfQogCitFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IGZ1bmN0aW9uUHJlY2lzZVRpbWUoRXhlY1N0YXRlKikKK3sKKyAgICByZXR1cm4gSlNWYWx1ZTo6 ZW5jb2RlKGpzTnVtYmVyKGN1cnJlbnRUaW1lKCkpKTsKK30KKwogRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBmdW5jdGlvblF1aXQoRXhlY1N0YXRlKiBleGVjKQogewogICAgIC8vIFRlY2hu aWNhbGx5LCBkZXN0cm95aW5nIHRoZSBoZWFwIGluIHRoZSBtaWRkbGUgb2YgSlMgZXhlY3V0aW9u IGlzIGEgbm8tbm8sCg==