65217 2011-07-26 16:04:03 -0700 AudioContext is not correctly accounting for hardware resources 2011-07-26 17:15:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers kbr oldest_to_newest 442598 0 crogers 2011-07-26 16:04:03 -0700 AudioContext is not correctly accounting for hardware resources 442604 1 102071 crogers 2011-07-26 16:13:52 -0700 Created attachment 102071 Patch 442606 2 crogers 2011-07-26 16:16:35 -0700 It turns out that the global ref-count is only decremented if the AudioContext::lazyInitialize() has been previously called. So we need to move the increment (and hardware initialization) properly into the lazyInitialize() method... 442618 3 102071 kbr 2011-07-26 16:40:56 -0700 Comment on attachment 102071 Patch Looks fine as long as it's been tested. 442634 4 crogers 2011-07-26 17:15:48 -0700 Committed r91801: <http://trac.webkit.org/changeset/91801> 102071 2011-07-26 16:13:52 -0700 2011-07-26 16:40:56 -0700 Patch bug-65217-20110726161351.patch text/plain 3269 crogers SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNzk1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMjYgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBBdWRpb0NvbnRleHQgaXMgbm90 IGNvcnJlY3RseSBhY2NvdW50aW5nIGZvciBoYXJkd2FyZSByZXNvdXJjZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MjE3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGF1 ZGlvIEFQSSBpcyBub3QgeWV0IGltcGxlbWVudGVkLgorCisgICAgICAgICogd2ViYXVkaW8vQXVk aW9Db250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6Y3JlYXRlKToK KyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6QXVkaW9Db250ZXh0KToKKyAgICAgICAg KFdlYkNvcmU6OkF1ZGlvQ29udGV4dDo6bGF6eUluaXRpYWxpemUpOgorCiAyMDExLTA3LTI2ICBN YXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0 b3IgYXV0b21hdGljYWxseSBnZW5lcmF0ZWQgSlMgRE9NIGJpbmRpbmdzIHRvIHJlcGxhY2Ugb3Bl cmF0b3IgbmV3IHdpdGggc3RhdGljIGNyZWF0ZSBtZXRob2RzCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAJKHJldmlzaW9uIDkxNzc5KQorKysgU291cmNlL1dl YkNvcmUvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTMsOCAr OTMsNiBAQCBQYXNzUmVmUHRyPEF1ZGlvQ29udGV4dD4gQXVkaW9Db250ZXh0OjpjCiAgICAgQVNT RVJUKGlzTWFpblRocmVhZCgpKTsKICAgICBpZiAoc19oYXJkd2FyZUNvbnRleHRDb3VudCA+PSBN YXhIYXJkd2FyZUNvbnRleHRzKQogICAgICAgICByZXR1cm4gMDsKLQotICAgICsrc19oYXJkd2Fy ZUNvbnRleHRDb3VudDsKICAgICAgICAgCiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBBdWRpb0Nv bnRleHQoZG9jdW1lbnQpKTsKIH0KQEAgLTEzNSwxMCArMTMzLDYgQEAgQXVkaW9Db250ZXh0OjpB dWRpb0NvbnRleHQoRG9jdW1lbnQqIGRvYwogICAgIC8vIEl0J3Mgbm90IHRoYXQgdXNlZnVsIHRv IGhhdmUgYSBjYWxsYmFjayBmdW5jdGlvbiBmb3IgdGhpcyBzaW5jZSB0aGUgYXVkaW8gdGhyZWFk IGF1dG9tYXRpY2FsbHkgc3RhcnRzIHJlbmRlcmluZyBvbiB0aGUgZ3JhcGgKICAgICAvLyB3aGVu IHRoaXMgaGFzIGZpbmlzaGVkIChzZWUgQXVkaW9EZXN0aW5hdGlvbk5vZGUpLgogICAgIG1faHJ0 ZkRhdGFiYXNlTG9hZGVyID0gSFJURkRhdGFiYXNlTG9hZGVyOjpjcmVhdGVBbmRMb2FkQXN5bmNo cm9ub3VzbHlJZk5lY2Vzc2FyeShzYW1wbGVSYXRlKCkpOwotCi0gICAgLy8gRklYTUU6IGZvciBu b3cgZGVmYXVsdCBBdWRpb0NvbnRleHQgZG9lcyBub3QgbmVlZCBhbiBleHBsaWNpdCBzdGFydFJl bmRlcmluZygpIGNhbGwuCi0gICAgLy8gV2UgbWF5IHdhbnQgdG8gY29uc2lkZXIgcmVxdWlyaW5n IGl0IGZvciBzeW1tZXRyeSB3aXRoIE9mZmxpbmVBdWRpb0NvbnRleHQKLSAgICBtX2Rlc3RpbmF0 aW9uTm9kZS0+c3RhcnRSZW5kZXJpbmcoKTsKIH0KIAogLy8gQ29uc3RydWN0b3IgZm9yIG9mZmxp bmUgKG5vbi1yZWFsdGltZSkgcmVuZGVyaW5nLgpAQCAtMTk0LDkgKzE4OCwxNyBAQCB2b2lkIEF1 ZGlvQ29udGV4dDo6bGF6eUluaXRpYWxpemUoKQogICAgICAgICBBU1NFUlQoIW1faXNBdWRpb1Ro cmVhZEZpbmlzaGVkKTsKICAgICAgICAgaWYgKCFtX2lzQXVkaW9UaHJlYWRGaW5pc2hlZCkgewog ICAgICAgICAgICAgaWYgKG1fZGVzdGluYXRpb25Ob2RlLmdldCgpKSB7Ci0gICAgICAgICAgICAg ICAgLy8gVGhpcyBzdGFydHMgdGhlIGF1ZGlvIHRocmVhZC4gIFRoZSBkZXN0aW5hdGlvbiBub2Rl J3MgcHJvdmlkZUlucHV0KCkgbWV0aG9kIHdpbGwgbm93IGJlIGNhbGxlZCByZXBlYXRlZGx5IHRv IHJlbmRlciBhdWRpby4KLSAgICAgICAgICAgICAgICAvLyBFYWNoIHRpbWUgcHJvdmlkZUlucHV0 KCkgaXMgY2FsbGVkLCBhIHBvcnRpb24gb2YgdGhlIGF1ZGlvIHN0cmVhbSBpcyByZW5kZXJlZC4g IExldCdzIGNhbGwgdGhpcyB0aW1lIHBlcmlvZCBhICJyZW5kZXIgcXVhbnR1bSIuCiAgICAgICAg ICAgICAgICAgbV9kZXN0aW5hdGlvbk5vZGUtPmluaXRpYWxpemUoKTsKKworICAgICAgICAgICAg ICAgIGlmICghaXNPZmZsaW5lQ29udGV4dCgpKSB7CisgICAgICAgICAgICAgICAgICAgIC8vIFRo aXMgc3RhcnRzIHRoZSBhdWRpbyB0aHJlYWQuIFRoZSBkZXN0aW5hdGlvbiBub2RlJ3MgcHJvdmlk ZUlucHV0KCkgbWV0aG9kIHdpbGwgbm93IGJlIGNhbGxlZCByZXBlYXRlZGx5IHRvIHJlbmRlciBh dWRpby4KKyAgICAgICAgICAgICAgICAgICAgLy8gRWFjaCB0aW1lIHByb3ZpZGVJbnB1dCgpIGlz IGNhbGxlZCwgYSBwb3J0aW9uIG9mIHRoZSBhdWRpbyBzdHJlYW0gaXMgcmVuZGVyZWQuIExldCdz IGNhbGwgdGhpcyB0aW1lIHBlcmlvZCBhICJyZW5kZXIgcXVhbnR1bSIuCisgICAgICAgICAgICAg ICAgICAgIC8vIE5PVEU6IGZvciBub3cgZGVmYXVsdCBBdWRpb0NvbnRleHQgZG9lcyBub3QgbmVl ZCBhbiBleHBsaWNpdCBzdGFydFJlbmRlcmluZygpIGNhbGwgZnJvbSBKYXZhU2NyaXB0LgorICAg ICAgICAgICAgICAgICAgICAvLyBXZSBtYXkgd2FudCB0byBjb25zaWRlciByZXF1aXJpbmcgaXQg Zm9yIHN5bW1ldHJ5IHdpdGggT2ZmbGluZUF1ZGlvQ29udGV4dC4KKyAgICAgICAgICAgICAgICAg ICAgbV9kZXN0aW5hdGlvbk5vZGUtPnN0YXJ0UmVuZGVyaW5nKCk7ICAgICAgICAgICAgICAgICAg ICAKKyAgICAgICAgICAgICAgICAgICAgKytzX2hhcmR3YXJlQ29udGV4dENvdW50OworICAgICAg ICAgICAgICAgIH0KKwogICAgICAgICAgICAgfQogICAgICAgICAgICAgbV9pc0luaXRpYWxpemVk ID0gdHJ1ZTsKICAgICAgICAgfQo=