65210 2011-07-26 15:31:30 -0700 [chromium] Remove viewport clear from release builds 2013-04-11 14:49:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 jamesr jamesr enne jamesr kbr nduca schenney vangelis webkit.review.bot oldest_to_newest 442574 0 jamesr 2011-07-26 15:31:30 -0700 [chromium] Remove viewport clear from release builds 442590 1 102067 jamesr 2011-07-26 15:55:41 -0700 Created attachment 102067 Patch 442648 2 102067 kbr 2011-07-26 17:32:19 -0700 Comment on attachment 102067 Patch Hmm. Debug builds are so slow that it's unlikely we will do extensive testing with them. But I'll leave this decision up to those working on the compositor. 442652 3 jamesr 2011-07-26 17:39:06 -0700 We do run the compositing tests in debug, at least. 442699 4 102067 webkit.review.bot 2011-07-26 19:14:55 -0700 Comment on attachment 102067 Patch Rejecting attachment 102067 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1 Last 500 characters of output: 0e94b75603c487eee0ba355e40fcb6b01c81ffa8 r91810 = 851bbe5a9502994f015ea8746c3ec847fc50b2b4 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9245650 442702 5 jamesr 2011-07-26 19:23:55 -0700 Gah, I misformatted the ChangeLog again. D'oh! 442705 6 jamesr 2011-07-26 19:28:20 -0700 Committed r91812: <http://trac.webkit.org/changeset/91812> 442719 7 enne 2011-07-26 20:18:33 -0700 Reverted r91812 for reason: Breaks Committed r91821: <http://trac.webkit.org/changeset/91821> 443134 8 jamesr 2011-07-27 13:39:14 -0700 So as it turns out, this clear was the only thing ensuring that the root layer's alpha channel was fully opaque. We mask out alpha writes when drawing the root layer so on the mac bot the alpha channel was in an undefined state. I think a better approach is to clear the default render surface whenever it is created or resized, instead of every frame. I'll look into this if I get a chance. We are paying a lot of bandwidth for this clear currently. 102067 2011-07-26 15:55:41 -0700 2013-04-11 14:48:57 -0700 Patch bug-65210-20110726155540.patch text/plain 1905 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3ODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZTJhZmJlZmZlMDU5NjFl NjBhMzE2NDkzZmJkN2Q2YjMwNjg2ZTBiLi4wZDI4NWVlNmU4ZTQ4NDhiN2U4ZjhjN2Y5MmVhYjU5 NjFjNmEzZGRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjYgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEF2 b2lkIGNsZWFyaW5nIHRoZSBmcmFtZWJ1ZmZlciB3aGVuIGNvbXBvc2l0aW5nIGluIHJlbGVhc2Ug YnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NTIxMAorCisgICAgICAgIFdlIGNsZWFyIHRoZSBkZWZhdWx0IGZyYW1lYnVmZmVyIHRvIGJsdWUg d2hlbiBjb21wb3NpdGluZyBzbyBpdCdzCisgICAgICAgIGVhc2llciB0byBzcG90IHJlZ2lvbnMg d2UgbWlzcy4gVGhpcyBpcyB1c2VmdWwgZm9yIGRlYnVnZ2luZywgYnV0IGVhdHMKKyAgICAgICAg YmFuZHdpZHRoIHVubmVjZXNzYXJpbHkgaW4gcmVsZWFzZSBidWlsZHMuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJzKToKKwogMjAx MS0wNy0yNiAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYwNzc4CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21p dW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJS ZW5kZXJlckNocm9taXVtLmNwcAppbmRleCA1NDAyMDY4MmIzMjJjMTE2ZmY2NjNmZDhjOGE3ZDhj MTMzMzEwZDkxLi5mNzUyNTEwNWM1YTg0NTlhZDljNzkwYmU4N2RlNzk1NTY3OGFjN2MxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJl bmRlcmVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKQEAgLTQ5NSwxMCArNDk1LDEyIEBA IHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJzKGNvbnN0IExheWVyTGlzdCYg cmVuZGVyU3VyZmFjZUxheWVyTGlzdCkKIAogICAgIHVzZVJlbmRlclN1cmZhY2UobV9kZWZhdWx0 UmVuZGVyU3VyZmFjZSk7CiAKKyNpZm5kZWYgTkRFQlVHCiAgICAgLy8gQ2xlYXIgdG8gYmx1ZSB0 byBtYWtlIGl0IGVhc2llciB0byBzcG90IHVucmVuZGVyZWQgcmVnaW9ucy4KICAgICBtX2NvbnRl eHQtPmNsZWFyQ29sb3IoMCwgMCwgMSwgMSk7CiAgICAgbV9jb250ZXh0LT5jb2xvck1hc2sodHJ1 ZSwgdHJ1ZSwgdHJ1ZSwgdHJ1ZSk7CiAgICAgbV9jb250ZXh0LT5jbGVhcihHcmFwaGljc0NvbnRl eHQzRDo6Q09MT1JfQlVGRkVSX0JJVCk7CisjZW5kaWYKICAgICAvLyBNYXNrIG91dCB3cml0ZXMg dG8gYWxwaGEgY2hhbm5lbDogc3VicGl4ZWwgYW50aWFsaWFzaW5nIHZpYSBTa2lhIHJlc3VsdHMg aW4gaW52YWxpZAogICAgIC8vIHplcm8gYWxwaGEgdmFsdWVzIG9uIHRleHQgZ2x5cGhzLiBUaGUg cm9vdCBsYXllciBpcyBhbHdheXMgb3BhcXVlLgogICAgIG1fY29udGV4dC0+Y29sb3JNYXNrKHRy dWUsIHRydWUsIHRydWUsIGZhbHNlKTsK