65195 2011-07-26 11:31:03 -0700 regression: generating CSSValueKeywords should not print by default 2011-07-26 12:13:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 evan evan tkent tony oldest_to_newest 442398 0 evan 2011-07-26 11:31:03 -0700 regression: generating CSSValueKeywords should not print by default 442400 1 102031 evan 2011-07-26 11:32:37 -0700 Created attachment 102031 Patch 442401 2 evan 2011-07-26 11:34:19 -0700 Here are all the callers I could find of applyPreprocessor: http://codesearch.google.com/codesearch#search/&exact_package=chromium&q=applypreprocessor&type=cs The ones that don't provide a final argument should print nothing; they regressed. The one that passes 1 as a final argument wants to always be quiet. So there was only one caller that actually wanted the output. 442402 3 102032 evan 2011-07-26 11:34:39 -0700 Created attachment 102032 Patch 442405 4 102032 tony 2011-07-26 11:37:06 -0700 Comment on attachment 102032 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102032&action=review > Source/WebCore/bindings/scripts/IDLParser.pm:70 > my @documentContent = applyPreprocessor($fileName, $defines, $preprocessor, $beQuiet); Nit: Remove $beQuiet here. 442432 5 evan 2011-07-26 12:13:14 -0700 Committed r91770: <http://trac.webkit.org/changeset/91770> 102031 2011-07-26 11:32:37 -0700 2011-07-26 11:34:36 -0700 Patch bug-65195-20110726113239.patch text/plain 2542 evan U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3NDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMjg2ZGFmNTI4ZmE2NTIx MzY0ZWY3ZmRlODhhNTQ5YTMzN2Y2Njg5Li44NmIyNDFjZmEwNWYxOWYzYzQ2YTg2ZWNjNmFhMmJl YTcwMDZhN2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMjYgIEV2YW4g TWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgcmVncmVzc2lvbjogZ2VuZXJh dGluZyBDU1NWYWx1ZUtleXdvcmRzIHNob3VsZCBub3QgcHJpbnQgYnkgZGVmYXVsdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxOTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIHJlZmFjdG9yaW5n IG1hZGUgc29tZSBjYWxsZXJzIG5vIGxvbmdlciBwYXNzIHRoZSBmaW5hbCAnYmVRdWlldCcKKyAg ICAgICAgcGFyYW1ldGVyIHRvIGFwcGx5UHJlcHJvY2Vzc29yLiAgVGhpcyBmbGFnIHdhcyBvbmx5 IHVzZWQgdG8gcHJpbnQgdGhlCisgICAgICAgIGlucHV0IGZpbGVuYW1lIGFueXdheSwgc28gcmVt b3ZlIHRoZSBmbGFnIGFuZCBqdXN0IG1ha2UgdGhlIGNhbGxlcgorICAgICAgICBwcmludCB0aGUg ZmlsZW5hbWUgaWYgaXQgd2FudHMgdGhpcy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv SURMUGFyc2VyLnBtOgorICAgICAgICAoUGFyc2UpOiBwcmludCBiZWZvcmUgY2FsbGluZyBhcHBs eVByZXByb2Nlc3NvciwgaWYgbmVjZXNzYXJ5LgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv cHJlcHJvY2Vzc29yLnBtOgorICAgICAgICAoYXBwbHlQcmVwcm9jZXNzb3IpOiByZW1vdmUgdGhl IGJlUXVpZXQgZmxhZzsganVzdCBhbHdheXMgYmUgcXVpZXQuCisKIDIwMTEtMDctMjYgIFNoaW55 YSBLYXdhbmFrYSAgPHNoaW55YWtAZ29vZ2xlLmNvbT4KIAogICAgICAgICBVc2VzIGlzSFRNTFNw YWNlIHRvIG5vcm1hbGl6ZSB3aGl0ZSBzcGFjZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvSURMUGFyc2VyLnBtCmluZGV4IDA1Mzc0Zjc1NWU2MzRhMWNiYWVlNmU4MzdjYmEw ODNmZTI1MDA4NmEuLjVmZDcwYTZhZGNlZTFmZWQ4OTNjYTZjMWE1MjgwMjA1MDc0MGIwNTMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtCkBAIC02Niw2 ICs2Niw3IEBAIHN1YiBQYXJzZQogICAgIG15ICRwcmVwcm9jZXNzb3IgPSBzaGlmdDsKICAgICAk cGFyZW50c09ubHkgPSBzaGlmdDsKIAorICAgIHByaW50ICIgfCAqKiogU3RhcnRpbmcgdG8gcGFy c2UgJGZpbGVOYW1lLi4uXG4gfFxuIiB1bmxlc3MgJGJlUXVpZXQ7CiAgICAgbXkgQGRvY3VtZW50 Q29udGVudCA9IGFwcGx5UHJlcHJvY2Vzc29yKCRmaWxlTmFtZSwgJGRlZmluZXMsICRwcmVwcm9j ZXNzb3IsICRiZVF1aWV0KTsKIAogICAgIG15ICRkYXRhQXZhaWxhYmxlID0gMDsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KaW5kZXggYzM4MmRh NmViZmY2NWJmNmIzYzgxMzRkZDk3NDY5ZDAwNDE4MGZhMy4uZGMwMjE5ZmRiNWFjMmUzZGRmOTgz MjUxOWQwOGI0MjFmMTBmMjBlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9wcmVwcm9jZXNzb3IucG0KQEAgLTM5LDcgKzM5LDYgQEAgc3ViIGFwcGx5UHJlcHJvY2Vz c29yCiAgICAgbXkgJGZpbGVOYW1lID0gc2hpZnQ7CiAgICAgbXkgJGRlZmluZXMgPSBzaGlmdDsK ICAgICBteSAkcHJlcHJvY2Vzc29yID0gc2hpZnQ7Ci0gICAgbXkgJGJlUXVpZXQgPSBzaGlmdDsK IAogICAgIGlmICghJHByZXByb2Nlc3NvcikgewogICAgICAgICByZXF1aXJlIENvbmZpZzsKQEAg LTU4LDggKzU3LDYgQEAgc3ViIGFwcGx5UHJlcHJvY2Vzc29yCiAgICAgICAgICRkZWZpbmVzID0g IiI7CiAgICAgfQogCi0gICAgcHJpbnQgIiB8ICoqKiBTdGFydGluZyB0byBwYXJzZSAkZmlsZU5h bWUuLi5cbiB8XG4iIHVubGVzcyAkYmVRdWlldDsKLQogICAgIG15ICRwaWQgPSBvcGVuMihcKlBQ X09VVCwgXCpQUF9JTiwgc3BsaXQoJyAnLCAkcHJlcHJvY2Vzc29yKSwgKG1hcCB7ICItRCRfIiB9 IHNwbGl0KCcgJywgJGRlZmluZXMpKSwgJGZpbGVOYW1lKTsKICAgICBjbG9zZSBQUF9JTjsKICAg ICBteSBAZG9jdW1lbnRDb250ZW50ID0gPFBQX09VVD47Cg== 102032 2011-07-26 11:34:39 -0700 2011-07-26 11:37:06 -0700 Patch bug-65195-20110726113441.patch text/plain 3198 evan U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3NDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyMjg2ZGFmNTI4ZmE2NTIx MzY0ZWY3ZmRlODhhNTQ5YTMzN2Y2Njg5Li44NmIyNDFjZmEwNWYxOWYzYzQ2YTg2ZWNjNmFhMmJl YTcwMDZhN2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMjYgIEV2YW4g TWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgcmVncmVzc2lvbjogZ2VuZXJh dGluZyBDU1NWYWx1ZUtleXdvcmRzIHNob3VsZCBub3QgcHJpbnQgYnkgZGVmYXVsdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxOTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIHJlZmFjdG9yaW5n IG1hZGUgc29tZSBjYWxsZXJzIG5vIGxvbmdlciBwYXNzIHRoZSBmaW5hbCAnYmVRdWlldCcKKyAg ICAgICAgcGFyYW1ldGVyIHRvIGFwcGx5UHJlcHJvY2Vzc29yLiAgVGhpcyBmbGFnIHdhcyBvbmx5 IHVzZWQgdG8gcHJpbnQgdGhlCisgICAgICAgIGlucHV0IGZpbGVuYW1lIGFueXdheSwgc28gcmVt b3ZlIHRoZSBmbGFnIGFuZCBqdXN0IG1ha2UgdGhlIGNhbGxlcgorICAgICAgICBwcmludCB0aGUg ZmlsZW5hbWUgaWYgaXQgd2FudHMgdGhpcy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv SURMUGFyc2VyLnBtOgorICAgICAgICAoUGFyc2UpOiBwcmludCBiZWZvcmUgY2FsbGluZyBhcHBs eVByZXByb2Nlc3NvciwgaWYgbmVjZXNzYXJ5LgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv cHJlcHJvY2Vzc29yLnBtOgorICAgICAgICAoYXBwbHlQcmVwcm9jZXNzb3IpOiByZW1vdmUgdGhl IGJlUXVpZXQgZmxhZzsganVzdCBhbHdheXMgYmUgcXVpZXQuCisKIDIwMTEtMDctMjYgIFNoaW55 YSBLYXdhbmFrYSAgPHNoaW55YWtAZ29vZ2xlLmNvbT4KIAogICAgICAgICBVc2VzIGlzSFRNTFNw YWNlIHRvIG5vcm1hbGl6ZSB3aGl0ZSBzcGFjZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvSURMUGFyc2VyLnBtCmluZGV4IDA1Mzc0Zjc1NWU2MzRhMWNiYWVlNmU4MzdjYmEw ODNmZTI1MDA4NmEuLjVmZDcwYTZhZGNlZTFmZWQ4OTNjYTZjMWE1MjgwMjA1MDc0MGIwNTMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtCkBAIC02Niw2 ICs2Niw3IEBAIHN1YiBQYXJzZQogICAgIG15ICRwcmVwcm9jZXNzb3IgPSBzaGlmdDsKICAgICAk cGFyZW50c09ubHkgPSBzaGlmdDsKIAorICAgIHByaW50ICIgfCAqKiogU3RhcnRpbmcgdG8gcGFy c2UgJGZpbGVOYW1lLi4uXG4gfFxuIiB1bmxlc3MgJGJlUXVpZXQ7CiAgICAgbXkgQGRvY3VtZW50 Q29udGVudCA9IGFwcGx5UHJlcHJvY2Vzc29yKCRmaWxlTmFtZSwgJGRlZmluZXMsICRwcmVwcm9j ZXNzb3IsICRiZVF1aWV0KTsKIAogICAgIG15ICRkYXRhQXZhaWxhYmxlID0gMDsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KaW5kZXggYzM4MmRh NmViZmY2NWJmNmIzYzgxMzRkZDk3NDY5ZDAwNDE4MGZhMy4uZGMwMjE5ZmRiNWFjMmUzZGRmOTgz MjUxOWQwOGI0MjFmMTBmMjBlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9wcmVwcm9jZXNzb3IucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9wcmVwcm9jZXNzb3IucG0KQEAgLTM5LDcgKzM5LDYgQEAgc3ViIGFwcGx5UHJlcHJvY2Vz c29yCiAgICAgbXkgJGZpbGVOYW1lID0gc2hpZnQ7CiAgICAgbXkgJGRlZmluZXMgPSBzaGlmdDsK ICAgICBteSAkcHJlcHJvY2Vzc29yID0gc2hpZnQ7Ci0gICAgbXkgJGJlUXVpZXQgPSBzaGlmdDsK IAogICAgIGlmICghJHByZXByb2Nlc3NvcikgewogICAgICAgICByZXF1aXJlIENvbmZpZzsKQEAg LTU4LDggKzU3LDYgQEAgc3ViIGFwcGx5UHJlcHJvY2Vzc29yCiAgICAgICAgICRkZWZpbmVzID0g IiI7CiAgICAgfQogCi0gICAgcHJpbnQgIiB8ICoqKiBTdGFydGluZyB0byBwYXJzZSAkZmlsZU5h bWUuLi5cbiB8XG4iIHVubGVzcyAkYmVRdWlldDsKLQogICAgIG15ICRwaWQgPSBvcGVuMihcKlBQ X09VVCwgXCpQUF9JTiwgc3BsaXQoJyAnLCAkcHJlcHJvY2Vzc29yKSwgKG1hcCB7ICItRCRfIiB9 IHNwbGl0KCcgJywgJGRlZmluZXMpKSwgJGZpbGVOYW1lKTsKICAgICBjbG9zZSBQUF9JTjsKICAg ICBteSBAZG9jdW1lbnRDb250ZW50ID0gPFBQX09VVD47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvbWFrZS1jc3MtZmlsZS1hcnJheXMucGwgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFr ZS1jc3MtZmlsZS1hcnJheXMucGwKaW5kZXggMGYwZTk2YTBhNWY3NzhmMTlkYWNmNTlkZjNmMjc2 YTE3MDQwZWU0NC4uM2FjMWVjZTRlZDdjM2Y0NTIzMWVkNDljZjA3YmFkYzIzMjZmMGNjOCAxMDA3 NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2UtY3NzLWZpbGUtYXJyYXlzLnBsCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlLWNzcy1maWxlLWFycmF5cy5wbApAQCAtNTYsNyArNTYs NyBAQCBmb3IgbXkgJGluIChAQVJHVikgewogICAgICAgICAkdGV4dCA9fiBzfF4jLio/JHx8bWc7 CiAgICAgfSBlbHNlIHsKICAgICAgICAgcmVxdWlyZSBwcmVwcm9jZXNzb3I7Ci0gICAgICAgICR0 ZXh0ID0gam9pbignJywgYXBwbHlQcmVwcm9jZXNzb3IoJGluLCAkZGVmaW5lcywgJHByZXByb2Nl c3NvciwgMSkpOworICAgICAgICAkdGV4dCA9IGpvaW4oJycsIGFwcGx5UHJlcHJvY2Vzc29yKCRp biwgJGRlZmluZXMsICRwcmVwcm9jZXNzb3IpKTsKICAgICB9CiAKICAgICAjIFJlbW92ZSBjb21t ZW50cyBpbiBhIHNpbXBsZS1taW5kZWQgd2F5IHRoYXQgd2lsbCB3b3JrIGZpbmUgZm9yIG91ciBm aWxlcy4K