<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>65192</bug_id>
          
          <creation_ts>2011-07-26 11:04:36 -0700</creation_ts>
          <short_desc>[EFL] Do not crash if the Cairo surface cannot be created.</short_desc>
          <delta_ts>2011-09-06 10:48:53 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Raphael Kubo da Costa (:rakuco)">rakuco</reporter>
          <assigned_to name="Raphael Kubo da Costa (:rakuco)">rakuco</assigned_to>
          <cc>leandro</cc>
    
    <cc>mrobinson</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>442372</commentid>
    <comment_count>0</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-07-26 11:04:36 -0700</bug_when>
    <thetext>[EFL] Do not crash if the Cairo surface cannot be created.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442378</commentid>
    <comment_count>1</comment_count>
      <attachid>102028</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-07-26 11:09:07 -0700</bug_when>
    <thetext>Created attachment 102028
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442383</commentid>
    <comment_count>2</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-07-26 11:10:35 -0700</bug_when>
    <thetext>CC&apos;ing mrobinson instead of tkent, as this is cairo-related.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442390</commentid>
    <comment_count>3</comment_count>
      <attachid>102028</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2011-07-26 11:21:44 -0700</bug_when>
    <thetext>Comment on attachment 102028
Patch

Attachment 102028 did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9251384</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442534</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-07-26 14:40:09 -0700</bug_when>
    <thetext>Wouldn&apos;t it be better to use the current clip to figure out how big the surface should be rather than to just fail?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443058</commentid>
    <comment_count>5</comment_count>
      <attachid>102164</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-07-27 12:08:39 -0700</bug_when>
    <thetext>Created attachment 102164
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443063</commentid>
    <comment_count>6</comment_count>
      <attachid>102164</attachid>
    <who name="Leandro Pereira">leandro</who>
    <bug_when>2011-07-27 12:14:36 -0700</bug_when>
    <thetext>Comment on attachment 102164
Patch

The &apos;return false&apos;  substituting &apos;return true&apos;  in themePartCacheEntrySurfaceCreate() shouldn&apos;t be there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443129</commentid>
    <comment_count>7</comment_count>
      <attachid>102179</attachid>
    <who name="Leandro Pereira">leandro</who>
    <bug_when>2011-07-27 13:30:37 -0700</bug_when>
    <thetext>Created attachment 102179
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443282</commentid>
    <comment_count>8</comment_count>
      <attachid>102179</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-07-27 19:38:47 -0700</bug_when>
    <thetext>Comment on attachment 102179
Patch

By my comment I actually was asking whether or not you could simply cache only what&apos;s within the clipping region, versus allocating a cache area the size of the entire widget.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>457646</commentid>
    <comment_count>9</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-08-26 10:56:24 -0700</bug_when>
    <thetext>Sorry for leaving this one behind for so long.

I was talking to Leandro about your question/suggestion a few minutes ago. If we were to cache what&apos;s visible, wouldn&apos;t we need to keep track of viewport size changes and all that, making the code much bigger?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>457748</commentid>
    <comment_count>10</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-08-26 13:42:08 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; Sorry for leaving this one behind for so long.
&gt; 
&gt; I was talking to Leandro about your question/suggestion a few minutes ago. If we were to cache what&apos;s visible, wouldn&apos;t we need to keep track of viewport size changes and all that, making the code much bigger?

I don&apos;t know exactly how your theme cache works, but it seems that if you should already be checking whether the widget changes size each time you draw. You&apos;d just need to add one more condition determining whether or not the clip region has moved or changed size. I&apos;m not sure how feasible that is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461174</commentid>
    <comment_count>11</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-09-02 05:41:07 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; I don&apos;t know exactly how your theme cache works, but it seems that if you should already be checking whether the widget changes size each time you draw. You&apos;d just need to add one more condition determining whether or not the clip region has moved or changed size. I&apos;m not sure how feasible that is.

After spending some time on this, it looks like implementing this suggestion could be feasible, but would require quite some effort. On the one hand, Edje (which actually renders the theme) has a hardcoded limit of 20000x20000 pixels for a widget&apos;s dimensions; on the other hand, the way RenderThemeEfl is currently implemented makes it a bit difficult to track the clipping region and decide where exactly in the cairo context to paint the rendered element (when scrolling, scaling and other things are taken into account it becomes even harder).

For now, I think it&apos;s OK to just not display elements which are too big (a 1-month-old GtkLauncher build I have here just displays the top of the textarea in the mentioned testcase, and my distro&apos;s Chromium displays mostly garbage after some point too).

I&apos;m submitting a new patch with a better heuristic in a few minutes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>461176</commentid>
    <comment_count>12</comment_count>
      <attachid>106118</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-09-02 05:45:37 -0700</bug_when>
    <thetext>Created attachment 106118
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462512</commentid>
    <comment_count>13</comment_count>
      <attachid>106419</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2011-09-06 07:55:00 -0700</bug_when>
    <thetext>Created attachment 106419
Be less strict about what sizes we consider to be invalid</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462647</commentid>
    <comment_count>14</comment_count>
      <attachid>106419</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-06 10:48:47 -0700</bug_when>
    <thetext>Comment on attachment 106419
Be less strict about what sizes we consider to be invalid

Clearing flags on attachment: 106419

Committed r94578: &lt;http://trac.webkit.org/changeset/94578&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>462648</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-09-06 10:48:53 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>102028</attachid>
            <date>2011-07-26 11:09:07 -0700</date>
            <delta_ts>2011-07-27 12:08:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-65192-20110726151236.patch</filename>
            <type>text/plain</type>
            <size>2671</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3NjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMmI5OTViYTE2MzE0NWM0
ZGNhNGE3MWI4ZDM3ZDM2N2FiMzFjOWQ3Li4wNDFjNTFiZmI1N2VmYTc3OTdkZDZiZGM3MDZiNzM0
YmU4YzlhODI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDctMjYgIFJhcGhh
ZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0VGTF0g
RG8gbm90IGNyYXNoIGlmIHRoZSBDYWlybyBzdXJmYWNlIGNhbm5vdCBiZSBjcmVhdGVkLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxOTIKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21lIHRlc3RzIHRy
eSB0byBjcmVhdGUgaHVnZSBlbGVtZW50cywgd2hpY2ggbWFrZSBjYWlybyBmYWlsIHRvCisgICAg
ICAgIGNyZWF0ZSB0aGUgcHJvcGVyIHN1cmZhY2UuIFdlIG5lZWQgbm90IGFzc2VydCBvciBwcmlu
dCBlcnJvciBtZXNzYWdlcworICAgICAgICBpbiBzdWNoIGNhc2VzLgorICAgICAgICBUaGlzIHNo
b3VsZCBtYWtlCisgICAgICAgIGZhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3ctaGVpZ2h0LWZsb2F0LW5v
dC1yZW1vdmVkLWNyYXNoLmh0bWwgc3RvcAorICAgICAgICBjcmFzaGluZy4KKworICAgICAgICBO
byBuZXcgdGVzdHMsIGFzIHRoaXMgd2FzIHVuY292ZXJlZCBieSBhbiBleGlzdGluZyBvbmUuCisK
KyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6UmVuZGVyVGhlbWVFZmw6OnRoZW1lUGFydENhY2hlRW50cnlTdXJmYWNlQ3JlYXRlKToK
KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFydCk6CisKIDIw
MTEtMDctMjYgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgogCiAgICAg
ICAgIFtDU1NSZWdpb25zXSBDb2xsZWN0IGZsb3dlZCBlbGVtZW50cyBpbiBkaWZmZXJlbnQgcmVu
ZGVyIGVsZW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5k
ZXJUaGVtZUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVF
ZmwuY3BwCmluZGV4IDYxMzUxZjU1NWViNmY1ZjRiN2UzYzQ1N2VjMDI4YjgzOTlhYjdmYzguLjM2
ZmMyYWE2NTA5YzMxZDJjYzVkMGUxZDc0ODU2MmRiNDAyZGZlNTMgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKKysrIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcApAQCAtMTM0LDEzICsxMzQsMTUg
QEAgYm9vbCBSZW5kZXJUaGVtZUVmbDo6dGhlbWVQYXJ0Q2FjaGVFbnRyeVN1cmZhY2VDcmVhdGUo
c3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkKICAgICBlbnRyeS0+c3VyZmFjZSA9IGNhaXJvX2lt
YWdlX3N1cmZhY2VfY3JlYXRlX2Zvcl9kYXRhKCh1bnNpZ25lZCBjaGFyICopZWNvcmVfZXZhc19i
dWZmZXJfcGl4ZWxzX2dldChlbnRyeS0+ZWUpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgQ0FJUk9fRk9STUFUX0FSR0IzMiwgdywgaCwgdyAq
IDQpOwogICAgIHN0YXR1cyA9IGNhaXJvX3N1cmZhY2Vfc3RhdHVzKGVudHJ5LT5zdXJmYWNlKTsK
LSAgICBpZiAoc3RhdHVzICE9IENBSVJPX1NUQVRVU19TVUNDRVNTKSB7CisgICAgaWYgKHN0YXR1
cyA9PSBDQUlST19TVEFUVVNfU1VDQ0VTUykKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICAv
LyBTb21lIHRlc3RzIChlLmcuIGZhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3ctaGVpZ2h0LWZsb2F0LW5v
dC1yZW1vdmVkLWNyYXNoLmh0bWwpIHRyaWVzIHRvIGNyZWF0ZSBodWdlIGVsZW1lbnRzCisgICAg
Ly8gYW5kIENhaXJvIGZhaWxzIHdpdGggQ0FJUk9fU1RBVFVTX0lOVkFMSURfU0laRTsgZG8gbm90
IHByaW50IGVycm9yIG1lc3NhZ2VzIGluIHN1Y2ggY2FzZXMuCisgICAgaWYgKHN0YXR1cyAhPSBD
QUlST19TVEFUVVNfSU5WQUxJRF9TSVpFKQogICAgICAgICBFSU5BX0xPR19FUlIoIkNvdWxkIG5v
dCBjcmVhdGUgY2Fpcm8gc3VyZmFjZTogJXMiLAogICAgICAgICAgICAgICAgICAgICAgY2Fpcm9f
c3RhdHVzX3RvX3N0cmluZyhzdGF0dXMpKTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0K
LQotICAgIHJldHVybiB0cnVlOworICAgIHJldHVybiBmYWxzZTsKIH0KIAogLy8gYWxsb2NhdGUg
YSBuZXcgZW50cnkgYW5kIGZpbGwgaXQgd2l0aCBlZGplIGdyb3VwCkBAIC0yOTcsNyArMjk5LDYg
QEAgYm9vbCBSZW5kZXJUaGVtZUVmbDo6cGFpbnRUaGVtZVBhcnQoUmVuZGVyT2JqZWN0KiBvYmpl
Y3QsIEZvcm1UeXBlIHR5cGUsIGNvbnN0IFAKICAgICBBU1NFUlQobV9lZGplKTsKIAogICAgIGVu
dHJ5ID0gY2FjaGVUaGVtZVBhcnRHZXQodHlwZSwgcmVjdC5zaXplKCkpOwotICAgIEFTU0VSVChl
bnRyeSk7CiAgICAgaWYgKCFlbnRyeSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>102164</attachid>
            <date>2011-07-27 12:08:39 -0700</date>
            <delta_ts>2011-07-27 13:30:37 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-65192-20110727161209.patch</filename>
            <type>text/plain</type>
            <size>3774</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTE4MzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZWUyZTk5YzA4NWUzMTg0
YWI5ZGQ4YjdlMzYxZDliN2JiMTNhNGYxLi4xZGY2YTQ3ZDZmMTRhZGFkZGM4ODgxYWVjNzhlN2U1
YzBjNGJhN2RiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDctMjcgIFJhcGhh
ZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0VGTF0g
RG8gbm90IGFsbG9jYXRlIGV4dHJlbWVseSBsYXJnZSBzdXJmYWNlcy4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MTkyCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VyZmFjZSBzaXplcyBsYXJnZXIgdGhh
biB0d2ljZSB0aGUgYXJlYSBvZiB0aGUgbWFpbiBmcmFtZSB2aWV3cG9ydAorICAgICAgICB3aWxs
IG5vdCBiZSBkcmF3biAob3IgYWxsb2NhdGVkLCBmb3IgdGhhdCBtYXR0ZXIpLiBUaGlzIHNob3Vs
ZCBiZQorICAgICAgICBlbm91Z2ggZm9yIHJlZ3VsYXIgZm9ybSB3aWRnZXRzLCBhbmQgbWFrZXMg
dGVzdHMgc3VjaCBhcworICAgICAgICBmYXN0L292ZXJmbG93L292ZXJmbG93LWhlaWdodC1mbG9h
dC1ub3QtcmVtb3ZlZC1jcmFzaC5odG1sIGFuZCBmcmllbmRzCisgICAgICAgIHN0b3AgY3Jhc2hp
bmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhcyB0aGlzIHdhcyB1bmNvdmVyZWQgYnkgZXhp
c3Rpbmcgb25lcy4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6dGhlbWVQYXJ0Q2FjaGVFbnRyeVN1
cmZhY2VDcmVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6OmlzRm9ybUVs
ZW1lbnRUb29MYXJnZVRvRGlzcGxheSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVm
bDo6Y2FjaGVUaGVtZVBhcnROZXcpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6
OnBhaW50VGhlbWVQYXJ0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwu
aDoKKwogMjAxMS0wNy0yNyAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0Bnb29nbGUuY29tPgog
CiAgICAgICAgIFVzZXMgaXNIVE1MU3BhY2UgdG8gbm9ybWFsaXplIHdoaXRlIHNwYWNlcy4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCmluZGV4IGNj
YWIwODFhYWJlMTgxNTI2NzUyZDMyNzc2YTcwN2M1MDJlNTA0NzIuLmY5NjhhYmMzM2EzY2JiZjk4
YWRjZWFjNGEzZGQwODYwNDE4YjRiN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
ZWZsL1JlbmRlclRoZW1lRWZsLmNwcApAQCAtMTQwLDE0ICsxNDAsMjcgQEAgYm9vbCBSZW5kZXJU
aGVtZUVmbDo6dGhlbWVQYXJ0Q2FjaGVFbnRyeVN1cmZhY2VDcmVhdGUoc3RydWN0IFRoZW1lUGFy
dENhY2hlRW50cnkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAotICAgIHJldHVybiB0
cnVlOworICAgIHJldHVybiBmYWxzZTsKK30KKworYm9vbCBSZW5kZXJUaGVtZUVmbDo6aXNGb3Jt
RWxlbWVudFRvb0xhcmdlVG9EaXNwbGF5KGNvbnN0IEludFNpemUmIGVsZW1lbnRTaXplKQorewor
ICAgIC8vIFNpbXBsZSBoZXVyaXN0aWMgdG8gYXZvaWQgY3JlYXRpbmcgZXh0cmVtZWx5IGxhcmdl
IHN1cmZhY2VzLCBsaWtlIHRoZSBvbmUgZXhwbG9yZWQgYnkKKyAgICAvLyBmYXN0L292ZXJmbG93
L292ZXJmbG93LWhlaWdodC1mbG9hdC1ub3QtcmVtb3ZlZC1jcmFzaC5odG1sLCB3aGlsZSBhbGxv
d2luZyBsZWdpdGltYXRlCisgICAgLy8gd2lkZ2V0cyB0byBiZSBkcmF3bi4KKyAgICBjb25zdCBJ
bnRSZWN0IHdpbmRvd0NsaXBSZWN0ID0gbV9wYWdlLT5tYWluRnJhbWUoKS0+dmlldygpLT53aW5k
b3dDbGlwUmVjdChmYWxzZSk7CisgICAgY29uc3QgaW50IHR3aWNlVGhlQXJlYSA9IDIgKiB3aW5k
b3dDbGlwUmVjdC53aWR0aCgpICogd2luZG93Q2xpcFJlY3QuaGVpZ2h0KCk7CisKKyAgICByZXR1
cm4gZWxlbWVudFNpemUud2lkdGgoKSA+IHR3aWNlVGhlQXJlYSB8fCBlbGVtZW50U2l6ZS5oZWln
aHQoKSA+IHR3aWNlVGhlQXJlYTsKIH0KIAogLy8gYWxsb2NhdGUgYSBuZXcgZW50cnkgYW5kIGZp
bGwgaXQgd2l0aCBlZGplIGdyb3VwCiBzdHJ1Y3QgUmVuZGVyVGhlbWVFZmw6OlRoZW1lUGFydENh
Y2hlRW50cnkqIFJlbmRlclRoZW1lRWZsOjpjYWNoZVRoZW1lUGFydE5ldyhGb3JtVHlwZSB0eXBl
LCBjb25zdCBJbnRTaXplJiBzaXplKQogewotICAgIHN0cnVjdCBUaGVtZVBhcnRDYWNoZUVudHJ5
ICplbnRyeSA9IG5ldyBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeTsKKyAgICBpZiAoaXNGb3Jt
RWxlbWVudFRvb0xhcmdlVG9EaXNwbGF5KHNpemUpKQorICAgICAgICByZXR1cm4gMDsKIAorICAg
IFRoZW1lUGFydENhY2hlRW50cnkqIGVudHJ5ID0gbmV3IFRoZW1lUGFydENhY2hlRW50cnk7CiAg
ICAgaWYgKCFlbnRyeSkgewogICAgICAgICBFSU5BX0xPR19FUlIoImNvdWxkIG5vdCBhbGxvY2F0
ZSBUaGVtZVBhcnRDYWNoZUVudHJ5LiIpOwogICAgICAgICByZXR1cm4gMDsKQEAgLTI5Nyw3ICsz
MTAsNiBAQCBib29sIFJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3Qq
IG9iamVjdCwgRm9ybVR5cGUgdHlwZSwgY29uc3QgUAogICAgIEFTU0VSVChtX2VkamUpOwogCiAg
ICAgZW50cnkgPSBjYWNoZVRoZW1lUGFydEdldCh0eXBlLCByZWN0LnNpemUoKSk7Ci0gICAgQVNT
RVJUKGVudHJ5KTsKICAgICBpZiAoIWVudHJ5KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKaW5kZXggZGExYzUx
NGJhYzBhOTY3NDUwZTEyMjgyODVmYTUzNjk2Y2UzZmVlOS4uZGE2OWMyZTQ1NjFhZmI3ZDUyMjk3
NDkyYzUzMTAzOTIzZDRhYmUwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
ZWZsL1JlbmRlclRoZW1lRWZsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Jl
bmRlclRoZW1lRWZsLmgKQEAgLTE5OSw2ICsxOTksNyBAQCBwcml2YXRlOgogICAgIGNvbnN0IGNo
YXIqIGVkamVHcm91cEZyb21Gb3JtVHlwZShGb3JtVHlwZSkgY29uc3Q7CiAgICAgdm9pZCBhcHBs
eUVkamVTdGF0ZUZyb21Gb3JtKEV2YXNfT2JqZWN0KiwgQ29udHJvbFN0YXRlcyk7CiAgICAgYm9v
bCBwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3QqLCBGb3JtVHlwZSwgY29uc3QgUGFpbnRJbmZv
JiwgY29uc3QgSW50UmVjdCYpOworICAgIGJvb2wgaXNGb3JtRWxlbWVudFRvb0xhcmdlVG9EaXNw
bGF5KGNvbnN0IEludFNpemUmKTsKIAogI2lmIEVOQUJMRShWSURFTykKICAgICBib29sIGVtaXRN
ZWRpYUJ1dHRvblNpZ25hbChGb3JtVHlwZSwgTWVkaWFDb250cm9sRWxlbWVudFR5cGUsIGNvbnN0
IEludFJlY3QmKTsK
</data>
<flag name="review"
          id="97333"
          type_id="1"
          status="-"
          setter="leandro"
    />
    <flag name="commit-queue"
          id="97334"
          type_id="3"
          status="-"
          setter="leandro"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>102179</attachid>
            <date>2011-07-27 13:30:37 -0700</date>
            <delta_ts>2011-09-02 05:45:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bla.patch</filename>
            <type>text/plain</type>
            <size>3561</size>
            <attacher name="Leandro Pereira">leandro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTE4MzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5ZWUyZTk5YzA4NWUzMTg0
YWI5ZGQ4YjdlMzYxZDliN2JiMTNhNGYxLi4xZGY2YTQ3ZDZmMTRhZGFkZGM4ODgxYWVjNzhlN2U1
YzBjNGJhN2RiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDctMjcgIFJhcGhh
ZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0VGTF0g
RG8gbm90IGFsbG9jYXRlIGV4dHJlbWVseSBsYXJnZSBzdXJmYWNlcy4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MTkyCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VyZmFjZSBzaXplcyBsYXJnZXIgdGhh
biB0d2ljZSB0aGUgYXJlYSBvZiB0aGUgbWFpbiBmcmFtZSB2aWV3cG9ydAorICAgICAgICB3aWxs
IG5vdCBiZSBkcmF3biAob3IgYWxsb2NhdGVkLCBmb3IgdGhhdCBtYXR0ZXIpLiBUaGlzIHNob3Vs
ZCBiZQorICAgICAgICBlbm91Z2ggZm9yIHJlZ3VsYXIgZm9ybSB3aWRnZXRzLCBhbmQgbWFrZXMg
dGVzdHMgc3VjaCBhcworICAgICAgICBmYXN0L292ZXJmbG93L292ZXJmbG93LWhlaWdodC1mbG9h
dC1ub3QtcmVtb3ZlZC1jcmFzaC5odG1sIGFuZCBmcmllbmRzCisgICAgICAgIHN0b3AgY3Jhc2hp
bmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhcyB0aGlzIHdhcyB1bmNvdmVyZWQgYnkgZXhp
c3Rpbmcgb25lcy4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6dGhlbWVQYXJ0Q2FjaGVFbnRyeVN1
cmZhY2VDcmVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6OmlzRm9ybUVs
ZW1lbnRUb29MYXJnZVRvRGlzcGxheSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVm
bDo6Y2FjaGVUaGVtZVBhcnROZXcpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6
OnBhaW50VGhlbWVQYXJ0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwu
aDoKKwogMjAxMS0wNy0yNyAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0Bnb29nbGUuY29tPgog
CiAgICAgICAgIFVzZXMgaXNIVE1MU3BhY2UgdG8gbm9ybWFsaXplIHdoaXRlIHNwYWNlcy4KZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCmluZGV4IGNj
YWIwODFhYWJlMTgxNTI2NzUyZDMyNzc2YTcwN2M1MDJlNTA0NzIuLmY5NjhhYmMzM2EzY2JiZjk4
YWRjZWFjNGEzZGQwODYwNDE4YjRiN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
ZWZsL1JlbmRlclRoZW1lRWZsLmNwcApAQCAtMTQzLDExICsxNDMsMjQgQEAKICAgICByZXR1cm4g
dHJ1ZTsKIH0KIAorYm9vbCBSZW5kZXJUaGVtZUVmbDo6aXNGb3JtRWxlbWVudFRvb0xhcmdlVG9E
aXNwbGF5KGNvbnN0IEludFNpemUmIGVsZW1lbnRTaXplKQoreworICAgIC8vIFNpbXBsZSBoZXVy
aXN0aWMgdG8gYXZvaWQgY3JlYXRpbmcgZXh0cmVtZWx5IGxhcmdlIHN1cmZhY2VzLCBsaWtlIHRo
ZSBvbmUgZXhwbG9yZWQgYnkKKyAgICAvLyBmYXN0L292ZXJmbG93L292ZXJmbG93LWhlaWdodC1m
bG9hdC1ub3QtcmVtb3ZlZC1jcmFzaC5odG1sLCB3aGlsZSBhbGxvd2luZyBsZWdpdGltYXRlCisg
ICAgLy8gd2lkZ2V0cyB0byBiZSBkcmF3bi4KKyAgICBjb25zdCBJbnRSZWN0IHdpbmRvd0NsaXBS
ZWN0ID0gbV9wYWdlLT5tYWluRnJhbWUoKS0+dmlldygpLT53aW5kb3dDbGlwUmVjdChmYWxzZSk7
CisgICAgY29uc3QgaW50IHR3aWNlVGhlQXJlYSA9IDIgKiB3aW5kb3dDbGlwUmVjdC53aWR0aCgp
ICogd2luZG93Q2xpcFJlY3QuaGVpZ2h0KCk7CisKKyAgICByZXR1cm4gZWxlbWVudFNpemUud2lk
dGgoKSA+IHR3aWNlVGhlQXJlYSB8fCBlbGVtZW50U2l6ZS5oZWlnaHQoKSA+IHR3aWNlVGhlQXJl
YTsKK30KKwogLy8gYWxsb2NhdGUgYSBuZXcgZW50cnkgYW5kIGZpbGwgaXQgd2l0aCBlZGplIGdy
b3VwCiBzdHJ1Y3QgUmVuZGVyVGhlbWVFZmw6OlRoZW1lUGFydENhY2hlRW50cnkqIFJlbmRlclRo
ZW1lRWZsOjpjYWNoZVRoZW1lUGFydE5ldyhGb3JtVHlwZSB0eXBlLCBjb25zdCBJbnRTaXplJiBz
aXplKQogewotICAgIHN0cnVjdCBUaGVtZVBhcnRDYWNoZUVudHJ5ICplbnRyeSA9IG5ldyBzdHJ1
Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeTsKKyAgICBpZiAoaXNGb3JtRWxlbWVudFRvb0xhcmdlVG9E
aXNwbGF5KHNpemUpKQorICAgICAgICByZXR1cm4gMDsKIAorICAgIFRoZW1lUGFydENhY2hlRW50
cnkqIGVudHJ5ID0gbmV3IFRoZW1lUGFydENhY2hlRW50cnk7CiAgICAgaWYgKCFlbnRyeSkgewog
ICAgICAgICBFSU5BX0xPR19FUlIoImNvdWxkIG5vdCBhbGxvY2F0ZSBUaGVtZVBhcnRDYWNoZUVu
dHJ5LiIpOwogICAgICAgICByZXR1cm4gMDsKQEAgLTI5Nyw3ICszMTAsNiBAQAogICAgIEFTU0VS
VChtX2VkamUpOwogCiAgICAgZW50cnkgPSBjYWNoZVRoZW1lUGFydEdldCh0eXBlLCByZWN0LnNp
emUoKSk7Ci0gICAgQVNTRVJUKGVudHJ5KTsKICAgICBpZiAoIWVudHJ5KQogICAgICAgICByZXR1
cm4gZmFsc2U7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5k
ZXJUaGVtZUVmbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZs
LmgKaW5kZXggZGExYzUxNGJhYzBhOTY3NDUwZTEyMjgyODVmYTUzNjk2Y2UzZmVlOS4uZGE2OWMy
ZTQ1NjFhZmI3ZDUyMjk3NDkyYzUzMTAzOTIzZDRhYmUwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKKysrIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKQEAgLTE5OSw2ICsxOTksNyBAQCBwcml2YXRl
OgogICAgIGNvbnN0IGNoYXIqIGVkamVHcm91cEZyb21Gb3JtVHlwZShGb3JtVHlwZSkgY29uc3Q7
CiAgICAgdm9pZCBhcHBseUVkamVTdGF0ZUZyb21Gb3JtKEV2YXNfT2JqZWN0KiwgQ29udHJvbFN0
YXRlcyk7CiAgICAgYm9vbCBwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3QqLCBGb3JtVHlwZSwg
Y29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOworICAgIGJvb2wgaXNGb3JtRWxlbWVu
dFRvb0xhcmdlVG9EaXNwbGF5KGNvbnN0IEludFNpemUmKTsKIAogI2lmIEVOQUJMRShWSURFTykK
ICAgICBib29sIGVtaXRNZWRpYUJ1dHRvblNpZ25hbChGb3JtVHlwZSwgTWVkaWFDb250cm9sRWxl
bWVudFR5cGUsIGNvbnN0IEludFJlY3QmKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>106118</attachid>
            <date>2011-09-02 05:45:37 -0700</date>
            <delta_ts>2011-09-06 07:54:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-65192-20110902094911.patch</filename>
            <type>text/plain</type>
            <size>3964</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ0MTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NGVmNTFhN2M4MWM1OTYx
MDQ1MmRhNThjYzZlNGEwMmJjNzM0NzBkLi4wMTc1NmFlYmYyMTdhOGRkMjIxNGNiYjRjYzAzYmNk
ZGJhODRkNTcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDktMDIgIFJhcGhh
ZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0VGTF0g
RG8gbm90IGFsbG9jYXRlIG1lbW9yeSBmb3IgZXh0cmVtZWx5IGxhcmdlIHN1cmZhY2VzLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxOTIKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTbyBmYXIsIFJlbmRl
clRoZW1lRWZsIHRyaWVkIHRvIGFsbG9jYXRlIGEgYnVmZmVyIGFuZCBhIGNhaXJvIHN1cmZhY2UK
KyAgICAgICAgdGhlIHNpemUgb2YgdGhlIHdob2xlIGZvcm0gZWxlbWVudCBwYXNzZWQgdG8gaXQu
CisKKyAgICAgICAgSW4gdGhlIGNhc2Ugb2YKKyAgICAgICAgZmFzdC9vdmVyZmxvdy9vdmVyZmxv
dy1oZWlnaHQtZmxvYXQtbm90LXJlbW92ZWQtY3Jhc2guaHRtbCBhbmQgb3RoZXJzLAorICAgICAg
ICB0aGlzIG1lYW50IGV4dHJlbWVseSBsYXJnZSB3aWRnZXRzLCB3aGljaCBjcmFzaGVkIHRoZSBj
b2RlLgorCisgICAgICAgIFdlIG5vdyBvbmx5IHJlbmRlciB0aGUgd2lkZ2V0cyBpZiB0aGV5IGFy
ZSBzbWFsbGVyIHRoYW4gc29tZSBoYXJkY29kZWQKKyAgICAgICAgYW5kIHN1ZmZpY2llbnRseSBs
YXJnZSB2YWx1ZXMgd2hpY2ggc2hvdWxkIHdvcmsgaW4gbW9zdCBjYXNlcy4KKworICAgICAgICBO
byBuZXcgdGVzdHMsIGFzIHRoaXMgd2FzIHVuY292ZXJlZCBieSBleGlzdGluZyBvbmVzLgorCisg
ICAgICAgICogcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OlJlbmRlclRoZW1lRWZsOjppc0Zvcm1FbGVtZW50VG9vTGFyZ2VUb0Rpc3BsYXkpOgorICAg
ICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6OmNhY2hlVGhlbWVQYXJ0TmV3KToKKyAgICAg
ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFydCk6CisgICAgICAgICog
cGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmg6CisKIDIwMTEtMDktMDIgIFZzZXZvbG9kIFZs
YXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWFr
ZSBpdCBtb3JlIGNsZWFyIHdoZW4gcmVxdWVzdHMgYXJlIGxvYWRlZCBmcm9tIGNhY2hlIG9uIG5l
dHdvcmsgcGFuZWwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVu
ZGVyVGhlbWVFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1l
RWZsLmNwcAppbmRleCA3MjFlZTIxMjczYmQyNTllNjdhNWQ2NDI0MDMwMTE5ZDJiMjgwNGY1Li5j
MTI4MWMwODE2ZWMxZmQ5ZmFhOThmMzk2YzhiYmMyODgxMjMxZjQxIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKQEAgLTE0MywxMSArMTQzLDI5
IEBAIGJvb2wgUmVuZGVyVGhlbWVFZmw6OnRoZW1lUGFydENhY2hlRW50cnlTdXJmYWNlQ3JlYXRl
KHN0cnVjdCBUaGVtZVBhcnRDYWNoZUVudHJ5CiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK2Jvb2wg
UmVuZGVyVGhlbWVFZmw6OmlzRm9ybUVsZW1lbnRUb29MYXJnZVRvRGlzcGxheShjb25zdCBJbnRT
aXplJiBlbGVtZW50U2l6ZSkKK3sKKyAgICAvLyBTaW1wbGUgaGV1cmlzdGljIHRvIGF2b2lkIGNy
ZWF0aW5nIGV4dHJlbWVseSBsYXJnZSBzdXJmYWNlcywgbGlrZSB0aGUgb25lIGV4cGxvcmVkIGJ5
CisgICAgLy8gZmFzdC9vdmVyZmxvdy9vdmVyZmxvdy1oZWlnaHQtZmxvYXQtbm90LXJlbW92ZWQt
Y3Jhc2guaHRtbCwgd2hpbGUgYWxsb3dpbmcgbGVnaXRpbWF0ZQorICAgIC8vIHdpZGdldHMgdG8g
YmUgZHJhd24uCisgICAgc3RhdGljIGNvbnN0IGludCBtYXhEaW1lbnNpb24gPSAyMDAwMDsKKyAg
ICBzdGF0aWMgY29uc3QgaW50IG1heEFyZWEgPSAxMDAwMDA7CisKKyAgICBjb25zdCBpbnQgd2lk
dGggPSBlbGVtZW50U2l6ZS53aWR0aCgpOworICAgIGNvbnN0IGludCBoZWlnaHQgPSBlbGVtZW50
U2l6ZS5oZWlnaHQoKTsKKworICAgIHJldHVybiAod2lkdGggPiBtYXhEaW1lbnNpb24gfHwgaGVp
Z2h0ID4gbWF4RGltZW5zaW9uIHx8ICh3aWR0aCAqIGhlaWdodCkgPiBtYXhBcmVhKTsKK30KKwog
Ly8gYWxsb2NhdGUgYSBuZXcgZW50cnkgYW5kIGZpbGwgaXQgd2l0aCBlZGplIGdyb3VwCiBzdHJ1
Y3QgUmVuZGVyVGhlbWVFZmw6OlRoZW1lUGFydENhY2hlRW50cnkqIFJlbmRlclRoZW1lRWZsOjpj
YWNoZVRoZW1lUGFydE5ldyhGb3JtVHlwZSB0eXBlLCBjb25zdCBJbnRTaXplJiBzaXplKQogewot
ICAgIHN0cnVjdCBUaGVtZVBhcnRDYWNoZUVudHJ5ICplbnRyeSA9IG5ldyBzdHJ1Y3QgVGhlbWVQ
YXJ0Q2FjaGVFbnRyeTsKKyAgICBpZiAoaXNGb3JtRWxlbWVudFRvb0xhcmdlVG9EaXNwbGF5KHNp
emUpKSB7CisgICAgICAgIEVJTkFfTE9HX0VSUigiY2Fubm90IHJlbmRlciBhbiBlbGVtZW50IG9m
IHNpemUgJWR4JWQiLCBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCkpOworICAgICAgICByZXR1
cm4gMDsKKyAgICB9CiAKKyAgICBUaGVtZVBhcnRDYWNoZUVudHJ5KiBlbnRyeSA9IG5ldyBUaGVt
ZVBhcnRDYWNoZUVudHJ5OwogICAgIGlmICghZW50cnkpIHsKICAgICAgICAgRUlOQV9MT0dfRVJS
KCJjb3VsZCBub3QgYWxsb2NhdGUgVGhlbWVQYXJ0Q2FjaGVFbnRyeS4iKTsKICAgICAgICAgcmV0
dXJuIDA7CkBAIC0yOTcsNyArMzE1LDYgQEAgYm9vbCBSZW5kZXJUaGVtZUVmbDo6cGFpbnRUaGVt
ZVBhcnQoUmVuZGVyT2JqZWN0KiBvYmplY3QsIEZvcm1UeXBlIHR5cGUsIGNvbnN0IFAKICAgICBB
U1NFUlQobV9lZGplKTsKIAogICAgIGVudHJ5ID0gY2FjaGVUaGVtZVBhcnRHZXQodHlwZSwgcmVj
dC5zaXplKCkpOwotICAgIEFTU0VSVChlbnRyeSk7CiAgICAgaWYgKCFlbnRyeSkKICAgICAgICAg
cmV0dXJuIGZhbHNlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv
UmVuZGVyVGhlbWVFZmwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVt
ZUVmbC5oCmluZGV4IGJjNWNiNjc5Y2RiNTBkMmI4NjgyMDVmNjViNjI3YTYzMjcyYzQ5YTcuLjMw
YTBmMGQ1ZWJlYjY4OTA1YmMxZTFlN2I5ODMzOTcxMDY0Y2Y1ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCisrKyBiL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCkBAIC0yMDAsNiArMjAwLDcgQEAgcHJp
dmF0ZToKICAgICBjb25zdCBjaGFyKiBlZGplR3JvdXBGcm9tRm9ybVR5cGUoRm9ybVR5cGUpIGNv
bnN0OwogICAgIHZvaWQgYXBwbHlFZGplU3RhdGVGcm9tRm9ybShFdmFzX09iamVjdCosIENvbnRy
b2xTdGF0ZXMpOwogICAgIGJvb2wgcGFpbnRUaGVtZVBhcnQoUmVuZGVyT2JqZWN0KiwgRm9ybVR5
cGUsIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKTsKKyAgICBib29sIGlzRm9ybUVs
ZW1lbnRUb29MYXJnZVRvRGlzcGxheShjb25zdCBJbnRTaXplJik7CiAKICNpZiBFTkFCTEUoVklE
RU8pCiAgICAgYm9vbCBlbWl0TWVkaWFCdXR0b25TaWduYWwoRm9ybVR5cGUsIE1lZGlhQ29udHJv
bEVsZW1lbnRUeXBlLCBjb25zdCBJbnRSZWN0Jik7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>106419</attachid>
            <date>2011-09-06 07:55:00 -0700</date>
            <delta_ts>2011-09-06 10:48:46 -0700</delta_ts>
            <desc>Be less strict about what sizes we consider to be invalid</desc>
            <filename>bug-65192-20110906115837.patch</filename>
            <type>text/plain</type>
            <size>3795</size>
            <attacher name="Raphael Kubo da Costa (:rakuco)">rakuco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTQ1NjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlYWNkMWE1YWRkNjk2MjBi
MGM4MmQ0YWRiYjY3N2U5NzM4YmEzNzI2Li44Yjk2ZjRhZTE2NThmYTFkOTQ2NjBiMTIxZjQ2OTA1
NzYxNmE2OTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDktMDYgIFJhcGhh
ZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgW0VGTF0g
RG8gbm90IGFsbG9jYXRlIG1lbW9yeSBmb3IgZXh0cmVtZWx5IGxhcmdlIHN1cmZhY2VzLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxOTIKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTbyBmYXIsIFJlbmRl
clRoZW1lRWZsIHRyaWVkIHRvIGFsbG9jYXRlIGEgYnVmZmVyIGFuZCBhIGNhaXJvIHN1cmZhY2UK
KyAgICAgICAgdGhlIHNpemUgb2YgdGhlIHdob2xlIGZvcm0gZWxlbWVudCBwYXNzZWQgdG8gaXQu
CisKKyAgICAgICAgSW4gdGhlIGNhc2Ugb2YKKyAgICAgICAgZmFzdC9vdmVyZmxvdy9vdmVyZmxv
dy1oZWlnaHQtZmxvYXQtbm90LXJlbW92ZWQtY3Jhc2guaHRtbCBhbmQgb3RoZXJzLAorICAgICAg
ICB0aGlzIG1lYW50IGV4dHJlbWVseSBsYXJnZSB3aWRnZXRzLCB3aGljaCBjcmFzaGVkIHRoZSBj
b2RlLgorCisgICAgICAgIFdlIG5vdyBvbmx5IHJlbmRlciB0aGUgd2lkZ2V0cyBpZiB0aGV5IGFy
ZSBzbWFsbGVyIHRoYW4gc29tZSBoYXJkY29kZWQKKyAgICAgICAgYW5kIHN1ZmZpY2llbnRseSBs
YXJnZSB2YWx1ZXMgd2hpY2ggc2hvdWxkIHdvcmsgaW4gbW9zdCBjYXNlcy4KKworICAgICAgICBO
byBuZXcgdGVzdHMsIGFzIHRoaXMgd2FzIHVuY292ZXJlZCBieSBleGlzdGluZyBvbmVzLgorCisg
ICAgICAgICogcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OlJlbmRlclRoZW1lRWZsOjppc0Zvcm1FbGVtZW50VG9vTGFyZ2VUb0Rpc3BsYXkpOgorICAg
ICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6OmNhY2hlVGhlbWVQYXJ0TmV3KToKKyAgICAg
ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpwYWludFRoZW1lUGFydCk6CisgICAgICAgICog
cGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmg6CisKIDIwMTEtMDktMDYgIFJvYiBCdWlzICA8
cmJ1aXNAcmltLmNvbT4KIAogICAgICAgICB1c2UgYWZ0ZXIgZnJlZSBpbiBXZWJDb3JlOjpTVkdU
UmVmRWxlbWVudDo6dXBkYXRlUmVmZXJlbmNlZFRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCmluZGV4IDcyMWVlMjEyNzNiZDI1OWU2N2E1ZDY0
MjQwMzAxMTlkMmIyODA0ZjUuLjBkZDMzMDYzODFjYmNmNGY4YWU1YzI2NWVjOTY1OTk1NGQxOWJk
MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVm
bC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNw
cApAQCAtMTQzLDExICsxNDMsMjUgQEAgYm9vbCBSZW5kZXJUaGVtZUVmbDo6dGhlbWVQYXJ0Q2Fj
aGVFbnRyeVN1cmZhY2VDcmVhdGUoc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkKICAgICByZXR1
cm4gdHJ1ZTsKIH0KIAorYm9vbCBSZW5kZXJUaGVtZUVmbDo6aXNGb3JtRWxlbWVudFRvb0xhcmdl
VG9EaXNwbGF5KGNvbnN0IEludFNpemUmIGVsZW1lbnRTaXplKQoreworICAgIC8vIFRoaXMgbGlt
aXQgb2YgMjAwMDAgcGl4ZWxzIGlzIGhhcmRjb2RlZCBpbnNpZGUgZWRqZSAtLSBhbnl0aGluZyBh
Ym92ZSB0aGlzIHNpemUKKyAgICAvLyB3aWxsIGJlIGNsaXBwZWQuIFRoaXMgdmFsdWUgc2VlbXMg
dG8gYmUgcmVhc29uYWJsZSBlbm91Z2ggc28gdGhhdCBoYXJkY29kaW5nIGl0CisgICAgLy8gaGVy
ZSB3b24ndCBiZSBhIHByb2JsZW0uCisgICAgc3RhdGljIGNvbnN0IGludCBtYXhFZGplRGltZW5z
aW9uID0gMjAwMDA7CisKKyAgICByZXR1cm4gZWxlbWVudFNpemUud2lkdGgoKSA+IG1heEVkamVE
aW1lbnNpb24gfHwgZWxlbWVudFNpemUuaGVpZ2h0KCkgPiBtYXhFZGplRGltZW5zaW9uOworfQor
CiAvLyBhbGxvY2F0ZSBhIG5ldyBlbnRyeSBhbmQgZmlsbCBpdCB3aXRoIGVkamUgZ3JvdXAKIHN0
cnVjdCBSZW5kZXJUaGVtZUVmbDo6VGhlbWVQYXJ0Q2FjaGVFbnRyeSogUmVuZGVyVGhlbWVFZmw6
OmNhY2hlVGhlbWVQYXJ0TmV3KEZvcm1UeXBlIHR5cGUsIGNvbnN0IEludFNpemUmIHNpemUpCiB7
Ci0gICAgc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkgKmVudHJ5ID0gbmV3IHN0cnVjdCBUaGVt
ZVBhcnRDYWNoZUVudHJ5OworICAgIGlmIChpc0Zvcm1FbGVtZW50VG9vTGFyZ2VUb0Rpc3BsYXko
c2l6ZSkpIHsKKyAgICAgICAgRUlOQV9MT0dfRVJSKCJjYW5ub3QgcmVuZGVyIGFuIGVsZW1lbnQg
b2Ygc2l6ZSAlZHglZCIsIHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSk7CisgICAgICAgIHJl
dHVybiAwOworICAgIH0KIAorICAgIFRoZW1lUGFydENhY2hlRW50cnkqIGVudHJ5ID0gbmV3IFRo
ZW1lUGFydENhY2hlRW50cnk7CiAgICAgaWYgKCFlbnRyeSkgewogICAgICAgICBFSU5BX0xPR19F
UlIoImNvdWxkIG5vdCBhbGxvY2F0ZSBUaGVtZVBhcnRDYWNoZUVudHJ5LiIpOwogICAgICAgICBy
ZXR1cm4gMDsKQEAgLTI5Nyw3ICszMTEsNiBAQCBib29sIFJlbmRlclRoZW1lRWZsOjpwYWludFRo
ZW1lUGFydChSZW5kZXJPYmplY3QqIG9iamVjdCwgRm9ybVR5cGUgdHlwZSwgY29uc3QgUAogICAg
IEFTU0VSVChtX2VkamUpOwogCiAgICAgZW50cnkgPSBjYWNoZVRoZW1lUGFydEdldCh0eXBlLCBy
ZWN0LnNpemUoKSk7Ci0gICAgQVNTRVJUKGVudHJ5KTsKICAgICBpZiAoIWVudHJ5KQogICAgICAg
ICByZXR1cm4gZmFsc2U7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm
bC9SZW5kZXJUaGVtZUVmbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRo
ZW1lRWZsLmgKaW5kZXggYmM1Y2I2NzljZGI1MGQyYjg2ODIwNWY2NWI2MjdhNjMyNzJjNDlhNy4u
MzBhMGYwZDVlYmViNjg5MDViYzFlMWU3Yjk4MzM5NzEwNjRjZjVkZSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKKysrIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKQEAgLTIwMCw2ICsyMDAsNyBAQCBw
cml2YXRlOgogICAgIGNvbnN0IGNoYXIqIGVkamVHcm91cEZyb21Gb3JtVHlwZShGb3JtVHlwZSkg
Y29uc3Q7CiAgICAgdm9pZCBhcHBseUVkamVTdGF0ZUZyb21Gb3JtKEV2YXNfT2JqZWN0KiwgQ29u
dHJvbFN0YXRlcyk7CiAgICAgYm9vbCBwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3QqLCBGb3Jt
VHlwZSwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOworICAgIGJvb2wgaXNGb3Jt
RWxlbWVudFRvb0xhcmdlVG9EaXNwbGF5KGNvbnN0IEludFNpemUmKTsKIAogI2lmIEVOQUJMRShW
SURFTykKICAgICBib29sIGVtaXRNZWRpYUJ1dHRvblNpZ25hbChGb3JtVHlwZSwgTWVkaWFDb250
cm9sRWxlbWVudFR5cGUsIGNvbnN0IEludFJlY3QmKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>