<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>65190</bug_id>
          
          <creation_ts>2011-07-26 10:12:00 -0700</creation_ts>
          <short_desc>Add protection space authentication callback code to CFNetwork loader on Mac</short_desc>
          <delta_ts>2011-07-26 16:44:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>51836</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Pratik Solanki">psolanki</reporter>
          <assigned_to name="Pratik Solanki">psolanki</assigned_to>
          <cc>ap</cc>
    
    <cc>beidson</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>jberlin</cc>
    
    <cc>koivisto</cc>
    
    <cc>psolanki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>442337</commentid>
    <comment_count>0</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-07-26 10:12:00 -0700</bug_when>
    <thetext>Currently, the USE(PROTECTION_SPACE_AUTH_CALLBACK) code is only implemented in ResourceHandleMac.mm. In order to use the CFNetwork based loader on Mac, we need to implement that call back in ResourceHandleCFNet.cpp as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442367</commentid>
    <comment_count>1</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-07-26 11:02:51 -0700</bug_when>
    <thetext>&lt;rdar://problem/9842424&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442370</commentid>
    <comment_count>2</comment_count>
      <attachid>102025</attachid>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-07-26 11:03:49 -0700</bug_when>
    <thetext>Created attachment 102025
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442376</commentid>
    <comment_count>3</comment_count>
      <attachid>102025</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-07-26 11:07:43 -0700</bug_when>
    <thetext>Comment on attachment 102025
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102025&amp;action=review

r=me, but it would be good to have a bug filed for the FIXME

&gt; Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:921
&gt; +    // FIXME: We should ask FrameLoaderClient.

Is there a bug filed for this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442385</commentid>
    <comment_count>4</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-07-26 11:11:48 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 102025 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=102025&amp;action=review
&gt; 
&gt; r=me, 

Thanks!

&gt; but it would be good to have a bug filed for the FIXME
&gt; 
&gt; &gt; Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:921
&gt; &gt; +    // FIXME: We should ask FrameLoaderClient.
&gt; 
&gt; Is there a bug filed for this?

It&apos;s the same in ResourceHandleMac.mm. We have lots of FIXMEs in the synchronous loader case (in both ResourceHandleCFNet.cpp and ResourceHandleMac.mm). Let me look around to see if we have a bug on that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442409</commentid>
    <comment_count>5</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-07-26 11:39:09 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)

&gt; &gt; Is there a bug filed for this?
&gt; 
&gt; It&apos;s the same in ResourceHandleMac.mm. We have lots of FIXMEs in the synchronous loader case (in both ResourceHandleCFNet.cpp and ResourceHandleMac.mm). Let me look around to see if we have a bug on that.

So there&apos;s bug 8342 about didReceiveAuthenticationChallenge but I couldn&apos;t find any for the protection space callback. Field &lt;https://bugs.webkit.org/show_bug.cgi?id=65196&gt;. I&apos;ll put a reference to it in the comments.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442422</commentid>
    <comment_count>6</comment_count>
      <attachid>102025</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-07-26 12:00:24 -0700</bug_when>
    <thetext>Comment on attachment 102025
Patch

Attachment 102025 did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9253371</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442495</commentid>
    <comment_count>7</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-07-26 13:38:37 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 102025 [details])
&gt; Attachment 102025 [details] did not pass mac-ews (mac):
&gt; Output: http://queues.webkit.org/results/9253371

Pretty sure this is because UNUSED_PARAM() should be inside #if LOG_DISABLED, not #if !LOG_DISABLED. If only the EWS bot let me see the full build result.... Will confirm with a release build (since debug doesn&apos;t have any problems compiling ResourceHandleMac.mm) and commit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>442619</commentid>
    <comment_count>8</comment_count>
    <who name="Pratik Solanki">psolanki</who>
    <bug_when>2011-07-26 16:44:33 -0700</bug_when>
    <thetext>Committed r91799: &lt;http://trac.webkit.org/changeset/91799&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>102025</attachid>
            <date>2011-07-26 11:03:49 -0700</date>
            <delta_ts>2011-07-26 12:00:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-65190-20110726110347.patch</filename>
            <type>text/plain</type>
            <size>7484</size>
            <attacher name="Pratik Solanki">psolanki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3NjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMmI5OTViYTE2MzE0NWM0
ZGNhNGE3MWI4ZDM3ZDM2N2FiMzFjOWQ3Li4yMTY0ZmYwMDE2NWNjYWU1YjEyNzljZDc0YWEwYWE4
MTk1Y2ViYmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDctMjYgIFByYXRp
ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBwcm90ZWN0aW9u
IHNwYWNlIGF1dGhlbnRpY2F0aW9uIGNhbGxiYWNrIGNvZGUgdG8gQ0ZOZXR3b3JrIGxvYWRlciBv
biBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1
MTkwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85ODQyNDI0PgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBvcnQgb3ZlciBwcm90ZWN0aW9uIHNwYWNl
IGF1dGhlbnRpY2F0aW9uIGNhbGxiYWNrIGNvZGUgZnJvbSBSZXNvdXJjZUhhbmRsZU1hYy5tbSB0
bworICAgICAgICBSZXNvdXJjZUhhbmRsZUNGTmV0LmNwcC4KKworICAgICAgICAqIHBsYXRmb3Jt
L25ldHdvcmsvUmVzb3VyY2VIYW5kbGUuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2Nm
L1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2FuUmVzcG9uZFRv
UHJvdGVjdGlvblNwYWNlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpjcmVh
dGVDRlVSTENvbm5lY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OmNh
bkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UpOgorICAgICAgICAoV2ViQ29yZTo6
V2ViQ29yZVN5bmNocm9ub3VzTG9hZGVyQ2xpZW50OjpjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJv
dGVjdGlvblNwYWNlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhh
bmRsZU1hYy5tbToKKyAgICAgICAgKC1bV2ViQ29yZVJlc291cmNlSGFuZGxlQXNEZWxlZ2F0ZSBj
b25uZWN0aW9uOmNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2U6XSk6IEFkZCBs
b2dnaW5nLgorCiAyMDExLTA3LTI2ICBBbGV4YW5kcnUgQ2hpY3VsaXRhICA8YWNoaWN1QGFkb2Jl
LmNvbT4KIAogICAgICAgICBbQ1NTUmVnaW9uc10gQ29sbGVjdCBmbG93ZWQgZWxlbWVudHMgaW4g
ZGlmZmVyZW50IHJlbmRlciBlbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9uZXR3b3JrL1Jlc291cmNlSGFuZGxlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u
ZXR3b3JrL1Jlc291cmNlSGFuZGxlLmgKaW5kZXggMDUzYTA0ZmI0MDc3YTgwM2NjNTE4YWI1MjFj
N2EzZjA0OGJmZGFjNC4uYTc0ODI2ODQyZDJhNTZjMGU3OTcyMDc2Y2FlMzRmYjU3ZTFlNjdlNiAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRs
ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGUu
aApAQCAtMTIyLDE4ICsxMjIsMTggQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCByZWNlaXZl
ZENhbmNlbGxhdGlvbihjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYpOwogI2VuZGlmCiAK
LSNpZiBQTEFURk9STShNQUMpICYmICFVU0UoQ0ZORVRXT1JLKQotICAgIHZvaWQgZGlkQ2FuY2Vs
QXV0aGVudGljYXRpb25DaGFsbGVuZ2UoY29uc3QgQXV0aGVudGljYXRpb25DaGFsbGVuZ2UmKTsK
KyNpZiBQTEFURk9STShNQUMpCiAjaWYgVVNFKFBST1RFQ1RJT05fU1BBQ0VfQVVUSF9DQUxMQkFD
SykKICAgICBib29sIGNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UoY29uc3Qg
UHJvdGVjdGlvblNwYWNlJik7CiAjZW5kaWYKKyNpZiAhVVNFKENGTkVUV09SSykKKyAgICB2b2lk
IGRpZENhbmNlbEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNvbnN0IEF1dGhlbnRpY2F0aW9uQ2hh
bGxlbmdlJik7CiAgICAgTlNVUkxDb25uZWN0aW9uICpjb25uZWN0aW9uKCkgY29uc3Q7CiAgICAg
V2ViQ29yZVJlc291cmNlSGFuZGxlQXNEZWxlZ2F0ZSAqZGVsZWdhdGUoKTsKICAgICB2b2lkIHJl
bGVhc2VEZWxlZ2F0ZSgpOwogICAgIGlkIHJlbGVhc2VQcm94eSgpOwogI2VuZGlmCiAKLSNpZiBQ
TEFURk9STShNQUMpCiAgICAgdm9pZCBzY2hlZHVsZShTY2hlZHVsZVBhaXIqKTsKICAgICB2b2lk
IHVuc2NoZWR1bGUoU2NoZWR1bGVQYWlyKik7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VIYW5kbGVDRk5ldC5jcHAgYi9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwCmlu
ZGV4IDJiY2I1YzY0ZGUxYmU1YWRjOTEzMjI4ZjY4NTAzYjM4MWUxMTlmYTkuLmQ0MmMzYTIwYTZi
ZGE2MmRlZmNlOWI5YTdlOWRjODQ1NzNiYjE0ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL25ldHdvcmsvY2YvUmVzb3VyY2VIYW5kbGVDRk5ldC5jcHAKKysrIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZUhhbmRsZUNGTmV0LmNwcApAQCAt
MTAzLDYgKzEwMyw5IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGRpZFJlY2VpdmVEYXRh
KFJlc291cmNlSGFuZGxlKiwgY29uc3QgY2hhciosIGludCwgaW50IC8qZW5jb2RlZERhdGFMZW5n
dGgqLyk7CiAgICAgdmlydHVhbCB2b2lkIGRpZEZpbmlzaExvYWRpbmcoUmVzb3VyY2VIYW5kbGUq
LCBkb3VibGUgLypmaW5pc2hUaW1lKi8pOwogICAgIHZpcnR1YWwgdm9pZCBkaWRGYWlsKFJlc291
cmNlSGFuZGxlKiwgY29uc3QgUmVzb3VyY2VFcnJvciYpOworI2lmIFVTRShQUk9URUNUSU9OX1NQ
QUNFX0FVVEhfQ0FMTEJBQ0spCisgICAgdmlydHVhbCBib29sIGNhbkF1dGhlbnRpY2F0ZUFnYWlu
c3RQcm90ZWN0aW9uU3BhY2UoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBQcm90ZWN0aW9uU3BhY2Um
KTsKKyNlbmRpZgogCiAgICAgYm9vbCBtX2FsbG93U3RvcmVkQ3JlZGVudGlhbHM7CiAgICAgUmVz
b3VyY2VSZXNwb25zZSYgbV9yZXNwb25zZTsKQEAgLTM0OCw2ICszNTEsMjEgQEAgc3RhdGljIHZv
aWQgZGlkUmVjZWl2ZUNoYWxsZW5nZShDRlVSTENvbm5lY3Rpb25SZWYgY29ubiwgQ0ZVUkxBdXRo
Q2hhbGxlbmdlUmVmIGMKICAgICBoYW5kbGUtPmRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxs
ZW5nZShBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShjaGFsbGVuZ2UsIGhhbmRsZSkpOwogfQogCisj
aWYgVVNFKFBST1RFQ1RJT05fU1BBQ0VfQVVUSF9DQUxMQkFDSykKK3N0YXRpYyBCb29sZWFuIGNh
blJlc3BvbmRUb1Byb3RlY3Rpb25TcGFjZShDRlVSTENvbm5lY3Rpb25SZWYgY29ubiwgQ0ZVUkxQ
cm90ZWN0aW9uU3BhY2VSZWYgcHJvdGVjdGlvblNwYWNlLCBjb25zdCB2b2lkKiBjbGllbnRJbmZv
KQoreworI2lmIExPR19ESVNBQkxFRAorICAgIFVOVVNFRF9QQVJBTShjb25uKTsKKyNlbmRpZgor
ICAgIFJlc291cmNlSGFuZGxlKiBoYW5kbGUgPSBzdGF0aWNfY2FzdDxSZXNvdXJjZUhhbmRsZSo+
KGNvbnN0X2Nhc3Q8dm9pZCo+KGNsaWVudEluZm8pKTsKKyAgICBBU1NFUlQoaGFuZGxlKTsKKwor
ICAgIExPRyhOZXR3b3JrLCAiQ0ZOZXQgLSBjYW5SZXNwb25kVG9Qcm90ZWN0aW9uU3BhY2UoY29u
bj0lcCwgaGFuZGxlPSVwICglcykiLCBjb25uLCBoYW5kbGUsIGhhbmRsZS0+Zmlyc3RSZXF1ZXN0
KCkudXJsKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CisKKyAgICByZXR1cm4gaGFuZGxlLT5j
YW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlKGNvcmUocHJvdGVjdGlvblNwYWNl
KSk7Cit9CisjZW5kaWYKKwogUmVzb3VyY2VIYW5kbGVJbnRlcm5hbDo6flJlc291cmNlSGFuZGxl
SW50ZXJuYWwoKQogewogICAgIGlmIChtX2Nvbm5lY3Rpb24pIHsKQEAgLTQ1OCw4ICs0NzYsOCBA
QCB2b2lkIFJlc291cmNlSGFuZGxlOjpjcmVhdGVDRlVSTENvbm5lY3Rpb24oYm9vbCBzaG91bGRV
c2VDcmVkZW50aWFsU3RvcmFnZSwgYm9vbAogCiAgICAgUmV0YWluUHRyPENGVVJMUmVxdWVzdFJl
Zj4gcmVxdWVzdChBZG9wdENGLCBtYWtlRmluYWxSZXF1ZXN0KGZpcnN0UmVxdWVzdCgpLCBzaG91
bGRDb250ZW50U25pZmYpKTsKIAotI2lmIEhBVkUoQ0ZORVRXT1JLX0RBVEFfQVJSQVlfQ0FMTEJB
Q0spCi0gICAgQ0ZVUkxDb25uZWN0aW9uQ2xpZW50X1Y2IGNsaWVudCA9IHsgNiwgdGhpcywgMCwg
MCwgMCwgV2ViQ29yZTo6d2lsbFNlbmRSZXF1ZXN0LCBkaWRSZWNlaXZlUmVzcG9uc2UsIGRpZFJl
Y2VpdmVEYXRhLCAwLCBkaWRGaW5pc2hMb2FkaW5nLCBkaWRGYWlsLCB3aWxsQ2FjaGVSZXNwb25z
ZSwgZGlkUmVjZWl2ZUNoYWxsZW5nZSwgZGlkU2VuZEJvZHlEYXRhLCBzaG91bGRVc2VDcmVkZW50
aWFsU3RvcmFnZUNhbGxiYWNrLCAwLCAwLCAwLCBkaWRSZWNlaXZlRGF0YUFycmF5fTsKKyNpZiBI
QVZFKENGTkVUV09SS19EQVRBX0FSUkFZX0NBTExCQUNLKSAmJiBVU0UoUFJPVEVDVElPTl9TUEFD
RV9BVVRIX0NBTExCQUNLKQorICAgIENGVVJMQ29ubmVjdGlvbkNsaWVudF9WNiBjbGllbnQgPSB7
IDYsIHRoaXMsIDAsIDAsIDAsIFdlYkNvcmU6OndpbGxTZW5kUmVxdWVzdCwgZGlkUmVjZWl2ZVJl
c3BvbnNlLCBkaWRSZWNlaXZlRGF0YSwgMCwgZGlkRmluaXNoTG9hZGluZywgZGlkRmFpbCwgd2ls
bENhY2hlUmVzcG9uc2UsIGRpZFJlY2VpdmVDaGFsbGVuZ2UsIGRpZFNlbmRCb2R5RGF0YSwgc2hv
dWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2VDYWxsYmFjaywgMCwgY2FuUmVzcG9uZFRvUHJvdGVjdGlv
blNwYWNlLCAwLCBkaWRSZWNlaXZlRGF0YUFycmF5fTsKICNlbHNlCiAgICAgQ0ZVUkxDb25uZWN0
aW9uQ2xpZW50X1YzIGNsaWVudCA9IHsgMywgdGhpcywgMCwgMCwgMCwgV2ViQ29yZTo6d2lsbFNl
bmRSZXF1ZXN0LCBkaWRSZWNlaXZlUmVzcG9uc2UsIGRpZFJlY2VpdmVEYXRhLCAwLCBkaWRGaW5p
c2hMb2FkaW5nLCBkaWRGYWlsLCB3aWxsQ2FjaGVSZXNwb25zZSwgZGlkUmVjZWl2ZUNoYWxsZW5n
ZSwgZGlkU2VuZEJvZHlEYXRhLCBzaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZUNhbGxiYWNrLCAw
fTsKICNlbmRpZgpAQCAtNTk2LDYgKzYxNCwxNiBAQCB2b2lkIFJlc291cmNlSGFuZGxlOjpkaWRS
ZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoY29uc3QgQXV0aGVudGljYXRpb25DaGFsbAog
ICAgICAgICBjbGllbnQoKS0+ZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKHRoaXMs
IGQtPm1fY3VycmVudFdlYkNoYWxsZW5nZSk7CiB9CiAKKyNpZiBVU0UoUFJPVEVDVElPTl9TUEFD
RV9BVVRIX0NBTExCQUNLKQorYm9vbCBSZXNvdXJjZUhhbmRsZTo6Y2FuQXV0aGVudGljYXRlQWdh
aW5zdFByb3RlY3Rpb25TcGFjZShjb25zdCBQcm90ZWN0aW9uU3BhY2UmIHByb3RlY3Rpb25TcGFj
ZSkKK3sKKyAgICBpZiAoY2xpZW50KCkpCisgICAgICAgIHJldHVybiBjbGllbnQoKS0+Y2FuQXV0
aGVudGljYXRlQWdhaW5zdFByb3RlY3Rpb25TcGFjZSh0aGlzLCBwcm90ZWN0aW9uU3BhY2UpOwor
CisgICAgcmV0dXJuIGZhbHNlOworfQorI2VuZGlmCisKIHZvaWQgUmVzb3VyY2VIYW5kbGU6OnJl
Y2VpdmVkQ3JlZGVudGlhbChjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYgY2hhbGxlbmdl
LCBjb25zdCBDcmVkZW50aWFsJiBjcmVkZW50aWFsKQogewogICAgIExPRyhOZXR3b3JrLCAiQ0ZO
ZXQgLSByZWNlaXZlZENyZWRlbnRpYWwoKSIpOwpAQCAtODg3LDYgKzkxNSwxNCBAQCBib29sIFdl
YkNvcmVTeW5jaHJvbm91c0xvYWRlckNsaWVudDo6c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2Uo
UmVzb3VyY2VIYW5kbGUqKQogICAgIHJldHVybiBtX2FsbG93U3RvcmVkQ3JlZGVudGlhbHM7CiB9
CiAKKyNpZiBVU0UoUFJPVEVDVElPTl9TUEFDRV9BVVRIX0NBTExCQUNLKQorYm9vbCBXZWJDb3Jl
U3luY2hyb25vdXNMb2FkZXJDbGllbnQ6OmNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9u
U3BhY2UoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBQcm90ZWN0aW9uU3BhY2UmKQoreworICAgIC8v
IEZJWE1FOiBXZSBzaG91bGQgYXNrIEZyYW1lTG9hZGVyQ2xpZW50LgorICAgIHJldHVybiB0cnVl
OworfQorI2VuZGlmCisKICNlbmRpZiAvLyBVU0UoQ0ZORVRXT1JLKQogCiAjaWYgSEFWRShDRk5F
VFdPUktfREFUQV9BUlJBWV9DQUxMQkFDSykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0KaW5kZXggNmRjODg4MjAw
YzFlZTA3MzcwYWYyYWZkZGIxMTRkMWZlNDAyMmIzMS4uNGJiYWU0ZjAxYzllZDMxM2EyMjVjYWQz
YmYxOTA4ZjY4ZTMxNzVhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0
d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv
cm0vbmV0d29yay9tYWMvUmVzb3VyY2VIYW5kbGVNYWMubW0KQEAgLTc2NSwxMyArNzY1LDE3IEBA
IFN0cmluZyBSZXNvdXJjZUhhbmRsZTo6cHJpdmF0ZUJyb3dzaW5nU3RvcmFnZVNlc3Npb25JZGVu
dGlmaWVyRGVmYXVsdEJhc2UoKQogfQogCiAjaWYgVVNFKFBST1RFQ1RJT05fU1BBQ0VfQVVUSF9D
QUxMQkFDSykKLS0gKEJPT0wpY29ubmVjdGlvbjooTlNVUkxDb25uZWN0aW9uICopdW51c2VkQ29u
bmVjdGlvbiBjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlOihOU1VSTFByb3Rl
Y3Rpb25TcGFjZSAqKXByb3RlY3Rpb25TcGFjZQorLSAoQk9PTCljb25uZWN0aW9uOihOU1VSTENv
bm5lY3Rpb24gKiljb25uZWN0aW9uIGNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3Bh
Y2U6KE5TVVJMUHJvdGVjdGlvblNwYWNlICopcHJvdGVjdGlvblNwYWNlCiB7Ci0gICAgVU5VU0VE
X1BBUkFNKHVudXNlZENvbm5lY3Rpb24pOwotICAgIAorI2lmICFMT0dfRElTQUJMRUQKKyAgICBV
TlVTRURfUEFSQU0oY29ubmVjdGlvbik7CisjZW5kaWYKKworICAgIExPRyhOZXR3b3JrLCAiSGFu
ZGxlICVwIGRlbGVnYXRlIGNvbm5lY3Rpb246JXAgY2FuQXV0aGVudGljYXRlQWdhaW5zdFByb3Rl
Y3Rpb25TcGFjZTolcCIsIG1faGFuZGxlLCBjb25uZWN0aW9uKTsKKwogICAgIGlmICghbV9oYW5k
bGUpCiAgICAgICAgIHJldHVybiBOTzsKLSAgICAgICAgCisKICAgICByZXR1cm4gbV9oYW5kbGUt
PmNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90ZWN0aW9uU3BhY2UoY29yZShwcm90ZWN0aW9uU3Bh
Y2UpKTsKIH0KICNlbmRpZgo=
</data>
<flag name="review"
          id="97143"
          type_id="1"
          status="+"
          setter="oliver"
    />
    <flag name="commit-queue"
          id="97156"
          type_id="3"
          status="-"
          setter="webkit.review.bot"
    />
          </attachment>
      

    </bug>

</bugzilla>