65189 2011-07-26 10:10:17 -0700 [Qt] [WK2] Disable the build with Qt versions older than 5.0 2011-07-26 11:10:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P3 Normal --- 62969 1 abecsi abecsi benjamin hausmann kenneth kling laszlo.gombos loki ossy webkit.review.bot oldest_to_newest 442331 0 abecsi 2011-07-26 10:10:17 -0700 Because of the transition of QtWebKit2 to the new SceneGraph infrastructure of Qt5 we need to disable the build for Qt versions older than 5.0. More information on this can be found here http://www.mail-archive.com/webkit-qt@lists.webkit.org/msg01674.html. 442361 1 102023 abecsi 2011-07-26 10:57:50 -0700 Created attachment 102023 proposed patch 442371 2 102023 ossy 2011-07-26 11:03:49 -0700 Comment on attachment 102023 proposed patch LGTM, r=me. 442373 3 102023 webkit.review.bot 2011-07-26 11:06:36 -0700 Comment on attachment 102023 proposed patch Rejecting attachment 102023 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/9238009 442381 4 102023 abecsi 2011-07-26 11:10:05 -0700 Comment on attachment 102023 proposed patch Clearing flags on attachment: 102023 Committed r91766: <http://trac.webkit.org/changeset/91766> 442382 5 abecsi 2011-07-26 11:10:12 -0700 All reviewed patches have been landed. Closing bug. 102023 2011-07-26 10:57:50 -0700 2011-07-26 11:10:05 -0700 proposed patch 1107319.patch text/plain 2451 abecsi ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlZTY1ZmYzLi4yYjJkZDNj IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDctMjYgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgorCisgICAgICAg IFtRdF0gW1dLMl0gRGlzYWJsZSB0aGUgYnVpbGQgd2l0aCBRdCB2ZXJzaW9ucyBvbGRlciB0aGFu IDUuMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUx ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNv dXJjZS9XZWJLaXQucHJvOiBBYm9ydCBpZiBub3QgdXNpbmcgUXQ1LgorCiAyMDExLTA3LTIwICBQ aWVycmUgUm9zc2kgIDxwaWVycmUucm9zc2lAZ21haWwuY29tPgogCiAgICAgICAgIFtRdF0gUXQ1 IEJ1aWxkIEZpeDogRGlzYWJsZSB0aGUgbGVnYWN5IG1hYyBhc3NlcnQgbWFjcm9zLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC5wcm8gYi9Tb3VyY2UvV2ViS2l0LnBybwppbmRleCA5YmUwZjRh Li4wYzU0MWUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0LnBybworKysgYi9Tb3VyY2UvV2Vi S2l0LnBybwpAQCAtOCw3ICs4LDE0IEBAIGluY2x1ZGUoV2ViS2l0LnByaSkKICAgICBleGlzdHMo JCRQV0QvSmF2YVNjcmlwdENvcmUvanNjLnBybyk6IFNVQkRJUlMgKz0gSmF2YVNjcmlwdENvcmUv anNjLnBybwogfQogCi13ZWJraXQyOmV4aXN0cygkJFBXRC9XZWJLaXQyL1dlYktpdDIucHJvKTog U1VCRElSUyArPSBXZWJLaXQyL1dlYktpdDIucHJvCit3ZWJraXQyIHsKKyAgICBsZXNzVGhhbihR VF9NQUpPUl9WRVJTSU9OLCA1KSB7CisgICAgICAgIG1lc3NhZ2UoIkJ1aWxkaW5nIFdlYktpdDIg d2l0aCBRdCB2ZXJzaW9ucyBvbGRlciB0aGFuIDUuMCBpcyBubyBsb25nZXIgc3VwcG9ydGVkLiIp CisgICAgICAgIG1lc3NhZ2UoIlJlYWQgaHR0cDovL3d3dy5tYWlsLWFyY2hpdmUuY29tL3dlYmtp dC1xdEBsaXN0cy53ZWJraXQub3JnL21zZzAxNjc0Lmh0bWwgZm9yIG1vcmUgaW5mb3JtYXRpb24u IikKKyAgICAgICAgZXJyb3IoIkFib3J0aW5nIGJ1aWxkLiIpCisgICAgfQorICAgIGV4aXN0cygk JFBXRC9XZWJLaXQyL1dlYktpdDIucHJvKTogU1VCRElSUyArPSBXZWJLaXQyL1dlYktpdDIucHJv Cit9CiAKIFNVQkRJUlMgKz0gV2ViQ29yZQogU1VCRElSUyArPSBXZWJLaXQvcXQvUXRXZWJLaXQu cHJvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKaW5kZXggYTQ3YzNhYy4uNzEyNzAzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDExLTA3LTI2ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBbUXRdIFtXSzJdIERpc2FibGUgdGhlIGJ1aWxkIHdpdGggUXQgdmVyc2lvbnMgb2xk ZXIgdGhhbiA1LjAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NTE4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogUGxhdGZvcm0vcXQvTW9kdWxlUXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpNb2R1bGU6 OnBsYXRmb3JtRnVuY3Rpb25Qb2ludGVyKTogRml4IHRoZSBidWlsZCBmb3IgUXQ1LgorCiAyMDEx LTA3LTIyICBKZXNzaWUgQmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1dl YktpdDJdIENoYW5naW5nIHRoZSBjb29raWUgYWNjZXB0IHBvbGljeSBpbiBQcml2YXRlIEJyb3dz aW5nIGRvZXNu4oCZdCB3b3JrLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0v cXQvTW9kdWxlUXQuY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vcXQvTW9kdWxlUXQuY3Bw CmluZGV4IDk4ODE1YTIuLmZhNjc3NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL3F0L01vZHVsZVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9xdC9Nb2R1 bGVRdC5jcHAKQEAgLTQ0LDcgKzQ0LDcgQEAgdm9pZCBNb2R1bGU6OnVubG9hZCgpCiB2b2lkKiBN b2R1bGU6OnBsYXRmb3JtRnVuY3Rpb25Qb2ludGVyKGNvbnN0IGNoYXIqIGZ1bmN0aW9uTmFtZSkg Y29uc3QKIHsKICAgICAvLyBVbmZvcnR1bmF0ZWx5IFFMaWJyYXJ5OjpyZXNvbHZlIGlzIG5vdCBj b25zdC4KLSAgICByZXR1cm4gY29uc3RfY2FzdDxRTGlicmFyeSo+KCZtX2xpYiktPnJlc29sdmUo ZnVuY3Rpb25OYW1lKTsKKyAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oY29uc3Rf Y2FzdDxRTGlicmFyeSo+KCZtX2xpYiktPnJlc29sdmUoZnVuY3Rpb25OYW1lKSk7CiB9CiAKIH0K