65182 2011-07-26 07:37:07 -0700 [SKIA] Skia GL context is not current when drawing text in canvas 2011-07-26 11:54:12 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon senorblanco vangelis webkit.review.bot oldest_to_newest 442240 0 bsalomon 2011-07-26 07:37:07 -0700 [SKIA] Skia GL context is not current when drawing text in canvas 442242 1 102001 bsalomon 2011-07-26 07:39:35 -0700 Created attachment 102001 Patch 442244 2 bsalomon 2011-07-26 07:42:39 -0700 Being a html/js ignoramus I'm not sure how to test these multiple-context bugs in layout tests but it'd be nice to. We would need a test that does canvas, composite, canvas. 442388 3 102001 senorblanco 2011-07-26 11:18:17 -0700 Comment on attachment 102001 Patch Looks good. r=me Offhand, I can't think of an easy way to write a test either. Since this is a pretty ugly issue, we'll land the fix now and try to come up with a test later. 442416 4 102001 webkit.review.bot 2011-07-26 11:54:08 -0700 Comment on attachment 102001 Patch Clearing flags on attachment: 102001 Committed r91768: <http://trac.webkit.org/changeset/91768> 442417 5 webkit.review.bot 2011-07-26 11:54:12 -0700 All reviewed patches have been landed. Closing bug. 102001 2011-07-26 07:39:35 -0700 2011-07-26 11:54:08 -0700 Patch bug-65182-20110726103933.patch text/plain 1430 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNzUzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjYgIEJyaWFuIFNh bG9tb24gIDxic2Fsb21vbkBnb29nbGUuY29tPgorCisgICAgICAgIFtTS0lBXSBNYWtlIHRoZSBz a2lhIEdMIGNvbnRleHQgY3VycmVudCB3aGVuIGRyYXdpbmcgdGV4dCB0byBncHUgYmFja2VkIHBs YXRmb3JtIGNvbnRleHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NTE4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gTm90IHN1cmUgaG93IHRvIHRlc3Qgd3JvbmctY3R4IGJ1Z3Mg aW4gbGF5b3V0IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lh Rm9udFdpbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYWludFNraWFUZXh0KToKKwogMjAxMS0w Ny0yNiAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdpbi5jcHAJKHJldmlzaW9u IDkxNzUzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9u dFdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5MSw2ICsxOTEsOSBAQCB2b2lkIHBhaW50U2tp YVRleHQoR3JhcGhpY3NDb250ZXh0KiBjb250CiAgICAgU2tDYW52YXMqIGNhbnZhcyA9IHBsYXRm b3JtQ29udGV4dC0+Y2FudmFzKCk7CiAgICAgVGV4dERyYXdpbmdNb2RlRmxhZ3MgdGV4dE1vZGUg PSBwbGF0Zm9ybUNvbnRleHQtPmdldFRleHREcmF3aW5nTW9kZSgpOwogCisgICAgLy8gSWYgcGxh dGZvcm1Db250ZXh0IGlzIEdQVS1iYWNrZWQgbWFrZSBpdHMgR0wgY29udGV4dCBjdXJyZW50Lgor ICAgIHBsYXRmb3JtQ29udGV4dC0+bWFrZUdyQ29udGV4dEN1cnJlbnQoKTsKKwogICAgIC8vIEZp bGxpbmcgKGlmIG5lY2Vzc2FyeSkuIFRoaXMgaXMgdGhlIGNvbW1vbiBjYXNlLgogICAgIFNrUGFp bnQgcGFpbnQ7CiAgICAgcGxhdGZvcm1Db250ZXh0LT5zZXR1cFBhaW50Rm9yRmlsbGluZygmcGFp bnQpOwo=