65181 2011-07-26 07:28:20 -0700 Pass on the suggested filename to the chromium client 2011-07-27 08:36:49 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified All RESOLVED FIXED P2 Normal --- 0 sadrul webkit-unassigned abarth fishd webkit.review.bot oldest_to_newest 442233 0 sadrul 2011-07-26 07:28:20 -0700 The suggested filename in a@download (added in https://bugs.webkit.org/show_bug.cgi?id=64580) is not yet used in any platform. With this patch, the suggested filename is sent to the chromium client. 442236 1 102000 sadrul 2011-07-26 07:30:11 -0700 Created attachment 102000 patch Not ready for review yet; the parent CLs need to go in first: https://bugs.webkit.org/show_bug.cgi?id=64580 http://codereview.chromium.org/7484061/ 442437 2 ap 2011-07-26 12:17:03 -0700 One comment about naming. In WebKit, "suggested file name" is what comes from the network loader, which builds it from data in Content-Disposition and Content-Type headers. Perhaps a different name can be used here to reduce confusion. 442491 3 fishd 2011-07-26 13:35:47 -0700 I like the use of suggestedName here. It makes this variable nicely self-documenting. "Start a download of this URL with this suggested name." I think it is good that it correlate to the C-D header too. Alexey, I'm not sure why you find this confusing. 442654 4 102000 sadrul 2011-07-26 17:41:02 -0700 Comment on attachment 102000 patch Requesting cq? since the parent patch has landed. 442664 5 sadrul 2011-07-26 17:54:42 -0700 (In reply to comment #4) > (From update of attachment 102000 [details]) > Requesting cq? since the parent patch has landed. Actually, that revision (r91797) probably needs to get rolled into the chromium tree first. I will ping here when that happens. 442863 6 sadrul 2011-07-27 05:13:39 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 102000 [details] [details]) > > Requesting cq? since the parent patch has landed. > > Actually, that revision (r91797) probably needs to get rolled into the chromium tree first. I will ping here when that happens. r91797 has been rolled into chromium trunk. cq? 442944 7 102000 webkit.review.bot 2011-07-27 08:36:44 -0700 Comment on attachment 102000 patch Clearing flags on attachment: 102000 Committed r91847: <http://trac.webkit.org/changeset/91847> 442945 8 webkit.review.bot 2011-07-27 08:36:49 -0700 All reviewed patches have been landed. Closing bug. 102000 2011-07-26 07:30:11 -0700 2011-07-27 08:36:44 -0700 patch webkit-a-download-filename.patch text/plain 1603 sadrul ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggOWJhZThlMy4uMWZiZjRhYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wNy0yNiAgU2FkcnVsIEhh YmliIENob3dkaHVyeSAgPHNhZHJ1bEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUGFzcyBvbiB0 aGUgc3VnZ2VzdGVkIG5hbWUgZm9yIGRvd25sb2FkIGZpbGUgdG8gdGhlIGNsaWVudC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MTgxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvRnJhbWVMb2Fk ZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnRJbXBs OjpzdGFydERvd25sb2FkKToKKwogMjAxMS0wNy0yMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZlcnQgcjkxNTEwIGR1ZSB0byBDaHJvbWl1bSBkZWJ1ZyB0 ZXN0IGZhaWx1cmVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJh bWVMb2FkZXJDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1l TG9hZGVyQ2xpZW50SW1wbC5jcHAKaW5kZXggMTFiNzY1NC4uNzE5ZWMyNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCkBA IC0xMDczLDEyICsxMDczLDEyIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRJbXBsOjpzZXRNYWlu RnJhbWVEb2N1bWVudFJlYWR5KGJvb2wgcmVhZHkpCiAKIC8vIENyZWF0ZXMgYSBuZXcgY29ubmVj dGlvbiBhbmQgYmVnaW5zIGRvd25sb2FkaW5nIGZyb20gdGhhdCAoY29udHJhc3QgdGhpcwogLy8g d2l0aCB8ZG93bmxvYWR8KS4KLXZvaWQgRnJhbWVMb2FkZXJDbGllbnRJbXBsOjpzdGFydERvd25s b2FkKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgU3RyaW5nJiAvKiBzdWdn ZXN0ZWROYW1lICovKQordm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OnN0YXJ0RG93bmxvYWQo Y29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZE5h bWUpCiB7CiAgICAgaWYgKG1fd2ViRnJhbWUtPmNsaWVudCgpKSB7CiAgICAgICAgIFdyYXBwZWRS ZXNvdXJjZVJlcXVlc3Qgd2VicmVxKHJlcXVlc3QpOwogICAgICAgICBtX3dlYkZyYW1lLT5jbGll bnQoKS0+bG9hZFVSTEV4dGVybmFsbHkoCi0gICAgICAgICAgICBtX3dlYkZyYW1lLCB3ZWJyZXEs IFdlYk5hdmlnYXRpb25Qb2xpY3lEb3dubG9hZCk7CisgICAgICAgICAgICBtX3dlYkZyYW1lLCB3 ZWJyZXEsIFdlYk5hdmlnYXRpb25Qb2xpY3lEb3dubG9hZCwgc3VnZ2VzdGVkTmFtZSk7CiAgICAg fQogfQogCg==