65179 2011-07-26 06:30:36 -0700 WebKit2 GTK public headers should have the same style rules rules than WebKit1 2011-10-06 00:00:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 69481 Gtk P2 Normal --- 1 cgarcia webkit-unassigned mrobinson oldest_to_newest 442209 0 cgarcia 2011-07-26 06:30:36 -0700 Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:63: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:66: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:69: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:69: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:73: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:73: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:76: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:76: Extra space before ( in function call [whitespace/parens] [4] These are all false positives. 442210 1 101994 cgarcia 2011-07-26 06:32:34 -0700 Created attachment 101994 Patch 442222 2 101994 mrobinson 2011-07-26 07:02:06 -0700 Comment on attachment 101994 Patch If possible it would be better to ignore only the headers. This change ignores headers and source files. 442260 3 cgarcia 2011-07-26 08:03:31 -0700 (In reply to comment #2) > (From update of attachment 101994 [details]) > If possible it would be better to ignore only the headers. This change ignores headers and source files. There will be false positives in the files too, like code generated from macros like G_DEFINE_TYPE. 442264 4 mrobinson 2011-07-26 08:07:17 -0700 (In reply to comment #3) > There will be false positives in the files too, like code generated from macros like G_DEFINE_TYPE. It makes sense to fix those as wel find them as well. I can help out with that. 442272 5 cgarcia 2011-07-26 08:16:37 -0700 (In reply to comment #4) > (In reply to comment #3) > > > There will be false positives in the files too, like code generated from macros like G_DEFINE_TYPE. > > It makes sense to fix those as wel find them as well. I can help out with that. what do you mean by fix them? I think we should use gobject macros for maintainability reasons. 442284 6 mrobinson 2011-07-26 08:38:11 -0700 (In reply to comment #5) > what do you mean by fix them? I think we should use gobject macros for maintainability reasons. Oh, I mean we can fix the style checker to not complain about G_DEFINE_TYPE lines as well as GObject method names. 442288 7 cgarcia 2011-07-26 08:41:00 -0700 (In reply to comment #6) > (In reply to comment #5) > > > what do you mean by fix them? I think we should use gobject macros for maintainability reasons. > > Oh, I mean we can fix the style checker to not complain about G_DEFINE_TYPE lines as well as GObject method names. Ah! that would be awesome :-) 478998 8 cgarcia 2011-10-06 00:00:12 -0700 *** This bug has been marked as a duplicate of bug 69481 *** 101994 2011-07-26 06:32:34 -0700 2011-07-26 07:02:05 -0700 Patch wk2-api-style.diff text/plain 1166 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4Njk0 NjFiLi43MjFkYTRlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAKIDIwMTEtMDctMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFdlYktpdDIgR1RLIHB1YmxpYyBoZWFk ZXJzIHNob3VsZCBoYXZlIHRoZSBzYW1lIHN0eWxlIHJ1bGVzIHJ1bGVzIHRoYW4gV2ViS2l0MQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxNzkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlci5weToKKworMjAxMS0wNy0yNiAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IFdl YktpdEd0ayBidWlsZCB3aXRoIEdUSysgMy54IGFmdGVyIHI5MTcwNy4KIAogICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9TZWxmU2Nyb2xsaW5nV2ViS2l0V2ViVmlldy5jcHA6CmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggMGNkZWM1MS4uODA1NjJiOCAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTUwLDYgKzE1MCw3IEBA IF9QQVRIX1JVTEVTX1NQRUNJRklFUiA9IFsKICAgICAgICMgQWxzbywgR1RLKyBhbGxvd3MgdGhl IHVzZSBvZiBOVUxMLgogICAgICAgIlNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVz dC9HT2JqZWN0IiwKICAgICAgICJTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvIiwKKyAgICAgICJT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay8iLAogICAgICAgIlRvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay8iXSwKICAgICAgWyItcmVhZGFiaWxpdHkvbmFtaW5nIiwKICAgICAgICItcmVh ZGFiaWxpdHkvcGFyYW1ldGVyX25hbWUiLAo=