65168 2011-07-26 02:31:07 -0700 Use AtomicString in Document::documentNamedItems and Document::windowNamedItems 2012-03-01 13:56:55 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All NEW P2 Normal --- 65172 1 paroga paroga oldest_to_newest 442158 0 paroga 2011-07-26 02:31:07 -0700 Use AtomicString in Document::documentNamedItems and Document::windowNamedItems 442167 1 101983 paroga 2011-07-26 03:30:57 -0700 Created attachment 101983 Patch 467605 2 101983 rniwa 2011-09-14 21:33:54 -0700 Comment on attachment 101983 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101983&action=review looks sane to me. > Source/WebCore/dom/Document.cpp:4152 > return HTMLNameCollection::create(this, WindowNamedItems, name); But HTMLNameCollection::create takes const String! 500007 3 101983 bfulgham 2011-11-10 09:44:27 -0800 Comment on attachment 101983 Patch For this patch to be useful, doesn't HTMLNameCollection::m_name need to be an AtomicString as well? 568893 4 101983 eric 2012-03-01 13:56:55 -0800 Comment on attachment 101983 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101983&action=review >> Source/WebCore/dom/Document.cpp:4152 >> return HTMLNameCollection::create(this, WindowNamedItems, name); > > But HTMLNameCollection::create takes const String! That doesn't make the change completely invalid, but w/o some sort of microbenchmark to demonstrate that this is a win, this isn't worth doing w/o the AtomicStirng being kept around. 101983 2011-07-26 03:30:57 -0700 2012-03-01 13:56:55 -0800 Patch bug-65168.patch text/plain 3941 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZTJiZjAzLi5iNWI3ZDNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMDctMjYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgVXNlIEF0b21pY1N0cmluZyBpbiBEb2N1bWVudDo6ZG9jdW1lbnROYW1lZEl0ZW1z IGFuZCBEb2N1bWVudDo6d2luZG93TmFtZWRJdGVtcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGaXggQXRvbWljU3RyaW5nIHZzLiBTdHJpbmcgdXNhZ2Ug dG8gYXZvaWQgdW5uZWNlc3NhcnkgdHlwZSBjb252ZXJzYXRpb25zLgorCisgICAgICAgICogYmlu ZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6bmFtZWRJ dGVtR2V0dGVyKToKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0hUTUxEb2N1bWVudEN1c3RvbS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpKU0hUTUxEb2N1bWVudDo6bmFtZUdldHRlcik6CisgICAg ICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp3aW5k b3dOYW1lZEl0ZW1zKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpkb2N1bWVudE5hbWVk SXRlbXMpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorCiAyMDExLTA3LTIyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmVydCByOTE1OTUgZm9yIGl0 IGJyb2tlIENocm9taXVtIFdpbmRvd3MgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKaW5kZXggODY4YzZjYy4uZWQ2MTZmZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcApA QCAtMTEwLDcgKzExMCw3IEBAIHN0YXRpYyBKU1ZhbHVlIG5hbWVkSXRlbUdldHRlcihFeGVjU3Rh dGUqIGV4ZWMsIEpTVmFsdWUgc2xvdEJhc2UsIGNvbnN0IElkZW50aWZpCiAgICAgQVNTRVJUKGRv Y3VtZW50KTsKICAgICBBU1NFUlQoZG9jdW1lbnQtPmlzSFRNTERvY3VtZW50KCkpOwogCi0gICAg UmVmUHRyPEhUTUxDb2xsZWN0aW9uPiBjb2xsZWN0aW9uID0gZG9jdW1lbnQtPndpbmRvd05hbWVk SXRlbXMoaWRlbnRpZmllclRvU3RyaW5nKHByb3BlcnR5TmFtZSkpOworICAgIFJlZlB0cjxIVE1M Q29sbGVjdGlvbj4gY29sbGVjdGlvbiA9IGRvY3VtZW50LT53aW5kb3dOYW1lZEl0ZW1zKGlkZW50 aWZpZXJUb0F0b21pY1N0cmluZyhwcm9wZXJ0eU5hbWUpKTsKICAgICBpZiAoY29sbGVjdGlvbi0+ bGVuZ3RoKCkgPT0gMSkKICAgICAgICAgcmV0dXJuIHRvSlMoZXhlYywgdGhpc09iaiwgY29sbGVj dGlvbi0+Zmlyc3RJdGVtKCkpOwogICAgIHJldHVybiB0b0pTKGV4ZWMsIHRoaXNPYmosIGNvbGxl Y3Rpb24uZ2V0KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNI VE1MRG9jdW1lbnRDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1M RG9jdW1lbnRDdXN0b20uY3BwCmluZGV4IGZjODE1ZjIuLjU5MWQ1YWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTERvY3VtZW50Q3VzdG9tLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxEb2N1bWVudEN1c3RvbS5jcHAKQEAgLTYx LDcgKzYxLDcgQEAgSlNWYWx1ZSBKU0hUTUxEb2N1bWVudDo6bmFtZUdldHRlcihFeGVjU3RhdGUq IGV4ZWMsIEpTVmFsdWUgc2xvdEJhc2UsIGNvbnN0IElkZW4KICAgICBKU0hUTUxEb2N1bWVudCog dGhpc09iaiA9IHN0YXRpY19jYXN0PEpTSFRNTERvY3VtZW50Kj4oYXNPYmplY3Qoc2xvdEJhc2Up KTsKICAgICBIVE1MRG9jdW1lbnQqIGRvY3VtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTERvY3VtZW50 Kj4odGhpc09iai0+aW1wbCgpKTsKIAotICAgIFN0cmluZyBuYW1lID0gaWRlbnRpZmllclRvU3Ry aW5nKHByb3BlcnR5TmFtZSk7CisgICAgQXRvbWljU3RyaW5nIG5hbWUgPSBpZGVudGlmaWVyVG9B dG9taWNTdHJpbmcocHJvcGVydHlOYW1lKTsKICAgICBSZWZQdHI8SFRNTENvbGxlY3Rpb24+IGNv bGxlY3Rpb24gPSBkb2N1bWVudC0+ZG9jdW1lbnROYW1lZEl0ZW1zKG5hbWUpOwogCiAgICAgdW5z aWduZWQgbGVuZ3RoID0gY29sbGVjdGlvbi0+bGVuZ3RoKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cAppbmRleCBkMmUwOTQ0Li43YzlhNWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTQx NDcsMTIgKzQxNDcsMTIgQEAgUGFzc1JlZlB0cjxIVE1MQWxsQ29sbGVjdGlvbj4gRG9jdW1lbnQ6 OmFsbCgpCiAgICAgcmV0dXJuIEhUTUxBbGxDb2xsZWN0aW9uOjpjcmVhdGUodGhpcyk7CiB9CiAK LVBhc3NSZWZQdHI8SFRNTENvbGxlY3Rpb24+IERvY3VtZW50Ojp3aW5kb3dOYW1lZEl0ZW1zKGNv bnN0IFN0cmluZyAmbmFtZSkKK1Bhc3NSZWZQdHI8SFRNTENvbGxlY3Rpb24+IERvY3VtZW50Ojp3 aW5kb3dOYW1lZEl0ZW1zKGNvbnN0IEF0b21pY1N0cmluZyAmbmFtZSkKIHsKICAgICByZXR1cm4g SFRNTE5hbWVDb2xsZWN0aW9uOjpjcmVhdGUodGhpcywgV2luZG93TmFtZWRJdGVtcywgbmFtZSk7 CiB9CiAKLVBhc3NSZWZQdHI8SFRNTENvbGxlY3Rpb24+IERvY3VtZW50Ojpkb2N1bWVudE5hbWVk SXRlbXMoY29uc3QgU3RyaW5nICZuYW1lKQorUGFzc1JlZlB0cjxIVE1MQ29sbGVjdGlvbj4gRG9j dW1lbnQ6OmRvY3VtZW50TmFtZWRJdGVtcyhjb25zdCBBdG9taWNTdHJpbmcgJm5hbWUpCiB7CiAg ICAgcmV0dXJuIEhUTUxOYW1lQ29sbGVjdGlvbjo6Y3JlYXRlKHRoaXMsIERvY3VtZW50TmFtZWRJ dGVtcywgbmFtZSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQu aCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IDEwNzUxYjUuLjc0YTA4ZDUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC00MDgsOCArNDA4LDggQEAgcHVibGljOgogICAgIFBh c3NSZWZQdHI8SFRNTENvbGxlY3Rpb24+IGFuY2hvcnMoKTsKICAgICBQYXNzUmVmUHRyPEhUTUxD b2xsZWN0aW9uPiBvYmplY3RzKCk7CiAgICAgUGFzc1JlZlB0cjxIVE1MQ29sbGVjdGlvbj4gc2Ny aXB0cygpOwotICAgIFBhc3NSZWZQdHI8SFRNTENvbGxlY3Rpb24+IHdpbmRvd05hbWVkSXRlbXMo Y29uc3QgU3RyaW5nJiBuYW1lKTsKLSAgICBQYXNzUmVmUHRyPEhUTUxDb2xsZWN0aW9uPiBkb2N1 bWVudE5hbWVkSXRlbXMoY29uc3QgU3RyaW5nJiBuYW1lKTsKKyAgICBQYXNzUmVmUHRyPEhUTUxD b2xsZWN0aW9uPiB3aW5kb3dOYW1lZEl0ZW1zKGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSk7Cisg ICAgUGFzc1JlZlB0cjxIVE1MQ29sbGVjdGlvbj4gZG9jdW1lbnROYW1lZEl0ZW1zKGNvbnN0IEF0 b21pY1N0cmluZyYgbmFtZSk7CiAKICAgICBQYXNzUmVmUHRyPEhUTUxBbGxDb2xsZWN0aW9uPiBh bGwoKTsKIAo=