65166 2011-07-25 23:10:22 -0700 [Chromium][DRT] MockSpellCheck.cpp should be clang clean 2011-07-26 00:17:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita webkit.review.bot oldest_to_newest 442120 0 morrita 2011-07-25 23:10:22 -0700 Asan enabled build complains as following: third_party/WebKit/Tools/DumpRenderTree/chromium/MockSpellCheck.cpp:78:36: error: operands of ? are integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare] int wordLength = wordEnd == -1 ? stringText.length() - wordOffset : wordEnd - wordOffset; ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~ 442121 1 101973 morrita 2011-07-25 23:13:38 -0700 Created attachment 101973 Patch 442122 2 101973 morrita 2011-07-25 23:15:28 -0700 Comment on attachment 101973 Patch Kent-san, could you take a look at this one line change? 442123 3 101973 tkent 2011-07-25 23:16:46 -0700 Comment on attachment 101973 Patch ok 442138 4 101973 webkit.review.bot 2011-07-26 00:17:37 -0700 Comment on attachment 101973 Patch Clearing flags on attachment: 101973 Committed r91745: <http://trac.webkit.org/changeset/91745> 442139 5 webkit.review.bot 2011-07-26 00:17:41 -0700 All reviewed patches have been landed. Closing bug. 101973 2011-07-25 23:13:38 -0700 2011-07-26 00:17:37 -0700 Patch bug-65166-20110726151336.patch text/plain 1564 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3NDMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZTY1MWI0NmQzMGU5ZmMwZGQxYjhlMGI4YTlmMDgyMmY2 ZjZhMDM0Li5mMzMxNzg2OTU5Y2NmOTYyM2JmZDBhYjRmZmJlMTU1OTY2YjEyMWY1IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDctMjUgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CisKKyAg ICAgICAgW0Nocm9taXVtXVtEUlRdIE1vY2tTcGVsbENoZWNrLmNwcCBzaG91bGQgYmUgY2xhbmcg Y2xlYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1 MTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrU3BlbGxDaGVjay5jcHA6CisgICAgICAgIChNb2Nr U3BlbGxDaGVjazo6c3BlbGxDaGVja1dvcmQpOiAtV3NpZ24tY29tcGFyZSB3YXJuaW5nLgorCiAy MDExLTA3LTI1ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAg ICAgIElnbm9yZSBsaW5lIGVuZGluZ3MgaW4gQ2hhbmdlTG9nVGVzdHMKZGlmZiAtLWdpdCBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tTcGVsbENoZWNrLmNwcCBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tTcGVsbENoZWNrLmNwcAppbmRleCA4NjAxNzZiYWZl ODU0MWQ4YmYwNDI1MTcyYzFjNDkyNjM1MTZhMGJjLi4yYTNmYTUxYWEwZGRhMmJhYzdhNDIyMDk0 ZDVkMTU3MmJiNjVmMjgzIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9Nb2NrU3BlbGxDaGVjay5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v TW9ja1NwZWxsQ2hlY2suY3BwCkBAIC03NSw3ICs3NSw3IEBAIGJvb2wgTW9ja1NwZWxsQ2hlY2s6 OnNwZWxsQ2hlY2tXb3JkKGNvbnN0IFdlYlN0cmluZyYgdGV4dCwgaW50KiBtaXNzcGVsbGVkT2Zm c2V0CiAgICAgaWYgKHdvcmRPZmZzZXQgPT0gLTEpCiAgICAgICAgIHJldHVybiB0cnVlOwogICAg IGludCB3b3JkRW5kID0gc3RyaW5nVGV4dC5maW5kKGlzTm90QVNDSUlBbHBoYSwgd29yZE9mZnNl dCk7Ci0gICAgaW50IHdvcmRMZW5ndGggPSB3b3JkRW5kID09IC0xID8gc3RyaW5nVGV4dC5sZW5n dGgoKSAtIHdvcmRPZmZzZXQgOiB3b3JkRW5kIC0gd29yZE9mZnNldDsKKyAgICBpbnQgd29yZExl bmd0aCA9IHdvcmRFbmQgPT0gLTEgPyBzdGF0aWNfY2FzdDxpbnQ+KHN0cmluZ1RleHQubGVuZ3Ro KCkpIC0gd29yZE9mZnNldCA6IHdvcmRFbmQgLSB3b3JkT2Zmc2V0OwogCiAgICAgLy8gTG9vayB1 cCBvdXIgbWlzc3BlbGxlZC13b3JkIHRhYmxlIHRvIGNoZWNrIGlmIHRoZSBleHRyYWN0ZWQgd29y ZCBpcyBhCiAgICAgLy8ga25vd24gbWlzc3BlbGxlZCB3b3JkLCBhbmQgcmV0dXJuIHRoZSBvZmZz ZXQgYW5kIHRoZSBsZW5ndGggb2YgdGhlCg==