65162 2011-07-25 21:13:04 -0700 Add an exception to coding style check for EFL port 2011-07-26 19:02:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65163 1 gyuyoung.kim webkit-unassigned eric rakuco tkent webkit.review.bot oldest_to_newest 442093 0 gyuyoung.kim 2011-07-25 21:13:04 -0700 In EFL coding style, '*' operator is next to variable instead of data type. I think it is better to adhere the rule in efl port because port implementation tends to be in the style of the embedding system. 442094 1 101967 gyuyoung.kim 2011-07-25 21:14:07 -0700 Created attachment 101967 Proposed Patch 442182 2 rakuco 2011-07-26 05:13:47 -0700 LGTM 442673 3 gyuyoung.kim 2011-07-26 18:10:48 -0700 CC'ing Eric, tkent, Could you please review this patch ? Sorry for adding CC. But, it was difficult to find proper reviewers. 442688 4 101967 tkent 2011-07-26 18:46:32 -0700 Comment on attachment 101967 Proposed Patch ok 442696 5 101967 webkit.review.bot 2011-07-26 19:02:53 -0700 Comment on attachment 101967 Proposed Patch Clearing flags on attachment: 101967 Committed r91810: <http://trac.webkit.org/changeset/91810> 442697 6 webkit.review.bot 2011-07-26 19:02:58 -0700 All reviewed patches have been landed. Closing bug. 101967 2011-07-25 21:14:07 -0700 2011-07-26 19:02:53 -0700 Proposed Patch patch-add-exception.patch text/plain 1213 gyuyoung.kim ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MjE5 YWU3Li41N2UyMmI5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjQgIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBBZGQgYW4gZXhjZXB0aW9uIHRvIGNvZGlu ZyBzdHlsZSBjaGVjayBmb3IgRUZMIHBvcnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NTE2MgorCisgICAgICAgIEFkZCBhbiBleGNlcHRpb24gb2Yg d2hpdGVzcGFjZS9kZWNsYXJhdGlvbiBmb3IgRUZMIHBvcnQuIEJlY2F1c2UsCisgICAgICAgICcq JyBvcGVyYXRvciBpcyBuZXh0IHRvIHZhcmlhYmxlIGluIEVGTCBjb2Rpbmcgc3R5bGUuCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXIucHk6CisKIDIwMTEtMDctMjAgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGRib3QgbWFya3MgYSBucnd0IGJvdCByZWQg d2hlbiB0ZXN0cyBhcmUgbWlzc2luZyByZXN1bHRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXIucHkKaW5kZXggMGNkZWM1MS4uMWI0MjZiNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTc2LDcgKzE3Niw4IEBAIF9QQVRIX1JVTEVTX1NQRUNJ RklFUiA9IFsKICAgICAgICJUb29scy9FV2ViTGF1bmNoZXIvIiwKICAgICAgICJUb29scy9NaW5p QnJvd3Nlci9lZmwvIl0sCiAgICAgIFsiLXJlYWRhYmlsaXR5L25hbWluZyIsCi0gICAgICAiLXJl YWRhYmlsaXR5L3BhcmFtZXRlcl9uYW1lIl0pLAorICAgICAgIi1yZWFkYWJpbGl0eS9wYXJhbWV0 ZXJfbmFtZSIsCisgICAgICAiLXdoaXRlc3BhY2UvZGVjbGFyYXRpb24iXSksCiAKICAgICAjIFdl YktpdDIgcnVsZXM6CiAgICAgIyBXZWJLaXQyIGFuZCBjZXJ0YWluIGRpcmVjdG9yaWVzIGhhdmUg aWRpb3N5bmNyYWNpZXMuCg==