65148 2011-07-25 16:08:01 -0700 Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision 2011-07-25 17:53:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth ojan oldest_to_newest 441952 0 abarth 2011-07-25 16:08:01 -0700 Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision 441953 1 101936 abarth 2011-07-25 16:08:19 -0700 Created attachment 101936 Patch 441965 2 101936 abarth 2011-07-25 16:14:50 -0700 Comment on attachment 101936 Patch Clearing flags on attachment: 101936 Committed r91719: <http://trac.webkit.org/changeset/91719> 441966 3 abarth 2011-07-25 16:14:53 -0700 All reviewed patches have been landed. Closing bug. 441995 4 ojan 2011-07-25 17:03:45 -0700 We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code? 442008 5 abarth 2011-07-25 17:13:59 -0700 > We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code? Why does JSONResultsGenerator have it's own secret version of _get_svn_revision ? :( 442009 6 abarth 2011-07-25 17:19:04 -0700 Here's the log: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Vista/builds/5169/steps/webkit_tests/logs/stdio 2011-07-25 17:18:12,144 464 manager.py:221 DEBUG Failed to learn head_svn_revision: 2011-07-25 17:18:12,144 464 manager.py:222 DEBUG [Error 2] The system cannot find the file specified 442019 7 abarth 2011-07-25 17:30:36 -0700 Attempt to fix in https://bugs.webkit.org/show_bug.cgi?id=65156 442026 8 ojan 2011-07-25 17:36:26 -0700 (In reply to comment #5) > > We know that the --xml version of this code in JSONResultsGenerator works on the windows bots. Why not just change the code? > > Why does JSONResultsGenerator have it's own secret version of _get_svn_revision ? :( I've mentioned this code a billion times to Eric everytime he's tried fixing this bug. This code was written before scm.py existed. An attempt to use scm.py's was made, but didn't work on windows so it was rolled back. :) Noone had time to look into why. See the FIXME above the code explaining all this. 442033 9 abarth 2011-07-25 17:53:11 -0700 Well, hopefully the fix in Bug 65156 will fix windows and then we can delete this second implementation. 101936 2011-07-25 16:08:19 -0700 2011-07-25 16:14:50 -0700 Patch bug-65148-20110725160818.patch text/plain 1700 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3MTAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZjQ3YmQ0MTQ3Yzc2ZTU4Yzg1ZGEzZTMzMDBiY2QzMzMw MzI5YTEzLi5kMzhjYTRjM2VlNDlkNTU4ODI1NTRmYzlhMDBhYzE1NjZmNmJlZDVkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg QEAKIDIwMTEtMDctMjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAg ICBBZGQgc29tZSBkZWJ1ZyBsb2dnaW5nIHRvIE5SV1QgdG8gZGlhZ25vc2Ugd2h5IHRoZSB3aW5k b3dzIGJvdHMgY2FuJ3QgZGV0ZXJtaW5lIHRoZWlyIFNWTiByZXZpc2lvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxNDgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHk6CisKKzIwMTEtMDctMjUgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAgICBJbmNyZWFzZSB0aGUgaW5mb3JtYXRp b24gZGVuc2l0eSBpbiBnYXJkZW4tby1tYXRpYwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxNDEKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKaW5kZXggZjJm ZmZjM2ZiYjA4MjFlZGZjYzUxMzNmNGJiZDY1YWQwNjU0MTMxOC4uMGI1N2VmMGRhMWVmYTdhM2Ix ODc2ZDY0YWM2ZDg4YTU5MjdlOTk4ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CkBAIC0yMTgsNiAr MjE4LDggQEAgZGVmIHN1bW1hcml6ZV9yZXN1bHRzKHBvcnRfb2JqLCBleHBlY3RhdGlvbnMsIHJl c3VsdF9zdW1tYXJ5LCByZXRyeV9zdW1tYXJ5LCB0ZXMKICAgICAgICAgIyBPbmNlIHdlIGZpeCBk ZXRlY3Rfc2NtX3N5c3RlbSB0byB1c2UgdGhlIG1vY2sgZmlsZSBzeXN0ZW0gd2UgY2FuIGFkZCB0 aGlzIGxvZyBiYWNrLgogICAgICAgICAjX2xvZy53YXJuKCJGYWlsZWQgdG8gZGV0ZXJtaW5lIHN2 biByZXZpc2lvbiBmb3IgY2hlY2tvdXQgKGN3ZDogJXMsIHdlYmtpdF9iYXNlOiAlcyksIGxlYXZp bmcgJ3JldmlzaW9uJyBrZXkgYmxhbmsgaW4gZnVsbF9yZXN1bHRzLmpzb24uXG4lcyIgJSAocG9y dF9vYmouX2ZpbGVzeXN0ZW0uZ2V0Y3dkKCksIHBvcnRfb2JqLnBhdGhfZnJvbV93ZWJraXRfYmFz ZSgpLCBlKSkKICAgICAgICAgIyBIYW5kbGUgY2FzZXMgd2hlcmUgd2UncmUgcnVubmluZyBvdXRz aWRlIG9mIHZlcnNpb24gY29udHJvbC4KKyAgICAgICAgX2xvZy5kZWJ1ZygnRmFpbGVkIHRvIGxl YXJuIGhlYWRfc3ZuX3JldmlzaW9uOicpCisgICAgICAgIF9sb2cuZGVidWcoZSkKICAgICAgICAg cmVzdWx0c1sncmV2aXNpb24nXSA9ICIiCiAKICAgICByZXR1cm4gcmVzdWx0cwo=