65136 2011-07-25 15:05:56 -0700 simplify the UI of the header above the test list table 2011-07-25 15:32:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth aroben eric tony oldest_to_newest 441895 0 ojan 2011-07-25 15:05:56 -0700 simplify the UI of the header above the test list table 441896 1 101918 ojan 2011-07-25 15:07:00 -0700 Created attachment 101918 Patch 441907 2 101918 abarth 2011-07-25 15:23:02 -0700 Comment on attachment 101918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101918&action=review > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2346 > + var isTrue = g_currentState[key]; isTrue ? > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2347 > + return '<label><input type=checkbox ' + (isTrue ? 'checked ' : '') + 'onclick="setQueryParameter(\'' + key + '\', ' + !isTrue + ')">' + text + '</label>'; /me advertises jQuery. :) 441920 3 ojan 2011-07-25 15:32:52 -0700 Committed r91711: <http://trac.webkit.org/changeset/91711> 101918 2011-07-25 15:07:00 -0700 2011-07-25 15:23:02 -0700 Patch bug-65136-20110725150659.patch text/plain 4571 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3MDUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkODlmYzE2OTFlMGJlOGNiOWFjNmU0ZDJkYzZkMGUxMjAw NmMwNzRjLi40NzRiMzc4YzAyMzljMDJmMDU2NDVjZjVmMTkyOGE3YTU5ZTRkZjI0IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTEtMDctMjUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAg ICBzaW1wbGlmeSB0aGUgVUkgb2YgdGhlIGhlYWRlciBhYm92ZSB0aGUgdGVzdCBsaXN0IHRhYmxl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTEzNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBjaGVj a2JveGVzIGluc3RlYWQgb2YgbGlua3Mgc2luY2UgdGhpcyBpcyByZWFsbHkgYWJvdXQgd2hpY2gg dGVzdHMgdG8gaW5jbHVkZS4KKyAgICAgICAgRW5kcyB1cCB1c2luZyBsZXNzIHRleHQgYW5kIHB1 dCB0aGUgY2hlY2tib3hlcyB0byB0aGUgcmlnaHQgb2YgdGhlIGhlYWRlciBpbnN0ZWFkIG9mIGJl bG93IGl0LgorCisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9m bGFraW5lc3NfZGFzaGJvYXJkLmh0bWw6CisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0 aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3Rlc3RzLmpzOgorCisyMDExLTA3LTI1 ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgYnkgZGVmYXVsdCBo aWRlIHRlc3RzIHRoYXQgaGF2ZSBwYXNzZXMgZm9yIGFsbCByZWNvcmRlZCBydW5zCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTEyNwogCmRpZmYgLS1n aXQgYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19k YXNoYm9hcmQuaHRtbCBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMv Zmxha2luZXNzX2Rhc2hib2FyZC5odG1sCmluZGV4IDc2YTZhMmVjNjk1ZDhiYmViYTZiOGZkZjM0 ZTNiNjJjM2Q1MWExMDYuLjY3YjkzOWE4Yjc0N2NhMWRlYmUzNGE3MTMxYWEzZjZlOWI4NGQ4MWEg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxh a2luZXNzX2Rhc2hib2FyZC5odG1sCisrKyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGlj LWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5odG1sCkBAIC00Nyw2ICs0Nyw5IEBAIGgz IHsKIGlucHV0IHsKICAgICBtYXJnaW4tcmlnaHQ6IDE1cHg7CiB9CitsYWJlbCB7CisgICAgcGFk ZGluZy1sZWZ0OiAyZW07Cit9CiAuZm9ybXMgewogICAgIGRpc3BsYXk6IC13ZWJraXQtYm94Owog fQpAQCAtMjMzOCwxMSArMjM0MSwyNiBAQCBmdW5jdGlvbiBodG1sRm9yTmF2QmFyKCkKICAgICBy ZXR1cm4gaHRtbDsKIH0KIAorZnVuY3Rpb24gY2hlY2tCb3hUb1RvZ2dsZVN0YXRlKGtleSwgdGV4 dCkKK3sKKyAgICB2YXIgaXNUcnVlID0gZ19jdXJyZW50U3RhdGVba2V5XTsKKyAgICByZXR1cm4g JzxsYWJlbD48aW5wdXQgdHlwZT1jaGVja2JveCAnICsgKGlzVHJ1ZSA/ICdjaGVja2VkICcgOiAn JykgKyAnb25jbGljaz0ic2V0UXVlcnlQYXJhbWV0ZXIoXCcnICsga2V5ICsgJ1wnLCAnICsgIWlz VHJ1ZSArICcpIj4nICsgdGV4dCArICc8L2xhYmVsPic7Cit9CisKIGZ1bmN0aW9uIGxpbmtIVE1M VG9Ub2dnbGVTdGF0ZShrZXksIGxpbmtUZXh0KQogewogICAgIHZhciBpc1RydWUgPSBnX2N1cnJl bnRTdGF0ZVtrZXldOwotICAgIHJldHVybiAnPHNwYW4gY2xhc3M9bGluayBvbmNsaWNrPSJzZXRR dWVyeVBhcmFtZXRlcihcJycgKyBrZXkgKyAnXCcsICcgKwotICAgICAgICAhaXNUcnVlICsgJyki PicgKyAoaXNUcnVlID8gJ0hpZGUnIDogJ1Nob3cnKSArICcgJyArIGxpbmtUZXh0ICsgJzwvc3Bh bj4nOworICAgIHJldHVybiAnPHNwYW4gY2xhc3M9bGluayBvbmNsaWNrPSJzZXRRdWVyeVBhcmFt ZXRlcihcJycgKyBrZXkgKyAnXCcsICcgKyAhaXNUcnVlICsgJykiPicgKyAoaXNUcnVlID8gJ0hp ZGUnIDogJ1Nob3cnKSArICcgJyArIGxpbmtUZXh0ICsgJzwvc3Bhbj4nOworfQorCitmdW5jdGlv biBoZWFkZXJGb3JUZXN0VGFibGVIdG1sKCkKK3sKKyAgICByZXR1cm4gJzxoMiBzdHlsZT0iZGlz cGxheTppbmxpbmUtYmxvY2siPkZhaWxpbmcgdGVzdHM8L2gyPicgKworICAgICAgICBjaGVja0Jv eFRvVG9nZ2xlU3RhdGUoJ3Nob3dXb250Rml4U2tpcCcsICdXT05URklYL1NLSVAnKSArCisgICAg ICAgIGNoZWNrQm94VG9Ub2dnbGVTdGF0ZSgnc2hvd0NvcnJlY3RFeHBlY3RhdGlvbnMnLCAndGVz dHMgd2l0aCBjb3JyZWN0IGV4cGVjdGF0aW9ucycpICsKKyAgICAgICAgY2hlY2tCb3hUb1RvZ2ds ZVN0YXRlKCdzaG93V3JvbmdFeHBlY3RhdGlvbnMnLCAndGVzdHMgd2l0aCB3cm9uZyBleHBlY3Rh dGlvbnMnKSArCisgICAgICAgIGNoZWNrQm94VG9Ub2dnbGVTdGF0ZSgnc2hvd0ZsYWt5JywgJ2Zs YWt5JykgKworICAgICAgICBjaGVja0JveFRvVG9nZ2xlU3RhdGUoJ3Nob3dTbG93JywgJ3Nsb3cn KTsKIH0KIAogZnVuY3Rpb24gZ2VuZXJhdGVQYWdlRm9yQnVpbGRlcihidWlsZGVyTmFtZSkKQEAg LTIzNjgsMTcgKzIzODYsMTAgQEAgZnVuY3Rpb24gZ2VuZXJhdGVQYWdlRm9yQnVpbGRlcihidWls ZGVyTmFtZSkKIAogICAgIHZhciBodG1sID0gaHRtbEZvck5hdkJhcigpOwogCi0gICAgaWYgKGlz TGF5b3V0VGVzdFJlc3VsdHMoKSkgewotICAgICAgICBodG1sICs9IGh0bWxGb3JUZXN0c1dpdGhF eHBlY3RhdGlvbnNCdXROb0ZhaWx1cmVzKGJ1aWxkZXJOYW1lKSArCi0gICAgICAgICAgICAnPGgy PkZhaWxpbmcgdGVzdHM8L2gyPicgKwotICAgICAgICAgICAgbGlua0hUTUxUb1RvZ2dsZVN0YXRl KCdzaG93V29udEZpeFNraXAnLCAnV09OVEZJWC9TS0lQJykgKyAnIHwgJyArCi0gICAgICAgICAg ICBsaW5rSFRNTFRvVG9nZ2xlU3RhdGUoJ3Nob3dDb3JyZWN0RXhwZWN0YXRpb25zJywgJ3Rlc3Rz IHdpdGggY29ycmVjdCBleHBlY3RhdGlvbnMnKSArICcgfCAnICsKLSAgICAgICAgICAgIGxpbmtI VE1MVG9Ub2dnbGVTdGF0ZSgnc2hvd1dyb25nRXhwZWN0YXRpb25zJywgJ3Rlc3RzIHdpdGggd3Jv bmcgZXhwZWN0YXRpb25zJykgKyAnIHwgJyArCi0gICAgICAgICAgICBsaW5rSFRNTFRvVG9nZ2xl U3RhdGUoJ3Nob3dGbGFreScsICdmbGFreScpICsgJyB8ICcgKwotICAgICAgICAgICAgbGlua0hU TUxUb1RvZ2dsZVN0YXRlKCdzaG93U2xvdycsICdzbG93Jyk7Ci0gICAgfQorICAgIGlmIChpc0xh eW91dFRlc3RSZXN1bHRzKCkpCisgICAgICAgIGh0bWwgKz0gaHRtbEZvclRlc3RzV2l0aEV4cGVj dGF0aW9uc0J1dE5vRmFpbHVyZXMoYnVpbGRlck5hbWUpICsgaGVhZGVyRm9yVGVzdFRhYmxlSHRt bCgpOwogCi0gICAgaHRtbCArPSAnIHwgQWxsIGNvbHVtbnMgYXJlIHNvcnRhYmxlLiB8IEZsYWtp bmVzcyByZWFkZXIgb3JkZXIgaXMgbmV3ZXIgLS0+IG9sZGVyIHJ1bnMuPGJyPicgKyB0ZXN0c0hU TUw7CisgICAgaHRtbCArPSAnPGJyPicgKyB0ZXN0c0hUTUw7CiAgICAgYXBwZW5kSFRNTChodG1s KTsKIAogICAgIHZhciB0aHMgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgndGgnKTsK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxh a2luZXNzX2Rhc2hib2FyZF90ZXN0cy5qcyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGlj LWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF90ZXN0cy5qcwppbmRleCA5YTMyM2FjNDlk YmI5OTI0OGFiNmIxN2E2NWJkNWQyYmJkYzlmZjRlLi4wMjMyYzc4MWY1YTJhY2E3MDNiOTEwZDRh NTM1YzQ5NjBhNTMwNGRjIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRp Yy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdGVzdHMuanMKKysrIGIvVG9vbHMvVGVz dFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3Rlc3Rz LmpzCkBAIC0zNTUsNiArMzU1LDEyIEBAIGZ1bmN0aW9uIHRlc3RIdG1sRm9yVGVzdHNXaXRoRXhw ZWN0YXRpb25zQnV0Tm9GYWlsdXJlcygpCiAgICAgYXNzZXJ0RXF1YWxzKGNvbnRhaW5lci5xdWVy eVNlbGVjdG9yQWxsKCcjc2tpcHBlZC10ZXN0cyA+IGRpdicpLmxlbmd0aCwgMCk7CiB9CiAKK2Z1 bmN0aW9uIHRlc3RIZWFkZXJGb3JUZXN0VGFibGVIdG1sKCkKK3sKKyAgICB2YXIgY29udGFpbmVy ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CisgICAgY29udGFpbmVyLmlubmVySFRN TCA9IGhlYWRlckZvclRlc3RUYWJsZUh0bWwoKTsKKyAgICBhc3NlcnRFcXVhbHMoY29udGFpbmVy LnF1ZXJ5U2VsZWN0b3JBbGwoJ2lucHV0JykubGVuZ3RoLCA1KTsKK30KIAogZnVuY3Rpb24gcnVu VGVzdHMoKQogewo=