65133 2011-07-25 14:38:54 -0700 Deprecate AudioBufferSourceNode .looping attribute and implement .loop 2011-07-25 16:40:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers kbr oldest_to_newest 441871 0 crogers 2011-07-25 14:38:54 -0700 Deprecate AudioBufferSourceNode .looping attribute and implement .loop 441875 1 101914 crogers 2011-07-25 14:45:55 -0700 Created attachment 101914 Patch 441876 2 crogers 2011-07-25 14:46:45 -0700 This partially addresses: https://bugs.webkit.org/show_bug.cgi?id=61524 441973 3 101914 kbr 2011-07-25 16:28:53 -0700 Comment on attachment 101914 Patch Looks OK. 441983 4 crogers 2011-07-25 16:40:28 -0700 Committed r91723: <http://trac.webkit.org/changeset/91723> 101914 2011-07-25 14:45:55 -0700 2011-07-25 16:28:53 -0700 Patch bug-65133-20110725144554.patch text/plain 5254 crogers SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNzA2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDctMjUgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBEZXByZWNhdGUgQXVkaW9CdWZm ZXJTb3VyY2VOb2RlIC5sb29waW5nIGF0dHJpYnV0ZSBhbmQgaW1wbGVtZW50IC5sb29wCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTEzMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBz aW5jZSBhdWRpbyBBUEkgaXMgbm90IHlldCBpbXBsZW1lbnRlZC4KKworICAgICAgICAqIHdlYmF1 ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0J1 ZmZlclNvdXJjZU5vZGU6OnJlbmRlckZyb21CdWZmZXIpOgorICAgICAgICAoV2ViQ29yZTo6QXVk aW9CdWZmZXJTb3VyY2VOb2RlOjp0b3RhbFBpdGNoUmF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpB dWRpb0J1ZmZlclNvdXJjZU5vZGU6Omxvb3BpbmcpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9C dWZmZXJTb3VyY2VOb2RlOjpzZXRMb29waW5nKToKKyAgICAgICAgKiB3ZWJhdWRpby9BdWRpb0J1 ZmZlclNvdXJjZU5vZGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQnVmZmVyU291cmNlTm9k ZTo6bG9vcCk6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0J1ZmZlclNvdXJjZU5vZGU6OnNldExv b3ApOgorICAgICAgICAqIHdlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9kZS5pZGw6CisKIDIw MTEtMDctMjUgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTEyNQpJbmRleDogU291cmNlL1dl YkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0J1ZmZlclNvdXJjZU5vZGUuY3BwCShyZXZpc2lv biA5MTcwMykKKysrIFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9k ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDggQEAKIAogI2luY2x1ZGUgIkF1ZGlv Q29udGV4dC5oIgogI2luY2x1ZGUgIkF1ZGlvTm9kZU91dHB1dC5oIgorI2luY2x1ZGUgIkRvY3Vt ZW50LmgiCisjaW5jbHVkZSAiU2NyaXB0Q2FsbFN0YWNrLmgiCiAjaW5jbHVkZSA8YWxnb3JpdGht PgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CiAKQEAgLTI0Nyw3ICsyNDksNyBAQCB2b2lk IEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6cmVuZGVyRnJvbUJ1CiAgICAgICAgIC8vIEZvciBsaW5l YXIgaW50ZXJwb2xhdGlvbiB3ZSBuZWVkIHRoZSBuZXh0IHNhbXBsZS1mcmFtZSB0b28uCiAgICAg ICAgIHVuc2lnbmVkIHJlYWRJbmRleDIgPSByZWFkSW5kZXggKyAxOwogICAgICAgICBpZiAocmVh ZEluZGV4MiA+PSBlbmRGcmFtZSkgewotICAgICAgICAgICAgaWYgKGxvb3BpbmcoKSkgeworICAg ICAgICAgICAgaWYgKGxvb3AoKSkgewogICAgICAgICAgICAgICAgIC8vIE1ha2Ugc3VyZSB0byB3 cmFwIGFyb3VuZCBhdCB0aGUgZW5kIG9mIHRoZSBidWZmZXIuCiAgICAgICAgICAgICAgICAgcmVh ZEluZGV4MiAtPSBkZWx0YUZyYW1lczsKICAgICAgICAgICAgIH0gZWxzZQpAQCAtMjc4LDcgKzI4 MCw3IEBAIHZvaWQgQXVkaW9CdWZmZXJTb3VyY2VOb2RlOjpyZW5kZXJGcm9tQnUKICAgICAgICAg aWYgKHZpcnR1YWxSZWFkSW5kZXggPj0gZW5kRnJhbWUpIHsKICAgICAgICAgICAgIHZpcnR1YWxS ZWFkSW5kZXggLT0gZGVsdGFGcmFtZXM7CiAKLSAgICAgICAgICAgIGlmICghbG9vcGluZygpKSB7 CisgICAgICAgICAgICBpZiAoIWxvb3AoKSkgewogICAgICAgICAgICAgICAgIC8vIElmIHdlJ3Jl IG5vdCBsb29waW5nLCB0aGVuIHN0b3AgcGxheWluZyB3aGVuIHdlIGdldCB0byB0aGUgZW5kLgog ICAgICAgICAgICAgICAgIG1faXNQbGF5aW5nID0gZmFsc2U7CiAKQEAgLTQyNCwxMCArNDI2LDMy IEBAIGRvdWJsZSBBdWRpb0J1ZmZlclNvdXJjZU5vZGU6OnRvdGFsUGl0Y2gKICAgICBBU1NFUlQo aXNUb3RhbFJhdGVWYWxpZCk7CiAgICAgaWYgKCFpc1RvdGFsUmF0ZVZhbGlkKQogICAgICAgICB0 b3RhbFJhdGUgPSAxLjA7Ci0gICAgCisKICAgICByZXR1cm4gdG90YWxSYXRlOwogfQogCitib29s IEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6bG9vcGluZygpCit7CisgICAgc3RhdGljIGJvb2wgZmly c3RUaW1lID0gdHJ1ZTsKKyAgICBpZiAoZmlyc3RUaW1lICYmIGNvbnRleHQoKSAmJiBjb250ZXh0 KCktPmRvY3VtZW50KCkpIHsKKyAgICAgICAgY29udGV4dCgpLT5kb2N1bWVudCgpLT5hZGRNZXNz YWdlKEpTTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIFdhcm5pbmdNZXNzYWdlTGV2ZWws ICJBdWRpb0J1ZmZlclNvdXJjZU5vZGUgJ2xvb3BpbmcnIGF0dHJpYnV0ZSBpcyBkZXByZWNhdGVk LiAgVXNlICdsb29wJyBpbnN0ZWFkLiIsIDEsIFN0cmluZygpLCAwKTsKKyAgICAgICAgZmlyc3RU aW1lID0gZmFsc2U7CisgICAgfQorCisgICAgcmV0dXJuIG1faXNMb29waW5nOworfQorCit2b2lk IEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6c2V0TG9vcGluZyhib29sIGxvb3BpbmcpCit7CisgICAg c3RhdGljIGJvb2wgZmlyc3RUaW1lID0gdHJ1ZTsKKyAgICBpZiAoZmlyc3RUaW1lICYmIGNvbnRl eHQoKSAmJiBjb250ZXh0KCktPmRvY3VtZW50KCkpIHsKKyAgICAgICAgY29udGV4dCgpLT5kb2N1 bWVudCgpLT5hZGRNZXNzYWdlKEpTTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIFdhcm5p bmdNZXNzYWdlTGV2ZWwsICJBdWRpb0J1ZmZlclNvdXJjZU5vZGUgJ2xvb3BpbmcnIGF0dHJpYnV0 ZSBpcyBkZXByZWNhdGVkLiAgVXNlICdsb29wJyBpbnN0ZWFkLiIsIDEsIFN0cmluZygpLCAwKTsK KyAgICAgICAgZmlyc3RUaW1lID0gZmFsc2U7CisgICAgfQorCisgICAgbV9pc0xvb3BpbmcgPSBs b29waW5nOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUo V0VCX0FVRElPKQpJbmRleDogU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXJTb3Vy Y2VOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZm ZXJTb3VyY2VOb2RlLmgJKHJldmlzaW9uIDkxNzAzKQorKysgU291cmNlL1dlYkNvcmUvd2ViYXVk aW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTY1LDggKzY1LDE1 IEBAIHB1YmxpYzoKICAgICB2b2lkIG5vdGVHcmFpbk9uKGRvdWJsZSB3aGVuLCBkb3VibGUgZ3Jh aW5PZmZzZXQsIGRvdWJsZSBncmFpbkR1cmF0aW9uKTsKICAgICB2b2lkIG5vdGVPZmYoZG91Ymxl IHdoZW4pOwogCi0gICAgYm9vbCBsb29waW5nKCkgY29uc3QgeyByZXR1cm4gbV9pc0xvb3Bpbmc7 IH0KLSAgICB2b2lkIHNldExvb3BpbmcoYm9vbCBsb29waW5nKSB7IG1faXNMb29waW5nID0gbG9v cGluZzsgfQorICAgIC8vIE5vdGU6IHRoZSBhdHRyaWJ1dGUgd2FzIG9yaWdpbmFsbHkgZXhwb3Nl ZCBhcyAubG9vcGluZywgYnV0IHRvIGJlIG1vcmUgY29uc2lzdGVudCBpbiBuYW1pbmcgd2l0aCA8 YXVkaW8+CisgICAgLy8gYW5kIHdpdGggaG93IGl0J3MgZGVzY3JpYmVkIGluIHRoZSBzcGVjaWZp Y2F0aW9uLCB0aGUgcHJvcGVyIGF0dHJpYnV0ZSBuYW1lIGlzIC5sb29wCisgICAgLy8gVGhlIG9s ZCBhdHRyaWJ1dGUgaXMga2VwdCBmb3IgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkuCisgICAgYm9v bCBsb29wKCkgY29uc3QgeyByZXR1cm4gbV9pc0xvb3Bpbmc7IH0KKyAgICB2b2lkIHNldExvb3Ao Ym9vbCBsb29waW5nKSB7IG1faXNMb29waW5nID0gbG9vcGluZzsgfQorCisgICAgLy8gRGVwcmVj YXRlZC4KKyAgICBib29sIGxvb3BpbmcoKTsKKyAgICB2b2lkIHNldExvb3BpbmcoYm9vbCk7CiAg ICAgCiAgICAgQXVkaW9HYWluKiBnYWluKCkgeyByZXR1cm4gbV9nYWluLmdldCgpOyB9ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAogICAgIEF1ZGlvUGFyYW0qIHBsYXli YWNrUmF0ZSgpIHsgcmV0dXJuIG1fcGxheWJhY2tSYXRlLmdldCgpOyB9CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS93ZWJhdWRpby9BdWRpb0J1ZmZlclNvdXJjZU5vZGUuaWRsCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9kZS5pZGwJKHJldmlz aW9uIDkxNzAzKQorKysgU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VO b2RlLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsOSBAQCBtb2R1bGUgYXVkaW8gewog CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBBdWRpb0dhaW4gZ2FpbjsKICAgICAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIEF1ZGlvUGFyYW0gcGxheWJhY2tSYXRlOwotICAgICAgICBhdHRyaWJ1 dGUgYm9vbGVhbiBsb29waW5nOyAvLyBGSVhNRTogY2hhbmdlIG5hbWUgdG8gJ2xvb3AnIG9uY2Ug c2FtcGxlcyBhcmUgdXBkYXRlZAorCisgICAgICAgIGF0dHJpYnV0ZSBib29sZWFuIGxvb3A7IC8v IFRoaXMgaXMgdGhlIHByb3BlciBhdHRyaWJ1dGUgbmFtZSBmcm9tIHRoZSBzcGVjaWZpY2F0aW9u LgorICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiBsb29waW5nOyAvLyBUaGlzIGlzIGFuIGFsaWFz IGZvciB0aGUgLmxvb3AgYXR0cmlidXRlIGZvciBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eS4KIAog ICAgICAgICB2b2lkIG5vdGVPbihpbiBmbG9hdCB3aGVuKTsKICAgICAgICAgdm9pZCBub3RlR3Jh aW5PbihpbiBmbG9hdCB3aGVuLCBpbiBmbG9hdCBncmFpbk9mZnNldCwgaW4gZmxvYXQgZ3JhaW5E dXJhdGlvbik7Cg==