65131 2011-07-25 13:49:51 -0700 [chromium] incorrect vertex shader used when rendering video layer 2011-07-25 16:27:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 1 reveman reveman jamesr webkit.review.bot oldest_to_newest 441836 0 reveman 2011-07-25 13:49:51 -0700 CCVideoLayerImpl is currently using the same vertex program as the tiler. This program uses a 'point' uniform to generate vertex coordinates but CCVideoLayerImpl never sets this uniform. 441841 1 101904 reveman 2011-07-25 13:55:33 -0700 Created attachment 101904 Patch 441851 2 101904 jamesr 2011-07-25 14:07:45 -0700 Comment on attachment 101904 Patch OK. We really should have some sort of test coverage to test this. 441970 3 101904 webkit.review.bot 2011-07-25 16:27:41 -0700 Comment on attachment 101904 Patch Clearing flags on attachment: 101904 Committed r91720: <http://trac.webkit.org/changeset/91720> 441971 4 webkit.review.bot 2011-07-25 16:27:46 -0700 All reviewed patches have been landed. Closing bug. 101904 2011-07-25 13:55:33 -0700 2011-07-25 16:27:41 -0700 Patch bug-65131-20110725165532.patch text/plain 5572 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogOTE3MDQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0YzE2ODNjZjg4Zjk3MDcz NmFhM2FjMmJjZjc2ZGUxYTIzZTUwY2Y3Li5mNzNiZDRiMDA3MWRlZWU4ZDNiMjA2MTEyZTAzNjA1 NTQ0YjJmMzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDctMjUgIERhdmlk IFJldmVtYW4gIDxyZXZlbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFVz ZSBjb3JyZWN0IHZlcnRleCBzaGFkZXIgd2hlbiByZW5kZXJpbmcgdmlkZW8gbGF5ZXIuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTEzMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBuZXcgVmVydGV4 U2hhZGVyUXVhZCBwcm9ncmFtIHRoYXQgaXMgdXNlZCBieSBMYXllclRpbGVyQ2hyb21pdW0uCisg ICAgICAgIENoYW5nZSBWZXJ0ZXhTaGFkZXJQb3NUZXhUcmFuc2Zvcm0gc28gaXQgd29ya3Mgd2l0 aCBDQ1ZpZGVvTGF5ZXJJbXBsLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vTGF5ZXJUaWxlckNocm9taXVtLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vU2hhZGVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VmVydGV4U2hhZGVy UG9zVGV4VHJhbnNmb3JtOjpWZXJ0ZXhTaGFkZXJQb3NUZXhUcmFuc2Zvcm0pOgorICAgICAgICAo V2ViQ29yZTo6VmVydGV4U2hhZGVyUG9zVGV4VHJhbnNmb3JtOjppbml0KToKKyAgICAgICAgKFdl YkNvcmU6OlZlcnRleFNoYWRlclBvc1RleFRyYW5zZm9ybTo6Z2V0U2hhZGVyU3RyaW5nKToKKyAg ICAgICAgKFdlYkNvcmU6OlZlcnRleFNoYWRlclF1YWQ6OlZlcnRleFNoYWRlclF1YWQpOgorICAg ICAgICAoV2ViQ29yZTo6VmVydGV4U2hhZGVyUXVhZDo6aW5pdCk6CisgICAgICAgIChXZWJDb3Jl OjpWZXJ0ZXhTaGFkZXJRdWFkOjpnZXRTaGFkZXJTdHJpbmcpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL1NoYWRlckNocm9taXVtLmg6CisgICAgICAgIChXZWJDb3JlOjpW ZXJ0ZXhTaGFkZXJRdWFkOjptYXRyaXhMb2NhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpWZXJ0 ZXhTaGFkZXJRdWFkOjp0ZXhUcmFuc2Zvcm1Mb2NhdGlvbik6CisKIDIwMTEtMDctMjUgIERhdmlk IEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NTEyNQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uaAppbmRl eCAwZWYxMWEyNTVhZDFiNTE0MzM0ODUyOGQ5OTgzNGVlZTcyNDY3ZDI1Li40OGY0ZjlmMjA4ZDM3 ZmNkYjlhMmVjYmQ0ZWUzOTUzMDU3NTg4YjFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0u aApAQCAtNzUsMTAgKzc1LDEwIEBAIHB1YmxpYzoKICAgICAvLyByZWN5Y2xlZCBieSB0aGUgdGV4 dHVyZSBtYW5hZ2VyLgogICAgIHZvaWQgcHJvdGVjdFRpbGVUZXh0dXJlcyhjb25zdCBJbnRSZWN0 JiBjb250ZW50UmVjdCk7CiAKLSAgICB0eXBlZGVmIFByb2dyYW1CaW5kaW5nPFZlcnRleFNoYWRl clBvc1RleFRyYW5zZm9ybSwgRnJhZ21lbnRTaGFkZXJSR0JBVGV4QWxwaGE+IFByb2dyYW07Cisg ICAgdHlwZWRlZiBQcm9ncmFtQmluZGluZzxWZXJ0ZXhTaGFkZXJRdWFkLCBGcmFnbWVudFNoYWRl clJHQkFUZXhBbHBoYT4gUHJvZ3JhbTsKICAgICAvLyBTaGFkZXIgcHJvZ3JhbSB0aGF0IHN3YXBz IHJlZCBhbmQgYmx1ZSBjb21wb25lbnRzIG9mIHRleHR1cmUuCiAgICAgLy8gVXNlZCB3aGVuIHRl eHR1cmUgZm9ybWF0IGRvZXMgbm90IG1hdGNoIG5hdGl2ZSBjb2xvciBmb3JtYXQuCi0gICAgdHlw ZWRlZiBQcm9ncmFtQmluZGluZzxWZXJ0ZXhTaGFkZXJQb3NUZXhUcmFuc2Zvcm0sIEZyYWdtZW50 U2hhZGVyUkdCQVRleFN3aXp6bGVBbHBoYT4gUHJvZ3JhbVN3aXp6bGU7CisgICAgdHlwZWRlZiBQ cm9ncmFtQmluZGluZzxWZXJ0ZXhTaGFkZXJRdWFkLCBGcmFnbWVudFNoYWRlclJHQkFUZXhTd2l6 emxlQWxwaGE+IFByb2dyYW1Td2l6emxlOwogCiAgICAgLy8gSWYgdGhpcyB0aWxlciBoYXMgZXhh Y3RseSBvbmUgdGlsZSwgcmV0dXJuIGl0cyB0ZXh0dXJlLiBPdGhlcndpc2UsIG51bGwuCiAgICAg TGF5ZXJUZXh0dXJlKiBnZXRTaW5nbGVUZXh0dXJlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaGFkZXJDaHJvbWl1bS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaGFkZXJDaHJvbWl1bS5jcHAK aW5kZXggNjNiODY3MDNmY2IxZTA4MzQzYTdjOTBmNzI3ZDBjMDEzMWI0NjYwNS4uNTBkZTgwNDdk MWI3YjlkMTNmZjcxOTYzOGMzNjIwZWI1ZmE2OWRhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2hhZGVyQ2hyb21pdW0uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1NoYWRlckNocm9taXVtLmNw cApAQCAtMTI0LDcgKzEyNCw2IEBAIFN0cmluZyBWZXJ0ZXhTaGFkZXJQb3M6OmdldFNoYWRlclN0 cmluZygpIGNvbnN0CiBWZXJ0ZXhTaGFkZXJQb3NUZXhUcmFuc2Zvcm06OlZlcnRleFNoYWRlclBv c1RleFRyYW5zZm9ybSgpCiAgICAgOiBtX21hdHJpeExvY2F0aW9uKC0xKQogICAgICwgbV90ZXhU cmFuc2Zvcm1Mb2NhdGlvbigtMSkKLSAgICAsIG1fcG9pbnRMb2NhdGlvbigtMSkKIHsKIH0KIApA QCAtMTMyLDExICsxMzEsNDEgQEAgdm9pZCBWZXJ0ZXhTaGFkZXJQb3NUZXhUcmFuc2Zvcm06Omlu aXQoR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQsIHVuc2lnbmVkIHByb2cKIHsKICAgICBtX21h dHJpeExvY2F0aW9uID0gY29udGV4dC0+Z2V0VW5pZm9ybUxvY2F0aW9uKHByb2dyYW0sICJtYXRy aXgiKTsKICAgICBtX3RleFRyYW5zZm9ybUxvY2F0aW9uID0gY29udGV4dC0+Z2V0VW5pZm9ybUxv Y2F0aW9uKHByb2dyYW0sICJ0ZXhUcmFuc2Zvcm0iKTsKKyAgICBBU1NFUlQobV9tYXRyaXhMb2Nh dGlvbiAhPSAtMSAmJiBtX3RleFRyYW5zZm9ybUxvY2F0aW9uICE9IC0xKTsKK30KKworU3RyaW5n IFZlcnRleFNoYWRlclBvc1RleFRyYW5zZm9ybTo6Z2V0U2hhZGVyU3RyaW5nKCkgY29uc3QKK3sK KyAgICByZXR1cm4gU0hBREVSKAorICAgICAgICBhdHRyaWJ1dGUgdmVjNCBhX3Bvc2l0aW9uOwor ICAgICAgICBhdHRyaWJ1dGUgdmVjMiBhX3RleENvb3JkOworICAgICAgICB1bmlmb3JtIG1hdDQg bWF0cml4OworICAgICAgICB1bmlmb3JtIHZlYzQgdGV4VHJhbnNmb3JtOworICAgICAgICB2YXJ5 aW5nIHZlYzIgdl90ZXhDb29yZDsKKyAgICAgICAgdm9pZCBtYWluKCkKKyAgICAgICAgeworICAg ICAgICAgICAgZ2xfUG9zaXRpb24gPSBtYXRyaXggKiBhX3Bvc2l0aW9uOworICAgICAgICAgICAg dl90ZXhDb29yZCA9IGFfdGV4Q29vcmQgKiB0ZXhUcmFuc2Zvcm0uencgKyB0ZXhUcmFuc2Zvcm0u eHk7CisgICAgICAgIH0KKyAgICApOworfQorCitWZXJ0ZXhTaGFkZXJRdWFkOjpWZXJ0ZXhTaGFk ZXJRdWFkKCkKKyAgICA6IG1fbWF0cml4TG9jYXRpb24oLTEpCisgICAgLCBtX3RleFRyYW5zZm9y bUxvY2F0aW9uKC0xKQorICAgICwgbV9wb2ludExvY2F0aW9uKC0xKQoreworfQorCit2b2lkIFZl cnRleFNoYWRlclF1YWQ6OmluaXQoR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQsIHVuc2lnbmVk IHByb2dyYW0pCit7CisgICAgbV9tYXRyaXhMb2NhdGlvbiA9IGNvbnRleHQtPmdldFVuaWZvcm1M b2NhdGlvbihwcm9ncmFtLCAibWF0cml4Iik7CisgICAgbV90ZXhUcmFuc2Zvcm1Mb2NhdGlvbiA9 IGNvbnRleHQtPmdldFVuaWZvcm1Mb2NhdGlvbihwcm9ncmFtLCAidGV4VHJhbnNmb3JtIik7CiAg ICAgbV9wb2ludExvY2F0aW9uID0gY29udGV4dC0+Z2V0VW5pZm9ybUxvY2F0aW9uKHByb2dyYW0s ICJwb2ludCIpOwogICAgIEFTU0VSVChtX21hdHJpeExvY2F0aW9uICE9IC0xICYmIG1fdGV4VHJh bnNmb3JtTG9jYXRpb24gIT0gLTEgJiYgbV9wb2ludExvY2F0aW9uICE9IC0xKTsKIH0KIAotU3Ry aW5nIFZlcnRleFNoYWRlclBvc1RleFRyYW5zZm9ybTo6Z2V0U2hhZGVyU3RyaW5nKCkgY29uc3QK K1N0cmluZyBWZXJ0ZXhTaGFkZXJRdWFkOjpnZXRTaGFkZXJTdHJpbmcoKSBjb25zdAogewogICAg IHJldHVybiBTSEFERVIoCiAgICAgICAgIGF0dHJpYnV0ZSB2ZWM0IGFfcG9zaXRpb247CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaGFkZXJD aHJvbWl1bS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2hh ZGVyQ2hyb21pdW0uaAppbmRleCA0ZTgwYzgwN2UwOGM2NDBlMzA4MzVmMDViNjYyNjBlNjVkNmVj ODIzLi5jZmM2MTFhNjQ5NWIxMWUxYTlmNDU1ZWEzZjllMWJlZmFkZTg5NTE5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaGFkZXJDaHJvbWl1 bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1NoYWRl ckNocm9taXVtLmgKQEAgLTkwLDYgKzkwLDIxIEBAIHB1YmxpYzoKIAogICAgIGludCBtYXRyaXhM b2NhdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fbWF0cml4TG9jYXRpb247IH0KICAgICBpbnQgdGV4 VHJhbnNmb3JtTG9jYXRpb24oKSBjb25zdCB7IHJldHVybiBtX3RleFRyYW5zZm9ybUxvY2F0aW9u OyB9CisKK3ByaXZhdGU6CisgICAgaW50IG1fbWF0cml4TG9jYXRpb247CisgICAgaW50IG1fdGV4 VHJhbnNmb3JtTG9jYXRpb247Cit9OworCitjbGFzcyBWZXJ0ZXhTaGFkZXJRdWFkIHsKK3B1Ymxp YzoKKyAgICBWZXJ0ZXhTaGFkZXJRdWFkKCk7CisKKyAgICB2b2lkIGluaXQoR3JhcGhpY3NDb250 ZXh0M0QqLCB1bnNpZ25lZCBwcm9ncmFtKTsKKyAgICBTdHJpbmcgZ2V0U2hhZGVyU3RyaW5nKCkg Y29uc3Q7CisKKyAgICBpbnQgbWF0cml4TG9jYXRpb24oKSBjb25zdCB7IHJldHVybiBtX21hdHJp eExvY2F0aW9uOyB9CisgICAgaW50IHRleFRyYW5zZm9ybUxvY2F0aW9uKCkgY29uc3QgeyByZXR1 cm4gbV90ZXhUcmFuc2Zvcm1Mb2NhdGlvbjsgfQogICAgIGludCBwb2ludExvY2F0aW9uKCkgY29u c3QgeyByZXR1cm4gbV9wb2ludExvY2F0aW9uOyB9CiAKIHByaXZhdGU6Cg==