65127 2011-07-25 13:04:09 -0700 by default hide tests that have passes for all recorded runs 2011-07-25 14:01:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth eric mihaip tony oldest_to_newest 441808 0 ojan 2011-07-25 13:04:09 -0700 by default hide tests that have passes for all recorded runs 441810 1 101897 ojan 2011-07-25 13:04:58 -0700 Created attachment 101897 Patch 441830 2 101897 abarth 2011-07-25 13:38:11 -0700 Comment on attachment 101897 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101897&action=review > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1360 > + for (var i = 0; i < tests.length; i++) > + html += open + tests[i].test + '</div>'; This line probably has XSS 441844 3 ojan 2011-07-25 14:01:27 -0700 (In reply to comment #2) > (From update of attachment 101897 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101897&action=review > > > Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1360 > > + for (var i = 0; i < tests.length; i++) > > + html += open + tests[i].test + '</div>'; > > This line probably has XSS Yeah. There's a number of XSS holes in this code. There's not actually anything valuable at test-results.appspot.com though, so I'm loathe to spend the significant refactoring effort to fix these in cases where it's not trivial. 441845 4 ojan 2011-07-25 14:01:54 -0700 Committed r91705: <http://trac.webkit.org/changeset/91705> 101897 2011-07-25 13:04:58 -0700 2011-07-25 13:38:11 -0700 Patch bug-65127-20110725130457.patch text/plain 5387 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogOTE2OTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjZTAxZmQxZDkyZjRlOGQ4YzVhZDVjZTJjZDgxMzY3NDMz YzE4NmNhLi4zZWFmMDM5YmFkYTNiOTVkNWUzZDZkM2Y4Mzg4YTY1YTgzZDFjYjU4IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDctMjUgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAg ICBieSBkZWZhdWx0IGhpZGUgdGVzdHMgdGhhdCBoYXZlIHBhc3NlcyBmb3IgYWxsIHJlY29yZGVk IHJ1bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1 MTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyBpcyBwYXJ0IG9mIHNpbXBsaWZ5aW5nIHRoZSBkZWZhdWx0IHZpZXdzIG9mIHRoZSBkYXNoYm9h cmQgdG8KKyAgICAgICAgbWFrZSBpdCBzaG93IGxlc3MgaW5mb3JtYXRpb24gZm9yIHRoZSBjb21t b24gdXNlIGNhc2VzLgorCisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJv YXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmh0bWw6CisgICAgICAgICogVGVzdFJlc3VsdFNlcnZl ci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3Rlc3RzLmpzOgorCiAyMDEx LTA3LTI1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgT3Zlcmhh dWwgZ2FyZGVuLW8tbWF0aWMgZnJvbnRlbmQgdG8gaW50ZWdyYXRlIHJldmlzaW9uIGhpc3Rvcnkg YW5kIGZhaWx1cmVzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1k YXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmQuaHRtbCBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2 ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5odG1sCmluZGV4IDEwOTRj NWEzNjgzNjkxNWFjYzI4NTU1N2FkZjNhMTkyZDJlN2Q3ZWYuLmI5MzU4MWZkYWFkOGYwYmM5NTlh OTIxNTZjNTBlOTc0ZWYyM2RlYzYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIv c3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5odG1sCisrKyBiL1Rvb2xzL1Rl c3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5odG1s CkBAIC0xODAsNyArMTgwLDggQEAgaW5wdXQgewogICAgIGJvcmRlcjogMXB4IHNvbGlkIGxpZ2h0 Z3JheTsKICAgICBoZWlnaHQ6IDBweDsKIH0KLSNwYXNzaW5nLXRlc3RzIHsKKyNwYXNzaW5nLXRl c3RzLAorI3NraXBwZWQtdGVzdHMgewogICAgIC13ZWJraXQtY29sdW1uLWNvdW50OiAzOwogICAg IC13ZWJraXQtY29sdW1uLWdhcDogMjVweDsKICAgICAtd2Via2l0LWNvbHVtbi1ydWxlOiAxcHgg ZGFzaGVkIGJsYWNrOwpAQCAtNDM0LDYgKzQzNSw3IEBAIGZ1bmN0aW9uIGhhbmRsZVZhbGlkSGFz aFBhcmFtZXRlcihrZXksIHZhbHVlKQogICAgIGNhc2UgJ2xlZ2FjeUV4cGVjdGF0aW9uc1NlbWFu dGljcyc6CiAgICAgY2FzZSAnc2hvd1NraXBwZWQnOgogICAgIGNhc2UgJ3Nob3dTbG93JzoKKyAg ICBjYXNlICdzaG93VW5leHBlY3RlZFBhc3Nlcyc6CiAgICAgY2FzZSAnc2hvd1dvbnRGaXhTa2lw JzoKICAgICBjYXNlICdleHBlY3RhdGlvbnNVcGRhdGUnOgogICAgIGNhc2UgJ3Nob3dSdW5zT25C dWlsZGVyUGFnZSc6CkBAIC00NTcsNiArNDU5LDcgQEAgZ19kZWZhdWx0U3RhdGVWYWx1ZXMgPSB7 CiAgICAgc2hvd1dvbnRGaXhTa2lwOiAhaXNMYXlvdXRUZXN0UmVzdWx0cygpLAogICAgIHNob3dT bG93OiAhaXNMYXlvdXRUZXN0UmVzdWx0cygpLAogICAgIHNob3dTa2lwcGVkOiAhaXNMYXlvdXRU ZXN0UmVzdWx0cygpLAorICAgIHNob3dVbmV4cGVjdGVkUGFzc2VzOiAhaXNMYXlvdXRUZXN0UmVz dWx0cygpLAogICAgIGV4cGVjdGF0aW9uc1VwZGF0ZTogZmFsc2UsCiAgICAgc2hvd1J1bnNPbkJ1 aWxkZXJQYWdlOiBmYWxzZSwKICAgICB1cGRhdGVJbmRleDogMCwKQEAgLTEzNDksMTkgKzEzNTIs MjEgQEAgZnVuY3Rpb24gaHRtbEZvclRlc3RzV2l0aEV4cGVjdGF0aW9uc0J1dE5vRmFpbHVyZXMo YnVpbGRlcikKICAgICB2YXIgb3BlbiA9ICc8ZGl2IG9uY2xpY2s9InNlbGVjdENvbnRlbnRzKHRo aXMpIj4nOwogCiAgICAgaWYgKHRlc3RzLmxlbmd0aCkgewotICAgICAgICBodG1sICs9ICAnPGgz PkhhdmUgbm90IGZhaWxlZCBpbiBsYXN0ICcgKyBnX3Jlc3VsdHNCeUJ1aWxkZXJbYnVpbGRlcl0u YnVpbGROdW1iZXJzLmxlbmd0aCArICcgcnVucy48L2gzPjxkaXYgaWQ9InBhc3NpbmctdGVzdHMi Pic7Ci0KLSAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0ZXN0cy5sZW5ndGg7IGkrKykKLSAg ICAgICAgICAgIGh0bWwgKz0gb3BlbiArIHRlc3RzW2ldLnRlc3QgKyAnPC9kaXY+JzsKLQotICAg ICAgICBodG1sICs9ICc8L2Rpdj4nOworICAgICAgICBodG1sICs9ICAnPGgzPicgKyBsaW5rSFRN TFRvVG9nZ2xlU3RhdGUoJ3Nob3dVbmV4cGVjdGVkUGFzc2VzJywgJ3Rlc3RzIHRoYXQgaGF2ZSBu b3QgZmFpbGVkIGluIGxhc3QgJyArIGdfcmVzdWx0c0J5QnVpbGRlcltidWlsZGVyXS5idWlsZE51 bWJlcnMubGVuZ3RoICsgJyBydW5zLicpICsgJzwvaDM+JzsKKyAgICAgICAgCisgICAgICAgIGlm IChnX2N1cnJlbnRTdGF0ZS5zaG93VW5leHBlY3RlZFBhc3NlcykgeworICAgICAgICAgICAgaHRt bCArPSAnPGRpdiBpZD0icGFzc2luZy10ZXN0cyI+JzsKKyAgICAgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgdGVzdHMubGVuZ3RoOyBpKyspCisgICAgICAgICAgICAgICAgaHRtbCArPSBvcGVu ICsgdGVzdHNbaV0udGVzdCArICc8L2Rpdj4nOworICAgICAgICAgICAgaHRtbCArPSAnPC9kaXY+ JzsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGlmIChza2lwcGVkUGF0aHMubGVuZ3RoKSB7Ci0g ICAgICAgIGh0bWwgKz0gJzxoMz4nICsgbGlua0hUTUxUb1RvZ2dsZVN0YXRlKCdzaG93U2tpcHBl ZCcsICdTa2lwcGVkIHRlc3RzIGluIHRlc3RfZXhwZWN0YXRpb25zLnR4dCcpICsgJzwvaDM+JzsK KyAgICAgICAgaHRtbCArPSAnPGgzPicgKyBsaW5rSFRNTFRvVG9nZ2xlU3RhdGUoJ3Nob3dTa2lw cGVkJywgJ3NraXBwZWQgdGVzdHMgaW4gdGVzdF9leHBlY3RhdGlvbnMudHh0JykgKyAnPC9oMz4n OwogCiAgICAgICAgIGlmIChnX2N1cnJlbnRTdGF0ZS5zaG93U2tpcHBlZCkKLSAgICAgICAgICAg IGh0bWwgKz0gJzxkaXYgaWQ9InBhc3NpbmctdGVzdHMiPicgKyBvcGVuICsgc2tpcHBlZFBhdGhz LmpvaW4oJzwvZGl2PicgKyBvcGVuKSArICc8L2Rpdj48L2Rpdj4nOworICAgICAgICAgICAgaHRt bCArPSAnPGRpdiBpZD0ic2tpcHBlZC10ZXN0cyI+JyArIG9wZW4gKyBza2lwcGVkUGF0aHMuam9p bignPC9kaXY+JyArIG9wZW4pICsgJzwvZGl2PjwvZGl2Pic7CiAgICAgfQogICAgIHJldHVybiBo dG1sOwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJv YXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3Rlc3RzLmpzIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZl ci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkX3Rlc3RzLmpzCmluZGV4IDA5 ZDc5ZjZkNGNkYjg5YTFhYTc5ZDlmOWNmMDQwMGY5Y2UwZWQ2MDAuLjlhMzIzYWM0OWRiYjk5MjQ4 YWI2YjE3YTY1YmQ1ZDJiYmRjOWZmNGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2 ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF90ZXN0cy5qcworKysgYi9U b29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9h cmRfdGVzdHMuanMKQEAgLTMyOSw5ICszMjksMzMgQEAgZnVuY3Rpb24gdGVzdFN1YnN0cmluZ0xp c3QoKQogICAgIGdfY3VycmVudFN0YXRlLnRlc3RUeXBlID0gJ2xheW91dC10ZXN0cyc7CiAgICAg Z19jdXJyZW50U3RhdGUudGVzdHMgPSAnZm9vL2Jhci5GTEFLWV9mb28uaHRtbCc7CiAgICAgYXNz ZXJ0RXF1YWxzKHN1YnN0cmluZ0xpc3QoKS50b1N0cmluZygpLCAnZm9vL2Jhci5GTEFLWV9mb28u aHRtbCcpOworfQorCitmdW5jdGlvbiB0ZXN0SHRtbEZvclRlc3RzV2l0aEV4cGVjdGF0aW9uc0J1 dE5vRmFpbHVyZXMoKQoreworICAgIHZhciBidWlsZGVyID0gJ1dlYktpdCBXaW4nOworICAgIGdf cGVyQnVpbGRlcldpdGhFeHBlY3RhdGlvbnNCdXROb0ZhaWx1cmVzW2J1aWxkZXJdID0gWydwYXNz aW5nLXRlc3QxLmh0bWwnLCAncGFzc2luZy10ZXN0Mi5odG1sJ107CisgICAgZ19wZXJCdWlsZGVy U2tpcHBlZFBhdGhzW2J1aWxkZXJdID0gWydza2lwcGVkLXRlc3QxLmh0bWwnXTsKKyAgICBnX3Jl c3VsdHNCeUJ1aWxkZXJbYnVpbGRlcl0gPSB7IGJ1aWxkTnVtYmVyczogWzUsIDQsIDMsIDFdIH07 CiAKKyAgICBnX2N1cnJlbnRTdGF0ZS5zaG93VW5leHBlY3RlZFBhc3NlcyA9IHRydWU7CisgICAg Z19jdXJyZW50U3RhdGUuc2hvd1NraXBwZWQgPSB0cnVlOworICAgIAorICAgIHZhciBjb250YWlu ZXIgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKKyAgICBjb250YWluZXIuaW5uZXJI VE1MID0gaHRtbEZvclRlc3RzV2l0aEV4cGVjdGF0aW9uc0J1dE5vRmFpbHVyZXMoYnVpbGRlcik7 CisgICAgYXNzZXJ0RXF1YWxzKGNvbnRhaW5lci5xdWVyeVNlbGVjdG9yQWxsKCcjcGFzc2luZy10 ZXN0cyA+IGRpdicpLmxlbmd0aCwgMik7CisgICAgYXNzZXJ0RXF1YWxzKGNvbnRhaW5lci5xdWVy eVNlbGVjdG9yQWxsKCcjc2tpcHBlZC10ZXN0cyA+IGRpdicpLmxlbmd0aCwgMSk7CisgICAgCisg ICAgZ19jdXJyZW50U3RhdGUuc2hvd1VuZXhwZWN0ZWRQYXNzZXMgPSBmYWxzZTsKKyAgICBnX2N1 cnJlbnRTdGF0ZS5zaG93U2tpcHBlZCA9IGZhbHNlOworICAgIAorICAgIHZhciBjb250YWluZXIg PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKKyAgICBjb250YWluZXIuaW5uZXJIVE1M ID0gaHRtbEZvclRlc3RzV2l0aEV4cGVjdGF0aW9uc0J1dE5vRmFpbHVyZXMoYnVpbGRlcik7Cisg ICAgYXNzZXJ0RXF1YWxzKGNvbnRhaW5lci5xdWVyeVNlbGVjdG9yQWxsKCcjcGFzc2luZy10ZXN0 cyA+IGRpdicpLmxlbmd0aCwgMCk7CisgICAgYXNzZXJ0RXF1YWxzKGNvbnRhaW5lci5xdWVyeVNl bGVjdG9yQWxsKCcjc2tpcHBlZC10ZXN0cyA+IGRpdicpLmxlbmd0aCwgMCk7CiB9CiAKKwogZnVu Y3Rpb24gcnVuVGVzdHMoKQogewogICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gJzxwcmUg aWQ9dW5pdHRlc3QtcmVzdWx0cz48L3ByZT4nOwo=