65122 2011-07-25 10:59:14 -0700 [chromium] HUD texture must be unreserved after drawing 2011-07-25 16:35:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vangelis jamesr enne jamesr kbr oldest_to_newest 441741 0 vangelis 2011-07-25 10:59:14 -0700 The HUD texture is now allocated out of the RenderSurface manager whose textures don't get explicitly unreserved after drawing. As a result, we end up doing a double-reserve of the HUD texture which hits an ASSERT in debug builds. 441968 1 101941 jamesr 2011-07-25 16:20:19 -0700 Created attachment 101941 Patch 441976 2 101941 kbr 2011-07-25 16:29:50 -0700 Comment on attachment 101941 Patch Looks OK as long as it's been tested. 441977 3 jamesr 2011-07-25 16:31:21 -0700 I tested locally with and without this patch in debug. Thanks for the quick review. 441979 4 jamesr 2011-07-25 16:35:32 -0700 Committed r91722: <http://trac.webkit.org/changeset/91722> 101941 2011-07-25 16:20:19 -0700 2011-07-25 16:29:50 -0700 Patch bug-65122-20110725162018.patch text/plain 1649 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTE2OTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwOTFlMDg3ZjczMjY4ODNi NGEwYzEzNTdjZTU1MzM5NDVmYTMzNmFkLi41OTgxZjQ1ODZjZWEwMTg4ZWUyZTdiYjhkZmQ3ZTY4 MWU3ODI3MGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMjUgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEhV RCB0ZXh0dXJlIG11c3QgYmUgdW5yZXNlcnZlZCBhZnRlciBkcmF3aW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTEyMgorCisgICAgICAgIFVucmVz ZXJ2ZSB0aGUgSFVEIHRleHR1cmUgYWZ0ZXIgZHJhd2luZy4gIFRvIHRlc3QsIHN0YXJ0IGNocm9t ZSBpbiBkZWJ1ZyB3aXRoIC0tc2hvdy1mcHMtY291bnRlci4gIFNpbmNlIHRoaXMgaXMKKyAgICAg ICAgYSBkZWJ1Z2dpbmcgb3B0aW9uLCBubyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDSGVhZHNVcERpc3BsYXkuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q0NIZWFkc1VwRGlzcGxheTo6ZHJhdyk6CisKIDIwMTEtMDctMjUgIERhbmllbCBCYXRlcyAg PGRiYXRlc0ByaW0uY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHI4NTk2NCk6IEltcHJvcGVy IHJlbGF5b3V0IG9mIHNvbWUgbmVzdGVkIHBvc2l0aW9uZWQgZWxlbWVudHMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDSGVhZHNVcERp c3BsYXkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NIZWFkc1VwRGlzcGxheS5jcHAKaW5kZXggMGMwNzBjNWNlNTc3MDBiMTVlZDA5YjE3MGMxYTky NDdiNWVhMmY5Yy4uN2YyY2VjNzc4NWNmMGYwZTBmMWFkM2Q0MTMzNTRjODM5MzZhMTVmYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NI ZWFkc1VwRGlzcGxheS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NIZWFkc1VwRGlzcGxheS5jcHAKQEAgLTE0Miw2ICsxNDIsNyBAQCB2b2lk IENDSGVhZHNVcERpc3BsYXk6OmRyYXcoKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbWF0cml4LCBodWRTaXplLndpZHRoKCksIGh1ZFNpemUuaGVpZ2h0KCksCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAxLjBmLCBwcm9ncmFtLT52ZXJ0ZXhTaGFkZXIo KS5tYXRyaXhMb2NhdGlvbigpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cHJvZ3JhbS0+ZnJhZ21lbnRTaGFkZXIoKS5hbHBoYUxvY2F0aW9uKCkpOworICAgIG1faHVkVGV4 dHVyZS0+dW5yZXNlcnZlKCk7CiB9CiAKIHZvaWQgQ0NIZWFkc1VwRGlzcGxheTo6ZHJhd0h1ZENv bnRlbnRzKEdyYXBoaWNzQ29udGV4dCogY3R4LCBjb25zdCBJbnRTaXplJiBodWRTaXplKQo=