65115 2011-07-25 08:52:31 -0700 glActiveTexture(0) is invalid 2011-07-25 10:39:36 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rectalogic webkit-unassigned cmarrin kbr webkit.review.bot zmo oldest_to_newest 441678 0 rectalogic 2011-07-25 08:52:31 -0700 platform/graphics/opengl/GraphicsContext3DOpenGL.cpp prepareTexture() calls glActiveTexture(0) which is invalid and results in GL error GL_INVALID_ENUM. Originally fixed in bug 64878, but extracted to here because it's orthogonal to that bug. 441685 1 101877 rectalogic 2011-07-25 09:05:26 -0700 Created attachment 101877 fix call to glActiveTexture 441700 2 101877 kbr 2011-07-25 09:36:48 -0700 Comment on attachment 101877 fix call to glActiveTexture Good catch. r=me Did you want this submitted via the commit queue? Mark cq? if so. 441729 3 101877 webkit.review.bot 2011-07-25 10:39:32 -0700 Comment on attachment 101877 fix call to glActiveTexture Clearing flags on attachment: 101877 Committed r91674: <http://trac.webkit.org/changeset/91674> 441730 4 webkit.review.bot 2011-07-25 10:39:36 -0700 All reviewed patches have been landed. Closing bug. 101877 2011-07-25 09:05:26 -0700 2011-07-25 10:39:32 -0700 fix call to glActiveTexture glActiveTexture.diff text/plain 1582 rectalogic ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjYTMzNTE5Li5iYmEzZmJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDctMjUgIEFuZHJldyBXYXNvbiAgPHJlY3RhbG9naWNAcmVjdGFsb2dpYy5jb20+ CisKKyAgICAgICAgZ2xBY3RpdmVUZXh0dXJlKDApIGlzIGludmFsaWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MTE1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhpc3RpbmcgV2ViR0wgbGF5b3V0IHRl c3RzLgorCisgICAgICAgIEZpeCBpbnZhbGlkIGdsQWN0aXZlVGV4dHVyZSgwKSBjYWxsLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdM LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpwcmVwYXJlVGV4dHVy ZSk6CisKIDIwMTEtMDctMjQgIFJvYiBCdWlzICA8cmJ1aXNAcmltLmNvbT4KIAogICAgICAgICBT VkcgPHVzZT4gZWxlbWVudCBpcyBub3QgcmVwb3NpdGlvbmVkIHdoZW4gbW92ZWQgdG8geD0wIHk9 MCB0aHJvdWdoIHNjcmlwdCAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wuY3BwCmlu ZGV4IGZkNzIwNzMuLmY2YjIxMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdM LmNwcApAQCAtMzMzLDcgKzMzMyw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnByZXBhcmVU ZXh0dXJlKCkKICAgICAgICAgOjpnbEJsaXRGcmFtZWJ1ZmZlckVYVCgwLCAwLCBtX2N1cnJlbnRX aWR0aCwgbV9jdXJyZW50SGVpZ2h0LCAwLCAwLCBtX2N1cnJlbnRXaWR0aCwgbV9jdXJyZW50SGVp Z2h0LCBHTF9DT0xPUl9CVUZGRVJfQklULCBHTF9MSU5FQVIpOwogICAgIH0KICAgICA6OmdsQmlu ZEZyYW1lYnVmZmVyRVhUKEdMX0ZSQU1FQlVGRkVSX0VYVCwgbV9mYm8pOwotICAgIDo6Z2xBY3Rp dmVUZXh0dXJlKDApOworICAgIDo6Z2xBY3RpdmVUZXh0dXJlKEdMX1RFWFRVUkUwKTsKICAgICA6 OmdsQmluZFRleHR1cmUoR0xfVEVYVFVSRV8yRCwgbV9jb21wb3NpdG9yVGV4dHVyZSk7CiAgICAg OjpnbENvcHlUZXhJbWFnZTJEKEdMX1RFWFRVUkVfMkQsIDAsIG1faW50ZXJuYWxDb2xvckZvcm1h dCwgMCwgMCwgbV9jdXJyZW50V2lkdGgsIG1fY3VycmVudEhlaWdodCwgMCk7CiAgICAgOjpnbEJp bmRUZXh0dXJlKEdMX1RFWFRVUkVfMkQsIG1fYm91bmRUZXh0dXJlMCk7Cg==