65096 2011-07-24 23:50:06 -0700 [CSS Exclusions] Use HANDLE_INHERIT_AND_INITIAL when parsing -webkit-wrap-shape 2011-07-25 16:23:31 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 achicu webkit-unassigned macpherson webkit.review.bot oldest_to_newest 441564 0 achicu 2011-07-24 23:50:06 -0700 Fix for the feedback in comment #30 From Luke Macpherson on https://bugs.webkit.org/show_bug.cgi?id=61726 . (From update of attachment 99531 [details]) View in context: https://bugs.webkit.org/attachment.cgi?id=99531&action=review > Source/WebCore/css/CSSStyleSelector.cpp:5314 > + if (isInitial) { remove this whole if and use the HANDLE_INHERIT_AND_INITIAL(wrapShape, WrapShape) instead. > Source/WebCore/css/CSSStyleSelector.cpp:5318 > + if (!primitiveValue) return; here, and remove the later checks. 441578 1 101853 achicu 2011-07-25 00:49:25 -0700 Created attachment 101853 Patch 441746 2 101853 webkit.review.bot 2011-07-25 11:02:15 -0700 Comment on attachment 101853 Patch Clearing flags on attachment: 101853 Committed r91679: <http://trac.webkit.org/changeset/91679> 441747 3 webkit.review.bot 2011-07-25 11:02:19 -0700 All reviewed patches have been landed. Closing bug. 441969 4 macpherson 2011-07-25 16:23:31 -0700 Looks good, thanks! 101853 2011-07-25 00:49:25 -0700 2011-07-25 11:02:15 -0700 Patch bug65096.patch text/plain 5305 achicu ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0NTIyMjQxLi43ODYzYWZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDct MjUgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIFtD U1MgRXhjbHVzaW9uc10gVXNlIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMIHdoZW4gcGFyc2lu ZyAtd2Via2l0LXdyYXAtc2hhcGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTY1MDk2CisKKyAgICAgICAgRml4ZWQgJ2luaGVyaXQnIHRlc3QgdG8gY29w eSB0aGUgdmFsdWUgZnJvbSB0aGUgcGFyZW50LiBBbHNvLCBhZGRlZCBuZXcgdGVzdHMKKyAgICAg ICAgZm9yICdpbmVyaGl0JyB3aXRoIG5vIHZhbHVlIGluIHRoZSBwYXJlbnQuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lvbnMv cGFyc2luZy13cmFwLXNoYXBlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V4Y2x1c2lv bnMvc2NyaXB0LXRlc3RzL3BhcnNpbmctd3JhcC1zaGFwZS5qczoKKwogMjAxMS0wNy0yNCAgS2Vu dCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBMZWZ0 b3ZlciBvZiByOTE2MzMgKFNWRyB0ZXN0IG1vdmUpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2V4Y2x1c2lvbnMvcGFyc2luZy13cmFwLXNoYXBlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL2Zhc3QvZXhjbHVzaW9ucy9wYXJzaW5nLXdyYXAtc2hhcGUtZXhwZWN0ZWQudHh0CmluZGV4 IDQ2NjkzZTcuLjZiYzk3NGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9u cy9wYXJzaW5nLXdyYXAtc2hhcGUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv ZXhjbHVzaW9ucy9wYXJzaW5nLXdyYXAtc2hhcGUtZXhwZWN0ZWQudHh0CkBAIC0yMyw3ICsyMywx MCBAQCBQQVNTIHRlc3RDU1NUZXh0KCJwb2x5Z29uKG5vbnplcm8sIDEwcHgsIDIwcHggMzBweCwg NDBweCA0MHB4LCA1MHB4KSIpIGlzICJwb2x5ZwogUEFTUyB0ZXN0Q29tcHV0ZWRTdHlsZSgicG9s eWdvbihub256ZXJvLCAxMHB4LCAyMHB4IDMwcHgsIDQwcHggNDBweCwgNTBweCkiKSBpcyAicG9s eWdvbihub256ZXJvLCAxMHB4LCAyMHB4IDMwcHgsIDQwcHggNDBweCwgNTBweCkiCiBQQVNTIHRl c3ROb3RJbmhlcml0ZWQoImF1dG8iLCAicmVjdCgxMHB4LCAyMHB4LCAzMHB4LCA0MHB4KSIpIGlz ICJwYXJlbnQ6IGF1dG8sIGNoaWxkOiByZWN0KDEwcHgsIDIwcHgsIDMwcHgsIDQwcHgpIgogUEFT UyB0ZXN0Tm90SW5oZXJpdGVkKCJyZWN0KDEwcHgsIDIwcHgsIDMwcHgsIDQwcHgpIiwgImluaXRp YWwiKSBpcyAicGFyZW50OiByZWN0KDEwcHgsIDIwcHgsIDMwcHgsIDQwcHgpLCBjaGlsZDogYXV0 byIKLVBBU1MgdGVzdE5vdEluaGVyaXRlZCgicmVjdCgxMHB4LCAyMHB4LCAzMHB4LCA0MHB4KSIs ICJpbmhlcml0IikgaXMgInBhcmVudDogcmVjdCgxMHB4LCAyMHB4LCAzMHB4LCA0MHB4KSwgY2hp bGQ6IGF1dG8iCitQQVNTIHRlc3ROb3RJbmhlcml0ZWQoInJlY3QoMTBweCwgMjBweCwgMzBweCwg NDBweCkiLCAiIikgaXMgInBhcmVudDogcmVjdCgxMHB4LCAyMHB4LCAzMHB4LCA0MHB4KSwgY2hp bGQ6IGF1dG8iCitQQVNTIHRlc3ROb3RJbmhlcml0ZWQoInJlY3QoMTBweCwgMjBweCwgMzBweCwg NDBweCkiLCAiaW5oZXJpdCIpIGlzICJwYXJlbnQ6IHJlY3QoMTBweCwgMjBweCwgMzBweCwgNDBw eCksIGNoaWxkOiByZWN0KDEwcHgsIDIwcHgsIDMwcHgsIDQwcHgpIgorUEFTUyB0ZXN0Tm90SW5o ZXJpdGVkKCIiLCAiaW5oZXJpdCIpIGlzICJwYXJlbnQ6IGF1dG8sIGNoaWxkOiBhdXRvIgorUEFT UyB0ZXN0Tm90SW5oZXJpdGVkKCJhdXRvIiwgImluaGVyaXQiKSBpcyAicGFyZW50OiBhdXRvLCBj aGlsZDogYXV0byIKIFBBU1MgdGVzdENTU1RleHQoImNhbGMoKSIpIGlzICIiCiBQQVNTIHRlc3RD b21wdXRlZFN0eWxlKCJjYWxjKCkiKSBpcyAiYXV0byIKIFBBU1MgdGVzdENTU1RleHQoIm5vbmUi KSBpcyAiIgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NjcmlwdC10 ZXN0cy9wYXJzaW5nLXdyYXAtc2hhcGUuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMv c2NyaXB0LXRlc3RzL3BhcnNpbmctd3JhcC1zaGFwZS5qcwppbmRleCA3YjllMDhkLi41NGU3MTg4 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2NyaXB0LXRlc3RzL3Bh cnNpbmctd3JhcC1zaGFwZS5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvc2Ny aXB0LXRlc3RzL3BhcnNpbmctd3JhcC1zaGFwZS5qcwpAQCAtNjksNyArNjksMTAgQEAgdGVzdCgi cG9seWdvbihub256ZXJvLCAxMHB4LCAyMHB4IDMwcHgsIDQwcHggNDBweCwgNTBweCkiLCAicG9s eWdvbihub256ZXJvLCAxMHAKIAogc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCd0ZXN0Tm90SW5oZXJp dGVkKCJhdXRvIiwgInJlY3QoMTBweCwgMjBweCwgMzBweCwgNDBweCkiKScsICJwYXJlbnQ6IGF1 dG8sIGNoaWxkOiByZWN0KDEwcHgsIDIwcHgsIDMwcHgsIDQwcHgpIik7CiBzaG91bGRCZUVxdWFs VG9TdHJpbmcoJ3Rlc3ROb3RJbmhlcml0ZWQoInJlY3QoMTBweCwgMjBweCwgMzBweCwgNDBweCki LCAiaW5pdGlhbCIpJywgInBhcmVudDogcmVjdCgxMHB4LCAyMHB4LCAzMHB4LCA0MHB4KSwgY2hp bGQ6IGF1dG8iKTsKLXNob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdE5vdEluaGVyaXRlZCgicmVj dCgxMHB4LCAyMHB4LCAzMHB4LCA0MHB4KSIsICJpbmhlcml0IiknLCAicGFyZW50OiByZWN0KDEw cHgsIDIwcHgsIDMwcHgsIDQwcHgpLCBjaGlsZDogYXV0byIpOworc2hvdWxkQmVFcXVhbFRvU3Ry aW5nKCd0ZXN0Tm90SW5oZXJpdGVkKCJyZWN0KDEwcHgsIDIwcHgsIDMwcHgsIDQwcHgpIiwgIiIp JywgInBhcmVudDogcmVjdCgxMHB4LCAyMHB4LCAzMHB4LCA0MHB4KSwgY2hpbGQ6IGF1dG8iKTsK K3Nob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdE5vdEluaGVyaXRlZCgicmVjdCgxMHB4LCAyMHB4 LCAzMHB4LCA0MHB4KSIsICJpbmhlcml0IiknLCAicGFyZW50OiByZWN0KDEwcHgsIDIwcHgsIDMw cHgsIDQwcHgpLCBjaGlsZDogcmVjdCgxMHB4LCAyMHB4LCAzMHB4LCA0MHB4KSIpOworc2hvdWxk QmVFcXVhbFRvU3RyaW5nKCd0ZXN0Tm90SW5oZXJpdGVkKCIiLCAiaW5oZXJpdCIpJywgInBhcmVu dDogYXV0bywgY2hpbGQ6IGF1dG8iKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygndGVzdE5vdElu aGVyaXRlZCgiYXV0byIsICJpbmhlcml0IiknLCAicGFyZW50OiBhdXRvLCBjaGlsZDogYXV0byIp OwogCiAvLyBuZWdhdGl2ZSB0ZXN0cwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjI5ODVkMy4uYjQ3NWJlYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTA3LTI1ICBBbGV4YW5kcnUgQ2hpY3Vs aXRhICA8YWNoaWN1QGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIEV4Y2x1c2lvbnNdIFVzZSBI QU5ETEVfSU5IRVJJVF9BTkRfSU5JVElBTCB3aGVuIHBhcnNpbmcgLXdlYmtpdC13cmFwLXNoYXBl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTA5Ngor CisgICAgICAgIEFsc28gdGhlICdpbmhlcml0JyBrZXl3b3JkIGlzIG5vdyB0cmVhdGVkIGNvcnJl Y3RseS4gSXQgd2lsbAorICAgICAgICBjb3B5IHRoZSB2YWx1ZSBmcm9tIHRoZSBwYXJlbnQgc3R5 bGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBj c3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTdHlsZVNlbGVj dG9yOjphcHBseVByb3BlcnR5KToKKwogMjAxMS0wNy0yNCAgTHVrZSBNYWNwaGVyc29uICAgPG1h Y3BoZXJzb25AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNtYWxsIGNsZWFudXAgb2YgbV9mb250 RGlydHkgdHJhY2tpbmcgaW4gQ1NTU3R5bGVTZWxlY3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0 eWxlU2VsZWN0b3IuY3BwCmluZGV4IGNkZTA5NzEuLjFhYTU3ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKQEAgLTUxODksMTUgKzUxODksMTMgQEAgdm9pZCBDU1NT dHlsZVNlbGVjdG9yOjphcHBseVByb3BlcnR5KGludCBpZCwgQ1NTVmFsdWUgKnZhbHVlKQogICAg IAogI2lmIEVOQUJMRShDU1NfRVhDTFVTSU9OUykKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0 V3JhcFNoYXBlOgotICAgICAgICBpZiAoaXNJbml0aWFsKSB7Ci0gICAgICAgICAgICBIQU5ETEVf SU5JVElBTF9DT05EKENTU1Byb3BlcnR5V2Via2l0V3JhcFNoYXBlLCBXcmFwU2hhcGUpCisgICAg ICAgIEhBTkRMRV9JTkhFUklUX0FORF9JTklUSUFMKHdyYXBTaGFwZSwgV3JhcFNoYXBlKTsKKyAg ICAgICAgaWYgKCFwcmltaXRpdmVWYWx1ZSkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAg fQogICAgICAgICAKLSAgICAgICAgaWYgKHByaW1pdGl2ZVZhbHVlICYmIHByaW1pdGl2ZVZhbHVl LT5nZXRJZGVudCgpID09IENTU1ZhbHVlQXV0bykKKyAgICAgICAgaWYgKHByaW1pdGl2ZVZhbHVl LT5nZXRJZGVudCgpID09IENTU1ZhbHVlQXV0bykKICAgICAgICAgICAgIG1fc3R5bGUtPnNldFdy YXBTaGFwZSgwKTsKLSAgICAgICAgCi0gICAgICAgIGlmIChwcmltaXRpdmVWYWx1ZSAmJiBwcmlt aXRpdmVWYWx1ZS0+cHJpbWl0aXZlVHlwZSgpID09IENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfU0hB UEUpCisgICAgICAgIGVsc2UgaWYgKHByaW1pdGl2ZVZhbHVlLT5wcmltaXRpdmVUeXBlKCkgPT0g Q1NTUHJpbWl0aXZlVmFsdWU6OkNTU19TSEFQRSkKICAgICAgICAgICAgIG1fc3R5bGUtPnNldFdy YXBTaGFwZShwcmltaXRpdmVWYWx1ZS0+Z2V0U2hhcGVWYWx1ZSgpKTsKIAogICAgICAgICByZXR1 cm47Cg==