65087 2011-07-24 15:22:40 -0700 Fix CSSFontSelector::addFontFaceRule() 2013-01-04 12:20:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 79103 P2 Normal --- 1 paroga paroga eric hyatt mitz oliver oldest_to_newest 441496 0 paroga 2011-07-24 15:22:40 -0700 Fix CSSFontSelector::addFontFaceRule() 441498 1 101837 paroga 2011-07-24 15:29:03 -0700 Created attachment 101837 Patch 441499 2 paroga 2011-07-24 15:37:54 -0700 Can you have a look at the patch attached at this bug please. I found a weird line of code added in http://trac.webkit.org/changeset/26484 while working on an other issue. I don't know what this code (not) does exactly, but it doesn't look sane to me. 441505 3 mitz 2011-07-24 16:54:06 -0700 Good catch! I know what the code is supposed to do: it’s supposed to make this work: <style> @font-face { font-family: sans-serif; src: local(ahem); } </style> <div style="font-family: sans-serif;">This should be in Ahem</div> However, looking at the working draft at <http://www.w3.org/TR/2011/WD-css3-fonts-20110324/#descdef-font-family> it seems as if generic family names are not valid values for the font-family font descriptor (it also doesn’t accept lists anymore…), so I’m not sure we should make the above snippet work. If we don’t, then of course we should just remove the whole thing. 441506 4 mitz 2011-07-24 16:55:41 -0700 The current code attempts (but as you’ve noticed, fails) to implement this earlier working draft: <http://www.w3.org/TR/2002/WD-css3-webfonts-20020802/#font-family>. 441518 5 101837 darin 2011-07-24 17:40:58 -0700 Comment on attachment 101837 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101837&action=review r=me on the idea of making the code work, but clearly we need regression tests before we actually make a change. And we need to consider what behavior you want as you and Mitz discussed above. > Source/WebCore/ChangeLog:10 > + The varibable "familyName" is declared twice in this function. > + The second decleration hides the first one and makes the whole > + code in the the second useless. You mean "defined", not "declared". varibable -> variable decleration -> declaration 800498 6 paroga 2013-01-04 12:20:22 -0800 Fix landed in http://trac.webkit.org/changeset/108366 *** This bug has been marked as a duplicate of bug 79103 *** 101837 2011-07-24 15:29:03 -0700 2011-07-24 17:40:58 -0700 Patch bug-65087-20110725002901.patch text/plain 1733 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogOTE2NTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjYTMzNTE5NzIxMjI2YmVj NDA3ZGY3MjA1NmRlNmRiNGExZDA5NjQ1Li5lZTNiNGQ3OWFjYjNmM2FlNjk1OTVkMjE2M2JhNWM2 ZTQ3Mzc2MDU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDctMjQgIFBhdHJp Y2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IENTU0ZvbnRT ZWxlY3Rvcjo6YWRkRm9udEZhY2VSdWxlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY1MDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIHZhcmliYWJsZSAiZmFtaWx5TmFtZSIgaXMgZGVjbGFyZWQg dHdpY2UgaW4gdGhpcyBmdW5jdGlvbi4KKyAgICAgICAgVGhlIHNlY29uZCBkZWNsZXJhdGlvbiBo aWRlcyB0aGUgZmlyc3Qgb25lIGFuZCBtYWtlcyB0aGUgd2hvbGUKKyAgICAgICAgY29kZSBpbiB0 aGUgdGhlIHNlY29uZCB1c2VsZXNzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQor CisgICAgICAgIFRoaXMgcGF0Y2ggaXMgTk9UIGZvciBsYW5kaW5nISEhIQorCisgICAgICAgICog Y3NzL0NTU0ZvbnRTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NGb250U2VsZWN0 b3I6OmFkZEZvbnRGYWNlUnVsZSk6CisKIDIwMTEtMDctMjQgIFJvYiBCdWlzICA8cmJ1aXNAcmlt LmNvbT4KIAogICAgICAgICBTVkcgPHVzZT4gZWxlbWVudCBpcyBub3QgcmVwb3NpdGlvbmVkIHdo ZW4gbW92ZWQgdG8geD0wIHk9MCB0aHJvdWdoIHNjcmlwdCAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NGb250U2VsZWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Zv bnRTZWxlY3Rvci5jcHAKaW5kZXggMWJmNGZjYTM1MzYzNjZmNjQ2Njk2YjBmYjI1ZTJmNTg2ZDgx N2IyMS4uYzQzMWE0OTllMTY0MTUyOGZhMWE4OWY1Zjg4NjkyNWQxMDk1ZjkxNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ZvbnRTZWxlY3Rvci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU0ZvbnRTZWxlY3Rvci5jcHAKQEAgLTI5Myw3ICsyOTMsNiBAQCB2b2lkIENT U0ZvbnRTZWxlY3Rvcjo6YWRkRm9udEZhY2VSdWxlKGNvbnN0IENTU0ZvbnRGYWNlUnVsZSogZm9u dEZhY2VSdWxlKQogICAgICAgICBlbHNlIGlmIChpdGVtLT5wcmltaXRpdmVUeXBlKCkgPT0gQ1NT UHJpbWl0aXZlVmFsdWU6OkNTU19JREVOVCkgewogICAgICAgICAgICAgLy8gV2UgbmVlZCB0byB1 c2UgdGhlIHJhdyB0ZXh0IGZvciBhbGwgdGhlIGdlbmVyaWMgZmFtaWx5IHR5cGVzLCBzaW5jZSBA Zm9udC1mYWNlIGlzIGEgd2F5IG9mIGFjdHVhbGx5CiAgICAgICAgICAgICAvLyBkZWZpbmluZyB3 aGF0IGZvbnQgdG8gdXNlIGZvciB0aG9zZSB0eXBlcy4KLSAgICAgICAgICAgIFN0cmluZyBmYW1p bHlOYW1lOwogICAgICAgICAgICAgc3dpdGNoIChpdGVtLT5nZXRJZGVudCgpKSB7CiAgICAgICAg ICAgICAgICAgY2FzZSBDU1NWYWx1ZVNlcmlmOgogICAgICAgICAgICAgICAgICAgICBmYW1pbHlO YW1lID0gIi13ZWJraXQtc2VyaWYiOwo=