65085 2011-07-24 14:58:18 -0700 Fix AtomicString vs. String usage in JSC binding 2011-07-26 04:32:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 65172 1 paroga paroga darin webkit.review.bot oldest_to_newest 441492 0 paroga 2011-07-24 14:58:18 -0700 Fix AtomicString vs. String usage in JSC binding 441493 1 101834 paroga 2011-07-24 15:00:57 -0700 Created attachment 101834 Patch 441514 2 101834 darin 2011-07-24 17:35:50 -0700 Comment on attachment 101834 Patch This change is great. Even better would be some way to catch such things at compile time. I’m tempted to suggest we make conversion from String to AtomicString an explicit function instead of an implicit constructor. 441524 3 101834 webkit.review.bot 2011-07-24 18:27:19 -0700 Comment on attachment 101834 Patch Clearing flags on attachment: 101834 Committed r91652: <http://trac.webkit.org/changeset/91652> 441525 4 webkit.review.bot 2011-07-24 18:27:23 -0700 All reviewed patches have been landed. Closing bug. 441548 5 paroga 2011-07-24 20:50:15 -0700 (In reply to comment #2) > (From update of attachment 101834 [details]) > This change is great. Even better would be some way to catch such things at compile time. I’m tempted to suggest we make conversion from String to AtomicString an explicit function instead of an implicit constructor. I'm working on making the AtomicString(String) constructor explicit, but there are tooooo many errors at the moment. 101834 2011-07-24 15:00:57 -0700 2011-07-24 18:27:19 -0700 Patch bug-65085-20110725000056.patch text/plain 2386 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogOTE2NTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjYTMzNTE5NzIxMjI2YmVj NDA3ZGY3MjA1NmRlNmRiNGExZDA5NjQ1Li4xODJjNzZiY2JmOWZhZTAwMjhiMWUxNzE3NWFiOGEx MjU1Yzg0NTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjQgIFBhdHJp Y2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IEF0b21pY1N0 cmluZyB2cy4gU3RyaW5nIHVzYWdlIGluIEpTQyBiaW5kaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTA4NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB1c3RyaW5nVG9BdG9taWNTdHJpbmcgaW5z dGVhZCBvZiB1c3RyaW5nVG9TdHJpbmcgd2hlcmUgYXBwcm9wcmlhdGUuCisKKyAgICAgICAgKiBi aW5kaW5ncy9qcy9KU0hUTUxBbGxDb2xsZWN0aW9uQ3VzdG9tLmNwcDoKKyAgICAgICAgKiBiaW5k aW5ncy9qcy9KU0hUTUxDb2xsZWN0aW9uQ3VzdG9tLmNwcDoKKwogMjAxMS0wNy0yNCAgUm9iIEJ1 aXMgIDxyYnVpc0ByaW0uY29tPgogCiAgICAgICAgIFNWRyA8dXNlPiBlbGVtZW50IGlzIG5vdCBy ZXBvc2l0aW9uZWQgd2hlbiBtb3ZlZCB0byB4PTAgeT0wIHRocm91Z2ggc2NyaXB0IApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MQWxsQ29sbGVjdGlvbkN1c3Rv bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxBbGxDb2xsZWN0aW9uQ3Vz dG9tLmNwcAppbmRleCA2NDYxNWI5OTIxZWM2MjBkMzc0Nzk2YWRlZWU5OGEwYjY4NjBkNDI1Li4z NzkzZmU1NWFmZGRkNmFkN2RjOTFjMTExNjQwYWQ3ZDgzMmUxOTFjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxBbGxDb2xsZWN0aW9uQ3VzdG9tLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxBbGxDb2xsZWN0aW9uQ3VzdG9tLmNw cApAQCAtODcsNyArODcsNyBAQCBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBj YWxsSFRNTEFsbENvbGxlY3Rpb24oRXhlY1N0YXRlKiBleGVjKQogICAgIFVTdHJpbmcgc3RyaW5n ID0gZXhlYy0+YXJndW1lbnQoMCkudG9TdHJpbmcoZXhlYyk7CiAgICAgdW5zaWduZWQgaW5kZXgg PSBJZGVudGlmaWVyOjp0b1VJbnQzMihleGVjLT5hcmd1bWVudCgxKS50b1N0cmluZyhleGVjKSwg b2spOwogICAgIGlmIChvaykgewotICAgICAgICBTdHJpbmcgcHN0ciA9IHVzdHJpbmdUb1N0cmlu ZyhzdHJpbmcpOworICAgICAgICBBdG9taWNTdHJpbmcgcHN0ciA9IHVzdHJpbmdUb0F0b21pY1N0 cmluZyhzdHJpbmcpOwogICAgICAgICBOb2RlKiBub2RlID0gY29sbGVjdGlvbi0+bmFtZWRJdGVt KHBzdHIpOwogICAgICAgICB3aGlsZSAobm9kZSkgewogICAgICAgICAgICAgaWYgKCFpbmRleCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSFRNTENvbGxlY3Rpb25D dXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MQ29sbGVjdGlvbkN1 c3RvbS5jcHAKaW5kZXggYTEzMDJmZGIwY2IxMDRkNDczNGNmOTNjMzRjNzdjNzBlMzg5ZDc0Mi4u NjQ2ZjhkODMyYzkxMDgzYWY4M2E4N2Y4NjBjMmZjMGU4NDRjYTEwNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MQ29sbGVjdGlvbkN1c3RvbS5jcHAKQEAg LTgzLDcgKzgzLDcgQEAgc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgY2FsbEhU TUxDb2xsZWN0aW9uKEV4ZWNTdGF0ZSogZXhlYykKICAgICBVU3RyaW5nIHN0cmluZyA9IGV4ZWMt PmFyZ3VtZW50KDApLnRvU3RyaW5nKGV4ZWMpOwogICAgIHVuc2lnbmVkIGluZGV4ID0gSWRlbnRp Zmllcjo6dG9VSW50MzIoZXhlYy0+YXJndW1lbnQoMSkudG9TdHJpbmcoZXhlYyksIG9rKTsKICAg ICBpZiAob2spIHsKLSAgICAgICAgU3RyaW5nIHBzdHIgPSB1c3RyaW5nVG9TdHJpbmcoc3RyaW5n KTsKKyAgICAgICAgQXRvbWljU3RyaW5nIHBzdHIgPSB1c3RyaW5nVG9BdG9taWNTdHJpbmcoc3Ry aW5nKTsKICAgICAgICAgTm9kZSogbm9kZSA9IGNvbGxlY3Rpb24tPm5hbWVkSXRlbShwc3RyKTsK ICAgICAgICAgd2hpbGUgKG5vZGUpIHsKICAgICAgICAgICAgIGlmICghaW5kZXgpCg==