65084 2011-07-24 13:58:29 -0700 Build without video but fullscreen API is broken 2011-07-28 07:12:57 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P3 Minor --- 0 dok webkit-unassigned pnormand vir.found webkit.review.bot oldest_to_newest 441491 0 101833 dok 2011-07-24 13:58:29 -0700 Created attachment 101833 Patch fixing missing isMediaElement() when building without video but fullscreen API Building without video support, but with fullscreen API is currently broken. The virtual method isMediaElement() is not defined in that case. Attached patch fixes this. 441513 1 101833 darin 2011-07-24 17:34:18 -0700 Comment on attachment 101833 Patch fixing missing isMediaElement() when building without video but fullscreen API View in context: https://bugs.webkit.org/attachment.cgi?id=101833&action=review > Source/WebCore/dom/Element.h:315 > -#if ENABLE(VIDEO) > +#if ENABLE(VIDEO) || ENABLE(FULLSCREEN_API) This is the wrong fix. The right fix is to put the code in EventDispatcher::determineDispatchBehavior inside this: #if ENABLE(FULLSCREEN_API) && ENABLE(VIDEO) 442864 2 vir.found 2011-07-27 05:14:40 -0700 I build nightlies with --disable-video --disable-video-track, and I get the same error: Source/WebCore/dom/EventDispatcher.cpp:387:22: error: ‘class WebCore::Element’ has no member named ‘isMediaElement’ ...thus confirming the bug. 442868 3 102132 dok 2011-07-27 05:22:40 -0700 Created attachment 102132 Proper fix for the bug. 442870 4 102132 pnormand 2011-07-27 05:28:16 -0700 Comment on attachment 102132 Proper fix for the bug. This looks good but lacks a ChangeLog entry. Please see http://www.webkit.org/coding/contributing.html :) 442874 5 102133 dok 2011-07-27 05:38:06 -0700 Created attachment 102133 Proper fix with ChangeLog entry. 443419 6 102133 pnormand 2011-07-28 03:51:02 -0700 Comment on attachment 102133 Proper fix with ChangeLog entry. View in context: https://bugs.webkit.org/attachment.cgi?id=102133&action=review Almost there, thanks again for the patch! > Source/WebCore/ChangeLog:3 > + This fixes build without video enabled. Bug 65084. You need to have 2 lines, one for the bug description and the second line containing the link to the bug. prepare-ChangeLog --bug 65084 can be used too :) > Source/WebCore/dom/EventDispatcher.cpp:9 > + * Copyright (C) 2011 Denis Oliver Kropp (dok@directfb.org) According to our contributor policy only substantive code changes allow a copyright update. This patch is quite small, so please remove this line. 443438 7 102245 dok 2011-07-28 05:28:09 -0700 Created attachment 102245 Final bug fix 443449 8 102245 pnormand 2011-07-28 05:59:54 -0700 Comment on attachment 102245 Final bug fix Thanks! 443473 9 102245 webkit.review.bot 2011-07-28 07:12:53 -0700 Comment on attachment 102245 Final bug fix Clearing flags on attachment: 102245 Committed r91923: <http://trac.webkit.org/changeset/91923> 443474 10 webkit.review.bot 2011-07-28 07:12:57 -0700 All reviewed patches have been landed. Closing bug. 101833 2011-07-24 13:58:29 -0700 2011-07-27 05:38:06 -0700 Patch fixing missing isMediaElement() when building without video but fullscreen API WebKit_Element_isMediaElement_fix.patch text/plain 815 dok ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5oCmluZGV4IDg5ZGNjNjAuLjkyNjNmODYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQu aApAQCAtNCw2ICs0LDcgQEAKICAqICAgICAgICAgICAoQykgMjAwMSBQZXRlciBLZWxseSAocG1r QHBvc3QuY29tKQogICogICAgICAgICAgIChDKSAyMDAxIERpcmsgTXVlbGxlciAobXVlbGxlckBr ZGUub3JnKQogICogQ29weXJpZ2h0IChDKSAyMDAzLCAyMDA0LCAyMDA1LCAyMDA2LCAyMDA3LCAy MDA4LCAyMDA5LCAyMDEwLCAyMDExIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq ICAgICAgICAgICAoQykgMjAxMSBEZW5pcyBPbGl2ZXIgS3JvcHAgKGRva0BkaXJlY3RmYi5vcmcp CiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmli dXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExp YnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTMxMSw3ICszMTIsNyBAQCBwdWJsaWM6CiAgICAgc3Rh dGljIGJvb2wgaXNNYXRoTUxFbGVtZW50KCkgeyByZXR1cm4gZmFsc2U7IH0KICNlbmRpZgogCi0j aWYgRU5BQkxFKFZJREVPKQorI2lmIEVOQUJMRShWSURFTykgfHwgRU5BQkxFKEZVTExTQ1JFRU5f QVBJKQogICAgIHZpcnR1YWwgYm9vbCBpc01lZGlhRWxlbWVudCgpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CiAjZW5kaWYKIAo= 102132 2011-07-27 05:22:40 -0700 2011-07-27 05:38:06 -0700 Proper fix for the bug. WebKit_65084_fix.patch text/plain 1095 dok SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuY3BwCShyZXZpc2lvbiA5MTQ2 MSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC02LDYgKzYsNyBAQAogICogQ29weXJpZ2h0IChDKSAyMDA4IE5va2lhIENvcnBvcmF0 aW9uIGFuZC9vciBpdHMgc3Vic2lkaWFyeSgtaWVzKQogICogQ29weXJpZ2h0IChDKSAyMDA5IFRv cmNoIE1vYmlsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuIChodHRwOi8vd3d3LnRvcmNobW9i aWxlLmNvbS8pCiAgKiBDb3B5cmlnaHQgKEMpIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMSBEZW5pcyBPbGl2ZXIgS3JvcHAgKGRva0Bk aXJlY3RmYi5vcmcpCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBj YW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBv ZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTM3OCw3ICszNzksNyBAQAogCiBF dmVudERpc3BhdGNoQmVoYXZpb3IgRXZlbnREaXNwYXRjaGVyOjpkZXRlcm1pbmVEaXNwYXRjaEJl aGF2aW9yKEV2ZW50KiBldmVudCwgTm9kZSogc2hhZG93Um9vdCkKIHsKLSNpZiBFTkFCTEUoRlVM TFNDUkVFTl9BUEkpCisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKSAmJiBFTkFCTEUoVklERU8p CiAgICAgLy8gVmlkZW8tb25seSBmdWxsIHNjcmVlbiBpcyBhIG1vZGUgd2hlcmUgd2UgdXNlIHRo ZSBzaGFkb3cgRE9NIGFzIGFuIGltcGxlbWVudGF0aW9uCiAgICAgLy8gZGV0YWlsIHRoYXQgc2hv dWxkIG5vdCBiZSBkZXRlY3RhYmxlIGJ5IHRoZSB3ZWIgY29udGVudC4KICAgICBpZiAoRWxlbWVu dCogZWxlbWVudCA9IG1fbm9kZS0+ZG9jdW1lbnQoKS0+d2Via2l0Q3VycmVudEZ1bGxTY3JlZW5F bGVtZW50KCkpIHsK 102133 2011-07-27 05:38:06 -0700 2011-07-28 05:28:09 -0700 Proper fix with ChangeLog entry. WebKit_65084_fix.patch text/plain 1822 dok SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxODM0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMjcgIERlbmlzIE9s aXZlciBLcm9wcCAgPGRva0BkaXJlY3RmYi5vcmc+CisKKyAgICAgICAgVGhpcyBmaXhlcyBidWls ZCB3aXRob3V0IHZpZGVvIGVuYWJsZWQuIEJ1ZyA2NTA4NC4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IHdpdGggLS1kaXNhYmxlLXZpZGVvLgor CisgICAgICAgICogZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpF dmVudERpc3BhdGNoZXI6OmRldGVybWluZURpc3BhdGNoQmVoYXZpb3IpOgorCiAyMDExLTA3LTI3 ICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogW0Nocm9taXVtXSBSRUdSRVNTSU9OOiBVbmNhdWdodCBUeXBlRXJyb3I6IENh bm5vdCByZWFkIHByb3BlcnR5ICdpc1RyYWNpbmdUb1dpbmRvd09iamVjdHMnIG9mIHVuZGVmaW5l ZApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAJKHJldmlzaW9uIDkx NDYxKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTYsNiArNiw3IEBACiAgKiBDb3B5cmlnaHQgKEMpIDIwMDggTm9raWEgQ29ycG9y YXRpb24gYW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDkg VG9yY2ggTW9iaWxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4gKGh0dHA6Ly93d3cudG9yY2ht b2JpbGUuY29tLykKICAqIENvcHlyaWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDExIERlbmlzIE9saXZlciBLcm9wcCAoZG9r QGRpcmVjdGZiLm9yZykKICAqCiAgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91 IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1z IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAtMzc4LDcgKzM3OSw3IEBAIGNv bnN0IEV2ZW50Q29udGV4dCogRXZlbnREaXNwYXRjaGVyOjp0b3AKIAogRXZlbnREaXNwYXRjaEJl aGF2aW9yIEV2ZW50RGlzcGF0Y2hlcjo6ZGV0ZXJtaW5lRGlzcGF0Y2hCZWhhdmlvcihFdmVudCog ZXZlbnQsIE5vZGUqIHNoYWRvd1Jvb3QpCiB7Ci0jaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQor I2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkgJiYgRU5BQkxFKFZJREVPKQogICAgIC8vIFZpZGVv LW9ubHkgZnVsbCBzY3JlZW4gaXMgYSBtb2RlIHdoZXJlIHdlIHVzZSB0aGUgc2hhZG93IERPTSBh cyBhbiBpbXBsZW1lbnRhdGlvbgogICAgIC8vIGRldGFpbCB0aGF0IHNob3VsZCBub3QgYmUgZGV0 ZWN0YWJsZSBieSB0aGUgd2ViIGNvbnRlbnQuCiAgICAgaWYgKEVsZW1lbnQqIGVsZW1lbnQgPSBt X25vZGUtPmRvY3VtZW50KCktPndlYmtpdEN1cnJlbnRGdWxsU2NyZWVuRWxlbWVudCgpKSB7Cg== 102245 2011-07-28 05:28:09 -0700 2011-07-28 07:12:53 -0700 Final bug fix WebKit_65084_fix.patch text/plain 1387 dok SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxODM0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjcgIERlbmlzIE9s aXZlciBLcm9wcCAgPGRva0BkaXJlY3RmYi5vcmc+CisKKyAgICAgICAgVGhpcyBmaXhlcyBidWls ZCB3aXRob3V0IHZpZGVvIGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02NTA4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRlc3Qgd2l0aCAtLWRpc2FibGUtdmlkZW8uCisKKyAgICAgICAgKiBk b20vRXZlbnREaXNwYXRjaGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50RGlzcGF0Y2hl cjo6ZGV0ZXJtaW5lRGlzcGF0Y2hCZWhhdmlvcik6CisKIDIwMTEtMDctMjggIFl1dGEgS2l0YW11 cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViU29ja2V0OiBQYXNzIHRoZSB2 YWx1ZSBvZiB1c2VIaXhpZTc2UHJvdG9jb2wgZmxhZyB0byBXZWJTb2NrZXQgb2JqZWN0CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAkocmV2aXNpb24gOTE0NjEpCisr KyBTb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzc4LDcgKzM3OCw3IEBAIGNvbnN0IEV2ZW50Q29udGV4dCogRXZlbnREaXNwYXRjaGVyOjp0 b3AKIAogRXZlbnREaXNwYXRjaEJlaGF2aW9yIEV2ZW50RGlzcGF0Y2hlcjo6ZGV0ZXJtaW5lRGlz cGF0Y2hCZWhhdmlvcihFdmVudCogZXZlbnQsIE5vZGUqIHNoYWRvd1Jvb3QpCiB7Ci0jaWYgRU5B QkxFKEZVTExTQ1JFRU5fQVBJKQorI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkgJiYgRU5BQkxF KFZJREVPKQogICAgIC8vIFZpZGVvLW9ubHkgZnVsbCBzY3JlZW4gaXMgYSBtb2RlIHdoZXJlIHdl IHVzZSB0aGUgc2hhZG93IERPTSBhcyBhbiBpbXBsZW1lbnRhdGlvbgogICAgIC8vIGRldGFpbCB0 aGF0IHNob3VsZCBub3QgYmUgZGV0ZWN0YWJsZSBieSB0aGUgd2ViIGNvbnRlbnQuCiAgICAgaWYg KEVsZW1lbnQqIGVsZW1lbnQgPSBtX25vZGUtPmRvY3VtZW50KCktPndlYmtpdEN1cnJlbnRGdWxs U2NyZWVuRWxlbWVudCgpKSB7Cg==