65055 2011-07-22 16:11:20 -0700 [chromium] Remove code that attempted to explicitly sync compositing state before compositing 2011-07-22 16:38:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne fishd jbates kbr nduca vangelis oldest_to_newest 441241 0 jamesr 2011-07-22 16:11:20 -0700 [chromium] Remove code that attempted to explicitly sync compositing state before compositing 441243 1 101788 jamesr 2011-07-22 16:15:01 -0700 Created attachment 101788 Patch 441244 2 jamesr 2011-07-22 16:15:45 -0700 I'd like to get this for m14. Turns out this code is not useful like I hoped it would be and hurts framerate on some pages :(. 441249 3 101788 kbr 2011-07-22 16:22:23 -0700 Comment on attachment 101788 Patch This looks fine to me but testing is the only way to know whether this removal has any adverse side-effects. 441253 4 jamesr 2011-07-22 16:25:09 -0700 The layout tests and brief manual testing are happy, and we've added a lot of defensive code. If I'm wrong I guess we'll find out via crash reports! Thanks for the prompt review. 441262 5 jamesr 2011-07-22 16:38:13 -0700 Committed r91621: <http://trac.webkit.org/changeset/91621> 101788 2011-07-22 16:15:01 -0700 2011-07-22 16:22:23 -0700 Patch bug-65055-20110722161500.patch text/plain 3435 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTE1OTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MTBmYmNlNTA4NGYzYTZmMmI3NzBmOGZjNWMyYmI0NTc1MWJjZWFhZi4uMWY0NzZiYzI4NmI4NjQ1 NGY3NGJhMzYzZjBkYzAwNmJjMjRlNWEzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMSBAQAorMjAxMS0wNy0yMiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGNvZGUgdGhhdCBhdHRlbXB0ZWQg dG8gZXhwbGljaXRseSBzeW5jIGNvbXBvc2l0aW5nIHN0YXRlIGJlZm9yZSBjb21wb3NpdGluZwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUwNTUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSB3YXMg c29tZSBsb2dpYyBpbiBXZWJWaWV3SW1wbCB0byB0cnkgdG8gc3luY2hyb25vdXNseSBjYWxjdWxh dGUgY29tcG9zaXRpbmcgcmVxdWlyZW1lbnRzIGFuZCBzeW5jCisgICAgICAgIGNvbXBvc2l0aW5n IHN0YXRlIG9uIGFsbCBmcmFtZXMgYmVmb3JlIHBhaW50aW5nIGluIGFuIGF0dGVtcHQgdG8gZmx1 c2ggb3V0IGFsbCBwZW5kaW5nIHVwZGF0ZXMgYmVmb3JlIGVudGVyaW5nCisgICAgICAgIHRoZSBj b21wb3NpdGUgcm91dGluZXMuIFRoZSBpZGVhIGJlaGluZCB0aGlzIGNvZGUgd2FzIHRoYXQgaXQg d291bGQgYWxsb3cgdXMgdG8gbm90IHdvcnJ5IGFib3V0IGNvbXBvc2l0aW5nCisgICAgICAgIHR1 cm5pbmcgb2ZmIGluIHRoZSBtaWRkbGUgb2YgYSBjb21wb3NpdGUgb3BlcmF0aW9uIGR1ZSB0byB0 aGluZ3MgbGlrZSBSZW5kZXJMYXllciBvdmVybGFwIGJlaW5nIGxhemlseQorICAgICAgICBjYWxj dWxhdGVkLiAgSW4gcHJhY3RpY2UsIHdlIHN0aWxsIG5lZWQgdG8gYmUgZGVmZW5zaXZlIHRvIGNv bXBvc2l0aW5nIHJlcXVpcmVtZW50cyB1cGRhdGluZyBkdXJpbmcgdGhlCisgICAgICAgIGNvbXBv c2l0ZSBhbnl3YXkgYW5kIHRoaXMgY29kZSBpcyBxdWl0ZSBleHBlbnNpdmUgb24gc29tZSBwYWdl cyAoMTBtcysgb24gdGhlIEhUTUwgc3BlY2lmaWNhdGlvbiBvbiBteSBib3gpLgorCisgICAgICAg ICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6Omxh eW91dCk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6CisKIDIwMTEtMDctMjIgIEFuZHJl dyBTY2hlcmt1cyAgPHNjaGVya3VzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgc3Vy ZmFjZVR5cGUoKSBhbmQgdGV4dHVyZSgpIG1ldGhvZHMgZnJvbSBDaHJvbWl1bSB2aWRlbyBmcmFt ZSBjbGFzc2VzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmlu ZGV4IDA1YWFiNDNiNDNmOWU2NDZjOTE2ZTQ4MmM0ZjY5MTY5ZDkyMjI0MmMuLjBlYTk4MmU4ZjAw M2UyYzViMTZlYTM1Y2YyMmNlNTY4Yjc4OTc1ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTEwNTksMTMgKzEwNTksNiBAQCB2b2lkIFdlYlZpZXdJ bXBsOjpsYXlvdXQoKQogICAgICAgICAvLyBsYXlvdXQgdG8gYmUgaW52YWxpZGF0ZWQsIHNvIGxh eW91dCBuZWVkcyB0byBiZSBjYWxsZWQgbGFzdC4KIAogICAgICAgICB3ZWJmcmFtZS0+bGF5b3V0 KCk7Ci0KLSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAgICAgIC8vIENhbGwg dXBkYXRlTGF5ZXJzIGhlcmUgaW5zdGVhZCBvZiBkdXJpbmcgZG9Db21wb3NpdGUgc28gdGhhdCB3 ZSBkb24ndAotICAgICAgICAvLyB0cmlnZ2VyIGFub3RoZXIgcmVkdW5kYW50IGZyYW1lIGR1cmlu ZyBkb0NvbXBvc2l0ZS4KLSAgICAgICAgaWYgKGlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2 ZSgpKQotICAgICAgICAgICAgc3luY0NvbXBvc2l0aW5nTGF5ZXJzKCk7Ci0jZW5kaWYKICAgICB9 CiB9CiAKQEAgLTExNTAsMTYgKzExNDMsNiBAQCB2b2lkIFdlYlZpZXdJbXBsOjphbmltYXRlQW5k TGF5b3V0KGRvdWJsZSBmcmFtZUJlZ2luVGltZSkKICAgICBsYXlvdXQoKTsKIH0KIAotdm9pZCBX ZWJWaWV3SW1wbDo6c3luY0NvbXBvc2l0aW5nTGF5ZXJzKCkKLXsKLSAgICBUUkFDRV9FVkVOVCgi V2ViVmlld0ltcGw6OnN5bmNDb21wb3NpdGluZ0xheWVycyIsIHRoaXMsIDApOwotICAgIC8vIFVw ZGF0ZSB0aGUgY29tcG9zaXRpbmcgcmVxdWlyZW1lbnRzIGZvciBhbGwgZnJhbWUgaW4gdGhlIHRy ZWUgYmVmb3JlIGRvaW5nIGFueSBwYWludGluZwotICAgIC8vIGFzIHRoZSBjb21wb3NpdGluZyBy ZXF1aXJlbWVudHMgZm9yIGEgUmVuZGVyTGF5ZXIgd2l0aGluIGEgc3ViZnJhbWUgbWlnaHQgY2hh bmdlLgotICAgIGZvciAoRnJhbWUqIGZyYW1lID0gcGFnZSgpLT5tYWluRnJhbWUoKTsgZnJhbWU7 IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KCkpCi0gICAgICAgIGZyYW1lLT52 aWV3KCktPnVwZGF0ZUNvbXBvc2l0aW5nTGF5ZXJzKCk7Ci0gICAgcGFnZSgpLT5tYWluRnJhbWUo KS0+dmlldygpLT5zeW5jQ29tcG9zaXRpbmdTdGF0ZUluY2x1ZGluZ1N1YmZyYW1lcygpOwotfQot CiB2b2lkIFdlYlZpZXdJbXBsOjpjb21wb3NpdGUoYm9vbCBmaW5pc2gpCiB7CiAjaWYgVVNFKEFD Q0VMRVJBVEVEX0NPTVBPU0lUSU5HKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViVmlld0ltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmgKaW5kZXggMjlhNjY4MjkwM2VmNTg2OTczOGNjZDYxNjJhMTAzYjhlNWZkYzdiMy4uZDZl NTdjNzI3MjQxNmFiNmFkYzg5Y2M1ZDAzYzc1ZThjN2IxYWNmMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCkBAIC00MzEsNyArNDMxLDYgQEAgcHJpdmF0ZToKICAg ICB2b2lkIHJlYWxsb2NhdGVSZW5kZXJlcigpOwogICAgIHZvaWQgdXBkYXRlTGF5ZXJSZW5kZXJl clNldHRpbmdzKCk7CiAgICAgdm9pZCB1cGRhdGVMYXllclJlbmRlcmVyVmlld3BvcnQoKTsKLSAg ICB2b2lkIHN5bmNDb21wb3NpdGluZ0xheWVycygpOwogI2VuZGlmCiAKICAgICBXZWJWaWV3Q2xp ZW50KiBtX2NsaWVudDsK