65037 2011-07-22 11:40:28 -0700 [chromium] Accelerated drawing broken by mismatched compositor tile sizes 2011-09-21 12:55:27 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64613 64942 1 reveman reveman alokp bsalomon enne jamesr tomhudson vangelis oldest_to_newest 441054 0 reveman 2011-07-22 11:40:28 -0700 Layer compositor currently use the smallest possible size for each tile instead of the same same size for all tiles. Accelerated drawing assumes that all tiles are of the same size. 441057 1 101747 reveman 2011-07-22 11:47:12 -0700 Created attachment 101747 Patch 441093 2 alokp 2011-07-22 12:32:52 -0700 This patch does fix accelerated-drawing path. Thank You! I think we should try to push this for M14. It will make accelerated-drawing path functional. I will leave it to enne and jamesr to make the final call. 441099 3 bsalomon 2011-07-22 12:36:26 -0700 (In reply to comment #2) > This patch does fix accelerated-drawing path. Thank You! > I think we should try to push this for M14. It will make accelerated-drawing path functional. Wouldn't we also need to resolve the DEPTH_STENCIL attachment issue? 441100 4 101747 enne 2011-07-22 12:37:53 -0700 Comment on attachment 101747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101747&action=review Thanks for working on fixing this. :) > Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp:203 > IntRect LayerTilerChromium::tileTexRect(const Tile* tile) const > { > const int index = m_tilingData.tileIndex(tile->i(), tile->j()); > - return m_tilingData.tileBoundsWithOuterBorder(index); > + IntRect texRect = m_tilingData.tileBoundsWithOuterBorder(index); > + texRect.setSize(m_tileSize); > + return texRect; > } Is this function needed anymore? Can we remove it and just call tileLayerRect? 441106 5 alokp 2011-07-22 12:42:49 -0700 (In reply to comment #3) > (In reply to comment #2) > > This patch does fix accelerated-drawing path. Thank You! > > I think we should try to push this for M14. It will make accelerated-drawing path functional. > > Wouldn't we also need to resolve the DEPTH_STENCIL attachment issue? You are right. jamesr: If we push this patch, I would request you to reconsider https://bugs.webkit.org/show_bug.cgi?id=64613. Brian is working on a long-term solution that will address your concerns. 441994 6 101747 jamesr 2011-07-25 17:02:11 -0700 Comment on attachment 101747 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101747&action=review > LayoutTests/platform/chromium/test_expectations.txt:3855 > +BUGWK65037 : compositing/color-matching/image-color-matching.html = IMAGE > +BUGWK65037 : compositing/geometry/fixed-position.html = IMAGE > +BUGWK65037 : compositing/geometry/vertical-scroll-composited.html = IMAGE > +BUGWK65037 : compositing/overflow/fixed-position-ancestor-clip.html = IMAGE > +BUGWK65037 : platform/chromium/compositing/huge-layer-rotated.html = IMAGE > +BUGWK65037 : platform/chromium/compositing/tiny-layer-rotated.html = IMAGE fyi: having these edits at the very end of test_expectations.txt means that you will almost certainly get merge conflicts. i'd suggest moving them up to a random spot a few hundred lines off the end. also, be careful that you don't introduce any duplicates (run new-run-webkit-tests --lint-test-files to check) > Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp:197 > IntRect LayerTilerChromium::tileTexRect(const Tile* tile) const this sure does look identical to tileLayerRect() to me, as enne noted. please unify 442351 7 reveman 2011-07-26 10:48:02 -0700 (In reply to comment #6) > > > Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp:197 > > IntRect LayerTilerChromium::tileTexRect(const Tile* tile) const > > this sure does look identical to tileLayerRect() to me, as enne noted. please unify I didn't do that just to keep this temporary fix minimal. This patch only makes sense until https://bugs.webkit.org/show_bug.cgi?id=64942 has landed so I'll wait until I know the outlook for that before I put any more work into this. 457686 8 reveman 2011-08-26 11:51:32 -0700 (In reply to comment #7) > (In reply to comment #6) > > > > > Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp:197 > > > IntRect LayerTilerChromium::tileTexRect(const Tile* tile) const > > > > this sure does look identical to tileLayerRect() to me, as enne noted. please unify > > I didn't do that just to keep this temporary fix minimal. This patch only makes sense until https://bugs.webkit.org/show_bug.cgi?id=64942 has landed so I'll wait until I know the outlook for that before I put any more work into this. That was a confusing comment. I meant to say that I DID this to keep the fix minimal but that's irrelevant now as 64942 has landed. Is this still an issue? It should have been resolved by 64942. 471072 9 alokp 2011-09-21 12:55:27 -0700 Fixed in r92255 101747 2011-07-22 11:47:12 -0700 2011-07-25 17:02:10 -0700 Patch bug-65037-20110722144711.patch text/plain 5855 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogOTE1NjYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1Mjc0ODBjODllMmY1NjRhMDM4ZWQx NTNhNmM3MDUxODMxMWRmNjg1Li4yYjEwNTkzMzg0ZTVlZTVlMWQ4MWRlY2MxNDVlOWNlM2Y0MzI4 ODAxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDctMjIgIERhdmlkIFJldmVtYW4gIDxy ZXZlbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFVzZSB0aGUgc2FtZSB0 aWxlIHNpemUgZm9yIGFsbCB0aWxlcyBpbiBhIGxheWVyLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUwMzcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dDoKKwogMjAxMS0wNy0yMiAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBnb29nbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjg5NTM1KTogRm9ybSByZXNldCBkb2VzIG5vdCBy ZXBhaW50IGEgZmlsZSB1cGxvYWQgY29udHJvbC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCAxOWM3YTY1YTZjYTkzMTk3 YTI3ZWZmZGFlMDY2YmMyMDU1N2ExNjI5Li45MDI0NDI2ZDNiODEzYTkwODI1NDcyZTkyZGQ5YWVh M2Q1M2ViNjk5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVz dF9leHBlY3RhdGlvbnMudHh0CkBAIC0zODQ2LDMgKzM4NDYsMTAgQEAgQlVHUk5JV0EgV0lOIDog aHR0cC90ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2UtdHJlZS9yZXNvdXJjZS10cmVlLW5vbi11bmlx dWUtdXJsLmgKIEJVR1JOSVdBIDogZmFzdC9jc3MvYWJzb2x1dGUtY2hpbGQtd2l0aC1wZXJjZW50 LWhlaWdodC1pbnNpZGUtcmVsYXRpdmUtcGFyZW50Lmh0bWwgPSBNSVNTSU5HCiAKIEJVR1dLNjUw MDkgTUFDIDogc2Nyb2xsYmFycy9zY3JvbGxiYXItZHJhZy10aHVtYi13aXRoLWxhcmdlLWNvbnRl bnQuaHRtbCA9IFRFWFQKKworQlVHV0s2NTAzNyA6IGNvbXBvc2l0aW5nL2NvbG9yLW1hdGNoaW5n L2ltYWdlLWNvbG9yLW1hdGNoaW5nLmh0bWwgPSBJTUFHRQorQlVHV0s2NTAzNyA6IGNvbXBvc2l0 aW5nL2dlb21ldHJ5L2ZpeGVkLXBvc2l0aW9uLmh0bWwgPSBJTUFHRQorQlVHV0s2NTAzNyA6IGNv bXBvc2l0aW5nL2dlb21ldHJ5L3ZlcnRpY2FsLXNjcm9sbC1jb21wb3NpdGVkLmh0bWwgPSBJTUFH RQorQlVHV0s2NTAzNyA6IGNvbXBvc2l0aW5nL292ZXJmbG93L2ZpeGVkLXBvc2l0aW9uLWFuY2Vz dG9yLWNsaXAuaHRtbCA9IElNQUdFCitCVUdXSzY1MDM3IDogcGxhdGZvcm0vY2hyb21pdW0vY29t cG9zaXRpbmcvaHVnZS1sYXllci1yb3RhdGVkLmh0bWwgPSBJTUFHRQorQlVHV0s2NTAzNyA6IHBs YXRmb3JtL2Nocm9taXVtL2NvbXBvc2l0aW5nL3RpbnktbGF5ZXItcm90YXRlZC5odG1sID0gSU1B R0UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA3MDJiMWU5MWUwNDJhNmUyZmJiNDAxZDk2NDk3NjNkZWY5MGY0N2Rm Li5iMWQ3YWQ4NmJhODUyYTUxNjY2ODViMDk2YjcxNDE0ZDA5MDJlMGRmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMDctMjIgIERhdmlkIFJldmVtYW4gIDxyZXZlbWFuQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFVzZSB0aGUgc2FtZSB0aWxlIHNpemUgZm9y IGFsbCB0aWxlcyBpbiBhIGxheWVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjUwMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUZXN0czogY29tcG9zaXRpbmcvc2hhZG93cy9zaGFkb3ctZHJhd2luZy5o dG1sIChleGlzdGluZykKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xh eWVyVGlsZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclRpbGVyQ2hyb21p dW06OnNldFRpbGVTaXplKToKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyVGlsZXJDaHJvbWl1bTo6 dGlsZVRleFJlY3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJUaWxlckNocm9taXVtOjpncm93 TGF5ZXJUb0NvbnRhaW4pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xh eWVyVGlsZXJDaHJvbWl1bS5oOgorCiAyMDExLTA3LTIyICBLZW50YXJvIEhhcmEgIDxoYXJha2Vu QGdvb2dsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyODk1MzUpOiBGb3JtIHJlc2V0IGRv ZXMgbm90IHJlcGFpbnQgYSBmaWxlIHVwbG9hZCBjb250cm9sLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJD aHJvbWl1bS5jcHAKaW5kZXggNzY5ZjhlNzFkYjNiODZkMzFmZDVmMDRjYzQ0Y2VlN2QwYjU3NmUx YS4uMmExNDFjZGM5MGU1ZGE2MjcwN2QzZmJkODk3MTg5YjczYzU2YWNiOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9t aXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9M YXllclRpbGVyQ2hyb21pdW0uY3BwCkBAIC03OCwxMiArNzgsMTIgQEAgR3JhcGhpY3NDb250ZXh0 M0QqIExheWVyVGlsZXJDaHJvbWl1bTo6bGF5ZXJSZW5kZXJlckNvbnRleHQoKSBjb25zdAogCiB2 b2lkIExheWVyVGlsZXJDaHJvbWl1bTo6c2V0VGlsZVNpemUoY29uc3QgSW50U2l6ZSYgc2l6ZSkK IHsKLSAgICBpZiAobV90aWxlU2l6ZSA9PSBzaXplKQorICAgIGlmIChtX3JlcXVlc3RlZFRpbGVT aXplID09IHNpemUpCiAgICAgICAgIHJldHVybjsKIAogICAgIHJlc2V0KCk7CiAKLSAgICBtX3Rp bGVTaXplID0gc2l6ZTsKKyAgICBtX3JlcXVlc3RlZFRpbGVTaXplID0gc2l6ZTsKIH0KIAogTGF5 ZXJUZXh0dXJlKiBMYXllclRpbGVyQ2hyb21pdW06OmdldFNpbmdsZVRleHR1cmUoKQpAQCAtMTg5 LDEzICsxODksMTcgQEAgSW50UmVjdCBMYXllclRpbGVyQ2hyb21pdW06OnRpbGVDb250ZW50UmVj dChjb25zdCBUaWxlKiB0aWxlKSBjb25zdAogSW50UmVjdCBMYXllclRpbGVyQ2hyb21pdW06OnRp bGVMYXllclJlY3QoY29uc3QgVGlsZSogdGlsZSkgY29uc3QKIHsKICAgICBjb25zdCBpbnQgaW5k ZXggPSBtX3RpbGluZ0RhdGEudGlsZUluZGV4KHRpbGUtPmkoKSwgdGlsZS0+aigpKTsKLSAgICBy ZXR1cm4gbV90aWxpbmdEYXRhLnRpbGVCb3VuZHNXaXRoQm9yZGVyKGluZGV4KTsKKyAgICBJbnRS ZWN0IGxheWVyUmVjdCA9IG1fdGlsaW5nRGF0YS50aWxlQm91bmRzV2l0aE91dGVyQm9yZGVyKGlu ZGV4KTsKKyAgICBsYXllclJlY3Quc2V0U2l6ZShtX3RpbGVTaXplKTsKKyAgICByZXR1cm4gbGF5 ZXJSZWN0OwogfQogCiBJbnRSZWN0IExheWVyVGlsZXJDaHJvbWl1bTo6dGlsZVRleFJlY3QoY29u c3QgVGlsZSogdGlsZSkgY29uc3QKIHsKICAgICBjb25zdCBpbnQgaW5kZXggPSBtX3RpbGluZ0Rh dGEudGlsZUluZGV4KHRpbGUtPmkoKSwgdGlsZS0+aigpKTsKLSAgICByZXR1cm4gbV90aWxpbmdE YXRhLnRpbGVCb3VuZHNXaXRoT3V0ZXJCb3JkZXIoaW5kZXgpOworICAgIEludFJlY3QgdGV4UmVj dCA9IG1fdGlsaW5nRGF0YS50aWxlQm91bmRzV2l0aE91dGVyQm9yZGVyKGluZGV4KTsKKyAgICB0 ZXhSZWN0LnNldFNpemUobV90aWxlU2l6ZSk7CisgICAgcmV0dXJuIHRleFJlY3Q7CiB9CiAKIHZv aWQgTGF5ZXJUaWxlckNocm9taXVtOjppbnZhbGlkYXRlUmVjdChjb25zdCBJbnRSZWN0JiBjb250 ZW50UmVjdCkKQEAgLTQxMSwxNyArNDE1LDE3IEBAIHZvaWQgTGF5ZXJUaWxlckNocm9taXVtOjpn cm93TGF5ZXJUb0NvbnRhaW4oY29uc3QgSW50UmVjdCYgY29udGVudFJlY3QpCiAgICAgLy8gR3Jv dyB0aGUgdGlsZSBhcnJheSB0byBjb250YWluIHRoaXMgY29udGVudCByZWN0LgogICAgIEludFJl Y3QgbGF5ZXJSZWN0ID0gY29udGVudFJlY3RUb0xheWVyUmVjdChjb250ZW50UmVjdCk7CiAgICAg SW50U2l6ZSByZWN0U2l6ZSA9IEludFNpemUobGF5ZXJSZWN0Lm1heFgoKSwgbGF5ZXJSZWN0Lm1h eFkoKSk7Ci0gICAgSW50U2l6ZSB0ZXhTaXplID0gbV90aWxlU2l6ZTsKKyAgICBtX3RpbGVTaXpl ID0gbV9yZXF1ZXN0ZWRUaWxlU2l6ZTsKIAogICAgIC8vIFVzZSByZWN0IHdpdGggYm9yZGVyIHRl eGVscyBhcyBtYXggdGV4dHVyZSBzaXplIHdoZW4gdGlsZSBzaXplCiAgICAgLy8gaGFzIG5vdCBi ZWVuIHNwZWNpZmllZC4KLSAgICBpZiAodGV4U2l6ZS5pc0VtcHR5KCkpIHsKLSAgICAgICAgdGV4 U2l6ZSA9IHJlY3RTaXplOworICAgIGlmIChtX3RpbGVTaXplLmlzRW1wdHkoKSkgeworICAgICAg ICBtX3RpbGVTaXplID0gcmVjdFNpemU7CiAgICAgICAgIGlmIChtX3RpbGluZ0RhdGEuYm9yZGVy VGV4ZWxzKCkpCi0gICAgICAgICAgICB0ZXhTaXplLmV4cGFuZCgyLCAyKTsKKyAgICAgICAgICAg IG1fdGlsZVNpemUuZXhwYW5kKDIsIDIpOwogICAgIH0KIAotICAgIG1fdGlsaW5nRGF0YS5zZXRN YXhUZXh0dXJlU2l6ZShtYXgodGV4U2l6ZS53aWR0aCgpLCB0ZXhTaXplLmhlaWdodCgpKSk7Cisg ICAgbV90aWxpbmdEYXRhLnNldE1heFRleHR1cmVTaXplKG1heChtX3RpbGVTaXplLndpZHRoKCks IG1fdGlsZVNpemUuaGVpZ2h0KCkpKTsKICAgICBJbnRTaXplIG9sZExheWVyU2l6ZShtX3RpbGlu Z0RhdGEudG90YWxTaXplWCgpLCBtX3RpbGluZ0RhdGEudG90YWxTaXplWSgpKTsKICAgICBJbnRT aXplIG5ld1NpemUgPSByZWN0U2l6ZS5leHBhbmRlZFRvKG9sZExheWVyU2l6ZSk7CiAgICAgbV90 aWxpbmdEYXRhLnNldFRvdGFsU2l6ZShuZXdTaXplLndpZHRoKCksIG5ld1NpemUuaGVpZ2h0KCkp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v TGF5ZXJUaWxlckNocm9taXVtLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uaAppbmRleCAwZWYxMWEyNTVhZDFiNTE0MzM0ODUy OGQ5OTgzNGVlZTcyNDY3ZDI1Li5hY2Y4ZDY1YTIxMWQ0Y2RlYzY5Y2YyOTIwYjE3ZWFlNzE1Yzdj ODRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9MYXllclRpbGVyQ2hyb21pdW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uaApAQCAtMTQwLDYgKzE0MCw3IEBAIHBy aXZhdGU6CiAgICAgR0MzRGVudW0gbV90ZXh0dXJlRm9ybWF0OwogCiAgICAgSW50U2l6ZSBtX3Rp bGVTaXplOworICAgIEludFNpemUgbV9yZXF1ZXN0ZWRUaWxlU2l6ZTsKICAgICBJbnRQb2ludCBt X2xheWVyUG9zaXRpb247CiAKICAgICBib29sIG1fc2tpcHNEcmF3Owo=