65035 2011-07-22 11:10:59 -0700 [Cairo] Text extent of shadowed text is calculated incorrectly 2012-03-16 19:54:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 64744 1 mrobinson webkit-unassigned igor.oliveira krit leandro o.gorter rakuco oldest_to_newest 441031 0 mrobinson 2011-07-22 11:10:59 -0700 This became apparently during conversion of Cairo shadows to using ShadowBlur. The failure is covered by LayoutTests/fast/canvas/fillText-shadow.html. 542196 1 o.gorter 2012-01-25 04:43:59 -0800 I confirm and have a patch: --- a/Source/WebCore/platform/graphics/cairo/FontCairo.cpp +++ b/Source/WebCore/platform/graphics/cairo/FontCairo.cpp @@ -85,7 +85,7 @@ static void drawGlyphsShadow(GraphicsContext* graphicsContext, const FloatPoint& cairo_text_extents_t extents; cairo_scaled_font_glyph_extents(font->platformData().scaledFont(), glyphs, numGlyphs, &extents); - FloatRect fontExtentsRect(point.x(), point.y() - extents.height, extents.width, extents.height); + FloatRect fontExtentsRect(point.x(), point.y() + extents.y_bearing, extents.width, extents.height); if (GraphicsContext* shadowContext = shadow.beginShadowLayer(graphicsContext, fontExtentsRect)) { drawGlyphsToContext(shadowContext->platformContext()->cr(), font, glyphs, numGlyphs); shadow.endShadowLayer(graphicsContext); 542197 2 123923 o.gorter 2012-01-25 04:45:28 -0800 Created attachment 123923 use y_bearing instead of height to correctly get rect covering the shadow 546461 3 mrobinson 2012-01-31 13:51:33 -0800 Thanks for your contribution. Do you mind attaching a changelog as explained here? http://www.webkit.org/coding/contributing.html? If you do that I can commit your patch straight from this bug. Please just remove the line about missing tests and replace it with a statement that it's covered by the test I listed above. 581227 4 mrobinson 2012-03-16 19:51:50 -0700 (In reply to comment #1) > I confirm and have a patch: > > --- a/Source/WebCore/platform/graphics/cairo/FontCairo.cpp > +++ b/Source/WebCore/platform/graphics/cairo/FontCairo.cpp > @@ -85,7 +85,7 @@ static void drawGlyphsShadow(GraphicsContext* graphicsContext, const FloatPoint& > > cairo_text_extents_t extents; > cairo_scaled_font_glyph_extents(font->platformData().scaledFont(), glyphs, numGlyphs, &extents); > - FloatRect fontExtentsRect(point.x(), point.y() - extents.height, extents.width, extents.height); > + FloatRect fontExtentsRect(point.x(), point.y() + extents.y_bearing, extents.width, extents.height); It seems that we also need to look at the x_bearing here as well. Will make this change and land this patch. Thanks for the contribution! 581228 5 mrobinson 2012-03-16 19:54:56 -0700 Committed r111110: <http://trac.webkit.org/changeset/111110> 123923 2012-01-25 04:45:28 -0800 2012-01-25 04:45:28 -0800 use y_bearing instead of height to correctly get rect covering the shadow text-shadow-extents.patch text/plain 961 o.gorter ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRD YWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250Q2Fp cm8uY3BwCmluZGV4IDM1ZDFlNWIuLjVhODQ3ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udENhaXJvLmNwcApAQCAtODUsNyArODUsNyBA QCBzdGF0aWMgdm9pZCBkcmF3R2x5cGhzU2hhZG93KEdyYXBoaWNzQ29udGV4dCogZ3JhcGhpY3ND b250ZXh0LCBjb25zdCBGbG9hdFBvaW50JgogCiAgICAgY2Fpcm9fdGV4dF9leHRlbnRzX3QgZXh0 ZW50czsKICAgICBjYWlyb19zY2FsZWRfZm9udF9nbHlwaF9leHRlbnRzKGZvbnQtPnBsYXRmb3Jt RGF0YSgpLnNjYWxlZEZvbnQoKSwgZ2x5cGhzLCBudW1HbHlwaHMsICZleHRlbnRzKTsKLSAgICBG bG9hdFJlY3QgZm9udEV4dGVudHNSZWN0KHBvaW50LngoKSwgcG9pbnQueSgpIC0gZXh0ZW50cy5o ZWlnaHQsIGV4dGVudHMud2lkdGgsIGV4dGVudHMuaGVpZ2h0KTsKKyAgICBGbG9hdFJlY3QgZm9u dEV4dGVudHNSZWN0KHBvaW50LngoKSwgcG9pbnQueSgpICsgZXh0ZW50cy55X2JlYXJpbmcsIGV4 dGVudHMud2lkdGgsIGV4dGVudHMuaGVpZ2h0KTsKICAgICBpZiAoR3JhcGhpY3NDb250ZXh0KiBz aGFkb3dDb250ZXh0ID0gc2hhZG93LmJlZ2luU2hhZG93TGF5ZXIoZ3JhcGhpY3NDb250ZXh0LCBm b250RXh0ZW50c1JlY3QpKSB7CiAgICAgICAgIGRyYXdHbHlwaHNUb0NvbnRleHQoc2hhZG93Q29u dGV4dC0+cGxhdGZvcm1Db250ZXh0KCktPmNyKCksIGZvbnQsIGdseXBocywgbnVtR2x5cGhzKTsK ICAgICAgICAgc2hhZG93LmVuZFNoYWRvd0xheWVyKGdyYXBoaWNzQ29udGV4dCk7Cg==