65025 2011-07-22 05:50:04 -0700 Eliminate WebKit2 compilation warnings. 2011-10-25 20:01:09 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 l.slachciak webkit-unassigned abarth andersca darin mdwajahatali.siddiqui rakuco webkit.review.bot oldest_to_newest 440919 0 l.slachciak 2011-07-22 05:50:04 -0700 Eliminate compilator warnings for WebKit2 related to wrong type comparison. 440928 1 101724 l.slachciak 2011-07-22 06:39:57 -0700 Created attachment 101724 Compilator warnings patch 441684 2 rakuco 2011-07-25 09:03:07 -0700 Looks OK to me. 444784 3 101724 menard 2011-08-01 11:36:15 -0700 Comment on attachment 101724 Compilator warnings patch View in context: https://bugs.webkit.org/attachment.cgi?id=101724&action=review LGTM. > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1268 > + if (wmodeIndex == notFound) { I guess it is using the WTF::NotFound. 466250 4 107168 mdwajahatali.siddiqui 2011-09-13 05:56:57 -0700 Created attachment 107168 more compiler warnings fix Addressing Comment#3 its WTF::notFound, also fixing some more warnings on webkit2 466349 5 107168 darin 2011-09-13 09:49:12 -0700 Comment on attachment 107168 more compiler warnings fix View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review > Source/WebKit2/UIProcess/WebContext.cpp:324 > + String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now)); The name we use for this type in WebKit is "unsigned long long" rather than "long long unsigned int". Anders may have additional comments. I know he often uses uint64_t intentionally so we might instead want to use the string that lets us format a uint64_t instead of changing the typecast. > Source/WebKit2/UIProcess/WebContext.cpp:733 > + String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now)); Ditto. > Source/WebKit2/ChangeLog:3 > + Eliminate WebKit2 compilation warnings. It would be better if this said what compiler and platform these warnings were found with. 466350 6 107168 darin 2011-09-13 09:49:41 -0700 Comment on attachment 107168 more compiler warnings fix View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1269 > + if (wmodeIndex == WTF::notFound) { We normally just call this notFound. I am surprised that the explicit WTF:: is needed, and if it’s not needed, please omit it. 466351 7 darin 2011-09-13 09:50:00 -0700 We normally want a separate bug for each patch. Putting two patches in a single bug is not good. 466356 8 andersca 2011-09-13 10:00:22 -0700 (In reply to comment #5) > (From update of attachment 107168 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review > > > Source/WebKit2/UIProcess/WebContext.cpp:324 > > + String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now)); > > The name we use for this type in WebKit is "unsigned long long" rather than "long long unsigned int". Anders may have additional comments. I know he often uses uint64_t intentionally so we might instead want to use the string that lets us format a uint64_t instead of changing the typecast. We only use explicitly sized types when dealing with CoreIPC messages; you want to avoid sending an unsigned long between a 64-bit and a 32-bit process. 466370 9 darin 2011-09-13 10:26:07 -0700 (In reply to comment #8) > (In reply to comment #5) > > (From update of attachment 107168 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review > > > > > Source/WebKit2/UIProcess/WebContext.cpp:324 > > > + String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now)); > > > > The name we use for this type in WebKit is "unsigned long long" rather than "long long unsigned int". Anders may have additional comments. I know he often uses uint64_t intentionally so we might instead want to use the string that lets us format a uint64_t instead of changing the typecast. > > We only use explicitly sized types when dealing with CoreIPC messages; you want to avoid sending an unsigned long between a 64-bit and a 32-bit process. Sure, but this is about interoperating with printf format strings. The two ways to do that are to use the macros for creating the format strings, or casting to a built-in language type such as "unsigned long long". Do you have a comment on which is preferred? Maybe the right fix is to use a format string more like "%.0f" instead of trying to cast to an integral type? 466375 10 andersca 2011-09-13 10:31:05 -0700 (In reply to comment #9) > Sure, but this is about interoperating with printf format strings. The two ways to do that are to use the macros for creating the format strings, or casting to a built-in language type such as "unsigned long long". Do you have a comment on which is preferred? Maybe the right fix is to use a format string more like "%.0f" instead of trying to cast to an integral type? I don't have a strong opinion. In this particular case I think a full date + time string would be better, but that might be outside the scope of this patch. 467012 11 107329 mdwajahatali.siddiqui 2011-09-14 07:06:31 -0700 Created attachment 107329 compiler warnings fix updated updated based on review 467016 12 mdwajahatali.siddiqui 2011-09-14 07:12:20 -0700 (In reply to comment #5) Thanks for the review !! > (From update of attachment 107168 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review > > > Source/WebKit2/UIProcess/WebContext.cpp:324 > > + String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now)); > > The name we use for this type in WebKit is "unsigned long long" rather than "long long unsigned int". Anders may have additional comments. I know he often uses uint64_t intentionally so we might instead want to use the string that lets us format a uint64_t instead of changing the typecast. Based on below comments its better to ignore fixing this for now as i see a need to capture full date + time and not floating values of time. Since fixing this will involve changing string format will submit as separate patch. Hence reverting the changes :) > > > Source/WebKit2/UIProcess/WebContext.cpp:733 > > + String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now)); > > Ditto. Same as above > > > Source/WebKit2/ChangeLog:3 > > + Eliminate WebKit2 compilation warnings. > > It would be better if this said what compiler and platform these warnings were found with. Done 467023 13 mdwajahatali.siddiqui 2011-09-14 07:25:06 -0700 (In reply to comment #7) > We normally want a separate bug for each patch. Putting two patches in a single bug is not good. Correct, the older patch is obsolete. 467550 14 107329 webkit.review.bot 2011-09-14 19:52:20 -0700 Comment on attachment 107329 compiler warnings fix updated Clearing flags on attachment: 107329 Committed r95154: <http://trac.webkit.org/changeset/95154> 484550 15 107168 abarth 2011-10-15 01:49:50 -0700 Comment on attachment 107168 more compiler warnings fix Cleared Darin Adler's review+ from obsolete attachment 107168 so that this bug does not appear in http://webkit.org/pending-commit. 490539 16 abarth 2011-10-25 20:01:09 -0700 Looks like this patch landed. If there are more bugs to fix, please open a new bug. 101724 2011-07-22 06:39:57 -0700 2011-10-25 20:00:41 -0700 Compilator warnings patch warnings.patch text/plain 2315 l.slachciak ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ZTU1N2JmLi5hMTkyOTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDctMjIgIEx1a2FzeiBTbGFjaGNpYWsgIDxsLnNsYWNoY2lha0BzYW1zdW5nLmNv bT4KKworICAgICAgICBFbGltaW5hdGUgV2ViS2l0MiBjb21waWxhdGlvbiB3YXJuaW5ncy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MDI1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWxpbWluYXRlIGNv bXBpbGF0b3Igd2FybmluZ3MgZm9yIFdlYktpdDIgcmVsYXRlZCB0byB3cm9uZyB0eXBlIGNvbXBh cmlzb24uCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHA6 CisgICAgICAgIChDb3JlSVBDOjpBcmd1bWVudEVuY29kZXI6On5Bcmd1bWVudEVuY29kZXIpOiBG aXhlZCBpbnQgLSBzaXplX3QgY29tcGFyaXNvbi4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi RnJhbWVMb2FkZXJDbGllbnQ6OmNyZWF0ZVBsdWdpbik6IEZpeGVkIGludCAtIHNpemVfdCBjb21w YXJpc29uLgorCiAyMDExLTA3LTIxICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNv bT4KIAogICAgICAgICBbUXRdW1dLMl0gQ29kZSBjbGVhbnVwIGZvciBkcmFnLWFuZC1kcm9wCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rl ci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5j cHAKaW5kZXggNGQ1OGM4NC4uNjZmNTI2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxh dGZvcm0vQ29yZUlQQy9Bcmd1bWVudEVuY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmNwcApAQCAtNTQsNyArNTQsNyBAQCBBcmd1 bWVudEVuY29kZXI6On5Bcmd1bWVudEVuY29kZXIoKQogI2lmICFVU0UoVU5JWF9ET01BSU5fU09D S0VUUykKICAgICAvLyBGSVhNRTogV2UgbmVlZCB0byBkaXNwb3NlIG9mIHRoZSBhdHRhY2htZW50 cyBpbiBjYXNlcyBvZiBmYWlsdXJlLgogI2Vsc2UKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IG1f YXR0YWNobWVudHMuc2l6ZSgpOyArK2kpCisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2F0 dGFjaG1lbnRzLnNpemUoKTsgKytpKQogICAgICAgICBtX2F0dGFjaG1lbnRzW2ldLmRpc3Bvc2Uo KTsKICNlbmRpZgogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJD b3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAppbmRleCAzMDE3 NTA2Li5lYjY1NzNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcApAQCAtMTI2 NSw3ICsxMjY1LDcgQEAgUGFzc1JlZlB0cjxXaWRnZXQ+IFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojpj cmVhdGVQbHVnaW4oY29uc3QgSW50U2l6ZSYsIEhUTUxQbHVnSW4KICAgICAgICAgLy8gQ3VycmVu dGx5IHdlIGRvbid0IHN1cHBvcnQgdHJhbnNwYXJlbmN5IGFuZCB3aW5kb3dlZCBtb2RlLgogICAg ICAgICAvLyBJbmplY3Qgd21vZGU9b3BhcXVlIHRvIG1ha2UgRmxhc2ggd29yayBpbiB0aGVzZSBj b25kaXRpb25zLgogICAgICAgICBzaXplX3Qgd21vZGVJbmRleCA9IHBhcmFtZXRlcnMubmFtZXMu ZmluZCgid21vZGUiKTsKLSAgICAgICAgaWYgKHdtb2RlSW5kZXggPT0gLTEpIHsKKyAgICAgICAg aWYgKHdtb2RlSW5kZXggPT0gbm90Rm91bmQpIHsKICAgICAgICAgICAgIHBhcmFtZXRlcnMubmFt ZXMuYXBwZW5kKCJ3bW9kZSIpOwogICAgICAgICAgICAgcGFyYW1ldGVycy52YWx1ZXMuYXBwZW5k KCJvcGFxdWUiKTsKICAgICAgICAgfSBlbHNlIGlmIChlcXVhbElnbm9yaW5nQ2FzZShwYXJhbWV0 ZXJzLnZhbHVlc1t3bW9kZUluZGV4XSwgIndpbmRvdyIpKQo= 107168 2011-09-13 05:56:57 -0700 2011-10-15 01:49:50 -0700 more compiler warnings fix more_compilation_warning_fix text/plain 3744 mdwajahatali.siddiqui SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVM b2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiA5NTAyMykK KysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2Fk ZXJDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjY2LDcgKzEyNjYsNyBAQAogICAgICAg ICAvLyBDdXJyZW50bHkgd2UgZG9uJ3Qgc3VwcG9ydCB0cmFuc3BhcmVuY3kgYW5kIHdpbmRvd2Vk IG1vZGUuCiAgICAgICAgIC8vIEluamVjdCB3bW9kZT1vcGFxdWUgdG8gbWFrZSBGbGFzaCB3b3Jr IGluIHRoZXNlIGNvbmRpdGlvbnMuCiAgICAgICAgIHNpemVfdCB3bW9kZUluZGV4ID0gcGFyYW1l dGVycy5uYW1lcy5maW5kKCJ3bW9kZSIpOwotICAgICAgICBpZiAod21vZGVJbmRleCA9PSAtMSkg eworICAgICAgICBpZiAod21vZGVJbmRleCA9PSBXVEY6Om5vdEZvdW5kKSB7CiAgICAgICAgICAg ICBwYXJhbWV0ZXJzLm5hbWVzLmFwcGVuZCgid21vZGUiKTsKICAgICAgICAgICAgIHBhcmFtZXRl cnMudmFsdWVzLmFwcGVuZCgib3BhcXVlIik7CiAgICAgICAgIH0gZWxzZSBpZiAoZXF1YWxJZ25v cmluZ0Nhc2UocGFyYW1ldGVycy52YWx1ZXNbd21vZGVJbmRleF0sICJ3aW5kb3ciKSkKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAJKHJldmlzaW9uIDk1MDIzKQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMjEsNyArMzIxLDcgQEAKICAgICBpZiAobV9tZW1vcnlTYW1wbGVyRW5hYmxlZCkgewog ICAgICAgICBTYW5kYm94RXh0ZW5zaW9uOjpIYW5kbGUgc2FtcGxlTG9nU2FuZGJveEhhbmRsZTsg ICAgICAgIAogICAgICAgICBkb3VibGUgbm93ID0gV1RGOjpjdXJyZW50VGltZSgpOwotICAgICAg ICBTdHJpbmcgc2FtcGxlTG9nRmlsZVBhdGggPSBTdHJpbmc6OmZvcm1hdCgiV2ViUHJvY2VzcyVs bHUiLCBzdGF0aWNfY2FzdDx1aW50NjRfdD4obm93KSk7CisgICAgICAgIFN0cmluZyBzYW1wbGVM b2dGaWxlUGF0aCA9IFN0cmluZzo6Zm9ybWF0KCJXZWJQcm9jZXNzJWxsdSIsIHN0YXRpY19jYXN0 PGxvbmcgbG9uZyB1bnNpZ25lZCBpbnQ+KG5vdykpOwogICAgICAgICBzYW1wbGVMb2dGaWxlUGF0 aCA9IFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvclRlbXBvcmFyeUZpbGUoc2FtcGxl TG9nRmlsZVBhdGgsIFNhbmRib3hFeHRlbnNpb246OldyaXRlT25seSwgc2FtcGxlTG9nU2FuZGJv eEhhbmRsZSk7CiAgICAgICAgIAogICAgICAgICBtX3Byb2Nlc3MtPnNlbmQoTWVzc2FnZXM6Oldl YlByb2Nlc3M6OlN0YXJ0TWVtb3J5U2FtcGxlcihzYW1wbGVMb2dTYW5kYm94SGFuZGxlLCBzYW1w bGVMb2dGaWxlUGF0aCwgbV9tZW1vcnlTYW1wbGVySW50ZXJ2YWwpLCAwKTsKQEAgLTczMCw3ICs3 MzAsNyBAQAogICAgIC8vIEZvciBXZWJQcm9jZXNzCiAgICAgU2FuZGJveEV4dGVuc2lvbjo6SGFu ZGxlIHNhbXBsZUxvZ1NhbmRib3hIYW5kbGU7ICAgIAogICAgIGRvdWJsZSBub3cgPSBXVEY6OmN1 cnJlbnRUaW1lKCk7Ci0gICAgU3RyaW5nIHNhbXBsZUxvZ0ZpbGVQYXRoID0gU3RyaW5nOjpmb3Jt YXQoIldlYlByb2Nlc3MlbGx1Iiwgc3RhdGljX2Nhc3Q8dWludDY0X3Q+KG5vdykpOworICAgIFN0 cmluZyBzYW1wbGVMb2dGaWxlUGF0aCA9IFN0cmluZzo6Zm9ybWF0KCJXZWJQcm9jZXNzJWxsdSIs IHN0YXRpY19jYXN0PGxvbmcgbG9uZyB1bnNpZ25lZCBpbnQ+KG5vdykpOwogICAgIHNhbXBsZUxv Z0ZpbGVQYXRoID0gU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yVGVtcG9yYXJ5Rmls ZShzYW1wbGVMb2dGaWxlUGF0aCwgU2FuZGJveEV4dGVuc2lvbjo6V3JpdGVPbmx5LCBzYW1wbGVM b2dTYW5kYm94SGFuZGxlKTsKICAgICAKICAgICBzZW5kVG9BbGxQcm9jZXNzZXMoTWVzc2FnZXM6 OldlYlByb2Nlc3M6OlN0YXJ0TWVtb3J5U2FtcGxlcihzYW1wbGVMb2dTYW5kYm94SGFuZGxlLCBz YW1wbGVMb2dGaWxlUGF0aCwgaW50ZXJ2YWwpKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL0NvcmVJUEMvQXJndW1lbnRFbmNvZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHAJKHJldmlzaW9uIDk1MDIz KQorKysgU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudEVuY29kZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01NCw3ICs1NCw3IEBACiAjaWYgIVVTRShVTklYX0RPTUFJTl9T T0NLRVRTKQogICAgIC8vIEZJWE1FOiBXZSBuZWVkIHRvIGRpc3Bvc2Ugb2YgdGhlIGF0dGFjaG1l bnRzIGluIGNhc2VzIG9mIGZhaWx1cmUuCiAjZWxzZQotICAgIGZvciAoaW50IGkgPSAwOyBpIDwg bV9hdHRhY2htZW50cy5zaXplKCk7ICsraSkKKyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1f YXR0YWNobWVudHMuc2l6ZSgpOyArK2kpCiAgICAgICAgIG1fYXR0YWNobWVudHNbaV0uZGlzcG9z ZSgpOwogI2VuZGlmCiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiA5NTAyMykKKysrIFNvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEx LTA5LTEzICBXYWphaGF0IFNpZGRpcXVpICA8bWR3YWphaGF0YWxpLnNpZGRpcXVpQG1vdG9yb2xh LmNvbT4KKworICAgICAgICBFbGltaW5hdGUgV2ViS2l0MiBjb21waWxhdGlvbiB3YXJuaW5ncy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MDI1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9y bS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHA6CisgICAgICAgIChDb3JlSVBDOjpBcmd1bWVu dEVuY29kZXI6On5Bcmd1bWVudEVuY29kZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250 ZXh0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6cHJvY2Vzc0RpZEZpbmlzaExh dW5jaGluZyk6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnN0YXJ0TWVtb3J5U2FtcGxl cik6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNs aWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lTG9hZGVyQ2xpZW50OjpjcmVhdGVQ bHVnaW4pOgorCiAyMDExLTA5LTEyICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4K 107329 2011-09-14 07:06:31 -0700 2011-09-14 19:52:19 -0700 compiler warnings fix updated compiler_warnings_fix_updated.patch text/plain 2144 mdwajahatali.siddiqui SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVM b2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCShyZXZpc2lvbiA5NTA4NikK KysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2Fk ZXJDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjY2LDcgKzEyNjYsNyBAQAogICAgICAg ICAvLyBDdXJyZW50bHkgd2UgZG9uJ3Qgc3VwcG9ydCB0cmFuc3BhcmVuY3kgYW5kIHdpbmRvd2Vk IG1vZGUuCiAgICAgICAgIC8vIEluamVjdCB3bW9kZT1vcGFxdWUgdG8gbWFrZSBGbGFzaCB3b3Jr IGluIHRoZXNlIGNvbmRpdGlvbnMuCiAgICAgICAgIHNpemVfdCB3bW9kZUluZGV4ID0gcGFyYW1l dGVycy5uYW1lcy5maW5kKCJ3bW9kZSIpOwotICAgICAgICBpZiAod21vZGVJbmRleCA9PSAtMSkg eworICAgICAgICBpZiAod21vZGVJbmRleCA9PSBub3RGb3VuZCkgewogICAgICAgICAgICAgcGFy YW1ldGVycy5uYW1lcy5hcHBlbmQoIndtb2RlIik7CiAgICAgICAgICAgICBwYXJhbWV0ZXJzLnZh bHVlcy5hcHBlbmQoIm9wYXF1ZSIpOwogICAgICAgICB9IGVsc2UgaWYgKGVxdWFsSWdub3JpbmdD YXNlKHBhcmFtZXRlcnMudmFsdWVzW3dtb2RlSW5kZXhdLCAid2luZG93IikpCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50RW5jb2Rlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudEVuY29kZXIuY3Bw CShyZXZpc2lvbiA5NTA4NikKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQXJn dW1lbnRFbmNvZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTQsNyArNTQsNyBAQAogI2lmICFV U0UoVU5JWF9ET01BSU5fU09DS0VUUykKICAgICAvLyBGSVhNRTogV2UgbmVlZCB0byBkaXNwb3Nl IG9mIHRoZSBhdHRhY2htZW50cyBpbiBjYXNlcyBvZiBmYWlsdXJlLgogI2Vsc2UKLSAgICBmb3Ig KGludCBpID0gMDsgaSA8IG1fYXR0YWNobWVudHMuc2l6ZSgpOyArK2kpCisgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCBtX2F0dGFjaG1lbnRzLnNpemUoKTsgKytpKQogICAgICAgICBtX2F0dGFj aG1lbnRzW2ldLmRpc3Bvc2UoKTsKICNlbmRpZgogfQpJbmRleDogU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24g OTUwODcpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxNyBAQAorMjAxMS0wOS0xNCAgV2FqYWhhdCBTaWRkaXF1aSAgPG1kd2FqYWhhdGFsaS5z aWRkaXF1aUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgRWxpbWluYXRlIFdlYktpdDIgY29tcGls YXRpb24gd2FybmluZ3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NTAyNQorCisgICAgICAgIFdhcm5pbmdzIGZvdW5kIHdpdGggZ2NjIG9uIGxpbnV4 LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxh dGZvcm0vQ29yZUlQQy9Bcmd1bWVudEVuY29kZXIuY3BwOgorICAgICAgICAoQ29yZUlQQzo6QXJn dW1lbnRFbmNvZGVyOjp+QXJndW1lbnRFbmNvZGVyKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViRnJhbWVMb2FkZXJDbGllbnQ6OmNyZWF0ZVBsdWdpbik6CisKIDIwMTEtMDktMTMgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIEMrKyBl eGNlcHRpb25zIHdoZW4gYnVpbGRpbmcgd2l0aCBjbGFuZwo=