65002 2011-07-21 18:13:57 -0700 Get authentication to work with USE(CFNETWORK) on Mac 2011-07-21 22:27:30 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 51836 1 psolanki psolanki ap beidson ddkilzer jberlin psolanki oldest_to_newest 440774 0 psolanki 2011-07-21 18:13:57 -0700 Authentication does not work on Mac with USE(CFNETWORK) because my previous patches would create a new CFURLAuthChallengeRef. This mean that equality checks later in the code (and in CFNetwork) would fail. 440777 1 101683 psolanki 2011-07-21 18:19:57 -0700 Created attachment 101683 Patch 440823 2 101683 ddkilzer 2011-07-21 21:02:43 -0700 Comment on attachment 101683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101683&action=review r=me > Source/WebCore/platform/network/mac/AuthenticationMac.mm:62 > + CFURLAuthChallengeRef m_cfChallenge; Should this be retained using a RetainPtr<CFURLAuthChallengeRef>? 440836 3 psolanki 2011-07-21 22:24:49 -0700 (In reply to comment #2) > (From update of attachment 101683 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101683&action=review > > r=me Thanks! > > Source/WebCore/platform/network/mac/AuthenticationMac.mm:62 > > + CFURLAuthChallengeRef m_cfChallenge; > > Should this be retained using a RetainPtr<CFURLAuthChallengeRef>? I think we should be okay without the RetainPtr. The only one holding a reference to the WebCoreAuthenticationClientAsChallengeSender object is the NSURLAuthenticationChallenge object and if that goes away, there's no way to call core(NSURLAuthenticationChallenge *) method which accesses the m_cfChallenge ivar. 440837 4 psolanki 2011-07-21 22:27:30 -0700 Committed r91554: <http://trac.webkit.org/changeset/91554> 101683 2011-07-21 18:19:57 -0700 2011-07-21 21:02:43 -0700 Patch bug-65002-20110721181956.patch text/plain 3969 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogOTE1NDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzMzAyNWEyZjVkZmYwZmMx MTZhZTdmMTliNWE5OTljMjdlNmViOWVjLi45MzhmNjdjNGRjMDMxNDQxMmQ2ODRmZWYwZTgxZmNl MmZkNTY2NWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDctMjEgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTAwMgorICAgICAgICBHZXQgYXV0aGVudGljYXRp b24gdG8gd29yayB3aXRoIFVTRShDRk5FVFdPUkspIG9uIE1hYworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluc3RlYWQgb2YgY3JlYXRpbmcgYSBuZXcg Q0ZVUkxBdXRoQ2hhbGxlbmdlUmVmLCB3ZSBzYXZlIGFuZCByZXVzZSB0aGUgc2FtZSBvYmplY3Qg YXMgdGhlCisgICAgICAgIG9uZSBnaXZlbiB0byB1cyBieSBDRk5ldHdvcmsuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL21hYy9BdXRoZW50aWNhdGlvbk1hYy5tbToKKyAgICAgICAgKC1b V2ViQ29yZUF1dGhlbnRpY2F0aW9uQ2xpZW50QXNDaGFsbGVuZ2VTZW5kZXIgc2V0Q0ZDaGFsbGVu Z2U6XSk6IEFjY2Vzc29yIG1ldGhvZHMgZm9yIHRoZQorICAgICAgICBuZXcgQ0ZVUkxBdXRoQ2hh bGxlbmdlUmVmIGl2YXIuCisgICAgICAgICgtW1dlYkNvcmVBdXRoZW50aWNhdGlvbkNsaWVudEFz Q2hhbGxlbmdlU2VuZGVyIGNmQ2hhbGxlbmdlXSk6CisgICAgICAgIChXZWJDb3JlOjpjb3JlKTog Q3JlYXRlIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlIHVzaW5nIHRoZSBzYXZlZCBDRlVSTEF1dGhD aGFsbGVuZ2VSZWYuCisgICAgICAgIChXZWJDb3JlOjptYWMpOiBVc2UgdGhlIENGVVJMQXV0aENo YWxsZW5nZVJlZiBvYmplY3QgaW4gQXV0aGVudGljYXRpb25DaGFsbGVuZ2UgaW5zdGVhZCBvZgor ICAgICAgICBjcmVhdGluZyBhIG5ldyBvbmUuCisKIDIwMTEtMDctMjEgIFJhZmFlbCBCcmFuZGFv ICA8cmFmYWVsLmxvYm9Ab3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBMb2NhbCBmaWxlcyBjYW5u b3QgbG9hZCBpY29ucy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvbWFjL0F1dGhlbnRpY2F0aW9uTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9tYWMvQXV0aGVudGljYXRpb25NYWMubW0KaW5kZXggYWYxYjNlM2UzMWZmMDA1MmQ3ZTE5 ODA0NWExOGRlZTU0MmY5YzU4Ny4uODJjNjYwYTZlODYyNzE2YmQxZjYyMGUwZjI3ZGRmMDM2OWZh NDkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvQXV0 aGVudGljYXRpb25NYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9t YWMvQXV0aGVudGljYXRpb25NYWMubW0KQEAgLTQzLDcgKzQzLDYgQEAKIEBlbmQKIAogQGludGVy ZmFjZSBOU1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlIChEZXRhaWxzKQotLShDRlVSTEF1dGhD aGFsbGVuZ2VSZWYpX2NyZWF0ZUNGQXV0aENoYWxsZW5nZTsKICsoTlNVUkxBdXRoZW50aWNhdGlv bkNoYWxsZW5nZSAqKV9hdXRoZW50aWNhdGlvbkNoYWxsZW5nZUZvckNGQXV0aENoYWxsZW5nZToo Q0ZVUkxBdXRoQ2hhbGxlbmdlUmVmKWNmQ2hhbGxlbmdlIHNlbmRlcjooaWQgPE5TVVJMQXV0aGVu dGljYXRpb25DaGFsbGVuZ2VTZW5kZXI+KXNlbmRlcjsKIEBlbmQKIApAQCAtNTksNiArNTgsOSBA QCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIEBpbnRlcmZhY2UgV2ViQ29yZUF1dGhlbnRpY2F0 aW9uQ2xpZW50QXNDaGFsbGVuZ2VTZW5kZXIgOiBOU09iamVjdCA8TlNVUkxBdXRoZW50aWNhdGlv bkNoYWxsZW5nZVNlbmRlcj4KIHsKICAgICBBdXRoZW50aWNhdGlvbkNsaWVudCogbV9jbGllbnQ7 CisjaWYgVVNFKENGTkVUV09SSykKKyAgICBDRlVSTEF1dGhDaGFsbGVuZ2VSZWYgbV9jZkNoYWxs ZW5nZTsKKyNlbmRpZgogfQogLSAoaWQpaW5pdFdpdGhBdXRoZW50aWNhdGlvbkNsaWVudDooQXV0 aGVudGljYXRpb25DbGllbnQqKWNsaWVudDsKIC0gKEF1dGhlbnRpY2F0aW9uQ2xpZW50KiljbGll bnQ7CkBAIC0xMDQsNiArMTA2LDE4IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogICAgICAg ICBtX2NsaWVudC0+cmVjZWl2ZWRDYW5jZWxsYXRpb24oY29yZShjaGFsbGVuZ2UpKTsKIH0KIAor I2lmIFVTRShDRk5FVFdPUkspCistICh2b2lkKXNldENGQ2hhbGxlbmdlOihDRlVSTEF1dGhDaGFs bGVuZ2VSZWYpY2hhbGxlbmdlCit7CisgICAgbV9jZkNoYWxsZW5nZSA9IGNoYWxsZW5nZTsKK30K KworLSAoQ0ZVUkxBdXRoQ2hhbGxlbmdlUmVmKWNmQ2hhbGxlbmdlCit7CisgICAgcmV0dXJuIG1f Y2ZDaGFsbGVuZ2U7Cit9CisjZW5kaWYKKwogQGVuZAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBA IC0xMTMsOCArMTI3LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogQXV0aGVudGljYXRpb25DaGFs bGVuZ2UgY29yZShOU1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlICptYWNDaGFsbGVuZ2UpCiB7 CiAgICAgV2ViQ29yZUF1dGhlbnRpY2F0aW9uQ2xpZW50QXNDaGFsbGVuZ2VTZW5kZXIgKmNoYWxs ZW5nZVNlbmRlciA9IChXZWJDb3JlQXV0aGVudGljYXRpb25DbGllbnRBc0NoYWxsZW5nZVNlbmRl ciopIFttYWNDaGFsbGVuZ2Ugc2VuZGVyXTsKLSAgICBBdXRoZW50aWNhdGlvbkNsaWVudCogYXV0 aENsaWVudCA9IFtjaGFsbGVuZ2VTZW5kZXIgY2xpZW50XTsKLSAgICByZXR1cm4gQXV0aGVudGlj YXRpb25DaGFsbGVuZ2UoW21hY0NoYWxsZW5nZSBfY3JlYXRlQ0ZBdXRoQ2hhbGxlbmdlXSwgYXV0 aENsaWVudCk7CisgICAgcmV0dXJuIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKFtjaGFsbGVuZ2VT ZW5kZXIgY2ZDaGFsbGVuZ2VdLCBbY2hhbGxlbmdlU2VuZGVyIGNsaWVudF0pOwogfQogCiBDcmVk ZW50aWFsIGNvcmUoTlNVUkxDcmVkZW50aWFsICptYWNDcmVkZW50aWFsKQpAQCAtMTM3LDcgKzE1 MCwxMCBAQCBOU1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlICptYWMoY29uc3QgQXV0aGVudGlj YXRpb25DaGFsbGVuZ2UmIGNvcmVDaGFsbGVuZ2UpCiB7CiAgICAgQXV0aGVudGljYXRpb25DbGll bnQqIGF1dGhDbGllbnQgPSBjb3JlQ2hhbGxlbmdlLmF1dGhlbnRpY2F0aW9uQ2xpZW50KCk7CiAg ICAgUmV0YWluUHRyPFdlYkNvcmVBdXRoZW50aWNhdGlvbkNsaWVudEFzQ2hhbGxlbmdlU2VuZGVy PiBjaGFsbGVuZ2VTZW5kZXIoQWRvcHROUywgW1tXZWJDb3JlQXV0aGVudGljYXRpb25DbGllbnRB c0NoYWxsZW5nZVNlbmRlciBhbGxvY10gaW5pdFdpdGhBdXRoZW50aWNhdGlvbkNsaWVudDphdXRo Q2xpZW50XSk7Ci0gICAgUmV0YWluUHRyPENGVVJMQXV0aENoYWxsZW5nZVJlZj4gYXV0aENoYWxs ZW5nZShBZG9wdENGLCBjcmVhdGVDRihjb3JlQ2hhbGxlbmdlKSk7CisgICAgUmV0YWluUHRyPENG VVJMQXV0aENoYWxsZW5nZVJlZj4gYXV0aENoYWxsZW5nZSA9IGNvcmVDaGFsbGVuZ2UuY2ZVUkxB dXRoQ2hhbGxlbmdlUmVmKCk7CisgICAgaWYgKCFhdXRoQ2hhbGxlbmdlKQorICAgICAgICBhdXRo Q2hhbGxlbmdlLmFkb3B0Q0YoY3JlYXRlQ0YoY29yZUNoYWxsZW5nZSkpOworICAgIFtjaGFsbGVu Z2VTZW5kZXIuZ2V0KCkgc2V0Q0ZDaGFsbGVuZ2U6YXV0aENoYWxsZW5nZS5nZXQoKV07CiAgICAg cmV0dXJuIFtbTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSBfYXV0aGVudGljYXRpb25DaGFs bGVuZ2VGb3JDRkF1dGhDaGFsbGVuZ2U6YXV0aENoYWxsZW5nZS5nZXQoKSBzZW5kZXI6Y2hhbGxl bmdlU2VuZGVyLmdldCgpXSBhdXRvcmVsZWFzZV07CiB9CiAK