65001 2011-07-21 18:08:43 -0700 REGRESSION(r90971): Placeholder and search cancel button are visible even in elements with visibility:hidden 2011-09-29 21:57:08 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P1 Major --- 1 tkent tkent dglazkov gaddis morrita webkit.review.bot oldest_to_newest 440769 0 tkent 2011-07-21 18:08:43 -0700 http://code.google.com/p/chromium/issues/detail?id=90090 Shadow elements doesn't inherit the 'visibility' style? 440771 1 tkent 2011-07-21 18:10:19 -0700 (In reply to comment #0) > Shadow elements doesn't inherit the 'visibility' style? Ah, they do. We set 'visibility' explicitly for placeholder nodes and search cancel buttons. 440781 2 101684 tkent 2011-07-21 18:28:42 -0700 Created attachment 101684 Patch 440786 3 101684 dglazkov 2011-07-21 18:43:42 -0700 Comment on attachment 101684 Patch hello the long tail of obscure bugs. 440797 4 101684 tkent 2011-07-21 19:37:28 -0700 Comment on attachment 101684 Patch Thanks! 440815 5 101684 webkit.review.bot 2011-07-21 20:17:24 -0700 Comment on attachment 101684 Patch Attachment 101684 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9191913 New failing tests: fast/forms/search-styled.html fast/forms/placeholder-pseudo-style.html fast/forms/textarea-placeholder-pseudo-style.html fast/forms/password-placeholder.html fast/forms/textarea-placeholder-wrapping.html fast/forms/placeholder-position.html fast/css/pseudo-cache-stale.html fast/forms/password-placeholder-text-security.html fast/forms/isindex-placeholder.html fast/forms/input-placeholder-text-indent.html fast/forms/placeholder-stripped.html 440816 6 tkent 2011-07-21 20:24:16 -0700 (In reply to comment #5) > (From update of attachment 101684 [details]) > Attachment 101684 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/9191913 > > New failing tests: > fast/forms/search-styled.html > fast/forms/placeholder-pseudo-style.html > fast/forms/textarea-placeholder-pseudo-style.html > fast/forms/password-placeholder.html > fast/forms/textarea-placeholder-wrapping.html > fast/forms/placeholder-position.html > fast/css/pseudo-cache-stale.html > fast/forms/password-placeholder-text-security.html > fast/forms/isindex-placeholder.html > fast/forms/input-placeholder-text-indent.html > fast/forms/placeholder-stripped.html Oops, we should not check renderer() in placeholderShouldBeVisible(). I'll fix it. 440820 7 tkent 2011-07-21 20:31:41 -0700 Committed r91550: <http://trac.webkit.org/changeset/91550> 440840 8 tkent 2011-07-21 22:36:10 -0700 A follow-up change: http://trac.webkit.org/changeset/91556 475883 9 ap 2011-09-29 21:57:08 -0700 *** Bug 30608 has been marked as a duplicate of this bug. *** 101684 2011-07-21 18:28:42 -0700 2011-07-21 20:17:24 -0700 Patch bug-65001-20110722102840.patch text/plain 6181 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogOTE1NDAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzN2NiMDRiYTRkYzAwMjM5N2ZmYWRk MmU0Yjk5N2ExNTk3NDU1OGJlLi5jYWM1NDc1YjA2N2YzNzBjMThkOWUyZDkwMzY5NGJmNzFjYjRk MjUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjEgIEtlbnQgVGFtdXJhICA8dGtl bnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjkwOTcxKTogUGxhY2Vob2xk ZXIgYW5kIHNlYXJjaCBjYW5jZWwgYnV0dG9uIGFyZSB2aXNpYmxlIGV2ZW4gaW4gZWxlbWVudHMg d2l0aCB2aXNpYmlsaXR5OmhpZGRlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY1MDAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLWluLWludmlzaWJsZS1lbGVt ZW50cy1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL3BsYWNlaG9s ZGVyLWluLWludmlzaWJsZS1lbGVtZW50cy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zv cm1zL3NlYXJjaC1jYW5jZWwtaW4taW52aXNpYmxlLWVsZW1lbnRzLWV4cGVjdGVkLmh0bWw6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvc2VhcmNoLWNhbmNlbC1pbi1pbnZpc2libGUtZWxl bWVudHMuaHRtbDogQWRkZWQuCisKIDIwMTEtMDctMjEgIEt1bGFudGhhaXZlbCBQYWxhbmljaGFt eSAgPGt1bGFudGhhaXZlbEBjb2RlYXVyb3JhLm9yZz4KIAogICAgICAgICBUZXN0IHRvIGNvdmVy IGFic29sdXRlbHkgcG9zaXRpb25lZCBjaGlsZCB3aXRoIHBlcmNlbnRhZ2UgaGVpZ2h0CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLWluLWludmlzaWJsZS1l bGVtZW50cy1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9wbGFjZWhvbGRl ci1pbi1pbnZpc2libGUtZWxlbWVudHMtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iZDU0NDM0 YjE1YzUxY2I3Y2M0MjJmNjBlYzFjZDY0ODFkZDQ3NDYzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1pbi1pbnZpc2libGUtZWxlbWVudHMtZXhw ZWN0ZWQuaHRtbApAQCAtMCwwICsxLDMgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8L2h0 bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLWluLWlu dmlzaWJsZS1lbGVtZW50cy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9wbGFjZWhvbGRl ci1pbi1pbnZpc2libGUtZWxlbWVudHMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45Y2E1NDEyZGNjYWE1ZDBj Nzk2YTA2MjA4ZTdlMTMzNGQxMjYzNWIyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9wbGFjZWhvbGRlci1pbi1pbnZpc2libGUtZWxlbWVudHMuaHRtbApAQCAtMCww ICsxLDE2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8aW5wdXQgcGxhY2Vo b2xkZXI9cGxhY2Vob2xkZXIgc3R5bGU9InZpc2liaWxpdHk6aGlkZGVuIj4gPGJyPgorPGlucHV0 IHBsYWNlaG9sZGVyPXBsYWNlaG9sZGVyIHN0eWxlPSJkaXNwbGF5Om5vbmUiPiA8YnI+Cis8aW5w dXQgcGxhY2Vob2xkZXI9cGxhY2Vob2xkZXIgc3R5bGU9Im9wYWNpdHk6MCI+IDxicj4KKzx0ZXh0 YXJlYSBwbGFjZWhvbGRlcj1wbGFjZWhvbGRlciBzdHlsZT0idmlzaWJpbGl0eTpoaWRkZW4iPjwv dGV4dGFyZWE+IDxicj4KKzx0ZXh0YXJlYSBwbGFjZWhvbGRlcj1wbGFjZWhvbGRlciBzdHlsZT0i ZGlzcGxheTpub25lIj48L3RleHRhcmVhPiA8YnI+Cis8dGV4dGFyZWEgcGxhY2Vob2xkZXI9cGxh Y2Vob2xkZXIgc3R5bGU9Im9wYWNpdHk6MCI+PC90ZXh0YXJlYT4gPGJyPgorCis8aW5wdXQgcGxh Y2Vob2xkZXI9cGxhY2Vob2xkZXIgaWQ9aT4KKzxzY3JpcHQ+Citkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnaScpLnN0eWxlLnZpc2liaWxpdHkgPSAnaGlkZGVuJzsKKzwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2Fu Y2VsLWluLWludmlzaWJsZS1lbGVtZW50cy1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWluLWludmlzaWJsZS1lbGVtZW50cy1leHBlY3RlZC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmJkNTQ0MzRiMTVjNTFjYjdjYzQyMmY2MGVjMWNkNjQ4MWRkNDc0NjMKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1jYW5jZWwtaW4t aW52aXNpYmxlLWVsZW1lbnRzLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwzIEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9m b3Jtcy9zZWFyY2gtY2FuY2VsLWluLWludmlzaWJsZS1lbGVtZW50cy5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9zZWFyY2gtY2FuY2VsLWluLWludmlzaWJsZS1lbGVtZW50cy5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjhlZWRhYmJjZTc2Yzc4MjIzYmFiZjRhYTI0Y2M0MzljNmNjZTQ5NTAKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlYXJjaC1jYW5jZWwtaW4taW52 aXNpYmxlLWVsZW1lbnRzLmh0bWwKQEAgLTAsMCArMSwxMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxib2R5PgorPGlucHV0IHR5cGU9c2VhcmNoIHZhbHVlPXEgc3R5bGU9InZpc2liaWxp dHk6aGlkZGVuIj4gPGJyPgorPGlucHV0IHR5cGU9c2VhcmNoIHZhbHVlPXEgc3R5bGU9ImRpc3Bs YXk6bm9uZSI+IDxicj4KKzxpbnB1dCB0eXBlPXNlYXJjaCB2YWx1ZT1xIHN0eWxlPSJvcGFjaXR5 OjAiPiA8YnI+Cis8aW5wdXQgdHlwZT1zZWFyY2ggdmFsdWU9cSBpZD1zPgorPHNjcmlwdD4KK2Rv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCdzJykuc3R5bGUudmlzaWJpbGl0eSA9ICdoaWRkZW4nOwor PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMwMjVhMmY1ZGZmMGZj MTE2YWU3ZjE5YjVhOTk5YzI3ZTZlYjllYy4uOTE0OWE0YzFjZDhlM2I5NjRjZjAxNGZiN2EzMWNi ZTg3NTg1ZGYxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTA3LTIxICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9OKHI5MDk3 MSk6IFBsYWNlaG9sZGVyIGFuZCBzZWFyY2ggY2FuY2VsIGJ1dHRvbiBhcmUgdmlzaWJsZSBldmVu IGluIGVsZW1lbnRzIHdpdGggdmlzaWJpbGl0eTpoaWRkZW4uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTAwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RzOiBmYXN0L2Zvcm1zL3BsYWNlaG9sZGVy LWluLWludmlzaWJsZS1lbGVtZW50cy5odG1sCisgICAgICAgICAgICAgICBmYXN0L2Zvcm1zL3Nl YXJjaC1jYW5jZWwtaW4taW52aXNpYmxlLWVsZW1lbnRzLmh0bWwKKworICAgICAgICAqIGh0bWwv SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRl eHRGb3JtQ29udHJvbEVsZW1lbnQ6OnBsYWNlaG9sZGVyU2hvdWxkQmVWaXNpYmxlKToKKyAgICAg ICAgRG9uJ3Qgc2hvdyB0aGUgcGxhY2Vob2xkZXIgaWYgdGhlICd2aXNpYmlsaXR5JyBwcm9wZXJ0 eSBvZiB0aGUgb3duZXIgZWxlbWVudCBpcyAnaGlkZGVuLicKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyVGV4dENvbnRyb2xTaW5nbGVMaW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl clRleHRDb250cm9sU2luZ2xlTGluZTo6dmlzaWJpbGl0eUZvckNhbmNlbEJ1dHRvbik6IGRpdHRv LgorCiAyMDExLTA3LTIxICBSYWZhZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5v cmc+CiAKICAgICAgICAgTG9jYWwgZmlsZXMgY2Fubm90IGxvYWQgaWNvbnMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwCmluZGV4IDZk YjdlNWJiZTkwM2ZlZmFmMGFmZmYzOGJkNjc5ZWFhZTYzY2RkMGYuLmJlYjJhMWIwYmFmM2IwNDI0 N2Y4ZmZmMTM1Nzg2NDVhOTI2OTNjOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwCkBAIC0xMzUsNyArMTM1LDkgQEAgYm9vbCBI VE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6cGxhY2Vob2xkZXJTaG91bGRCZVZpc2libGUoKSBj b25zdAogICAgICAgICAmJiBpc0VtcHR5VmFsdWUoKQogICAgICAgICAmJiBpc0VtcHR5U3VnZ2Vz dGVkVmFsdWUoKQogICAgICAgICAmJiAhaXNQbGFjZWhvbGRlckVtcHR5KCkKLSAgICAgICAgJiYg KGRvY3VtZW50KCktPmZvY3VzZWROb2RlKCkgIT0gdGhpcyB8fCAocmVuZGVyZXIoKSAmJiByZW5k ZXJlcigpLT50aGVtZSgpLT5zaG91bGRTaG93UGxhY2Vob2xkZXJXaGVuRm9jdXNlZCgpKSk7Cisg ICAgICAgICYmIHJlbmRlcmVyKCkKKyAgICAgICAgJiYgKGRvY3VtZW50KCktPmZvY3VzZWROb2Rl KCkgIT0gdGhpcyB8fCByZW5kZXJlcigpLT50aGVtZSgpLT5zaG91bGRTaG93UGxhY2Vob2xkZXJX aGVuRm9jdXNlZCgpKQorICAgICAgICAmJiByZW5kZXJlcigpLT5zdHlsZSgpLT52aXNpYmlsaXR5 KCkgPT0gVklTSUJMRTsKIH0KIAogdm9pZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6dXBk YXRlUGxhY2Vob2xkZXJWaXNpYmlsaXR5KGJvb2wgcGxhY2Vob2xkZXJWYWx1ZUNoYW5nZWQpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2xTaW5n bGVMaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNp bmdsZUxpbmUuY3BwCmluZGV4IDA3MDBkMDgwNDA5OTMzZGNhODIzZGM3YjRiYWMxYTJlMTAwMjQw MDguLjUyYTVhYzhhZDE1ZTAzOTBlNWNmZmQ0NGI0MTc0YzdhMTdlNWRlZWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxp bmUuY3BwCkBAIC01MzksNyArNTM5LDcgQEAgdm9pZCBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxp bmU6OnVwZGF0ZUNhbmNlbEJ1dHRvblZpc2liaWxpdHkoKSBjb25zdAogCiBFVmlzaWJpbGl0eSBS ZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6OnZpc2liaWxpdHlGb3JDYW5jZWxCdXR0b24oKSBj b25zdAogewotICAgIHJldHVybiBpbnB1dEVsZW1lbnQoKS0+dmFsdWUoKS5pc0VtcHR5KCkgPyBI SURERU4gOiBWSVNJQkxFOworICAgIHJldHVybiAoc3R5bGUoKS0+dmlzaWJpbGl0eSgpID09IEhJ RERFTiB8fCBpbnB1dEVsZW1lbnQoKS0+dmFsdWUoKS5pc0VtcHR5KCkpID8gSElEREVOIDogVklT SUJMRTsKIH0KIAogY29uc3QgQXRvbWljU3RyaW5nJiBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxp bmU6OmF1dG9zYXZlTmFtZSgpIGNvbnN0Cg==