64996 2011-07-21 16:58:01 -0700 Gif animations stop working if system time is changed to a time in past 2011-07-28 17:02:47 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) All All RESOLVED FIXED http://en.wikipedia.org/wiki/Graphics_Interchange_Format P2 Normal --- 0 webkit.devdatta webkit-unassigned jamesr mrobinson simonjam webkit.devdatta webkit.review.bot oldest_to_newest 440726 0 webkit.devdatta 2011-07-21 16:58:01 -0700 Steps to reproduce: 1. Launch a web-page with animated gif images. For e.g. http://en.wikipedia.org/wiki/Graphics_Interchange_Format 2. While the animation is on, change the system time to a time in past. Result: Observe that the gif animations stop working. Expected behavior: Animation should work independent of change in system time. 440730 1 101669 webkit.devdatta 2011-07-21 17:03:16 -0700 Created attachment 101669 Patch 443542 2 101669 mrobinson 2011-07-28 10:18:23 -0700 Comment on attachment 101669 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101669&action=review > Source/WebCore/ChangeLog:10 > + Test: Load http://en.wikipedia.org/wiki/Graphics_Interchange_Format > + Change system time to a time in past > + Is there a test in manual-tests that uses an animated GIF? If so it might be better to refer to that one. 443663 3 102302 webkit.devdatta 2011-07-28 14:51:40 -0700 Created attachment 102302 Patch 443664 4 102302 jamesr 2011-07-28 14:55:53 -0700 Comment on attachment 102302 Patch Patch looks great! Thanks for fixing this. Do you need help committing this? Mark the "cq" flag "cq?" to request a commit from the commit bot, if so. 443718 5 102302 webkit.review.bot 2011-07-28 17:02:43 -0700 Comment on attachment 102302 Patch Clearing flags on attachment: 102302 Committed r91960: <http://trac.webkit.org/changeset/91960> 443719 6 webkit.review.bot 2011-07-28 17:02:47 -0700 All reviewed patches have been landed. Closing bug. 101669 2011-07-21 17:03:16 -0700 2011-07-28 14:51:35 -0700 Patch bug-64996-20110722175219.patch text/plain 1379 webkit.devdatta SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNTMxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMjIgIERldmRhdHRh IERlc2hwYW5kZSAgPHB3amQ3M0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgRml4ZWQgZ2lmIGFu aW1hdGlvbiBkZXBlbmRlbmN5IG9uIHN5c3RlbSB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDk5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IExvYWQgaHR0cDovL2VuLndpa2lwZWRpYS5v cmcvd2lraS9HcmFwaGljc19JbnRlcmNoYW5nZV9Gb3JtYXQKKyAgICAgICAgQ2hhbmdlIHN5c3Rl bSB0aW1lIHRvIGEgdGltZSBpbiBwYXN0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9C aXRtYXBJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFnZTo6c3RhcnRBbmlt YXRpb24pOgorCiAyMDExLTA3LTIxICBHYXZpbiBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEV4dGVuZCB0aGUgcHJvdGVjdG9yIG9mIGEgQ1NTIHN0eWxlIHNoZWV0LiAg QmVjYXVzZSBjaGVja0xvYWRlZCgpIGNhbiByZWN1cnNpdmVseSBkZWxldGUKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAJKHJldmlz aW9uIDkxNDk2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1h Z2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDgsNyArMzA4LDcgQEAgdm9pZCBCaXRtYXBJbWFn ZTo6c3RhcnRBbmltYXRpb24oYm9vbCBjYQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBJZiB3 ZSBhcmVuJ3QgYWxyZWFkeSBhbmltYXRpbmcsIHNldCBub3cgYXMgdGhlIGFuaW1hdGlvbiBzdGFy dCB0aW1lLgotICAgIGNvbnN0IGRvdWJsZSB0aW1lID0gY3VycmVudFRpbWUoKTsKKyAgICBjb25z dCBkb3VibGUgdGltZSA9IG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpOwogICAgIGlmICgh bV9kZXNpcmVkRnJhbWVTdGFydFRpbWUpCiAgICAgICAgIG1fZGVzaXJlZEZyYW1lU3RhcnRUaW1l ID0gdGltZTsKIAo= 102302 2011-07-28 14:51:40 -0700 2011-07-28 17:02:43 -0700 Patch bug-64996-20110729032143.patch text/plain 1417 webkit.devdatta SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxOTUwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMjggIERldmRhdHRh IERlc2hwYW5kZSAgPHB3amQ3M0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgRml4ZWQgZ2lmIGFu aW1hdGlvbiBkZXBlbmRlbmN5IG9uIHN5c3RlbSB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDk5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IExvYWQgV2ViQ29yZS9tYW51YWwtdGVzdHMv YW5pbWF0ZWQtZ2lmLWxvb3BpbmcuaHRtbAorICAgICAgICBDaGFuZ2Ugc3lzdGVtIHRpbWUgdG8g YSB0aW1lIGluIHBhc3QKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1hcEltYWdlOjpzdGFydEFuaW1hdGlvbik6IEJp dG1hcCBhbmltYXRpb24gaXMgbm93IGJhc2VkCisgICAgICAgIG9uIG1vbm90b25pY2FsbHlJbmNy ZWFzaW5nVGltZSBpbnN0ZWFkIG9mIGN1cnJlbnRUaW1lCisKIDIwMTEtMDctMjggIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NTMyMwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNwcAkocmV2aXNpb24gOTE5NDcpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMwOCw3ICszMDgsNyBAQCB2b2lkIEJpdG1hcEltYWdlOjpzdGFydEFuaW1hdGlvbihi b29sIGNhCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIElmIHdlIGFyZW4ndCBhbHJlYWR5IGFu aW1hdGluZywgc2V0IG5vdyBhcyB0aGUgYW5pbWF0aW9uIHN0YXJ0IHRpbWUuCi0gICAgY29uc3Qg ZG91YmxlIHRpbWUgPSBjdXJyZW50VGltZSgpOworICAgIGNvbnN0IGRvdWJsZSB0aW1lID0gbW9u b3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCk7CiAgICAgaWYgKCFtX2Rlc2lyZWRGcmFtZVN0YXJ0 VGltZSkKICAgICAgICAgbV9kZXNpcmVkRnJhbWVTdGFydFRpbWUgPSB0aW1lOwogCg==