64991 2011-07-21 16:21:40 -0700 [chromium] Force slow scrolling path for non-composited frames in a composited page 2011-07-22 12:26:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne fishd vangelis oldest_to_newest 440705 0 jamesr 2011-07-21 16:21:40 -0700 [chromium] Force slow scrolling path for non-composited frames in a composited page 440716 1 101666 jamesr 2011-07-21 16:45:46 -0700 Created attachment 101666 Patch 440719 2 enne 2011-07-21 16:49:57 -0700 *** Bug 64915 has been marked as a duplicate of this bug. *** 440733 3 101666 enne 2011-07-21 17:05:21 -0700 Comment on attachment 101666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101666&action=review Unofficially, the code looks good to me. We could also cut the explanation out and just say we don't handle it. > Source/WebCore/ChangeLog:10 > + The chromium compositor does not properly handle fast path scrolls for non-composited iframe in a composited > + page. In particular, we don't receive invalidations that are outside the viewport bounds for non-composited > + iframes, but we still try to use the contents from tiles that extend outside the viewport when they are scrolled > + in to view. For the main frame we do receive invalidations outside the viewport (see > + FrameView::clipsRepaints()) so everything works out. I thought the larger issue was that we don't handle the different scroll offsets from the main frame and the sub frame. This causes a problem because we're scrolling via redrawing the root directly at the scroll offset rather than scrolling via copying a rectangle from the backbuffer based on the offset that gets passed to WebViewImpl::scrollRootLayerRect. 440734 4 101670 jamesr 2011-07-21 17:05:50 -0700 Created attachment 101670 more accurate changelog 441089 5 jamesr 2011-07-22 12:26:49 -0700 Committed r91591: <http://trac.webkit.org/changeset/91591> 101666 2011-07-21 16:45:46 -0700 2011-07-21 17:05:47 -0700 Patch bug-64991-20110721164545.patch text/plain 2131 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTEzMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMTA3YmQyNTVmOTgzMDEw ZDJkZGU4MWJmYzBkNmY3MzY1OTAxZTU3Li4yNzI2YTU0NWNkMDEwZWY3YmEwMGFmZjQzYjYyY2Ni ZjY2ODFjODM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMjEgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEZv cmNlIHNsb3cgc2Nyb2xsaW5nIHBhdGggZm9yIG5vbi1jb21wb3NpdGVkIGZyYW1lcyBpbiBhIGNv bXBvc2l0ZWQgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjQ5OTEKKworICAgICAgICBUaGUgY2hyb21pdW0gY29tcG9zaXRvciBkb2VzIG5vdCBw cm9wZXJseSBoYW5kbGUgZmFzdCBwYXRoIHNjcm9sbHMgZm9yIG5vbi1jb21wb3NpdGVkIGlmcmFt ZSBpbiBhIGNvbXBvc2l0ZWQKKyAgICAgICAgcGFnZS4gSW4gcGFydGljdWxhciwgd2UgZG9uJ3Qg cmVjZWl2ZSBpbnZhbGlkYXRpb25zIHRoYXQgYXJlIG91dHNpZGUgdGhlIHZpZXdwb3J0IGJvdW5k cyBmb3Igbm9uLWNvbXBvc2l0ZWQKKyAgICAgICAgaWZyYW1lcywgYnV0IHdlIHN0aWxsIHRyeSB0 byB1c2UgdGhlIGNvbnRlbnRzIGZyb20gdGlsZXMgdGhhdCBleHRlbmQgb3V0c2lkZSB0aGUgdmll d3BvcnQgd2hlbiB0aGV5IGFyZSBzY3JvbGxlZAorICAgICAgICBpbiB0byB2aWV3LiAgRm9yIHRo ZSBtYWluIGZyYW1lIHdlIGRvIHJlY2VpdmUgaW52YWxpZGF0aW9ucyBvdXRzaWRlIHRoZSB2aWV3 cG9ydCAoc2VlCisgICAgICAgIEZyYW1lVmlldzo6Y2xpcHNSZXBhaW50cygpKSBzbyBldmVyeXRo aW5nIHdvcmtzIG91dC4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lVmlldzo6dXNlU2xvd1JlcGFpbnRzKToKKwogMjAxMS0wNy0xOSAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgdW51c2Vk IGNvZGUgaW4gRm9ybURhdGFTdHJlYW1DRk5ldApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmlu ZGV4IDdjOTUzODA1MzNiM2MyYTQ5YjI0NmE5NzU5Y2M0NDU2NGRmMjg4MjguLjU3ZDkwNzFhOWMz ZTUyYWUzM2VhYWQ1ZGI2MzIxNGVhOWY4OWZiYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAKQEAgLTExNDUsNiArMTE0NSwxMyBAQCBib29sIEZyYW1lVmlldzo6dXNlU2xvd1JlcGFpbnRz KCkgY29uc3QKICAgICBpZiAobV91c2VTbG93UmVwYWludHMgfHwgbV9zbG93UmVwYWludE9iamVj dENvdW50ID4gMCB8fCAocGxhdGZvcm1XaWRnZXQoKSAmJiBtX2ZpeGVkT2JqZWN0Q291bnQgPiAw KSB8fCBtX2lzT3ZlcmxhcHBlZCB8fCAhbV9jb250ZW50SXNPcGFxdWUpCiAgICAgICAgIHJldHVy biB0cnVlOwogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisgICAgLy8gVGhlIGNocm9taXVtIGNv bXBvc2l0b3IgZG9lcyBub3Qgc3VwcG9ydCBzY3JvbGxpbmcgYSBub24tY29tcG9zaXRlZCBmcmFt ZSB3aXRoaW4gYSBjb21wb3NpdGVkIHBhZ2UgdGhyb3VnaAorICAgIC8vIHRoZSBmYXN0IHNjcm9s bGluZyBwYXRoLCBzbyBmb3JjZSBzbG93IHNjcm9sbGluZyBpbiB0aGF0IGNhc2UuCisgICAgaWYg KCFpc0VuY2xvc2VkSW5Db21wb3NpdGluZ0xheWVyKCkgJiYgbV9mcmFtZS0+cGFnZSgpICYmIG1f ZnJhbWUtPnBhZ2UoKS0+bWFpbkZyYW1lKCktPnZpZXcoKS0+aGFzQ29tcG9zaXRlZENvbnRlbnQo KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisjZW5kaWYKKwogICAgIGlmIChGcmFtZVZpZXcqIHBh cmVudFZpZXcgPSBwYXJlbnRGcmFtZVZpZXcoKSkKICAgICAgICAgcmV0dXJuIHBhcmVudFZpZXct PnVzZVNsb3dSZXBhaW50cygpOwogCg== 101670 2011-07-21 17:05:50 -0700 2011-07-22 08:02:12 -0700 more accurate changelog bug-64991-20110721170549.patch text/plain 1750 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogOTEzMjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwMTA3YmQyNTVmOTgzMDEw ZDJkZGU4MWJmYzBkNmY3MzY1OTAxZTU3Li4xYjM0ZWU4YzYyMTJjYzI2YzFlZmY1MDdlN2EyMWM2 Mjk2MTM3OTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDctMjEgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEZv cmNlIHNsb3cgc2Nyb2xsaW5nIHBhdGggZm9yIG5vbi1jb21wb3NpdGVkIGZyYW1lcyBpbiBhIGNv bXBvc2l0ZWQgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjQ5OTEKKworICAgICAgICBUaGUgY2hyb21pdW0gY29tcG9zaXRvciBkb2VzIG5vdCBw cm9wZXJseSBoYW5kbGUgZmFzdCBwYXRoIHNjcm9sbHMgZm9yIG5vbi1jb21wb3NpdGVkIGlmcmFt ZSBpbiBhIGNvbXBvc2l0ZWQKKyAgICAgICAgcGFnZS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVW aWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6dXNlU2xvd1JlcGFpbnRzKToK KwogMjAxMS0wNy0xOSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIHNvbWUgdW51c2VkIGNvZGUgaW4gRm9ybURhdGFTdHJlYW1DRk5ldApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuY3BwCmluZGV4IDdjOTUzODA1MzNiM2MyYTQ5YjI0NmE5NzU5Y2M0NDU2NGRm Mjg4MjguLjU3ZDkwNzFhOWMzZTUyYWUzM2VhYWQ1ZGI2MzIxNGVhOWY4OWZiYTUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTExNDUsNiArMTE0NSwxMyBAQCBib29sIEZyYW1lVmll dzo6dXNlU2xvd1JlcGFpbnRzKCkgY29uc3QKICAgICBpZiAobV91c2VTbG93UmVwYWludHMgfHwg bV9zbG93UmVwYWludE9iamVjdENvdW50ID4gMCB8fCAocGxhdGZvcm1XaWRnZXQoKSAmJiBtX2Zp eGVkT2JqZWN0Q291bnQgPiAwKSB8fCBtX2lzT3ZlcmxhcHBlZCB8fCAhbV9jb250ZW50SXNPcGFx dWUpCiAgICAgICAgIHJldHVybiB0cnVlOwogCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCisgICAg Ly8gVGhlIGNocm9taXVtIGNvbXBvc2l0b3IgZG9lcyBub3Qgc3VwcG9ydCBzY3JvbGxpbmcgYSBu b24tY29tcG9zaXRlZCBmcmFtZSB3aXRoaW4gYSBjb21wb3NpdGVkIHBhZ2UgdGhyb3VnaAorICAg IC8vIHRoZSBmYXN0IHNjcm9sbGluZyBwYXRoLCBzbyBmb3JjZSBzbG93IHNjcm9sbGluZyBpbiB0 aGF0IGNhc2UuCisgICAgaWYgKCFpc0VuY2xvc2VkSW5Db21wb3NpdGluZ0xheWVyKCkgJiYgbV9m cmFtZS0+cGFnZSgpICYmIG1fZnJhbWUtPnBhZ2UoKS0+bWFpbkZyYW1lKCktPnZpZXcoKS0+aGFz Q29tcG9zaXRlZENvbnRlbnQoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisjZW5kaWYKKwogICAg IGlmIChGcmFtZVZpZXcqIHBhcmVudFZpZXcgPSBwYXJlbnRGcmFtZVZpZXcoKSkKICAgICAgICAg cmV0dXJuIHBhcmVudFZpZXctPnVzZVNsb3dSZXBhaW50cygpOwogCg==