64975 2011-07-21 14:00:21 -0700 Column spans and multi-column elements should not collapse margins with their children 2011-07-22 18:19:22 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt bdakin phiw2 oldest_to_newest 440627 0 hyatt 2011-07-21 14:00:21 -0700 Column spans and multi-column elements should establish block formatting contexts. They mostly do except for the part where they should not be collapsing margins with their children. This bug is about fixing the margin collapsing issue. 440629 1 101642 hyatt 2011-07-21 14:02:30 -0700 Created attachment 101642 Patch 440632 2 hyatt 2011-07-21 14:17:11 -0700 Fixed in r91497. A bunch of multicol tests will need to be rebaselined. I'm on Lion so can't do SL. 441314 3 phiw2 2011-07-22 18:19:22 -0700 Should '-webkit-column-count:0' establish a block formatting context and prevent margin-collapse through ? It does with the latest nightly (r91611) on Snow leopard. The spec says: "Values must be greater than 0" http://dev.w3.org/csswg/css3-multicol/#cc Opera 11.5 does not establish a BFC - the margins of the child element collapse through (unless of course the multi-col element has a border) testcase: http://dev.l-c-n.com/CSS3/multi-col/multicol-bfc3.html 101642 2011-07-21 14:02:30 -0700 2011-07-21 14:04:00 -0700 Patch patch.txt text/plain 1760 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNDk2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjEgIERhdmUgSHlh dHQgIDxoeWF0dEBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY0OTc1CisgICAgICAgIEVsZW1lbnRzIHRoYXQgaGF2ZSBjb2x1bW5z IChlLmcuLCBjb2x1bW4td2lkdGggb3IgY29sdW1uLWNvdW50IG5vbi1hdXRvKSBhcyB3ZWxsIGFz IGVsZW1lbnRzIHRoYXQKKyAgICAgICAgZXN0YWJsaXNoIGNvbHVtbi1zcGFucyBlc3RhYmxpc2gg YmxvY2sgZm9ybWF0dGluZyBjb250ZXh0cywgYW5kIHRoZXJlZm9yZSB0aGV5IHNob3VsZCBub3Qg YmUgYWxsb3dpbmcKKyAgICAgICAgY2hpbGQgbWFyZ2lucyB0byBjb2xsYXBzZSB3aXRoIHRoZWly IG93biBtYXJnaW5zLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyQmxvY2s6Ok1hcmdpbkluZm86Ok1hcmdpbkluZm8pOgorCiAyMDExLTA3LTE5ICBNYXR0aGV3 IERlbGFuZXkgIDxtZGVsYW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGZhc3QgcGF0aCBm b3IgSW1hZ2VCdWZmZXI6OmRyYXcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmNwcAkocmV2aXNpb24gOTE0NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Myw3ICs5Myw4IEBAIFJlbmRlckJs b2NrOjpNYXJnaW5JbmZvOjpNYXJnaW5JbmZvKFJlbmQKICAgICAvLyB3ZSdyZSBwb3NpdGlvbmVk LCBmbG9hdGluZywgYSB0YWJsZSBjZWxsLgogICAgIG1fY2FuQ29sbGFwc2VXaXRoQ2hpbGRyZW4g PSAhYmxvY2stPmlzUmVuZGVyVmlldygpICYmICFibG9jay0+aXNSb290KCkgJiYgIWJsb2NrLT5p c1Bvc2l0aW9uZWQoKQogICAgICAgICAmJiAhYmxvY2stPmlzRmxvYXRpbmcoKSAmJiAhYmxvY2st PmlzVGFibGVDZWxsKCkgJiYgIWJsb2NrLT5oYXNPdmVyZmxvd0NsaXAoKSAmJiAhYmxvY2stPmlz SW5saW5lQmxvY2tPcklubGluZVRhYmxlKCkKLSAgICAgICAgJiYgIWJsb2NrLT5pc1dyaXRpbmdN b2RlUm9vdCgpOworICAgICAgICAmJiAhYmxvY2stPmlzV3JpdGluZ01vZGVSb290KCkgJiYgYmxv Y2stPnN0eWxlKCktPmhhc0F1dG9Db2x1bW5Db3VudCgpICYmIGJsb2NrLT5zdHlsZSgpLT5oYXNB dXRvQ29sdW1uV2lkdGgoKQorICAgICAgICAmJiAhYmxvY2stPnN0eWxlKCktPmNvbHVtblNwYW4o KTsKIAogICAgIG1fY2FuQ29sbGFwc2VNYXJnaW5CZWZvcmVXaXRoQ2hpbGRyZW4gPSBtX2NhbkNv bGxhcHNlV2l0aENoaWxkcmVuICYmIChiZWZvcmVCb3JkZXJQYWRkaW5nID09IDApICYmIGJsb2Nr LT5zdHlsZSgpLT5tYXJnaW5CZWZvcmVDb2xsYXBzZSgpICE9IE1TRVBBUkFURTsKIAo=