64964 2011-07-21 11:23:49 -0700 DFG JIT - Enable support for eval code 2011-07-21 11:58:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 440511 0 barraclough 2011-07-21 11:23:49 -0700 This is basically the same as program code, to the JIT! 440515 1 101612 barraclough 2011-07-21 11:26:08 -0700 Created attachment 101612 The patch 440538 2 101612 sam 2011-07-21 11:51:03 -0700 Comment on attachment 101612 The patch View in context: https://bugs.webkit.org/attachment.cgi?id=101612&action=review > Source/JavaScriptCore/ChangeLog:12 > + - Enable opcodeNames in !DEBUG builds. You mean, !NDEBUG builds. 440549 3 barraclough 2011-07-21 11:58:41 -0700 Fixed in r91482 101612 2011-07-21 11:26:08 -0700 2011-07-21 11:51:03 -0700 The patch 64964.patch text/plain 5362 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTE0NzgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDctMjEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDk2NAor ICAgICAgICBERkcgSklUIC0gRW5hYmxlIHN1cHBvcnQgZm9yIGV2YWwgY29kZQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYmFzaWNhbGx5 IHRoZSBzYW1lIGFzIHByb2dyYW0gY29kZSwgdG8gdGhlIEpJVCEKKworICAgICAgICAqIGJ5dGVj b2RlL09wY29kZS5jcHA6CisgICAgICAgICogYnl0ZWNvZGUvT3Bjb2RlLmg6CisgICAgICAgICAg ICAtIEVuYWJsZSBvcGNvZGVOYW1lcyBpbiAhREVCVUcgYnVpbGRzLgorICAgICAgICAqIGRmZy9E RkdPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgICAgIC0gRml4IGEgYnVnIGV4cG9zZWQgYnkgZXZh bCBzdXBwb3J0LCB0aHJvdyBjb3JyZWN0IHR5cGUgZXJyb3IgZm9yIG5ldy4KKyAgICAgICAgKiBy dW50aW1lL0V4ZWN1dGFibGUuY3BwOgorICAgICAgICAoSlNDOjpFdmFsRXhlY3V0YWJsZTo6Y29t cGlsZUludGVybmFsKToKKyAgICAgICAgICAgIC0gRW5hYmxlIERGRyBKSVQgZm9yIGV2YWwgY29k ZS4KKwogMjAxMS0wNy0yMCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5j b20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjkxMzgwLgpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5jcHAJKHJldmlzaW9uIDkxNDI5KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM5LDcgKzM5LDcgQEAgdXNpbmcgbmFtZXNwYWNlIHN0ZDsKIAogbmFtZXNwYWNlIEpT QyB7CiAKLSNpZiBFTkFCTEUoT1BDT0RFX1NBTVBMSU5HKSB8fCBFTkFCTEUoQ09ERUJMT0NLX1NB TVBMSU5HKSB8fCBFTkFCTEUoT1BDT0RFX1NUQVRTKQorI2lmICFkZWZpbmVkKE5ERUJVRykgfHwg RU5BQkxFKE9QQ09ERV9TQU1QTElORykgfHwgRU5BQkxFKENPREVCTE9DS19TQU1QTElORykgfHwg RU5BQkxFKE9QQ09ERV9TVEFUUykKIAogY29uc3QgY2hhciogY29uc3Qgb3Bjb2RlTmFtZXNbXSA9 IHsKICNkZWZpbmUgT1BDT0RFX05BTUVfRU5UUlkob3Bjb2RlLCBzaXplKSAjb3Bjb2RlLApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL09wY29kZS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9PcGNvZGUuaAkocmV2aXNpb24gOTE0Mjkp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvT3Bjb2RlLmgJKHdvcmtpbmcgY29w eSkKQEAgLTIzNCw3ICsyMzQsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICB0eXBlZGVmIE9wY29k ZUlEIE9wY29kZTsKICNlbmRpZgogCi0jaWYgRU5BQkxFKE9QQ09ERV9TQU1QTElORykgfHwgRU5B QkxFKENPREVCTE9DS19TQU1QTElORykgfHwgRU5BQkxFKE9QQ09ERV9TVEFUUykKKyNpZiAhZGVm aW5lZChOREVCVUcpIHx8IEVOQUJMRShPUENPREVfU0FNUExJTkcpIHx8IEVOQUJMRShDT0RFQkxP Q0tfU0FNUExJTkcpIHx8IEVOQUJMRShPUENPREVfU1RBVFMpCiAKICNkZWZpbmUgUEFERElOR19T VFJJTkcgIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIgogI2RlZmluZSBQQURESU5H X1NUUklOR19MRU5HVEggc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHN0cmxlbihQQURESU5HX1NUUklO RykpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0aW9ucy5jcHAJ KHJldmlzaW9uIDkxNDI5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRp b25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgyLDMyICs0ODIsMzQgQEAgc3RhdGljIHZvaWQq IGhhbmRsZUhvc3RDYWxsKEV4ZWNTdGF0ZSogZQogICAgICAgICB9CiAgICAgCiAgICAgICAgIEFT U0VSVChjYWxsVHlwZSA9PSBDYWxsVHlwZU5vbmUpOwotICAgIH0gZWxzZSB7Ci0gICAgICAgIEFT U0VSVChraW5kID09IENvZGVGb3JDb25zdHJ1Y3QpOwotICAgICAgICAKLSAgICAgICAgQ29uc3Ry dWN0RGF0YSBjb25zdHJ1Y3REYXRhOwotICAgICAgICBDb25zdHJ1Y3RUeXBlIGNvbnN0cnVjdFR5 cGUgPSBnZXRDb25zdHJ1Y3REYXRhKGNhbGxlZSwgY29uc3RydWN0RGF0YSk7CisgICAgICAgIGV4 ZWMtPmdsb2JhbERhdGEoKS5leGNlcHRpb24gPSBjcmVhdGVOb3RBRnVuY3Rpb25FcnJvcihleGVj LCBjYWxsZWUpOworICAgICAgICByZXR1cm4gMDsKKyAgICB9CisKKyAgICBBU1NFUlQoa2luZCA9 PSBDb2RlRm9yQ29uc3RydWN0KTsKKyAgICAKKyAgICBDb25zdHJ1Y3REYXRhIGNvbnN0cnVjdERh dGE7CisgICAgQ29uc3RydWN0VHlwZSBjb25zdHJ1Y3RUeXBlID0gZ2V0Q29uc3RydWN0RGF0YShj YWxsZWUsIGNvbnN0cnVjdERhdGEpOworICAgIAorICAgIEFTU0VSVChjb25zdHJ1Y3RUeXBlICE9 IENvbnN0cnVjdFR5cGVKUyk7CisgICAgCisgICAgaWYgKGNvbnN0cnVjdFR5cGUgPT0gQ29uc3Ry dWN0VHlwZUhvc3QpIHsKKyAgICAgICAgaWYgKCFnbG9iYWxEYXRhLT5pbnRlcnByZXRlci0+cmVn aXN0ZXJGaWxlKCkuZ3JvdyhleGVjQ2FsbGVlLT5yZWdpc3RlcnMoKSkpIHsKKyAgICAgICAgICAg IGdsb2JhbERhdGEtPmV4Y2VwdGlvbiA9IGNyZWF0ZVN0YWNrT3ZlcmZsb3dFcnJvcihleGVjKTsK KyAgICAgICAgICAgIHJldHVybiAwOworICAgICAgICB9CiAgICAgICAgIAotICAgICAgICBBU1NF UlQoY29uc3RydWN0VHlwZSAhPSBDb25zdHJ1Y3RUeXBlSlMpOworICAgICAgICBleGVjQ2FsbGVl LT5zZXRTY29wZUNoYWluKGV4ZWMtPnNjb3BlQ2hhaW4oKSk7CiAgICAgICAgIAotICAgICAgICBp ZiAoY29uc3RydWN0VHlwZSA9PSBDb25zdHJ1Y3RUeXBlSG9zdCkgewotICAgICAgICAgICAgaWYg KCFnbG9iYWxEYXRhLT5pbnRlcnByZXRlci0+cmVnaXN0ZXJGaWxlKCkuZ3JvdyhleGVjQ2FsbGVl LT5yZWdpc3RlcnMoKSkpIHsKLSAgICAgICAgICAgICAgICBnbG9iYWxEYXRhLT5leGNlcHRpb24g PSBjcmVhdGVTdGFja092ZXJmbG93RXJyb3IoZXhlYyk7Ci0gICAgICAgICAgICAgICAgcmV0dXJu IDA7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIGV4ZWNDYWxsZWUt PnNldFNjb3BlQ2hhaW4oZXhlYy0+c2NvcGVDaGFpbigpKTsKLSAgICAgICAgICAgIAotICAgICAg ICAgICAgZ2xvYmFsRGF0YS0+aG9zdENhbGxSZXR1cm5WYWx1ZSA9IEpTVmFsdWU6OmRlY29kZShj b25zdHJ1Y3REYXRhLm5hdGl2ZS5mdW5jdGlvbihleGVjQ2FsbGVlKSk7Ci0gICAgICAgICAgICAK LSAgICAgICAgICAgIGlmIChnbG9iYWxEYXRhLT5leGNlcHRpb24pCi0gICAgICAgICAgICAgICAg cmV0dXJuIDA7Ci0gICAgICAgICAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oZ2V0 SG9zdENhbGxSZXR1cm5WYWx1ZSk7Ci0gICAgICAgIH0KKyAgICAgICAgZ2xvYmFsRGF0YS0+aG9z dENhbGxSZXR1cm5WYWx1ZSA9IEpTVmFsdWU6OmRlY29kZShjb25zdHJ1Y3REYXRhLm5hdGl2ZS5m dW5jdGlvbihleGVjQ2FsbGVlKSk7CiAgICAgICAgIAotICAgICAgICBBU1NFUlQoY29uc3RydWN0 VHlwZSA9PSBDb25zdHJ1Y3RUeXBlTm9uZSk7CisgICAgICAgIGlmIChnbG9iYWxEYXRhLT5leGNl cHRpb24pCisgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIHJlaW50ZXJwcmV0 X2Nhc3Q8dm9pZCo+KGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpOwogICAgIH0KLSAgICBleGVjLT5n bG9iYWxEYXRhKCkuZXhjZXB0aW9uID0gY3JlYXRlTm90QUZ1bmN0aW9uRXJyb3IoZXhlYywgY2Fs bGVlKTsKKyAgICAKKyAgICBBU1NFUlQoY29uc3RydWN0VHlwZSA9PSBDb25zdHJ1Y3RUeXBlTm9u ZSk7CisgICAgZXhlYy0+Z2xvYmFsRGF0YSgpLmV4Y2VwdGlvbiA9IGNyZWF0ZU5vdEFDb25zdHJ1 Y3RvckVycm9yKGV4ZWMsIGNhbGxlZSk7CiAgICAgcmV0dXJuIDA7CiB9CiAKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwCShyZXZpc2lvbiA5MTQy OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xODksNyArMTg5LDkgQEAgSlNPYmplY3QqIEV2YWxFeGVjdXRhYmxlOjpj b21waWxlSW50ZXJuYQogCiAjaWYgRU5BQkxFKEpJVCkKICAgICBpZiAoZXhlYy0+Z2xvYmFsRGF0 YSgpLmNhblVzZUpJVCgpKSB7Ci0gICAgICAgIG1faml0Q29kZUZvckNhbGwgPSBKSVQ6OmNvbXBp bGUoc2NvcGVDaGFpbk5vZGUtPmdsb2JhbERhdGEsIG1fZXZhbENvZGVCbG9jay5nZXQoKSk7Cisg ICAgICAgIGJvb2wgZGZnQ29tcGlsZWQgPSB0cnlERkdDb21waWxlKGV4ZWMsIG1fZXZhbENvZGVC bG9jay5nZXQoKSwgbV9qaXRDb2RlRm9yQ2FsbCk7CisgICAgICAgIGlmICghZGZnQ29tcGlsZWQp CisgICAgICAgICAgICBtX2ppdENvZGVGb3JDYWxsID0gSklUOjpjb21waWxlKHNjb3BlQ2hhaW5O b2RlLT5nbG9iYWxEYXRhLCBtX2V2YWxDb2RlQmxvY2suZ2V0KCkpOwogI2lmICFFTkFCTEUoT1BD T0RFX1NBTVBMSU5HKQogICAgICAgICBpZiAoIUJ5dGVjb2RlR2VuZXJhdG9yOjpkdW1wc0dlbmVy YXRlZENvZGUoKSkKICAgICAgICAgICAgIG1fZXZhbENvZGVCbG9jay0+ZGlzY2FyZEJ5dGVjb2Rl KCk7Cg==