64961 2011-07-21 10:26:19 -0700 Replace preprocessor statements in IDL files with Conditional attribute 2011-09-01 07:29:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 64231 67400 1 paroga paroga darin webkit.review.bot oldest_to_newest 440476 0 paroga 2011-07-21 10:26:19 -0700 Replace preprocessor statements in IDL files with Conditional attribute 440490 1 101605 paroga 2011-07-21 10:55:37 -0700 Created attachment 101605 Patch 440591 2 101605 darin 2011-07-21 12:50:40 -0700 Comment on attachment 101605 Patch What’s the rationale? Why is this better? 440603 3 paroga 2011-07-21 13:03:47 -0700 (In reply to comment #2) > (From update of attachment 101605 [details]) > What’s the rationale? Why is this better? The preprocessor causes many problems on native windows (e.g. no support for spaces in path) for me. See also <http://trac.webkit.org/changeset/90717> 440945 4 darin 2011-07-22 07:51:55 -0700 (In reply to comment #3) > The preprocessor causes many problems on native windows (e.g. no support for spaces in path) for me. > See also <http://trac.webkit.org/changeset/90717> In the future please make a brief mention of motivation like this in the change log entry. 440970 5 101605 webkit.review.bot 2011-07-22 08:50:50 -0700 Comment on attachment 101605 Patch Clearing flags on attachment: 101605 Committed r91570: <http://trac.webkit.org/changeset/91570> 440971 6 webkit.review.bot 2011-07-22 08:50:55 -0700 All reviewed patches have been landed. Closing bug. 101605 2011-07-21 10:55:37 -0700 2011-07-22 08:50:50 -0700 Patch bug-64961.patch text/plain 6775 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZTU1MDk0Li41NzE0ODFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDctMjEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmVwbGFjZSBwcmVwcm9jZXNzb3Igc3RhdGVtZW50cyBpbiBJREwgZmlsZXMgd2l0 aCBDb25kaXRpb25hbCBhdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY0OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVwbGFjZWQgRU5BQkxFX0RBVEFMSVNULCBFTkFCTEVfRElSRUNUT1JZ X1VQTE9BRCwgRU5BQkxFX0lOUFVUX1NQRUVDSCwgRU5BQkxFX01FRElBX1NUQVRJU1RJQ1MKKyAg ICAgICAgYW5kIEVOQUJMRV9PUklFTlRBVElPTl9FVkVOVFMgd2l0aCB0aGUgY29ycmVzcG9uZGlu ZyBDb25kaXRpb25hbCBhdHRyaWJ1dGUuCisKKyAgICAgICAgKiBodG1sL0hUTUxCb2R5RWxlbWVu dC5pZGw6CisgICAgICAgICogaHRtbC9IVE1MRnJhbWVTZXRFbGVtZW50LmlkbDoKKyAgICAgICAg KiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxl bWVudC5pZGw6CisgICAgICAgICogaHRtbC9IVE1MVmlkZW9FbGVtZW50LmlkbDoKKwogMjAxMS0w Ny0yMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGdvb2dsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogW3Byb3RvY29sXSBleHRlbmQgc2V0QnJlYWtwb2ludEJ5VXJsIHJlcXVlc3Qg dG8gYWNjZXB0IGluY29tcGxldGUgVVJMIChwcmVkaWNhdGVzKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MQm9keUVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MQm9keUVsZW1lbnQuaWRsCmluZGV4IDQ3MDllM2YuLmQ2ODUxZDQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxCb2R5RWxlbWVudC5pZGwKQEAgLTQwLDkgKzQwLDcgQEAgbW9kdWxlIGh0bWwg ewogICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtLCBXaW5kb3dFdmVudExpc3RlbmVyXSBFdmVu dExpc3RlbmVyIG9uc3RvcmFnZTsKICAgICAgICAgYXR0cmlidXRlIFtEb250RW51bSwgV2luZG93 RXZlbnRMaXN0ZW5lcl0gRXZlbnRMaXN0ZW5lciBvbnVubG9hZDsKIAotI2lmIGRlZmluZWQoRU5B QkxFX09SSUVOVEFUSU9OX0VWRU5UUykgJiYgRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUwotICAg ICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtLCBXaW5kb3dFdmVudExpc3RlbmVyXSBFdmVudExpc3Rl bmVyIG9ub3JpZW50YXRpb25jaGFuZ2U7Ci0jZW5kaWYKKyAgICAgICAgYXR0cmlidXRlIFtDb25k aXRpb25hbD1PUklFTlRBVElPTl9FVkVOVFMsIERvbnRFbnVtLCBXaW5kb3dFdmVudExpc3RlbmVy XSBFdmVudExpc3RlbmVyIG9ub3JpZW50YXRpb25jaGFuZ2U7CiAKICAgICAgICAgLy8gT3ZlcnJp ZGVzIG9mIEVsZW1lbnQgYXR0cmlidXRlcyAod2l0aCBkaWZmZXJlbnQgaW1wbGVtZW50YXRpb24g aW4gYmluZGluZ3MpLgogICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVtLCBXaW5kb3dFdmVudExp c3RlbmVyXSBFdmVudExpc3RlbmVyIG9uYmx1cjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTEZyYW1lU2V0RWxlbWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG cmFtZVNldEVsZW1lbnQuaWRsCmluZGV4IDA2YWFiNmEuLmRiMjY0MTAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lU2V0RWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRnJhbWVTZXRFbGVtZW50LmlkbApAQCAtMzgsOSArMzgsNyBAQCBtb2R1 bGUgaHRtbCB7CiAgICAgICAgIGF0dHJpYnV0ZSBbRG9udEVudW0sIFdpbmRvd0V2ZW50TGlzdGVu ZXJdIEV2ZW50TGlzdGVuZXIgb25zdG9yYWdlOwogICAgICAgICBhdHRyaWJ1dGUgW0RvbnRFbnVt LCBXaW5kb3dFdmVudExpc3RlbmVyXSBFdmVudExpc3RlbmVyIG9udW5sb2FkOwogCi0jaWYgZGVm aW5lZChFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTKSAmJiBFTkFCTEVfT1JJRU5UQVRJT05fRVZF TlRTCi0gICAgICAgIGF0dHJpYnV0ZSBbRG9udEVudW1dIEV2ZW50TGlzdGVuZXIgb25vcmllbnRh dGlvbmNoYW5nZTsKLSNlbmRpZgorICAgICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPU9SSUVO VEFUSU9OX0VWRU5UUywgRG9udEVudW1dIEV2ZW50TGlzdGVuZXIgb25vcmllbnRhdGlvbmNoYW5n ZTsKIAogICAgICAgICAvLyBPdmVycmlkZXMgb2YgRWxlbWVudCBhdHRyaWJ1dGVzICh3aXRoIGRp ZmZlcmVudCBpbXBsZW1lbnRhdGlvbiBpbiBiaW5kaW5ncykuCiAgICAgICAgIGF0dHJpYnV0ZSBb RG9udEVudW0sIFdpbmRvd0V2ZW50TGlzdGVuZXJdIEV2ZW50TGlzdGVuZXIgb25ibHVyOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5pZGwKaW5kZXggNjE1OTY0MS4uNDY4MjQx ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmlkbAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaWRsCkBAIC00MCwxNiAr NDAsMTIgQEAgbW9kdWxlIGh0bWwgewogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xl YW4gZGlzYWJsZWQ7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gYm9vbGVhbiBhdXRvZm9j dXM7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGF1dG9jb21wbGV0ZTsK LSNpZiBkZWZpbmVkKEVOQUJMRV9EQVRBTElTVCkgJiYgRU5BQkxFX0RBVEFMSVNUCi0gICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBIVE1MRWxlbWVudCAgICAgbGlzdDsKLSNlbmRpZgorICAgICAg ICByZWFkb25seSBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPURBVEFMSVNUXSBIVE1MRWxlbWVudCBs aXN0OwogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIERPTVN0cmluZyBtYXg7CiAgICAgICAg IGF0dHJpYnV0ZSBsb25nIG1heExlbmd0aCBzZXR0ZXIgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAg ICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIG1pbjsKICAgICAgICAgYXR0cmli dXRlIFtSZWZsZWN0XSBib29sZWFuIG11bHRpcGxlOwotI2lmIGRlZmluZWQoRU5BQkxFX0RJUkVD VE9SWV9VUExPQUQpICYmIEVOQUJMRV9ESVJFQ1RPUllfVVBMT0FECi0gICAgICAgIGF0dHJpYnV0 ZSBbUmVmbGVjdF0gYm9vbGVhbiB3ZWJraXRkaXJlY3Rvcnk7Ci0jZW5kaWYKKyAgICAgICAgYXR0 cmlidXRlIFtDb25kaXRpb25hbD1ESVJFQ1RPUllfVVBMT0FELCBSZWZsZWN0XSBib29sZWFuIHdl YmtpdGRpcmVjdG9yeTsKICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgbmFt ZTsKICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgcGF0dGVybjsKICAgICAg ICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJpbmcgcGxhY2Vob2xkZXI7CkBAIC03MCw5ICs2 Niw3IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgYXR0cmlidXRlIERhdGUgdmFsdWVBc0RhdGUg c2V0dGVyIHJhaXNlcyhET01FeGNlcHRpb24pOwogI2VuZGlmCiAgICAgICAgIGF0dHJpYnV0ZSBk b3VibGUgdmFsdWVBc051bWJlciBzZXR0ZXIgcmFpc2VzKERPTUV4Y2VwdGlvbik7Ci0jaWYgZGVm aW5lZChFTkFCTEVfREFUQUxJU1QpICYmIEVOQUJMRV9EQVRBTElTVAotICAgICAgICByZWFkb25s eSBhdHRyaWJ1dGUgSFRNTE9wdGlvbkVsZW1lbnQgc2VsZWN0ZWRPcHRpb247Ci0jZW5kaWYKKyAg ICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtDb25kaXRpb25hbD1EQVRBTElTVF0gSFRNTE9wdGlv bkVsZW1lbnQgc2VsZWN0ZWRPcHRpb247CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gYm9v bGVhbiBpbmNyZW1lbnRhbDsKIAogICAgICAgICB2b2lkIHN0ZXBVcChpbiBbT3B0aW9uYWxdIGxv bmcgbikgcmFpc2VzKERPTUV4Y2VwdGlvbik7CkBAIC0xMDUsMTEgKzk5LDkgQEAgbW9kdWxlIGh0 bWwgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRmlsZUxpc3QgZmlsZXM7CiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBOb2RlTGlzdCBsYWJlbHM7CiAKLSNpZiBkZWZpbmVkKEVOQUJM RV9JTlBVVF9TUEVFQ0gpICYmIEVOQUJMRV9JTlBVVF9TUEVFQ0gKLSAgICAgICAgYXR0cmlidXRl IFtSZWZsZWN0LCBFbmFibGVkQXRSdW50aW1lXSBib29sZWFuIHdlYmtpdFNwZWVjaDsKLSAgICAg ICAgYXR0cmlidXRlIFtSZWZsZWN0LCBFbmFibGVkQXRSdW50aW1lXSBib29sZWFuIHdlYmtpdEdy YW1tYXI7Ci0gICAgICAgIGF0dHJpYnV0ZSBbRG9udEVudW1dIEV2ZW50TGlzdGVuZXIgb253ZWJr aXRzcGVlY2hjaGFuZ2U7Ci0jZW5kaWYKKyAgICAgICAgYXR0cmlidXRlIFtDb25kaXRpb25hbD1J TlBVVF9TUEVFQ0gsIFJlZmxlY3QsIEVuYWJsZWRBdFJ1bnRpbWVdIGJvb2xlYW4gd2Via2l0U3Bl ZWNoOworICAgICAgICBhdHRyaWJ1dGUgW0NvbmRpdGlvbmFsPUlOUFVUX1NQRUVDSCwgUmVmbGVj dCwgRW5hYmxlZEF0UnVudGltZV0gYm9vbGVhbiB3ZWJraXRHcmFtbWFyOworICAgICAgICBhdHRy aWJ1dGUgW0NvbmRpdGlvbmFsPUlOUFVUX1NQRUVDSCwgRG9udEVudW1dIEV2ZW50TGlzdGVuZXIg b253ZWJraXRzcGVlY2hjaGFuZ2U7CiAgICAgfTsKIAogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5pZGwKaW5kZXggODAwY2QzZC4uNGJlMWVkMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaWRsCkBAIC04NSwxMCArODUsOCBAQCBtb2R1bGUgaHRt bCB7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gd2Via2l0SGFzQ2xvc2VkQ2FwdGlv bnM7CiAgICAgYXR0cmlidXRlIGJvb2xlYW4gd2Via2l0Q2xvc2VkQ2FwdGlvbnNWaXNpYmxlOwog Ci0jaWYgZGVmaW5lZChFTkFCTEVfTUVESUFfU1RBVElTVElDUykgJiYgRU5BQkxFX01FRElBX1NU QVRJU1RJQ1MKICAgICAvLyBUaGUgbnVtYmVyIG9mIGJ5dGVzIGNvbnN1bWVkIGJ5IHRoZSBtZWRp YSBkZWNvZGVyLgotICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBsb25nIHdlYmtpdEF1 ZGlvRGVjb2RlZEJ5dGVDb3VudDsKLSAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWduZWQgbG9u ZyB3ZWJraXRWaWRlb0RlY29kZWRCeXRlQ291bnQ7Ci0jZW5kaWYKKyAgICByZWFkb25seSBhdHRy aWJ1dGUgW0NvbmRpdGlvbmFsPU1FRElBX1NUQVRJU1RJQ1NdIHVuc2lnbmVkIGxvbmcgd2Via2l0 QXVkaW9EZWNvZGVkQnl0ZUNvdW50OworICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbQ29uZGl0aW9u YWw9TUVESUFfU1RBVElTVElDU10gdW5zaWduZWQgbG9uZyB3ZWJraXRWaWRlb0RlY29kZWRCeXRl Q291bnQ7CiB9OwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9F bGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFZpZGVvRWxlbWVudC5pZGwKaW5k ZXggZDM4ZmExMy4uMjQ2NzdmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M VmlkZW9FbGVtZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1l bnQuaWRsCkBAIC00NSwxNCArNDUsMTIgQEAgbW9kdWxlIGh0bWwgewogICAgICAgICB2b2lkIHdl YmtpdEVudGVyRnVsbFNjcmVlbigpIHJhaXNlcyAoRE9NRXhjZXB0aW9uKTsKICAgICAgICAgdm9p ZCB3ZWJraXRFeGl0RnVsbFNjcmVlbigpOwogCi0jaWYgZGVmaW5lZChFTkFCTEVfTUVESUFfU1RB VElTVElDUykgJiYgRU5BQkxFX01FRElBX1NUQVRJU1RJQ1MKICAgICAgICAgLy8gVGhlIG51bWJl ciBvZiBmcmFtZXMgdGhhdCBoYXZlIGJlZW4gZGVjb2RlZCBhbmQgbWFkZSBhdmFpbGFibGUgZm9y CiAgICAgICAgIC8vIHBsYXliYWNrLgotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgdW5zaWdu ZWQgbG9uZyB3ZWJraXREZWNvZGVkRnJhbWVDb3VudDsKKyAgICAgICAgcmVhZG9ubHkgYXR0cmli dXRlIFtDb25kaXRpb25hbD1NRURJQV9TVEFUSVNUSUNTXSB1bnNpZ25lZCBsb25nIHdlYmtpdERl Y29kZWRGcmFtZUNvdW50OwogCiAgICAgICAgIC8vIFRoZSBudW1iZXIgb2YgZGVjb2RlZCBmcmFt ZXMgdGhhdCBoYXZlIGJlZW4gZHJvcHBlZCBieSB0aGUgcGxheWVyCiAgICAgICAgIC8vIGZvciBw ZXJmb3JtYW5jZSByZWFzb25zIGR1cmluZyBwbGF5YmFjay4KLSAgICAgICAgcmVhZG9ubHkgYXR0 cmlidXRlIHVuc2lnbmVkIGxvbmcgd2Via2l0RHJvcHBlZEZyYW1lQ291bnQ7Ci0jZW5kaWYKKyAg ICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtDb25kaXRpb25hbD1NRURJQV9TVEFUSVNUSUNTXSB1 bnNpZ25lZCBsb25nIHdlYmtpdERyb3BwZWRGcmFtZUNvdW50OwogICAgIH07CiB9Cg==