64923 2011-07-20 21:27:33 -0700 [EFL] Defines header files will be publicly installed explicitly. 2011-07-28 21:53:24 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 kangil.han webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 440240 0 kangil.han 2011-07-20 21:27:33 -0700 Removes 'ewk_util.h' from public header list because it has been determined to internal purpose. 440242 1 kangil.han 2011-07-20 21:31:51 -0700 A method of defining open header list has been changed to an explicit manner. In addition, 'ewk/ewk_util.h' was deleted because API in this file has been determined to internal purposes. 440244 2 101553 kangil.han 2011-07-20 21:34:51 -0700 Created attachment 101553 Patch file I am attaching a patch file. Please review my patch. 440249 3 101553 gyuyoung.kim 2011-07-20 21:43:50 -0700 Comment on attachment 101553 Patch file LGTM. 440363 4 rakuco 2011-07-21 06:10:25 -0700 I don't see much need for changing how we specify which headers are installed -- either way, we still need to specify quite a few headers manually, but the code gets bigger if we explicitly list which files should be installed in opposition to listing which files should not be installed. > Source/WebKit/efl/ChangeLog:3 > + [EFL] A method of defining open header list has been changed This is *very* vague for a one-line description of the change. > Source/WebKit/efl/ChangeLog:6 > + A method of defining open header list has been changed to an explicit manner. You should explain why this has been done. 440908 5 101715 kangil.han 2011-07-22 05:03:28 -0700 Created attachment 101715 Patch file I think that addressing header list clearly one by one would be better to understand even though it needs little more lines in source code. Please review my patch. 440911 6 rakuco 2011-07-22 05:17:28 -0700 I'm still not convinced by the arguments you have presented. What if you move the private headers to a private/ directory inside ewk? I'd be OK with this and I think it should be explicitly enough for you too. > Source/WebKit/efl/ChangeLog:3 > + [EFL] A method of defining open header list has been changed to an explicit manner. That's not much in line with what I had in mind when I asked you to be less vague here. If one starts reading the ChangeLog file, this will probably make very little sense. What's an "open header", for a start? You should say something like "[EFL] Explicitly define which headers will be publicly installed". > Source/WebKit/efl/ChangeLog:7 > + different packages to clearly understand which header files contain publid API. publid -> public This would only help if people actually resorted to looking at the build system to check that (which means people working on webkit-efl itself, not people using it in other applications/packages), so this does not look very convincing. > Source/WebKit/efl/ChangeLog:9 > + modify cmake file by this change. OK, this is a more compelling argument, as people will probably add internal headers more frequently than public ones. Still, neither of kind of addition should be frequent enough to justify such change. > Source/WebKit/efl/ChangeLog:12 > + because API in this file has been determined to internal purposes. You could just say "Do not install ewk_util.h anymore, as it only has internal API". Plus, you need to adjust EWebKit.h accordingly. 440918 7 101721 kangil.han 2011-07-22 05:49:34 -0700 Created attachment 101721 Patch file Please review my patch file. 440921 8 rakuco 2011-07-22 05:56:07 -0700 I'd like to hear your answers to some suggestions and questions I raised in my previous comment, namely moving private headers to private/ and why I don't think the current patch will "improve the readability which files will be publicly installed". And EWebKit.h is still wrong. 441566 9 kangil.han 2011-07-24 23:56:24 -0700 Dear Raphael, Here are my answers. 1. Creating 'private' directory and moving files contain internal API seem good to me. However, I think this suggestion is improving my patch not a substitution. One my small concern about your idea is that there are no ports using 'private' directory. For example, GTK port locates '*private*' header files together with others. 2. I believe 'white-list' way is better than 'black-list'. At initial time, I only concentrated on removing 'ewk_util.h' file from installation. But, some of my colleagues suggested me to change a way to define open header list from 'black-list' to 'white-list' while internal code-review. I agreed with them because I thought 'white-list' way would reduce mistakes from developers especially newly joined people. This is because newly created header file without addressing in cmake won't affect system. As you mentioned, internal header files would be created more frequently and as a result, developers would not be irritated from inserting one line in cmake file. This is also an additional benefit from this patch. 3. You are right. 'EWebKit.h' is the file that developers, who want to implement stuff by using EWebkit, should know about. However, Including header correctly to 'EWebKit.h' should be precondition of my patch. Rather, my patch will remove internally used header files from installation. As you said, developers would read 'EWebKit.h' in most cases but I think installing internal header files to the system is not nice. I hope this helps your understanding. 441587 10 101721 ryuan.choi 2011-07-25 02:03:39 -0700 Comment on attachment 101721 Patch file View in context: https://bugs.webkit.org/attachment.cgi?id=101721&action=review > Source/WebKit/efl/CMakeListsEfl.txt:218 > +LIST(APPEND EWebKit_HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/EWebKit.h") Anyway, It's not good for me. you can use SET for these headers. SET(EWebKit_Headers EWebKit.h ... ewk_window_features.h ) 441590 11 kangil.han 2011-07-25 02:26:02 -0700 Okay Ryuan, I will fix it after I finish discuss with Raphael. 441686 12 rakuco 2011-07-25 09:13:08 -0700 (In reply to comment #9) > 1. Creating 'private' directory and moving files contain internal API seem good to me. However, I think this suggestion is improving my patch not a substitution. One my small concern about your idea is that there are no ports using 'private' directory. For example, GTK port locates '*private*' header files together with others. The layout is very port-dependent and should be up to each port's maintainers, so I don't think there should be any problem with doing so. > 2. I believe 'white-list' way is better than 'black-list'. > At initial time, I only concentrated on removing 'ewk_util.h' file from installation. > But, some of my colleagues suggested me to change a way to define open header list from 'black-list' to 'white-list' while internal code-review. I agreed with them because I thought 'white-list' way would reduce mistakes from developers especially newly joined people. This is because newly created header file without addressing in cmake won't affect system. As you mentioned, internal header files would be created more frequently and as a result, developers would not be irritated from inserting one line in cmake file. This is also an additional benefit from this patch. This is a valid point, I think we can go this way instead of arguing forever. > 3. You are right. 'EWebKit.h' is the file that developers, who want to implement stuff by using EWebkit, should know about. However, Including header correctly to 'EWebKit.h' should be precondition of my patch. Rather, my patch will remove internally used header files from installation. As you said, developers would read 'EWebKit.h' in most cases but I think installing internal header files to the system is not nice. That's not what I meant. What I'm saying is that EWebKit.h is still #including ewk_utils.h, which is not going to be installed anymore. 442135 13 kangil.han 2011-07-26 00:10:32 -0700 (In reply to comment #12) > The layout is very port-dependent and should be up to each port's maintainers, so I don't think there should be any problem with doing so. If so, I don't have any reason to disagree with you. Let's hear other developers opinion. > That's not what I meant. What I'm saying is that EWebKit.h is still #including ewk_utils.h, which is not going to be installed anymore. Sorry but I couldn't find 'ewk_util.h' in 'EWebKit.h'. 442189 14 rakuco 2011-07-26 05:39:19 -0700 (In reply to comment #13) > > That's not what I meant. What I'm saying is that EWebKit.h is still #including ewk_utils.h, which is not going to be installed anymore. > > Sorry but I couldn't find 'ewk_util.h' in 'EWebKit.h'. Oops, I was not looking at my upstream checkout, ewk_util.h is not included by EWebKit.h indeed. So r+ from my side after you follow Ryuan's suggestion. 442787 15 102106 kangil.han 2011-07-27 01:53:59 -0700 Created attachment 102106 Patch file Please review attached patch file. Please also leave opinion about creating 'private' directory for private source files in EFL port. 442792 16 ryuan.choi 2011-07-27 02:00:13 -0700 (In reply to comment #15) > Created an attachment (id=102106) [details] > Patch file > > Please review attached patch file. > Please also leave opinion about creating 'private' directory for private source files in EFL port. LGTM. 442906 17 rakuco 2011-07-27 06:43:21 -0700 > Please review attached patch file. LGTM. > Please also leave opinion about creating 'private' directory for private source files in EFL port. I'm all for it. 443351 18 kangil.han 2011-07-27 22:55:27 -0700 For creating 'private' directory for internally used source code, let's discuss in another bug because we can separate this idea from current patch. Dear Raphael, please create new bug. I am going to review this patch at this state. 443810 19 102106 webkit.review.bot 2011-07-28 21:53:19 -0700 Comment on attachment 102106 Patch file Clearing flags on attachment: 102106 Committed r91973: <http://trac.webkit.org/changeset/91973> 443811 20 webkit.review.bot 2011-07-28 21:53:24 -0700 All reviewed patches have been landed. Closing bug. 101553 2011-07-20 21:34:51 -0700 2011-07-22 05:00:49 -0700 Patch file patch.txt text/plain 2843 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBmZjFiNjJiLi45MjMzY2M4IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMjAgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtFRkxdIEEgbWV0aG9kIG9mIGRlZmluaW5nIG9wZW4gaGVhZGVy IGxpc3QgaGFzIGJlZW4gY2hhbmdlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NjQ5MjMKKworICAgICAgICBBIG1ldGhvZCBvZiBkZWZpbmluZyBvcGVu IGhlYWRlciBsaXN0IGhhcyBiZWVuIGNoYW5nZWQgdG8gYW4gZXhwbGljaXQgbWFubmVyLgorICAg ICAgICBJbiBhZGRpdGlvbiwgJ2V3ay9ld2tfdXRpbC5oJyB3YXMgZGVsZXRlZCBiZWNhdXNlIEFQ SSBpbiB0aGlzIGZpbGUgaGFzIGJlZW4gZGV0ZXJtaW5lZAorICAgICAgICB0byBpbnRlcm5hbCBw dXJwb3Nlcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIENNYWtlTGlzdHNFZmwudHh0OgorCiAyMDExLTA3LTE5ICBHeXV5b3VuZyBLaW0gIDxneXV5 b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQWRkIGV3a19uZXR3b3JrLmNw cHxoIGZpbGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50 eHQgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DTWFrZUxpc3RzRWZsLnR4dAppbmRleCAyY2U1MjM5Li5k YTg0YTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DTWFrZUxpc3RzRWZsLnR4dAor KysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DTWFrZUxpc3RzRWZsLnR4dApAQCAtMjE1LDE1ICsyMTUs MjEgQEAgSU5TVEFMTChGSUxFUyAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdC9lZmwvZXdlYmtp dC5wYwogCiBVTlNFVChMSUJTX1BSSVZBVEUpCiAKLUZJTEUoR0xPQiBFV2ViS2l0X0hFQURFUlMg IiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrLyouaCIpCi1MSVNUKFJFTU9WRV9J VEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2sv ZXdrX3ByaXZhdGUuaCIpCi1MSVNUKFJFTU9WRV9JVEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFL RV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3RpbGVkX3ByaXZhdGUuaCIpCi1MSVNU KFJFTU9WRV9JVEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9 L2VmbC9ld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuaCIpCi1MSVNUKFJFTU9WRV9JVEVNIEVX ZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3Rp bGVkX21hdHJpeC5oIikKLUxJU1QoUkVNT1ZFX0lURU0gRVdlYktpdF9IRUFERVJTICIke0NNQUtF X0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuaCIpCi0KLUlGIChO T1QgV1RGX1VTRV9TT1VQKQotICAgIExJU1QoUkVNT1ZFX0lURU0gRVdlYktpdF9IRUFERVJTICIk e0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfYXV0aF9zb3VwLmgiKQorTElT VChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZs L2V3ay9FV2ViS2l0LmgiKQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NV UlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfYXV0aC5oIikKK0xJU1QoQVBQRU5EIEVXZWJL aXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2NvbnRl eHRtZW51LmgiKQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRf U09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfY29va2llcy5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRf SEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2ZyYW1lLmgi KQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJ Un0vZWZsL2V3ay9ld2tfaGlzdG9yeS5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAi JHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2xvZ2dpbmcuaCIpCitMSVNU KEFQUEVORCBFV2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwv ZXdrL2V3a19tYWluLmgiKQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NV UlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfbmV0d29yay5oIikKK0xJU1QoQVBQRU5EIEVX ZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3Nl dHRpbmdzLmgiKQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRf U09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfdmlldy5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVB REVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3dpbmRvd19mZWF0 dXJlcy5oIikKKworSUYgKFdURl9VU0VfU09VUCkKKyAgICBMSVNUKEFQUEVORCBFV2ViS2l0X0hF QURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a19hdXRoX3NvdXAu aCIpCiBFTkRJRiAoKQogCiBJTlNUQUxMKEZJTEVTICR7RVdlYktpdF9IRUFERVJTfQo= 101715 2011-07-22 05:03:28 -0700 2011-07-22 05:48:49 -0700 Patch file patch.txt text/plain 3129 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBmZjFiNjJiLi44ZTRhY2MyIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMjAgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtFRkxdIEEgbWV0aG9kIG9mIGRlZmluaW5nIG9wZW4gaGVhZGVy IGxpc3QgaGFzIGJlZW4gY2hhbmdlZCB0byBhbiBleHBsaWNpdCBtYW5uZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDkyMworCisgICAgICAgIFRo aXMgY2hhbmdlIHdvdWxkIGhlbHAgZGV2ZWxvcGVycyB3b3JraW5nIG9uIEVXZWJLaXQgb3IgdXNp bmcgaXQgaW4KKyAgICAgICAgZGlmZmVyZW50IHBhY2thZ2VzIHRvIGNsZWFybHkgdW5kZXJzdGFu ZCB3aGljaCBoZWFkZXIgZmlsZXMgY29udGFpbiBwdWJsaWQgQVBJLgorICAgICAgICBJbiBhZGRp dGlvbiwgZGV2ZWxvcGVycyB3aG8gd2FudCB0byBhZGQgbmV3IGludGVybmFsIGhlYWRlciBmaWxl KHMpIGRvbid0IG5lZWQgdG8KKyAgICAgICAgbW9kaWZ5IGNtYWtlIGZpbGUgYnkgdGhpcyBjaGFu Z2UuCisgICAgICAgIFRoZXJlIGlzIG9uZSBtb3JlIG1vZGlmaWNhdGlvbi4KKyAgICAgICAgJ2V3 ay9ld2tfdXRpbC5oJyB3YXMgZGVsZXRlZCBmcm9tIG9wZW4gaGVhZGVyIGxpc3QKKyAgICAgICAg YmVjYXVzZSBBUEkgaW4gdGhpcyBmaWxlIGhhcyBiZWVuIGRldGVybWluZWQgdG8gaW50ZXJuYWwg cHVycG9zZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBDTWFrZUxpc3RzRWZsLnR4dDoKKwogMjAxMS0wNy0xOSAgR3l1eW91bmcgS2ltICA8Z3l1 eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEFkZCBld2tfbmV0d29yay5j cHB8aCBmaWxlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NNYWtlTGlzdHNFZmwu dHh0IGIvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50eHQKaW5kZXggMmNlNTIzOS4u ZGE4NGEwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50eHQK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50eHQKQEAgLTIxNSwxNSArMjE1 LDIxIEBAIElOU1RBTEwoRklMRVMgJHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQvZWZsL2V3ZWJr aXQucGMKIAogVU5TRVQoTElCU19QUklWQVRFKQogCi1GSUxFKEdMT0IgRVdlYktpdF9IRUFERVJT ICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay8qLmgiKQotTElTVChSRU1PVkVf SVRFTSBFV2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdr L2V3a19wcml2YXRlLmgiKQotTElTVChSRU1PVkVfSVRFTSBFV2ViS2l0X0hFQURFUlMgIiR7Q01B S0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a190aWxlZF9wcml2YXRlLmgiKQotTElT VChSRU1PVkVfSVRFTSBFV2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElS fS9lZmwvZXdrL2V3a190aWxlZF9iYWNraW5nX3N0b3JlLmgiKQotTElTVChSRU1PVkVfSVRFTSBF V2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a190 aWxlZF9tYXRyaXguaCIpCi1MSVNUKFJFTU9WRV9JVEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFL RV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmgiKQotCi1JRiAo Tk9UIFdURl9VU0VfU09VUCkKLSAgICBMSVNUKFJFTU9WRV9JVEVNIEVXZWJLaXRfSEVBREVSUyAi JHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2F1dGhfc291cC5oIikKK0xJ U1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2Vm bC9ld2svRVdlYktpdC5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9D VVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2F1dGguaCIpCitMSVNUKEFQUEVORCBFV2Vi S2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a19jb250 ZXh0bWVudS5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5U X1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2Nvb2tpZXMuaCIpCitMSVNUKEFQUEVORCBFV2ViS2l0 X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a19mcmFtZS5o IikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9E SVJ9L2VmbC9ld2svZXdrX2hpc3RvcnkuaCIpCitMSVNUKEFQUEVORCBFV2ViS2l0X0hFQURFUlMg IiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a19sb2dnaW5nLmgiKQorTElT VChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZs L2V3ay9ld2tfbWFpbi5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9D VVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX25ldHdvcmsuaCIpCitMSVNUKEFQUEVORCBF V2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a19z ZXR0aW5ncy5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5U X1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3ZpZXcuaCIpCitMSVNUKEFQUEVORCBFV2ViS2l0X0hF QURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a193aW5kb3dfZmVh dHVyZXMuaCIpCisKK0lGIChXVEZfVVNFX1NPVVApCisgICAgTElTVChBUFBFTkQgRVdlYktpdF9I RUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfYXV0aF9zb3Vw LmgiKQogRU5ESUYgKCkKIAogSU5TVEFMTChGSUxFUyAke0VXZWJLaXRfSEVBREVSU30K 101721 2011-07-22 05:49:34 -0700 2011-07-27 01:52:19 -0700 Patch file patch.txt text/plain 2951 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBmZjFiNjJiLi44NmMwNmQxIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDctMjAgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtFRkxdIERlZmluZXMgaGVhZGVyIGZpbGVzIHdpbGwgYmUgcHVi bGljbHkgaW5zdGFsbGVkIGV4cGxpY2l0bHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDkyMworCisgICAgICAgIFRoaXMgY2hhbmdlIHdvdWxkIGlt cHJvdmUgcmVhZGliaWxpdHkgd2hpY2ggZmlsZXMgd2lsbCBiZSBwdWJsaWNseSBpbnN0YWxsZWQu CisgICAgICAgIEluIGFkZGl0aW9uLCBkZXZlbG9wZXJzIHdobyB3YW50IHRvIGFkZCBuZXcgaW50 ZXJuYWwgaGVhZGVyIGZpbGUocykKKyAgICAgICAgZG9uJ3QgbmVlZCB0byBtb2RpZnkgY21ha2Ug ZmlsZSBieSB0aGlzIGNoYW5nZS4KKyAgICAgICAgUGx1cywgJ2V3ay9ld2tfdXRpbC5oJyB3aWxs IG5vdCBiZSBpbnN0YWxsZWQgYW55bW9yZSBiZWNhdXNlIGl0IG9ubHkgaGFzIGludGVybmFsIEFQ SS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENN YWtlTGlzdHNFZmwudHh0OgorCiAyMDExLTA3LTE5ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQWRkIGV3a19uZXR3b3JrLmNwcHxoIGZp bGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50eHQgYi9T b3VyY2UvV2ViS2l0L2VmbC9DTWFrZUxpc3RzRWZsLnR4dAppbmRleCAyY2U1MjM5Li5kYTg0YTBj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DTWFrZUxpc3RzRWZsLnR4dAorKysgYi9T b3VyY2UvV2ViS2l0L2VmbC9DTWFrZUxpc3RzRWZsLnR4dApAQCAtMjE1LDE1ICsyMTUsMjEgQEAg SU5TVEFMTChGSUxFUyAke0NNQUtFX0JJTkFSWV9ESVJ9L1dlYktpdC9lZmwvZXdlYmtpdC5wYwog CiBVTlNFVChMSUJTX1BSSVZBVEUpCiAKLUZJTEUoR0xPQiBFV2ViS2l0X0hFQURFUlMgIiR7Q01B S0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrLyouaCIpCi1MSVNUKFJFTU9WRV9JVEVNIEVX ZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3By aXZhdGUuaCIpCi1MSVNUKFJFTU9WRV9JVEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJS RU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3RpbGVkX3ByaXZhdGUuaCIpCi1MSVNUKFJFTU9W RV9JVEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9l d2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuaCIpCi1MSVNUKFJFTU9WRV9JVEVNIEVXZWJLaXRf SEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3RpbGVkX21h dHJpeC5oIikKLUxJU1QoUkVNT1ZFX0lURU0gRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJF TlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfdGlsZWRfbW9kZWwuaCIpCi0KLUlGIChOT1QgV1RG X1VTRV9TT1VQKQotICAgIExJU1QoUkVNT1ZFX0lURU0gRVdlYktpdF9IRUFERVJTICIke0NNQUtF X0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfYXV0aF9zb3VwLmgiKQorTElTVChBUFBF TkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9F V2ViS2l0LmgiKQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRf U09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfYXV0aC5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVB REVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2NvbnRleHRtZW51 LmgiKQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNF X0RJUn0vZWZsL2V3ay9ld2tfY29va2llcy5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVS UyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2ZyYW1lLmgiKQorTElT VChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZs L2V3ay9ld2tfaGlzdG9yeS5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFL RV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2xvZ2dpbmcuaCIpCitMSVNUKEFQUEVO RCBFV2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3 a19tYWluLmgiKQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRf U09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfbmV0d29yay5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRf SEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3NldHRpbmdz LmgiKQorTElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09VUkNF X0RJUn0vZWZsL2V3ay9ld2tfdmlldy5oIikKK0xJU1QoQVBQRU5EIEVXZWJLaXRfSEVBREVSUyAi JHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX3dpbmRvd19mZWF0dXJlcy5o IikKKworSUYgKFdURl9VU0VfU09VUCkKKyAgICBMSVNUKEFQUEVORCBFV2ViS2l0X0hFQURFUlMg IiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a19hdXRoX3NvdXAuaCIpCiBF TkRJRiAoKQogCiBJTlNUQUxMKEZJTEVTICR7RVdlYktpdF9IRUFERVJTfQo= 102106 2011-07-27 01:53:59 -0700 2011-07-28 21:53:19 -0700 Patch file patch.txt text/plain 2521 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBmZjFiNjJiLi41MDAxMGU2IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDctMjAgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtFRkxdIERlZmluZXMgaGVhZGVyIGZpbGVzIHdpbGwgYmUgcHVi bGljbHkgaW5zdGFsbGVkIGV4cGxpY2l0bHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02NDkyMworCisgICAgICAgIFRoaXMgcGF0Y2ggbW9kaWZpZXMg YSB3YXkgdG8gZGVmaW5lIG9wZW4gaGVhZGVyIGxpc3QgZnJvbSBibGFjay1saXN0IHRvIHdoaXRl LWxpc3QuCisgICAgICAgIFBsdXMsICdld2svZXdrX3V0aWwuaCcgd2lsbCBub3QgYmUgaW5zdGFs bGVkIGFueW1vcmUgYmVjYXVzZSBpdCBvbmx5IGhhcyBpbnRlcm5hbCBBUEkuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzRWZsLnR4 dDoKKwogMjAxMS0wNy0xOSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFtFRkxdIEFkZCBld2tfbmV0d29yay5jcHB8aCBmaWxlcy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NNYWtlTGlzdHNFZmwudHh0IGIvU291cmNlL1dlYktpdC9l ZmwvQ01ha2VMaXN0c0VmbC50eHQKaW5kZXggMmNlNTIzOS4uZjdkODU1YiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9lZmwvQ01ha2VMaXN0c0VmbC50eHQKKysrIGIvU291cmNlL1dlYktpdC9l ZmwvQ01ha2VMaXN0c0VmbC50eHQKQEAgLTIxNSwxNSArMjE1LDIzIEBAIElOU1RBTEwoRklMRVMg JHtDTUFLRV9CSU5BUllfRElSfS9XZWJLaXQvZWZsL2V3ZWJraXQucGMKIAogVU5TRVQoTElCU19Q UklWQVRFKQogCi1GSUxFKEdMT0IgRVdlYktpdF9IRUFERVJTICIke0NNQUtFX0NVUlJFTlRfU09V UkNFX0RJUn0vZWZsL2V3ay8qLmgiKQotTElTVChSRU1PVkVfSVRFTSBFV2ViS2l0X0hFQURFUlMg IiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a19wcml2YXRlLmgiKQotTElT VChSRU1PVkVfSVRFTSBFV2ViS2l0X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElS fS9lZmwvZXdrL2V3a190aWxlZF9wcml2YXRlLmgiKQotTElTVChSRU1PVkVfSVRFTSBFV2ViS2l0 X0hFQURFUlMgIiR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a190aWxlZF9i YWNraW5nX3N0b3JlLmgiKQotTElTVChSRU1PVkVfSVRFTSBFV2ViS2l0X0hFQURFUlMgIiR7Q01B S0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9lZmwvZXdrL2V3a190aWxlZF9tYXRyaXguaCIpCi1MSVNU KFJFTU9WRV9JVEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9 L2VmbC9ld2svZXdrX3RpbGVkX21vZGVsLmgiKQotCi1JRiAoTk9UIFdURl9VU0VfU09VUCkKLSAg ICBMSVNUKFJFTU9WRV9JVEVNIEVXZWJLaXRfSEVBREVSUyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJD RV9ESVJ9L2VmbC9ld2svZXdrX2F1dGhfc291cC5oIikKK1NFVChFV2ViS2l0X0hFQURFUlMKKyAg ICAke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9FV2ViS2l0LmgKKyAgICAke0NN QUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfYXV0aC5oCisgICAgJHtDTUFLRV9D VVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2NvbnRleHRtZW51LmgKKyAgICAke0NNQUtF X0NVUlJFTlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfY29va2llcy5oCisgICAgJHtDTUFLRV9D VVJSRU5UX1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2ZyYW1lLmgKKyAgICAke0NNQUtFX0NVUlJF TlRfU09VUkNFX0RJUn0vZWZsL2V3ay9ld2tfaGlzdG9yeS5oCisgICAgJHtDTUFLRV9DVVJSRU5U X1NPVVJDRV9ESVJ9L2VmbC9ld2svZXdrX2xvZ2dpbmcuaAorICAgICR7Q01BS0VfQ1VSUkVOVF9T T1VSQ0VfRElSfS9lZmwvZXdrL2V3a19tYWluLmgKKyAgICAke0NNQUtFX0NVUlJFTlRfU09VUkNF X0RJUn0vZWZsL2V3ay9ld2tfbmV0d29yay5oCisgICAgJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9E SVJ9L2VmbC9ld2svZXdrX3NldHRpbmdzLmgKKyAgICAke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJ Un0vZWZsL2V3ay9ld2tfdmlldy5oCisgICAgJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9L2Vm bC9ld2svZXdrX3dpbmRvd19mZWF0dXJlcy5oCispCisKK0lGIChXVEZfVVNFX1NPVVApCisgICAg TElTVChBUFBFTkQgRVdlYktpdF9IRUFERVJTICR7Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfS9l ZmwvZXdrL2V3a19hdXRoX3NvdXAuaCkKIEVORElGICgpCiAKIElOU1RBTEwoRklMRVMgJHtFV2Vi S2l0X0hFQURFUlN9Cg==