64919 2011-07-20 20:03:41 -0700 Remove remaining uses of CSSPrimitiveValue::computeLengthIntForLength() 2011-07-28 18:47:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson darin dglazkov hyatt macpherson simon.fraser webkit.review.bot oldest_to_newest 440216 0 macpherson 2011-07-20 20:03:41 -0700 Remove remaining uses of CSSPrimitiveValue::computeLengthIntForLength() 440234 1 101551 macpherson 2011-07-20 21:16:34 -0700 Created attachment 101551 Patch 441982 2 macpherson 2011-07-25 16:37:17 -0700 Ping! 443234 3 macpherson 2011-07-27 17:28:06 -0700 Been sitting here for over a week now. Adding dglazkov. 443244 4 101551 simon.fraser 2011-07-27 18:01:52 -0700 Comment on attachment 101551 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101551&action=review > Source/WebCore/css/CSSPrimitiveValue.cpp:279 > + // FIXME: Length.h no longer expects 28 bit integers, so these bounds should be INT_MAX and INT_MIN Why not fix that now? 443253 5 101551 macpherson 2011-07-27 18:18:58 -0700 Comment on attachment 101551 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101551&action=review >> Source/WebCore/css/CSSPrimitiveValue.cpp:279 >> + // FIXME: Length.h no longer expects 28 bit integers, so these bounds should be INT_MAX and INT_MIN > > Why not fix that now? Trying to avoid behavioral changes in this patch. Changing this will impact a lot of properties, and potentially breaks a number of tests. This comment is mostly about correcting the obsolete one above. 443738 6 101551 darin 2011-07-28 17:38:33 -0700 Comment on attachment 101551 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101551&action=review >>> Source/WebCore/css/CSSPrimitiveValue.cpp:279 >>> + // FIXME: Length.h no longer expects 28 bit integers, so these bounds should be INT_MAX and INT_MIN >> >> Why not fix that now? > > Trying to avoid behavioral changes in this patch. Changing this will impact a lot of properties, and potentially breaks a number of tests. This comment is mostly about correcting the obsolete one above. Probably the word is “could” rather than “should”. Also would be best to have a period instead. > Source/WebCore/platform/Length.h:97 > + void setQuirk(bool quirk) > + { > + m_quirk = quirk; > + } I find the name “quirk” puzzling for a boolean data member. A boolean is not a quirk. Not your fault, but really confusing. 443760 7 101551 webkit.review.bot 2011-07-28 18:47:04 -0700 Comment on attachment 101551 Patch Clearing flags on attachment: 101551 Committed r91969: <http://trac.webkit.org/changeset/91969> 443761 8 webkit.review.bot 2011-07-28 18:47:09 -0700 All reviewed patches have been landed. Closing bug. 101551 2011-07-20 21:16:34 -0700 2011-07-28 18:47:04 -0700 Patch bug-64919-20110721141631.patch text/plain 6210 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNDQxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDctMjAgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgcmVt YWluaW5nIHVzZXMgb2YgQ1NTUHJpbWl0aXZlVmFsdWU6OmNvbXB1dGVMZW5ndGhJbnRGb3JMZW5n dGgoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ5 MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBu ZXcgdGVzdHMgLyBjbGVhbnVwIG9ubHkuCisKKyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0aXZlVmFs dWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6OmNvbXB1dGVMZW5n dGgpOgorICAgICAgICBSZW1vdmUgaW1wbGVtZW50YXRpb24gb2YgY29tcHV0ZUxlbmd0aEludEZv ckxlbmd0aCgpCisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmg6CisgICAgICAgIFJl bW92ZSBkZWZpbml0aW9uIG9mIGNvbXB1dGVMZW5ndGhJbnRGb3JMZW5ndGgoKQorICAgICAgICAq IGNzcy9DU1NTdHlsZUFwcGx5UHJvcGVydHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwbHlQ cm9wZXJ0eUxlbmd0aDo6YXBwbHlWYWx1ZSk6CisgICAgICAgIFJlbW92ZSB1c2Ugb2YgY29tcHV0 ZUxlbmd0aEludEZvckxlbmd0aCgpCisgICAgICAgICogY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSk6Cisg ICAgICAgIFJlbW92ZSB1c2Ugb2YgY29tcHV0ZUxlbmd0aEludEZvckxlbmd0aCgpCisgICAgICAg ICogcGxhdGZvcm0vTGVuZ3RoLmg6CisgICAgICAgIChXZWJDb3JlOjpMZW5ndGg6OnNldFF1aXJr KToKKyAgICAgICAgQWRkcyB0aGUgYWJpbGl0eSB0byBzZXQgdGhlIG1fcXVpcmsgbWVtYmVyIHZh cmlhYmxlIGFmdGVyIGNvbnN0cnVjdGlvbi4KKwogMjAxMS0wNy0yMCAgUnlvc3VrZSBOaXdhICA8 cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgcjkxNDM1LgpJbmRl eDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCShyZXZpc2lvbiA5MTQz MykKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI3NCwxNiArMjc0LDEwIEBAIHRlbXBsYXRlPD4gaW50IENTU1ByaW1pdGl2ZVZh bHVlOjpjb21wdXQKICAgICByZXR1cm4gcm91bmRGb3JJbXByZWNpc2VDb252ZXJzaW9uPGludCwg SU5UX01BWCwgSU5UX01JTj4oY29tcHV0ZUxlbmd0aERvdWJsZShzdHlsZSwgcm9vdFN0eWxlLCBt dWx0aXBsaWVyLCBjb21wdXRpbmdGb250U2l6ZSkpOwogfQogCi0vLyBMZW5ndGhzIGV4cGVjdCBh biBpbnQgdGhhdCBpcyBvbmx5IDI4LWJpdHMsIHNvIHdlIGhhdmUgdG8gY2hlY2sgZm9yIGEKLS8v IGRpZmZlcmVudCBvdmVyZmxvdy4KLWludCBDU1NQcmltaXRpdmVWYWx1ZTo6Y29tcHV0ZUxlbmd0 aEludEZvckxlbmd0aChSZW5kZXJTdHlsZSogc3R5bGUsIFJlbmRlclN0eWxlKiByb290U3R5bGUs IGRvdWJsZSBtdWx0aXBsaWVyLCBib29sIGNvbXB1dGluZ0ZvbnRTaXplKQotewotICAgIHJldHVy biByb3VuZEZvckltcHJlY2lzZUNvbnZlcnNpb248aW50LCBpbnRNYXhGb3JMZW5ndGgsIGludE1p bkZvckxlbmd0aD4oY29tcHV0ZUxlbmd0aERvdWJsZShzdHlsZSwgcm9vdFN0eWxlLCBtdWx0aXBs aWVyLCBjb21wdXRpbmdGb250U2l6ZSkpOwotfQotCiB0ZW1wbGF0ZTw+IExlbmd0aCBDU1NQcmlt aXRpdmVWYWx1ZTo6Y29tcHV0ZUxlbmd0aChSZW5kZXJTdHlsZSogc3R5bGUsIFJlbmRlclN0eWxl KiByb290U3R5bGUsIGRvdWJsZSBtdWx0aXBsaWVyLCBib29sIGNvbXB1dGluZ0ZvbnRTaXplKQog ewotICAgIHJldHVybiBMZW5ndGgoY29tcHV0ZUxlbmd0aEludEZvckxlbmd0aChzdHlsZSwgcm9v dFN0eWxlLCBtdWx0aXBsaWVyLCBjb21wdXRpbmdGb250U2l6ZSksIEZpeGVkKTsKKyAgICAvLyBG SVhNRTogTGVuZ3RoLmggbm8gbG9uZ2VyIGV4cGVjdHMgMjggYml0IGludGVnZXJzLCBzbyB0aGVz ZSBib3VuZHMgc2hvdWxkIGJlIElOVF9NQVggYW5kIElOVF9NSU4KKyAgICByZXR1cm4gTGVuZ3Ro KHJvdW5kRm9ySW1wcmVjaXNlQ29udmVyc2lvbjxpbnQsIGludE1heEZvckxlbmd0aCwgaW50TWlu Rm9yTGVuZ3RoPihjb21wdXRlTGVuZ3RoRG91YmxlKHN0eWxlLCByb290U3R5bGUsIG11bHRpcGxp ZXIsIGNvbXB1dGluZ0ZvbnRTaXplKSksIEZpeGVkKTsKIH0KIAogdGVtcGxhdGU8PiBzaG9ydCBD U1NQcmltaXRpdmVWYWx1ZTo6Y29tcHV0ZUxlbmd0aChSZW5kZXJTdHlsZSogc3R5bGUsIFJlbmRl clN0eWxlKiByb290U3R5bGUsIGRvdWJsZSBtdWx0aXBsaWVyLCBib29sIGNvbXB1dGluZ0ZvbnRT aXplKQpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmgJKHJldmlzaW9u IDkxNDMzKQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmgJKHdvcmtp bmcgY29weSkKQEAgLTE0Niw3ICsxNDYsNiBAQCBwdWJsaWM6CiAgICAgICogYW5kIHNvbWUgdG9v bCB0byBjYWxpYnJhdGUuCiAgICAgICovCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gVCBjb21w dXRlTGVuZ3RoKFJlbmRlclN0eWxlKiBjdXJyU3R5bGUsIFJlbmRlclN0eWxlKiByb290U3R5bGUs IGRvdWJsZSBtdWx0aXBsaWVyID0gMS4wLCBib29sIGNvbXB1dGluZ0ZvbnRTaXplID0gZmFsc2Up OwotICAgIGludCBjb21wdXRlTGVuZ3RoSW50Rm9yTGVuZ3RoKFJlbmRlclN0eWxlKiBjdXJyU3R5 bGUsIFJlbmRlclN0eWxlKiByb290U3R5bGUsIGRvdWJsZSBtdWx0aXBsaWVyID0gMS4wLCBib29s IGNvbXB1dGluZ0ZvbnRTaXplID0gZmFsc2UpOwogCiAgICAgLy8gdXNlIHdpdGggY2FyZSEhIQog ICAgIHZvaWQgc2V0UHJpbWl0aXZlVHlwZSh1bnNpZ25lZCBzaG9ydCB0eXBlKSB7IG1fdHlwZSA9 IHR5cGU7IH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJvcGVydHku Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZUFwcGx5UHJvcGVy dHkuY3BwCShyZXZpc2lvbiA5MTQzMykKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZUFw cGx5UHJvcGVydHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjYsOSArMjY2LDExIEBAIHByaXZh dGU6CiAgICAgICAgICAgICBzZXRWYWx1ZShzZWxlY3Rvci0+c3R5bGUoKSwgTGVuZ3RoKCkpOwog ICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIGludCB0eXBlID0gcHJpbWl0aXZlVmFsdWUtPnBy aW1pdGl2ZVR5cGUoKTsKLSAgICAgICAgICAgIGlmIChDU1NQcmltaXRpdmVWYWx1ZTo6aXNVbml0 VHlwZUxlbmd0aCh0eXBlKSkKLSAgICAgICAgICAgICAgICBzZXRWYWx1ZShzZWxlY3Rvci0+c3R5 bGUoKSwgTGVuZ3RoKHByaW1pdGl2ZVZhbHVlLT5jb21wdXRlTGVuZ3RoSW50Rm9yTGVuZ3RoKHNl bGVjdG9yLT5zdHlsZSgpLCBzZWxlY3Rvci0+cm9vdEVsZW1lbnRTdHlsZSgpLCBzZWxlY3Rvci0+ c3R5bGUoKS0+ZWZmZWN0aXZlWm9vbSgpKSwgRml4ZWQsIHByaW1pdGl2ZVZhbHVlLT5pc1F1aXJr VmFsdWUoKSkpOwotICAgICAgICAgICAgZWxzZSBpZiAodHlwZSA9PSBDU1NQcmltaXRpdmVWYWx1 ZTo6Q1NTX1BFUkNFTlRBR0UpCisgICAgICAgICAgICBpZiAoQ1NTUHJpbWl0aXZlVmFsdWU6Omlz VW5pdFR5cGVMZW5ndGgodHlwZSkpIHsKKyAgICAgICAgICAgICAgICBMZW5ndGggbGVuZ3RoID0g cHJpbWl0aXZlVmFsdWUtPmNvbXB1dGVMZW5ndGg8TGVuZ3RoPihzZWxlY3Rvci0+c3R5bGUoKSwg c2VsZWN0b3ItPnJvb3RFbGVtZW50U3R5bGUoKSwgc2VsZWN0b3ItPnN0eWxlKCktPmVmZmVjdGl2 ZVpvb20oKSk7CisgICAgICAgICAgICAgICAgbGVuZ3RoLnNldFF1aXJrKHByaW1pdGl2ZVZhbHVl LT5pc1F1aXJrVmFsdWUoKSk7CisgICAgICAgICAgICAgICAgc2V0VmFsdWUoc2VsZWN0b3ItPnN0 eWxlKCksIGxlbmd0aCk7CisgICAgICAgICAgICB9IGVsc2UgaWYgKHR5cGUgPT0gQ1NTUHJpbWl0 aXZlVmFsdWU6OkNTU19QRVJDRU5UQUdFKQogICAgICAgICAgICAgICAgIHNldFZhbHVlKHNlbGVj dG9yLT5zdHlsZSgpLCBMZW5ndGgocHJpbWl0aXZlVmFsdWUtPmdldERvdWJsZVZhbHVlKCksIFBl cmNlbnQpKTsKICAgICAgICAgfQogICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT dHlsZVNlbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5 bGVTZWxlY3Rvci5jcHAJKHJldmlzaW9uIDkxNDMzKQorKysgU291cmNlL1dlYkNvcmUvY3NzL0NT U1N0eWxlU2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OTYwLDcgKzQ5NjAsNyBAQCB2 b2lkIENTU1N0eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkoaW50CiAgICAgICAgIGZsb2F0IHBl cnNwZWN0aXZlVmFsdWU7CiAgICAgICAgIGludCB0eXBlID0gcHJpbWl0aXZlVmFsdWUtPnByaW1p dGl2ZVR5cGUoKTsKICAgICAgICAgaWYgKENTU1ByaW1pdGl2ZVZhbHVlOjppc1VuaXRUeXBlTGVu Z3RoKHR5cGUpKQotICAgICAgICAgICAgcGVyc3BlY3RpdmVWYWx1ZSA9IHN0YXRpY19jYXN0PGZs b2F0PihwcmltaXRpdmVWYWx1ZS0+Y29tcHV0ZUxlbmd0aEludEZvckxlbmd0aChzdHlsZSgpLCBt X3Jvb3RFbGVtZW50U3R5bGUsIHpvb21GYWN0b3IpKTsKKyAgICAgICAgICAgIHBlcnNwZWN0aXZl VmFsdWUgPSBwcmltaXRpdmVWYWx1ZS0+Y29tcHV0ZUxlbmd0aDxmbG9hdD4oc3R5bGUoKSwgbV9y b290RWxlbWVudFN0eWxlLCB6b29tRmFjdG9yKTsKICAgICAgICAgZWxzZSBpZiAodHlwZSA9PSBD U1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUikgewogICAgICAgICAgICAgLy8gRm9yIGJhY2t3 YXJkIGNvbXBhdGliaWxpdHksIHRyZWF0IHZhbHVlbGVzcyBudW1iZXJzIGFzIHB4LgogICAgICAg ICAgICAgcGVyc3BlY3RpdmVWYWx1ZSA9IENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUocHJpbWl0 aXZlVmFsdWUtPmdldERvdWJsZVZhbHVlKCksIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfUFgpLT5j b21wdXRlTGVuZ3RoPGZsb2F0PihzdHlsZSgpLCBtX3Jvb3RFbGVtZW50U3R5bGUsIHpvb21GYWN0 b3IpOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoLmgJKHJldmlzaW9uIDkxNDMzKQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoLmgJKHdvcmtpbmcgY29weSkKQEAgLTkxLDYg KzkxLDExIEBAIHB1YmxpYzoKICAgICBMZW5ndGhUeXBlIHR5cGUoKSBjb25zdCB7IHJldHVybiBz dGF0aWNfY2FzdDxMZW5ndGhUeXBlPihtX3R5cGUpOyB9CiAgICAgYm9vbCBxdWlyaygpIGNvbnN0 IHsgcmV0dXJuIG1fcXVpcms7IH0KIAorICAgIHZvaWQgc2V0UXVpcmsoYm9vbCBxdWlyaykKKyAg ICB7CisgICAgICAgIG1fcXVpcmsgPSBxdWlyazsKKyAgICB9CisKICAgICB2b2lkIHNldFZhbHVl KExlbmd0aFR5cGUgdCwgaW50IHZhbHVlKQogICAgIHsKICAgICAgICAgbV90eXBlID0gdDsK