64916 2011-07-20 19:05:59 -0700 [Qt][WK2] Code cleanup for drag-and-drop 2011-07-21 06:39:53 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned kling webkit.review.bot oldest_to_newest 440186 0 yael 2011-07-20 19:05:59 -0700 After https://bugs.webkit.org/show_bug.cgi?id=60621, we can pass NULL bitmap handles, so remove the hack that was introduced in http://trac.webkit.org/changeset/89582. Also fix a typo introduced in http://trac.webkit.org/changeset/90458. A patch is coming. 440197 1 101544 yael 2011-07-20 19:23:46 -0700 Created attachment 101544 Patch 440361 2 101544 kling 2011-07-21 05:42:40 -0700 Comment on attachment 101544 Patch r=me 440375 3 101544 webkit.review.bot 2011-07-21 06:39:49 -0700 Comment on attachment 101544 Patch Clearing flags on attachment: 101544 Committed r91463: <http://trac.webkit.org/changeset/91463> 440376 4 webkit.review.bot 2011-07-21 06:39:53 -0700 All reviewed patches have been landed. Closing bug. 101544 2011-07-20 19:23:46 -0700 2011-07-21 06:39:49 -0700 Patch 64916.patch text/plain 4899 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxNDM4KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMDctMjAgIFlhZWwgQWhh cm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBDb2RlIGNs ZWFudXAgZm9yIGRyYWctYW5kLWRyb3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY0OTE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViUGFnZVByb3h5OjpzdGFydERyYWcpOgorICAgICAgICBBbGxvdyByZWNlaXZpbmcg YSBOVUxMIGJpdG1hcCBmcm9tIHRoZSB3ZWIgcHJvY2Vzcy4KKyAgICAgICAgCisgICAgICAgICog VUlQcm9jZXNzL3F0L3FkZXNrdG9wd2VicGFnZXByb3h5LmNwcDoKKyAgICAgICAgKFFEZXNrdG9w V2ViUGFnZVByb3h5OjpoYW5kbGVFdmVudCk6CisgICAgICAgIEZpeCB0eXBvIGludHJvZHVjZWQg aW4gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvOTA0NTguCisgICAgICAgIEFsbCBE bkQgcmVsYXRlZCBldmVudHMgc2hvdWxkIGJlIEdyYXBoaWNzU2NlbmUgZXZlbnRzLgorICAgICAg ICAKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L3F0L1dlYkRyYWdDbGllbnRR dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OmNvbnZlcnRRUGl4bWFwVG9TaGFyZWFibGVCaXRtYXAp OgorICAgICAgICBSZW1vdmUgaGFjayB0aGF0IGNyZWF0ZXMgYSAxeDEgYml0bWFwLgorICAgICAg ICBJdCBpcyBubyBsb25nZXIgbmVlZGVkIGFmdGVyIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hh bmdlc2V0LzkxMDE2LgorICAgICAgICAKKyAgICAgICAgKFdlYktpdDo6V2ViRHJhZ0NsaWVudDo6 c3RhcnREcmFnKToKKyAgICAgICAgQWxsb3cgc2VuZGluZyBhIE5VTEwgYml0bWFwIHRvIHRoZSBV SSBwcm9jZXNzLgorCiAyMDExLTA3LTIwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBw bGUuY29tPgogCiAgICAgICAgIFNjcm9sbGJhciBjb2xvciBoZXVyaXN0aWMgbmVlZHMgdG8gYmUg aG9va2VkIHVwIGluIFdlYktpdDEKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCShyZXZpc2lvbiA5MTQzMykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OTIsOSArODkyLDEyIEBAIHZv aWQgV2ViUGFnZVByb3h5OjpzdGFydERyYWdEcm9wKGNvbnN0IEkKICNpZiBQTEFURk9STShRVCkK IHZvaWQgV2ViUGFnZVByb3h5OjpzdGFydERyYWcoY29uc3QgRHJhZ0RhdGEmIGRyYWdEYXRhLCBj b25zdCBTaGFyZWFibGVCaXRtYXA6OkhhbmRsZSYgZHJhZ0ltYWdlSGFuZGxlKQogewotICAgIFJl ZlB0cjxTaGFyZWFibGVCaXRtYXA+IGRyYWdJbWFnZSA9IFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRl KGRyYWdJbWFnZUhhbmRsZSk7Ci0gICAgaWYgKCFkcmFnSW1hZ2UpCi0gICAgICAgIHJldHVybjsK KyAgICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBkcmFnSW1hZ2UgPSAwOworICAgIGlmICghZHJh Z0ltYWdlSGFuZGxlLmlzTnVsbCgpKSB7CisgICAgICAgIGRyYWdJbWFnZSA9IFNoYXJlYWJsZUJp dG1hcDo6Y3JlYXRlKGRyYWdJbWFnZUhhbmRsZSk7CisgICAgICAgIGlmICghZHJhZ0ltYWdlKQor ICAgICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIG1fcGFnZUNsaWVudC0+c3RhcnREcmFn KGRyYWdEYXRhLCBkcmFnSW1hZ2UucmVsZWFzZSgpKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9xZGVza3RvcHdlYnBhZ2Vwcm94eS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L3FkZXNrdG9wd2VicGFnZXByb3h5LmNwcAkocmV2aXNp b24gOTE0MzMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvcWRlc2t0b3B3ZWJwYWdl cHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MywxMyArOTMsMTMgQEAgYm9vbCBRRGVza3Rv cFdlYlBhZ2VQcm94eTo6aGFuZGxlRXZlbnQoUQogICAgICAgICByZXR1cm4gaGFuZGxlV2hlZWxF dmVudChyZWludGVycHJldF9jYXN0PFFHcmFwaGljc1NjZW5lV2hlZWxFdmVudCo+KGV2KSk7CiAg ICAgY2FzZSBRRXZlbnQ6OkdyYXBoaWNzU2NlbmVIb3Zlck1vdmU6CiAgICAgICAgIHJldHVybiBo YW5kbGVIb3Zlck1vdmVFdmVudChyZWludGVycHJldF9jYXN0PFFHcmFwaGljc1NjZW5lSG92ZXJF dmVudCo+KGV2KSk7Ci0gICAgY2FzZSBRRXZlbnQ6OkRyYWdFbnRlcjoKKyAgICBjYXNlIFFFdmVu dDo6R3JhcGhpY3NTY2VuZURyYWdFbnRlcjoKICAgICAgICAgcmV0dXJuIGhhbmRsZURyYWdFbnRl ckV2ZW50KHJlaW50ZXJwcmV0X2Nhc3Q8UUdyYXBoaWNzU2NlbmVEcmFnRHJvcEV2ZW50Kj4oZXYp KTsKLSAgICBjYXNlIFFFdmVudDo6RHJhZ0xlYXZlOgorICAgIGNhc2UgUUV2ZW50OjpHcmFwaGlj c1NjZW5lRHJhZ0xlYXZlOgogICAgICAgICByZXR1cm4gaGFuZGxlRHJhZ0xlYXZlRXZlbnQocmVp bnRlcnByZXRfY2FzdDxRR3JhcGhpY3NTY2VuZURyYWdEcm9wRXZlbnQqPihldikpOwotICAgIGNh c2UgUUV2ZW50OjpEcmFnTW92ZToKKyAgICBjYXNlIFFFdmVudDo6R3JhcGhpY3NTY2VuZURyYWdN b3ZlOgogICAgICAgICByZXR1cm4gaGFuZGxlRHJhZ01vdmVFdmVudChyZWludGVycHJldF9jYXN0 PFFHcmFwaGljc1NjZW5lRHJhZ0Ryb3BFdmVudCo+KGV2KSk7Ci0gICAgY2FzZSBRRXZlbnQ6OkRy b3A6CisgICAgY2FzZSBRRXZlbnQ6OkdyYXBoaWNzU2NlbmVEcm9wOgogICAgICAgICByZXR1cm4g aGFuZGxlRHJvcEV2ZW50KHJlaW50ZXJwcmV0X2Nhc3Q8UUdyYXBoaWNzU2NlbmVEcmFnRHJvcEV2 ZW50Kj4oZXYpKTsKICAgICB9CiAgICAgcmV0dXJuIFF0V2ViUGFnZVByb3h5OjpoYW5kbGVFdmVu dChldik7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L3F0 L1dlYkRyYWdDbGllbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJEcmFnQ2xpZW50UXQuY3BwCShyZXZpc2lvbiA5MTQz MykKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvcXQvV2ViRHJh Z0NsaWVudFF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsMTUgKzQwLDEzIEBAIG5hbWVzcGFj ZSBXZWJLaXQgewogCiBzdGF0aWMgUGFzc1JlZlB0cjxTaGFyZWFibGVCaXRtYXA+IGNvbnZlcnRR UGl4bWFwVG9TaGFyZWFibGVCaXRtYXAoUVBpeG1hcCogcGl4bWFwKQogewotICAgIC8vIEZJWE1F OiBXZSBuZWVkIHRoaXMgaGFjayB1bnRpbCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjA2MjEgaXMgZml4ZWQuCi0gICAgLy8gV2UgY2Fubm90IHBhc3MgYSBudWxsIGhh bmRsZSBzbyBjcmVhdGUgYSBwaXhtYXAgc2l6ZSAxeDEgYW5kIHNlbmQgdGhhdCBpbnN0ZWFkLgot ICAgIFFQaXhtYXAgcChRU2l6ZSgxLCAxKSk7Ci0gICAgaWYgKHBpeG1hcCkKLSAgICAgICAgcCA9 ICpwaXhtYXA7Ci0gICAgUmVmUHRyPFNoYXJlYWJsZUJpdG1hcD4gYml0bWFwID0gU2hhcmVhYmxl Qml0bWFwOjpjcmVhdGVTaGFyZWFibGUoSW50U2l6ZShwLnNpemUoKSksIFNoYXJlYWJsZUJpdG1h cDo6U3VwcG9ydHNBbHBoYSk7CisgICAgaWYgKCFwaXhtYXApCisgICAgICAgIHJldHVybiAwOwor CisgICAgUmVmUHRyPFNoYXJlYWJsZUJpdG1hcD4gYml0bWFwID0gU2hhcmVhYmxlQml0bWFwOjpj cmVhdGVTaGFyZWFibGUoSW50U2l6ZShwaXhtYXAtPnNpemUoKSksIFNoYXJlYWJsZUJpdG1hcDo6 U3VwcG9ydHNBbHBoYSk7CiAgICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dD4gZ3JhcGhpY3NDb250 ZXh0ID0gYml0bWFwLT5jcmVhdGVHcmFwaGljc0NvbnRleHQoKTsKIAotICAgIGdyYXBoaWNzQ29u dGV4dC0+cGxhdGZvcm1Db250ZXh0KCktPmRyYXdQaXhtYXAoMCwgMCwgcCk7CisgICAgZ3JhcGhp Y3NDb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+ZHJhd1BpeG1hcCgwLCAwLCAqcGl4bWFwKTsK ICAgICByZXR1cm4gYml0bWFwLnJlbGVhc2UoKTsKIH0KIApAQCAtNjEsNyArNTksNyBAQCB2b2lk IFdlYkRyYWdDbGllbnQ6OnN0YXJ0RHJhZyhEcmFnSW1hZ2VSCiAKICAgICBSZWZQdHI8U2hhcmVh YmxlQml0bWFwPiBiaXRtYXAgPSBjb252ZXJ0UVBpeG1hcFRvU2hhcmVhYmxlQml0bWFwKGRyYWdJ bWFnZSk7CiAgICAgU2hhcmVhYmxlQml0bWFwOjpIYW5kbGUgaGFuZGxlOwotICAgIGlmICghYml0 bWFwLT5jcmVhdGVIYW5kbGUoaGFuZGxlKSkKKyAgICBpZiAoYml0bWFwICYmICFiaXRtYXAtPmNy ZWF0ZUhhbmRsZShoYW5kbGUpKQogICAgICAgICByZXR1cm47CiAKICAgICBtX3BhZ2UtPnNlbmQo TWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6U3RhcnREcmFnKGRyYWdEYXRhLCBoYW5kbGUpKTsK