64914 2011-07-20 18:00:06 -0700 REGRESSION (r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use 2011-10-15 01:54:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 69168 69170 1 webkit.review.bot kling hyatt jamesr kling mitz pfeldman simon.fraser oldest_to_newest 440157 0 webkit.review.bot 2011-07-20 18:00:06 -0700 REGRESSION(82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use Requested by jamesr on #webkit. 440159 1 simon.fraser 2011-07-20 18:04:09 -0700 Dan says that bidiEmbeddingLevel has to be 6 bits, to comply with the Unicode standard. m_expansion is a count of pixels used for justification. Any fix for this bug should add compile-time asserts. 440162 2 jamesr 2011-07-20 18:05:11 -0700 http://trac.webkit.org/changeset/82611 added a bit to all InlineBoxes to optimize some overflow cases, but that also grew the number of bits stored at the end of InlineBox from 32 to 33. Due to alignment this costs extra memory, possibly an extra word, and probably also makes accessing m_expansion slower since it now occupies parts of 3 bytes instead of 2. This was a big speedup, so we should look for something else to save the space. According to https://bugs.webkit.org/show_bug.cgi?id=57178 we can delete 4 unused bits. That patch was rolled out due to some GTK accessibility crap depending on it, but that might be easy to fix. Does m_expansion have to be 11 bits? There might be other bits in here that aren't super helpful. It would be great to have compile time assertions on object size to avoid regressing the size of core objects like this in the future. 446599 3 simon.fraser 2011-08-04 10:25:15 -0700 *** Bug 65695 has been marked as a duplicate of this bug. *** 457936 4 kling 2011-08-27 05:25:42 -0700 (In reply to comment #2) > Does m_expansion have to be 11 bits? It used to be 12 bits, back when it was called m_toAdd. Then it was silently reduced to 11 bits in bug 46386. It's fairly trivial to create a document that will overflow this bitfield, whether it's 10 or 11 bits wide. Someone who knows more about text layout should comment though. 457937 5 105434 kling 2011-08-27 05:47:04 -0700 Created attachment 105434 Proposed patch 457938 6 105434 benjamin 2011-08-27 06:00:47 -0700 Comment on attachment 105434 Proposed patch Gosh, for an unused function, that is ridiculous. 457939 7 kling 2011-08-27 06:23:02 -0700 (In reply to comment #1) > Any fix for this bug should add compile-time asserts. What would be the best way of doing that? I could add something like: COMPILE_ASSERT(sizeof(InlineBox) == 56 || sizeof(InlineBox) == 32, SizeOfInlineBox); But that could break depending on compiler flags (struct packing, alignment, ...) 476246 8 109325 kling 2011-09-30 12:33:17 -0700 Created attachment 109325 Patch for landing (r=anttik) 476294 9 109325 webkit.review.bot 2011-09-30 13:48:32 -0700 Comment on attachment 109325 Patch for landing (r=anttik) Clearing flags on attachment: 109325 Committed r96422: <http://trac.webkit.org/changeset/96422> 476295 10 webkit.review.bot 2011-09-30 13:48:38 -0700 All reviewed patches have been landed. Closing bug. 476870 11 109461 kling 2011-10-03 03:43:28 -0700 Created attachment 109461 Speculative Win32 tweak for EWS. 476989 12 109488 kling 2011-10-03 08:35:19 -0700 Created attachment 109488 EWS Y U NO process this patch? Trying EWS again.. Also reopening bug since the patch was rolled out. 478273 13 kling 2011-10-05 04:40:32 -0700 Relanded in <http://trac.webkit.org/changeset/96693>. 484554 14 105434 abarth 2011-10-15 01:51:59 -0700 Comment on attachment 105434 Proposed patch Cleared Benjamin Poulain's review+ from obsolete attachment 105434 so that this bug does not appear in http://webkit.org/pending-commit. 105434 2011-08-27 05:47:04 -0700 2011-10-15 01:51:59 -0700 Proposed patch bug-64914.diff text/plain 3147 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1Y2Q0ZDEzLi4xNTQyZGQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDgtMjcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjgyNjExKTogSW5saW5lQm94IGhhcyAzMyBiaXRzIG9mIGJpdHNldCwg Y2F1c2luZyBhbGlnbm1lbnQgaXNzdWVzIGFuZCBleHRyYSBtZW1vcnkgdXNlLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ5MTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgSW5saW5lQm94Ojpw cmV2T25MaW5lRXhpc3RzKCkgYW5kIGl0cyB0d28gYWNjb21wYW55aW5nIGJpdGZpZWxkcworICAg ICAgICBzaW5jZSBub2JvZHkgaXMgdXNpbmcgdGhlbSBhbnltb3JlLiBuZXh0T25MaW5lRXhpc3Rz KCkgaXMgc3RpbGwgdXNlZCBieQorICAgICAgICBHVEsrIGFjY2Vzc2liaWxpdHkgY29kZS4KKwor ICAgICAgICAqIHJlbmRlcmluZy9JbmxpbmVCb3guY3BwOgorICAgICAgICAqIHJlbmRlcmluZy9J bmxpbmVCb3guaDoKKyAgICAgICAgKFdlYkNvcmU6OklubGluZUJveDo6SW5saW5lQm94KToKKwog MjAxMS0wOC0yNiAgWGlhb21laSBKaSAgPHhqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVn cmVzc2lvbig5MTc4OCk6IEJhZCBjYXN0IGluIFdlYkNvcmU6OmJsb2NrV2l0aE5leHRMaW5lQm94 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCmluZGV4IDhhODA0YjkuLmU5YTM2 NjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCkBAIC0yNjMsMjEgKzI2 Myw2IEBAIGJvb2wgSW5saW5lQm94OjpuZXh0T25MaW5lRXhpc3RzKCkgY29uc3QKICAgICByZXR1 cm4gbV9uZXh0T25MaW5lRXhpc3RzOwogfQogCi1ib29sIElubGluZUJveDo6cHJldk9uTGluZUV4 aXN0cygpIGNvbnN0Ci17Ci0gICAgaWYgKCFtX2RldGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMp IHsKLSAgICAgICAgbV9kZXRlcm1pbmVkSWZQcmV2T25MaW5lRXhpc3RzID0gdHJ1ZTsKLSAgICAg ICAgCi0gICAgICAgIGlmICghcGFyZW50KCkpCi0gICAgICAgICAgICBtX3ByZXZPbkxpbmVFeGlz dHMgPSBmYWxzZTsKLSAgICAgICAgZWxzZSBpZiAocHJldk9uTGluZSgpKQotICAgICAgICAgICAg bV9wcmV2T25MaW5lRXhpc3RzID0gdHJ1ZTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgbV9w cmV2T25MaW5lRXhpc3RzID0gcGFyZW50KCktPnByZXZPbkxpbmVFeGlzdHMoKTsKLSAgICB9Ci0g ICAgcmV0dXJuIG1fcHJldk9uTGluZUV4aXN0czsKLX0KLQogSW5saW5lQm94KiBJbmxpbmVCb3g6 Om5leHRMZWFmQ2hpbGQoKSBjb25zdAogewogICAgIElubGluZUJveCogbGVhZiA9IDA7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmggYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKaW5kZXggZTBhNmJmNi4uN2U5NzQ4ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUJveC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaApAQCAtNTYsOSArNTYsNyBAQCBwdWJsaWM6CiAg ICAgICAgICwgbV9kaXJPdmVycmlkZShmYWxzZSkKICAgICAgICAgLCBtX2lzVGV4dChmYWxzZSkK ICAgICAgICAgLCBtX2RldGVybWluZWRJZk5leHRPbkxpbmVFeGlzdHMoZmFsc2UpCi0gICAgICAg ICwgbV9kZXRlcm1pbmVkSWZQcmV2T25MaW5lRXhpc3RzKGZhbHNlKQogICAgICAgICAsIG1fbmV4 dE9uTGluZUV4aXN0cyhmYWxzZSkKLSAgICAgICAgLCBtX3ByZXZPbkxpbmVFeGlzdHMoZmFsc2Up CiAgICAgICAgICwgbV9leHBhbnNpb24oMCkKICNpZm5kZWYgTkRFQlVHCiAgICAgICAgICwgbV9o YXNCYWRQYXJlbnQoZmFsc2UpCkBAIC05MCw5ICs4OCw3IEBAIHB1YmxpYzoKICAgICAgICAgLCBt X2Rpck92ZXJyaWRlKGZhbHNlKQogICAgICAgICAsIG1faXNUZXh0KGZhbHNlKQogICAgICAgICAs IG1fZGV0ZXJtaW5lZElmTmV4dE9uTGluZUV4aXN0cyhmYWxzZSkKLSAgICAgICAgLCBtX2RldGVy bWluZWRJZlByZXZPbkxpbmVFeGlzdHMoZmFsc2UpCiAgICAgICAgICwgbV9uZXh0T25MaW5lRXhp c3RzKGZhbHNlKQotICAgICAgICAsIG1fcHJldk9uTGluZUV4aXN0cyhmYWxzZSkKICAgICAgICAg LCBtX2V4cGFuc2lvbigwKQogI2lmbmRlZiBOREVCVUcKICAgICAgICAgLCBtX2hhc0JhZFBhcmVu dChmYWxzZSkKQEAgLTIwMyw3ICsxOTksNiBAQCBwdWJsaWM6CiAgICAgICAgIG1fcHJldiA9IHBy ZXY7CiAgICAgfQogICAgIGJvb2wgbmV4dE9uTGluZUV4aXN0cygpIGNvbnN0OwotICAgIGJvb2wg cHJldk9uTGluZUV4aXN0cygpIGNvbnN0OwogCiAgICAgdmlydHVhbCBib29sIGlzTGVhZigpIGNv bnN0IHsgcmV0dXJuIHRydWU7IH0KICAgICAKQEAgLTM2NSw5ICszNjAsNyBAQCBwdWJsaWM6CiAg ICAgYm9vbCBtX2lzVGV4dCA6IDE7IC8vIFdoZXRoZXIgb3Igbm90IHRoaXMgb2JqZWN0IHJlcHJl c2VudHMgdGV4dCB3aXRoIGEgbm9uLXplcm8gaGVpZ2h0LiBJbmNsdWRlcyBub24taW1hZ2UgbGlz dCBtYXJrZXJzLCB0ZXh0IGJveGVzLgogcHJvdGVjdGVkOgogICAgIG11dGFibGUgYm9vbCBtX2Rl dGVybWluZWRJZk5leHRPbkxpbmVFeGlzdHMgOiAxOwotICAgIG11dGFibGUgYm9vbCBtX2RldGVy bWluZWRJZlByZXZPbkxpbmVFeGlzdHMgOiAxOwogICAgIG11dGFibGUgYm9vbCBtX25leHRPbkxp bmVFeGlzdHMgOiAxOwotICAgIG11dGFibGUgYm9vbCBtX3ByZXZPbkxpbmVFeGlzdHMgOiAxOwog ICAgIHNpZ25lZCBtX2V4cGFuc2lvbiA6IDExOyAvLyBmb3IganVzdGlmaWVkIHRleHQKIAogI2lm bmRlZiBOREVCVUcK 109325 2011-09-30 12:33:17 -0700 2011-10-03 03:43:28 -0700 Patch for landing (r=anttik) bug-64914-v2.diff text/plain 3744 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MmM2Y2U4Li5mOTBmOTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDktMzAgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjgyNjExKSBJbmxpbmVCb3ggaGFzIDMzIGJpdHMgb2YgYml0c2V0LCBj YXVzaW5nIGFsaWdubWVudCBpc3N1ZXMgYW5kIGV4dHJhIG1lbW9yeSB1c2UuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDkxNAorCisgICAgICAgIFJl dmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgorCisgICAgICAgIFJlbW92ZSBJbmxpbmVCb3g6OnBy ZXZPbkxpbmVFeGlzdHMoKSBhbmQgaXRzIHR3byBhY2NvbXBhbnlpbmcgYml0ZmllbGRzCisgICAg ICAgIHNpbmNlIG5vYm9keSBpcyB1c2luZyB0aGVtIGFueW1vcmUuIG5leHRPbkxpbmVFeGlzdHMo KSBpcyBzdGlsbCB1c2VkIGJ5CisgICAgICAgIEdUSysgYWNjZXNzaWJpbGl0eSBjb2RlLgorCisg ICAgICAgIEFsc28gYWRkZWQgYSBjb21waWxlLXRpbWUgYXNzZXJ0aW9uIHRvIGd1YXJkIGFnYWlu c3QgZnV0dXJlIGJsb2F0aW5nIG9mCisgICAgICAgIHRoZSBJbmxpbmVCb3ggY2xhc3MuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvSW5saW5lQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNhbWVT aXplQXNJbmxpbmVCb3g6On5TYW1lU2l6ZUFzSW5saW5lQm94KToKKyAgICAgICAgKiByZW5kZXJp bmcvSW5saW5lQm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVCb3g6OklubGluZUJveCk6 CisKIDIwMTEtMDktMjkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmVtb3ZlIGRpcmVjdCByZWFkcyB0byBtX2ZpcnN0Tm9kZUluc2VydGVkIGFuZCBtX2xhc3RM ZWFmSW5zZXJ0ZWQgaW4gUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL0lubGluZUJveC5jcHAKaW5kZXggMmVkYTQwMi4uMThlOWExYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0lubGluZUJveC5jcHAKQEAgLTM0LDYgKzM0LDE5IEBACiB1c2luZyBuYW1lc3Bh Y2Ugc3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CisKK2NsYXNzIFNhbWVTaXplQXNJbmxpbmVC b3ggeworICAgIHZpcnR1YWwgflNhbWVTaXplQXNJbmxpbmVCb3goKSB7IH0KKyAgICB2b2lkKiBh WzRdOworICAgIEZsb2F0UG9pbnQgYjsKKyAgICBmbG9hdCBjOworICAgIHVpbnQzMl90IGQ7Cisj aWZuZGVmIE5ERUJVRworICAgIGJvb2wgZTsKKyNlbmRpZgorfTsKKworQ09NUElMRV9BU1NFUlQo c2l6ZW9mKElubGluZUJveCkgPT0gc2l6ZW9mKFNhbWVTaXplQXNJbmxpbmVCb3gpLCBJbmxpbmVC b3hfc2l6ZV9ndWFyZCk7CiAgICAgCiAjaWZuZGVmIE5ERUJVRwogc3RhdGljIGJvb2wgaW5Jbmxp bmVCb3hEZXRhY2g7CkBAIC0yNTgsMjEgKzI3MSw2IEBAIGJvb2wgSW5saW5lQm94OjpuZXh0T25M aW5lRXhpc3RzKCkgY29uc3QKICAgICByZXR1cm4gbV9uZXh0T25MaW5lRXhpc3RzOwogfQogCi1i b29sIElubGluZUJveDo6cHJldk9uTGluZUV4aXN0cygpIGNvbnN0Ci17Ci0gICAgaWYgKCFtX2Rl dGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMpIHsKLSAgICAgICAgbV9kZXRlcm1pbmVkSWZQcmV2 T25MaW5lRXhpc3RzID0gdHJ1ZTsKLSAgICAgICAgCi0gICAgICAgIGlmICghcGFyZW50KCkpCi0g ICAgICAgICAgICBtX3ByZXZPbkxpbmVFeGlzdHMgPSBmYWxzZTsKLSAgICAgICAgZWxzZSBpZiAo cHJldk9uTGluZSgpKQotICAgICAgICAgICAgbV9wcmV2T25MaW5lRXhpc3RzID0gdHJ1ZTsKLSAg ICAgICAgZWxzZQotICAgICAgICAgICAgbV9wcmV2T25MaW5lRXhpc3RzID0gcGFyZW50KCktPnBy ZXZPbkxpbmVFeGlzdHMoKTsKLSAgICB9Ci0gICAgcmV0dXJuIG1fcHJldk9uTGluZUV4aXN0czsK LX0KLQogSW5saW5lQm94KiBJbmxpbmVCb3g6Om5leHRMZWFmQ2hpbGQoKSBjb25zdAogewogICAg IElubGluZUJveCogbGVhZiA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvSW5saW5lQm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKaW5k ZXggY2Y2ZGE1Ni4uM2Y1ZDEyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L0lubGluZUJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaApA QCAtNTYsOSArNTYsNyBAQCBwdWJsaWM6CiAgICAgICAgICwgbV9kaXJPdmVycmlkZShmYWxzZSkK ICAgICAgICAgLCBtX2lzVGV4dChmYWxzZSkKICAgICAgICAgLCBtX2RldGVybWluZWRJZk5leHRP bkxpbmVFeGlzdHMoZmFsc2UpCi0gICAgICAgICwgbV9kZXRlcm1pbmVkSWZQcmV2T25MaW5lRXhp c3RzKGZhbHNlKQogICAgICAgICAsIG1fbmV4dE9uTGluZUV4aXN0cyhmYWxzZSkKLSAgICAgICAg LCBtX3ByZXZPbkxpbmVFeGlzdHMoZmFsc2UpCiAgICAgICAgICwgbV9leHBhbnNpb24oMCkKICNp Zm5kZWYgTkRFQlVHCiAgICAgICAgICwgbV9oYXNCYWRQYXJlbnQoZmFsc2UpCkBAIC05MCw5ICs4 OCw3IEBAIHB1YmxpYzoKICAgICAgICAgLCBtX2Rpck92ZXJyaWRlKGZhbHNlKQogICAgICAgICAs IG1faXNUZXh0KGZhbHNlKQogICAgICAgICAsIG1fZGV0ZXJtaW5lZElmTmV4dE9uTGluZUV4aXN0 cyhmYWxzZSkKLSAgICAgICAgLCBtX2RldGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMoZmFsc2Up CiAgICAgICAgICwgbV9uZXh0T25MaW5lRXhpc3RzKGZhbHNlKQotICAgICAgICAsIG1fcHJldk9u TGluZUV4aXN0cyhmYWxzZSkKICAgICAgICAgLCBtX2V4cGFuc2lvbigwKQogI2lmbmRlZiBOREVC VUcKICAgICAgICAgLCBtX2hhc0JhZFBhcmVudChmYWxzZSkKQEAgLTIwMyw3ICsxOTksNiBAQCBw dWJsaWM6CiAgICAgICAgIG1fcHJldiA9IHByZXY7CiAgICAgfQogICAgIGJvb2wgbmV4dE9uTGlu ZUV4aXN0cygpIGNvbnN0OwotICAgIGJvb2wgcHJldk9uTGluZUV4aXN0cygpIGNvbnN0OwogCiAg ICAgdmlydHVhbCBib29sIGlzTGVhZigpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KICAgICAKQEAg LTM2NCw5ICszNTksNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBtX2lzVGV4dCA6IDE7IC8vIFdoZXRo ZXIgb3Igbm90IHRoaXMgb2JqZWN0IHJlcHJlc2VudHMgdGV4dCB3aXRoIGEgbm9uLXplcm8gaGVp Z2h0LiBJbmNsdWRlcyBub24taW1hZ2UgbGlzdCBtYXJrZXJzLCB0ZXh0IGJveGVzLgogcHJvdGVj dGVkOgogICAgIG11dGFibGUgYm9vbCBtX2RldGVybWluZWRJZk5leHRPbkxpbmVFeGlzdHMgOiAx OwotICAgIG11dGFibGUgYm9vbCBtX2RldGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMgOiAxOwog ICAgIG11dGFibGUgYm9vbCBtX25leHRPbkxpbmVFeGlzdHMgOiAxOwotICAgIG11dGFibGUgYm9v bCBtX3ByZXZPbkxpbmVFeGlzdHMgOiAxOwogICAgIHNpZ25lZCBtX2V4cGFuc2lvbiA6IDExOyAv LyBmb3IganVzdGlmaWVkIHRleHQKIAogI2lmbmRlZiBOREVCVUcK 109461 2011-10-03 03:43:28 -0700 2011-10-03 08:35:19 -0700 Speculative Win32 tweak for EWS. bug-64914-v3.diff text/plain 3767 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ODQ4ZWVkLi5hZmQxNzA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMTAtMDMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjgyNjExKSBJbmxpbmVCb3ggaGFzIDMzIGJpdHMgb2YgYml0c2V0LCBj YXVzaW5nIGFsaWdubWVudCBpc3N1ZXMgYW5kIGV4dHJhIG1lbW9yeSB1c2UuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDkxNAorCisgICAgICAgIFJl dmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgorCisgICAgICAgIFJlbW92ZSBJbmxpbmVCb3g6OnBy ZXZPbkxpbmVFeGlzdHMoKSBhbmQgaXRzIHR3byBhY2NvbXBhbnlpbmcgYml0ZmllbGRzCisgICAg ICAgIHNpbmNlIG5vYm9keSBpcyB1c2luZyB0aGVtIGFueW1vcmUuIG5leHRPbkxpbmVFeGlzdHMo KSBpcyBzdGlsbCB1c2VkIGJ5CisgICAgICAgIEdUSysgYWNjZXNzaWJpbGl0eSBjb2RlLgorCisg ICAgICAgIEFsc28gYWRkZWQgYSBjb21waWxlLXRpbWUgYXNzZXJ0aW9uIHRvIGd1YXJkIGFnYWlu c3QgZnV0dXJlIGJsb2F0aW5nIG9mCisgICAgICAgIHRoZSBJbmxpbmVCb3ggY2xhc3MuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvSW5saW5lQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNhbWVT aXplQXNJbmxpbmVCb3g6On5TYW1lU2l6ZUFzSW5saW5lQm94KToKKyAgICAgICAgKiByZW5kZXJp bmcvSW5saW5lQm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVCb3g6OklubGluZUJveCk6 CisKIDIwMTEtMTAtMDMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IG1vdmUgY29uc29sZSBtZXNzYWdlIGZvcm1hdHRpbmcgZnJv bSBDb25zb2xlVmlldy5qcyBpbnRvIENvbnNvbGVNZXNzYWdlLmpzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9JbmxpbmVCb3guY3BwCmluZGV4IDJlZGE0MDIuLmMyZGU3ZGUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCkBAIC0zNCw2ICszNCwyMCBAQAogdXNpbmcgbmFtZXNw YWNlIHN0ZDsKIAogbmFtZXNwYWNlIFdlYkNvcmUgeworCitjbGFzcyBTYW1lU2l6ZUFzSW5saW5l Qm94IHsKKyAgICB2aXJ0dWFsIH5TYW1lU2l6ZUFzSW5saW5lQm94KCkgeyB9CisgICAgdm9pZCog YVs0XTsKKyAgICBGbG9hdFBvaW50IGI7CisgICAgZmxvYXQgYzsKKyAgICB1aW50MzJfdCBkIDog MzE7CisgICAgYm9vbCBlIDogMTsKKyNpZm5kZWYgTkRFQlVHCisgICAgYm9vbCBmOworI2VuZGlm Cit9OworCitDT01QSUxFX0FTU0VSVChzaXplb2YoSW5saW5lQm94KSA9PSBzaXplb2YoU2FtZVNp emVBc0lubGluZUJveCksIElubGluZUJveF9zaXplX2d1YXJkKTsKICAgICAKICNpZm5kZWYgTkRF QlVHCiBzdGF0aWMgYm9vbCBpbklubGluZUJveERldGFjaDsKQEAgLTI1OCwyMSArMjcyLDYgQEAg Ym9vbCBJbmxpbmVCb3g6Om5leHRPbkxpbmVFeGlzdHMoKSBjb25zdAogICAgIHJldHVybiBtX25l eHRPbkxpbmVFeGlzdHM7CiB9CiAKLWJvb2wgSW5saW5lQm94OjpwcmV2T25MaW5lRXhpc3RzKCkg Y29uc3QKLXsKLSAgICBpZiAoIW1fZGV0ZXJtaW5lZElmUHJldk9uTGluZUV4aXN0cykgewotICAg ICAgICBtX2RldGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMgPSB0cnVlOwotICAgICAgICAKLSAg ICAgICAgaWYgKCFwYXJlbnQoKSkKLSAgICAgICAgICAgIG1fcHJldk9uTGluZUV4aXN0cyA9IGZh bHNlOwotICAgICAgICBlbHNlIGlmIChwcmV2T25MaW5lKCkpCi0gICAgICAgICAgICBtX3ByZXZP bkxpbmVFeGlzdHMgPSB0cnVlOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBtX3ByZXZPbkxp bmVFeGlzdHMgPSBwYXJlbnQoKS0+cHJldk9uTGluZUV4aXN0cygpOwotICAgIH0KLSAgICByZXR1 cm4gbV9wcmV2T25MaW5lRXhpc3RzOwotfQotCiBJbmxpbmVCb3gqIElubGluZUJveDo6bmV4dExl YWZDaGlsZCgpIGNvbnN0CiB7CiAgICAgSW5saW5lQm94KiBsZWFmID0gMDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9JbmxpbmVCb3guaAppbmRleCBjZjZkYTU2Li4zZjVkMTI4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0lubGluZUJveC5oCkBAIC01Niw5ICs1Niw3IEBAIHB1YmxpYzoKICAgICAgICAg LCBtX2Rpck92ZXJyaWRlKGZhbHNlKQogICAgICAgICAsIG1faXNUZXh0KGZhbHNlKQogICAgICAg ICAsIG1fZGV0ZXJtaW5lZElmTmV4dE9uTGluZUV4aXN0cyhmYWxzZSkKLSAgICAgICAgLCBtX2Rl dGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMoZmFsc2UpCiAgICAgICAgICwgbV9uZXh0T25MaW5l RXhpc3RzKGZhbHNlKQotICAgICAgICAsIG1fcHJldk9uTGluZUV4aXN0cyhmYWxzZSkKICAgICAg ICAgLCBtX2V4cGFuc2lvbigwKQogI2lmbmRlZiBOREVCVUcKICAgICAgICAgLCBtX2hhc0JhZFBh cmVudChmYWxzZSkKQEAgLTkwLDkgKzg4LDcgQEAgcHVibGljOgogICAgICAgICAsIG1fZGlyT3Zl cnJpZGUoZmFsc2UpCiAgICAgICAgICwgbV9pc1RleHQoZmFsc2UpCiAgICAgICAgICwgbV9kZXRl cm1pbmVkSWZOZXh0T25MaW5lRXhpc3RzKGZhbHNlKQotICAgICAgICAsIG1fZGV0ZXJtaW5lZElm UHJldk9uTGluZUV4aXN0cyhmYWxzZSkKICAgICAgICAgLCBtX25leHRPbkxpbmVFeGlzdHMoZmFs c2UpCi0gICAgICAgICwgbV9wcmV2T25MaW5lRXhpc3RzKGZhbHNlKQogICAgICAgICAsIG1fZXhw YW5zaW9uKDApCiAjaWZuZGVmIE5ERUJVRwogICAgICAgICAsIG1faGFzQmFkUGFyZW50KGZhbHNl KQpAQCAtMjAzLDcgKzE5OSw2IEBAIHB1YmxpYzoKICAgICAgICAgbV9wcmV2ID0gcHJldjsKICAg ICB9CiAgICAgYm9vbCBuZXh0T25MaW5lRXhpc3RzKCkgY29uc3Q7Ci0gICAgYm9vbCBwcmV2T25M aW5lRXhpc3RzKCkgY29uc3Q7CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNMZWFmKCkgY29uc3QgeyBy ZXR1cm4gdHJ1ZTsgfQogICAgIApAQCAtMzY0LDkgKzM1OSw3IEBAIHB1YmxpYzoKICAgICBib29s IG1faXNUZXh0IDogMTsgLy8gV2hldGhlciBvciBub3QgdGhpcyBvYmplY3QgcmVwcmVzZW50cyB0 ZXh0IHdpdGggYSBub24temVybyBoZWlnaHQuIEluY2x1ZGVzIG5vbi1pbWFnZSBsaXN0IG1hcmtl cnMsIHRleHQgYm94ZXMuCiBwcm90ZWN0ZWQ6CiAgICAgbXV0YWJsZSBib29sIG1fZGV0ZXJtaW5l ZElmTmV4dE9uTGluZUV4aXN0cyA6IDE7Ci0gICAgbXV0YWJsZSBib29sIG1fZGV0ZXJtaW5lZElm UHJldk9uTGluZUV4aXN0cyA6IDE7CiAgICAgbXV0YWJsZSBib29sIG1fbmV4dE9uTGluZUV4aXN0 cyA6IDE7Ci0gICAgbXV0YWJsZSBib29sIG1fcHJldk9uTGluZUV4aXN0cyA6IDE7CiAgICAgc2ln bmVkIG1fZXhwYW5zaW9uIDogMTE7IC8vIGZvciBqdXN0aWZpZWQgdGV4dAogCiAjaWZuZGVmIE5E RUJVRwo= 109488 2011-10-03 08:35:19 -0700 2011-10-03 08:35:19 -0700 EWS Y U NO process this patch? bug-64914-v3.diff text/plain 3767 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ODQ4ZWVkLi5hZmQxNzA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMTAtMDMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjgyNjExKSBJbmxpbmVCb3ggaGFzIDMzIGJpdHMgb2YgYml0c2V0LCBj YXVzaW5nIGFsaWdubWVudCBpc3N1ZXMgYW5kIGV4dHJhIG1lbW9yeSB1c2UuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NDkxNAorCisgICAgICAgIFJl dmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgorCisgICAgICAgIFJlbW92ZSBJbmxpbmVCb3g6OnBy ZXZPbkxpbmVFeGlzdHMoKSBhbmQgaXRzIHR3byBhY2NvbXBhbnlpbmcgYml0ZmllbGRzCisgICAg ICAgIHNpbmNlIG5vYm9keSBpcyB1c2luZyB0aGVtIGFueW1vcmUuIG5leHRPbkxpbmVFeGlzdHMo KSBpcyBzdGlsbCB1c2VkIGJ5CisgICAgICAgIEdUSysgYWNjZXNzaWJpbGl0eSBjb2RlLgorCisg ICAgICAgIEFsc28gYWRkZWQgYSBjb21waWxlLXRpbWUgYXNzZXJ0aW9uIHRvIGd1YXJkIGFnYWlu c3QgZnV0dXJlIGJsb2F0aW5nIG9mCisgICAgICAgIHRoZSBJbmxpbmVCb3ggY2xhc3MuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvSW5saW5lQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNhbWVT aXplQXNJbmxpbmVCb3g6On5TYW1lU2l6ZUFzSW5saW5lQm94KToKKyAgICAgICAgKiByZW5kZXJp bmcvSW5saW5lQm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVCb3g6OklubGluZUJveCk6 CisKIDIwMTEtMTAtMDMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBnb29nbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IG1vdmUgY29uc29sZSBtZXNzYWdlIGZvcm1hdHRpbmcgZnJv bSBDb25zb2xlVmlldy5qcyBpbnRvIENvbnNvbGVNZXNzYWdlLmpzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9JbmxpbmVCb3guY3BwCmluZGV4IDJlZGE0MDIuLmMyZGU3ZGUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCkBAIC0zNCw2ICszNCwyMCBAQAogdXNpbmcgbmFtZXNw YWNlIHN0ZDsKIAogbmFtZXNwYWNlIFdlYkNvcmUgeworCitjbGFzcyBTYW1lU2l6ZUFzSW5saW5l Qm94IHsKKyAgICB2aXJ0dWFsIH5TYW1lU2l6ZUFzSW5saW5lQm94KCkgeyB9CisgICAgdm9pZCog YVs0XTsKKyAgICBGbG9hdFBvaW50IGI7CisgICAgZmxvYXQgYzsKKyAgICB1aW50MzJfdCBkIDog MzE7CisgICAgYm9vbCBlIDogMTsKKyNpZm5kZWYgTkRFQlVHCisgICAgYm9vbCBmOworI2VuZGlm Cit9OworCitDT01QSUxFX0FTU0VSVChzaXplb2YoSW5saW5lQm94KSA9PSBzaXplb2YoU2FtZVNp emVBc0lubGluZUJveCksIElubGluZUJveF9zaXplX2d1YXJkKTsKICAgICAKICNpZm5kZWYgTkRF QlVHCiBzdGF0aWMgYm9vbCBpbklubGluZUJveERldGFjaDsKQEAgLTI1OCwyMSArMjcyLDYgQEAg Ym9vbCBJbmxpbmVCb3g6Om5leHRPbkxpbmVFeGlzdHMoKSBjb25zdAogICAgIHJldHVybiBtX25l eHRPbkxpbmVFeGlzdHM7CiB9CiAKLWJvb2wgSW5saW5lQm94OjpwcmV2T25MaW5lRXhpc3RzKCkg Y29uc3QKLXsKLSAgICBpZiAoIW1fZGV0ZXJtaW5lZElmUHJldk9uTGluZUV4aXN0cykgewotICAg ICAgICBtX2RldGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMgPSB0cnVlOwotICAgICAgICAKLSAg ICAgICAgaWYgKCFwYXJlbnQoKSkKLSAgICAgICAgICAgIG1fcHJldk9uTGluZUV4aXN0cyA9IGZh bHNlOwotICAgICAgICBlbHNlIGlmIChwcmV2T25MaW5lKCkpCi0gICAgICAgICAgICBtX3ByZXZP bkxpbmVFeGlzdHMgPSB0cnVlOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBtX3ByZXZPbkxp bmVFeGlzdHMgPSBwYXJlbnQoKS0+cHJldk9uTGluZUV4aXN0cygpOwotICAgIH0KLSAgICByZXR1 cm4gbV9wcmV2T25MaW5lRXhpc3RzOwotfQotCiBJbmxpbmVCb3gqIElubGluZUJveDo6bmV4dExl YWZDaGlsZCgpIGNvbnN0CiB7CiAgICAgSW5saW5lQm94KiBsZWFmID0gMDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9JbmxpbmVCb3guaAppbmRleCBjZjZkYTU2Li4zZjVkMTI4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0lubGluZUJveC5oCkBAIC01Niw5ICs1Niw3IEBAIHB1YmxpYzoKICAgICAgICAg LCBtX2Rpck92ZXJyaWRlKGZhbHNlKQogICAgICAgICAsIG1faXNUZXh0KGZhbHNlKQogICAgICAg ICAsIG1fZGV0ZXJtaW5lZElmTmV4dE9uTGluZUV4aXN0cyhmYWxzZSkKLSAgICAgICAgLCBtX2Rl dGVybWluZWRJZlByZXZPbkxpbmVFeGlzdHMoZmFsc2UpCiAgICAgICAgICwgbV9uZXh0T25MaW5l RXhpc3RzKGZhbHNlKQotICAgICAgICAsIG1fcHJldk9uTGluZUV4aXN0cyhmYWxzZSkKICAgICAg ICAgLCBtX2V4cGFuc2lvbigwKQogI2lmbmRlZiBOREVCVUcKICAgICAgICAgLCBtX2hhc0JhZFBh cmVudChmYWxzZSkKQEAgLTkwLDkgKzg4LDcgQEAgcHVibGljOgogICAgICAgICAsIG1fZGlyT3Zl cnJpZGUoZmFsc2UpCiAgICAgICAgICwgbV9pc1RleHQoZmFsc2UpCiAgICAgICAgICwgbV9kZXRl cm1pbmVkSWZOZXh0T25MaW5lRXhpc3RzKGZhbHNlKQotICAgICAgICAsIG1fZGV0ZXJtaW5lZElm UHJldk9uTGluZUV4aXN0cyhmYWxzZSkKICAgICAgICAgLCBtX25leHRPbkxpbmVFeGlzdHMoZmFs c2UpCi0gICAgICAgICwgbV9wcmV2T25MaW5lRXhpc3RzKGZhbHNlKQogICAgICAgICAsIG1fZXhw YW5zaW9uKDApCiAjaWZuZGVmIE5ERUJVRwogICAgICAgICAsIG1faGFzQmFkUGFyZW50KGZhbHNl KQpAQCAtMjAzLDcgKzE5OSw2IEBAIHB1YmxpYzoKICAgICAgICAgbV9wcmV2ID0gcHJldjsKICAg ICB9CiAgICAgYm9vbCBuZXh0T25MaW5lRXhpc3RzKCkgY29uc3Q7Ci0gICAgYm9vbCBwcmV2T25M aW5lRXhpc3RzKCkgY29uc3Q7CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNMZWFmKCkgY29uc3QgeyBy ZXR1cm4gdHJ1ZTsgfQogICAgIApAQCAtMzY0LDkgKzM1OSw3IEBAIHB1YmxpYzoKICAgICBib29s IG1faXNUZXh0IDogMTsgLy8gV2hldGhlciBvciBub3QgdGhpcyBvYmplY3QgcmVwcmVzZW50cyB0 ZXh0IHdpdGggYSBub24temVybyBoZWlnaHQuIEluY2x1ZGVzIG5vbi1pbWFnZSBsaXN0IG1hcmtl cnMsIHRleHQgYm94ZXMuCiBwcm90ZWN0ZWQ6CiAgICAgbXV0YWJsZSBib29sIG1fZGV0ZXJtaW5l ZElmTmV4dE9uTGluZUV4aXN0cyA6IDE7Ci0gICAgbXV0YWJsZSBib29sIG1fZGV0ZXJtaW5lZElm UHJldk9uTGluZUV4aXN0cyA6IDE7CiAgICAgbXV0YWJsZSBib29sIG1fbmV4dE9uTGluZUV4aXN0 cyA6IDE7Ci0gICAgbXV0YWJsZSBib29sIG1fcHJldk9uTGluZUV4aXN0cyA6IDE7CiAgICAgc2ln bmVkIG1fZXhwYW5zaW9uIDogMTE7IC8vIGZvciBqdXN0aWZpZWQgdGV4dAogCiAjaWZuZGVmIE5E RUJVRwo=