64911 2011-07-20 17:36:23 -0700 DFG non-speculative JIT does not use() the aliased GetByVal, resulting in bloated use counts 2011-07-20 19:12:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 fpizlo webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 440142 0 fpizlo 2011-07-20 17:36:23 -0700 The DFG non-speculative JIT does not use() the aliased GetByVal when compiling GetByVal, which results in that first GetByVal's use count never dropping to zero. The DFG non-speculative JIT should call use() on the aliased GetByVal. 440144 1 101535 fpizlo 2011-07-20 17:38:51 -0700 Created attachment 101535 the patch 440188 2 101535 webkit.review.bot 2011-07-20 19:12:38 -0700 Comment on attachment 101535 the patch Clearing flags on attachment: 101535 Committed r91439: <http://trac.webkit.org/changeset/91439> 440189 3 webkit.review.bot 2011-07-20 19:12:42 -0700 All reviewed patches have been landed. Closing bug. 101535 2011-07-20 17:38:51 -0700 2011-07-20 19:12:38 -0700 the patch usegetbyval_patch_1.diff text/plain 1338 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTE0MjgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDctMjAgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE Rkcgbm9uLXNwZWN1bGF0aXZlIEpJVCBkb2VzIG5vdCB1c2UoKSB0aGUgYWxpYXNlZCBHZXRCeVZh bCwKKyAgICAgICAgcmVzdWx0aW5nIGluIGJsb2F0ZWQgdXNlIGNvdW50cy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY0OTExCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJbnNlcnRlZCBhIGNh bGwgdG8gdXNlKCkgZm9yIHRoZSBhbGlhc2VkIEdldEJ5VmFsLgorCisgICAgICAgICogZGZnL0RG R05vblNwZWN1bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpOb25TcGVjdWxhdGl2 ZUpJVDo6Y29tcGlsZSk6CisKIDIwMTEtMDctMjAgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBERkcgc3BlY3VsYXRpdmUgSklUIHNvbWV0aW1lcyBjbGFpbXMgdG8g dXNlIGNvbXBhcmUgb3BlcmFuZHMgdHdpY2UsIGxlYWRpbmcgdG8KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHTm9uU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9uU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lv biA5MTQyNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9uU3BlY3VsYXRpdmVK SVQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MDcsNiArNzA3LDkgQEAgdm9pZCBOb25TcGVjdWxh dGl2ZUpJVDo6Y29tcGlsZShTcGVjdWxhdAogICAgICAgICBicmVhazsKIAogICAgIGNhc2UgR2V0 QnlWYWw6IHsKKyAgICAgICAgaWYgKG5vZGUuY2hpbGQzKCkgIT0gTm9Ob2RlKQorICAgICAgICAg ICAgdXNlKG5vZGUuY2hpbGQzKCkpOworICAgICAgICAKICAgICAgICAgSlNWYWx1ZU9wZXJhbmQg YmFzZSh0aGlzLCBub2RlLmNoaWxkMSgpKTsKICAgICAgICAgSlNWYWx1ZU9wZXJhbmQgcHJvcGVy dHkodGhpcywgbm9kZS5jaGlsZDIoKSk7CiAK