64907 2011-07-20 17:15:54 -0700 [Qt] Qt5 Build Fix: remove useless use of qRound(int) 2011-07-21 02:29:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P3 Blocker --- 0 rohan webkit-unassigned webkit.review.bot oldest_to_newest 440124 0 rohan 2011-07-20 17:15:54 -0700 Rounding an integer doesn't make sense. Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, code using qRound(int) does not compile: Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp: In constructor 'WebCore::FontPlatformData::FontPlatformData(const WebCore::FontDescription&, const WTF::AtomicString&, int, int)': Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp:67: error: call of overloaded 'qRound(int)' is ambiguous ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1176: note: candidates are: int qRound(double) ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1178: note: int qRound(float) Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp:69: error: call of overloaded 'qRound(int&)' is ambiguous ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1176: note: candidates are: int qRound(double) ../qtbase/include/QtCore/../../src/corelib/global/qglobal.h:1178: note: int qRound(float) 440147 1 101537 rohan 2011-07-20 17:41:26 -0700 Created attachment 101537 [PATCH] Qt5 Build Fix: remove useless use of qRound(int) 440304 2 101537 noam 2011-07-21 01:27:19 -0700 Comment on attachment 101537 [PATCH] Qt5 Build Fix: remove useless use of qRound(int) LGTM 440317 3 101537 webkit.review.bot 2011-07-21 02:29:35 -0700 Comment on attachment 101537 [PATCH] Qt5 Build Fix: remove useless use of qRound(int) Clearing flags on attachment: 101537 Committed r91452: <http://trac.webkit.org/changeset/91452> 440318 4 webkit.review.bot 2011-07-21 02:29:39 -0700 All reviewed patches have been landed. Closing bug. 101537 2011-07-20 17:41:26 -0700 2011-07-21 02:29:35 -0700 [PATCH] Qt5 Build Fix: remove useless use of qRound(int) 0001-Qt5-Build-Fix-remove-useless-use-of-qRound-int.patch text/plain 2822 rohan RnJvbSBmNzVjNGM2YzljMmIyMjA2NDZiMDA0NzkzYTNiNzI5M2E4ODZhOTQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2hhbiBNY0dvdmVybiA8cm9oYW5AbWNnb3Zlcm4uaWQuYXU+ CkRhdGU6IFRodSwgMjEgSnVsIDIwMTEgMTA6MDc6NTUgKzEwMDAKU3ViamVjdDogW1BBVENIXSBR dDUgQnVpbGQgRml4OiByZW1vdmUgdXNlbGVzcyB1c2Ugb2YgcVJvdW5kKGludCkKClJvdW5kaW5n IGFuIGludGVnZXIgZG9lc24ndCBtYWtlIHNlbnNlLgpTaW5jZSAyZGNkMzkzOWE4YmQ1ZmY3NDNl NGM4N2Y4N2IyZDgxYjFhMTAxNDY3IGluIHF0YmFzZSwgdGhpcyBpcyBub3QKcGVybWl0dGVkIHRv IGNvbXBpbGUuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDE4ICsrKysrKysrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0ZvbnRQbGF0Zm9ybURhdGFRdC5jcHAgICAgfCAgICA0ICsrLS0KIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL3F0L1BsYXRmb3JtU2NyZWVuUXQuY3BwICAgIHwgICAgMiArLQogMyBmaWxlcyBj aGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5 ZTViYjI4Li5jOWM1NDFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDctMjAg IFJvaGFuIE1jR292ZXJuICA8cm9oYW5AbWNnb3Zlcm4uaWQuYXU+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBRdDUgQnVpbGQgRml4OiByZW1v dmUgdXNlbGVzcyB1c2Ugb2YgcVJvdW5kKGludCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY0OTA3CisKKyAgICAgICAgUm91bmRpbmcgYW4gaW50ZWdl ciBkb2Vzbid0IG1ha2Ugc2Vuc2UuCisgICAgICAgIFNpbmNlIDJkY2QzOTM5YThiZDVmZjc0M2U0 Yzg3Zjg3YjJkODFiMWExMDE0NjcgaW4gcXRiYXNlLCB0aGlzIGlzIG5vdAorICAgICAgICBwZXJt aXR0ZWQgdG8gY29tcGlsZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFBsYXRmb3JtRGF0YVF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OkZvbnRQbGF0Zm9ybURhdGEpOiBFbGltaW5h dGUgcVJvdW5kKGludCkuCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1TY3JlZW5RdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5EZXB0aFBlckNvbXBvbmVudCk6IERpdHRvLgor CiAyMDExLTAzLTAxICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Gb250UGxhdGZvcm1EYXRhUXQuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvRm9udFBsYXRmb3JtRGF0YVF0LmNwcAppbmRl eCAxODVhZTg1Li41NGVjYWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9Gb250UGxhdGZvcm1EYXRhUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0ZvbnRQbGF0Zm9ybURhdGFRdC5jcHAKQEAgLTY0LDkgKzY0LDkg QEAgRm9udFBsYXRmb3JtRGF0YTo6Rm9udFBsYXRmb3JtRGF0YShjb25zdCBGb250RGVzY3JpcHRp b24mIGRlc2NyaXB0aW9uLCBjb25zdCBBdG8KICAgICA6IG1fZGF0YShhZG9wdFJlZihuZXcgRm9u dFBsYXRmb3JtRGF0YVByaXZhdGUoKSkpCiB7CiAgICAgUUZvbnQmIGZvbnQgPSBtX2RhdGEtPmZv bnQ7Ci0gICAgaW50IHJlcXVlc3RlZFNpemUgPSBxUm91bmQoZGVzY3JpcHRpb24uY29tcHV0ZWRQ aXhlbFNpemUoKSk7CisgICAgaW50IHJlcXVlc3RlZFNpemUgPSBkZXNjcmlwdGlvbi5jb21wdXRl ZFBpeGVsU2l6ZSgpOwogICAgIGZvbnQuc2V0RmFtaWx5KGZhbWlseU5hbWUpOwotICAgIGZvbnQu c2V0UGl4ZWxTaXplKHFSb3VuZChyZXF1ZXN0ZWRTaXplKSk7CisgICAgZm9udC5zZXRQaXhlbFNp emUocmVxdWVzdGVkU2l6ZSk7CiAgICAgZm9udC5zZXRJdGFsaWMoZGVzY3JpcHRpb24uaXRhbGlj KCkpOwogICAgIGZvbnQuc2V0V2VpZ2h0KHRvUUZvbnRXZWlnaHQoZGVzY3JpcHRpb24ud2VpZ2h0 KCkpKTsKICAgICBmb250LnNldFdvcmRTcGFjaW5nKHdvcmRTcGFjaW5nKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtU2NyZWVuUXQuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1TY3JlZW5RdC5jcHAKaW5kZXggNGRiOGJkMS4u OTI1NWU3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1T Y3JlZW5RdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1TY3Jl ZW5RdC5jcHAKQEAgLTgwLDcgKzgwLDcgQEAgaW50IHNjcmVlbkRlcHRoUGVyQ29tcG9uZW50KFdp ZGdldCogdykKICAgICBjYXNlIDMyOgogICAgICAgICByZXR1cm4gODsKICAgICBkZWZhdWx0Ogot ICAgICAgICByZXR1cm4gcVJvdW5kKGRlcHRoIC8gMyk7CisgICAgICAgIHJldHVybiBkZXB0aCAv IDM7CiAgICAgfQogfQogCi0tIAoxLjcuMC40Cgo=